auditable 0.0.9 → 0.1.0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 0.1.0 (1012-04-11)
+#### Changes
+* previously, `audit_tag_with` updates the latest audit if no changes are detected in a record's audited changes. now it creates a new audit row instead because this works better and prevent losing history if we call `audit_tag_with` multiple times. new audits are only created if the combo of 4 attributes is different: `modifications`, `tag`, `user`, `action`.
+* bump minor version because it is more ready for production use at this point
+
 ### 0.0.9 (2012-04-10)
 #### Improvement
 * Add `last_change_of(attribute)` to show the last change that happened to an attribute. Thanks to @zuf

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in auditable.gemspec
 gemspec
+
+gem 'debugger', :platform => :ruby_19

data/lib/auditable/audit.rb

@@ -70,5 +70,13 @@ module Auditable
     def changed_by
       user
     end
+
+    def same_audited_content?(other_audit)
+      other_audit and relevant_attributes == other_audit.relevant_attributes
+    end
+
+    def relevant_attributes
+      attributes.slice("modifications", "tag", "action", "user").reject {|k,v| v.blank? }
+    end
   end
 end

data/lib/auditable/auditing.rb

@@ -61,19 +61,19 @@ module Auditable
         end
       end
 
-      if last_audit.nil? || last_audit.modifications != snap
-        # build new audit
-        audit = audits.build(:modifications => snap)
-      else
-        # no changes on modifications, but have to update the latest record
-        audit = audits.last
-      end
+      last_saved_audit = audits.last
 
+      # build new audit
+      audit = audits.build(:modifications => snap)
       options[:tag]    = self.audit_tag    || options[:tag]
       options[:action] = self.audit_action || options[:action]
       options[:user]   = self.changed_by   || options[:user]
+      audit.attributes = audit.attributes.merge options
 
-      audit.update_attributes(options)
+      # only save if it's different from before
+      if !audit.same_audited_content?(last_saved_audit)
+        audit.save
+      end
     end
 
     # Get the latest changes by comparing the latest two audits

data/lib/auditable/version.rb

@@ -1,3 +1,3 @@
 module Auditable
-  VERSION = "0.0.9"
+  VERSION = "0.1.0"
 end

data/spec/lib/auditable_spec.rb

@@ -154,6 +154,7 @@ describe Auditable do
 
   context "no changes on audited attributes" do
     it "should not create new audits" do
+      survey.save
       expect { survey.save }.to_not change { survey.audits.count }
     end
   end

data/spec/support/models.rb

@@ -10,15 +10,4 @@ end
 
 # TODO add Question class to give examples on association stuff
 
-# prepare test data
-class CreateTestSchema < ActiveRecord::Migration
-  def change
-    create_table "surveys", :force => true do |t|
-      t.string "title"
-    end
-    create_table "users", :force => true do |t|
-      t.string "name"
-    end
-  end
-end
 

data/spec/support/schema.rb

@@ -3,6 +3,18 @@ ActiveRecord::Base.establish_connection({
   :database => ':memory:'
 })
 
+# prepare test data
+class CreateTestSchema < ActiveRecord::Migration
+  def change
+    create_table "surveys", :force => true do |t|
+      t.string "title"
+    end
+    create_table "users", :force => true do |t|
+      t.string "name"
+    end
+  end
+end
+
 CreateTestSchema.migrate(:up)
 
 # run gem's required migration

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: auditable
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2156128620 !ruby/object:Gem::Requirement
+  requirement: &2156128720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156128620
+  version_requirements: *2156128720
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2156125000 !ruby/object:Gem::Requirement
+  requirement: &2156125140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *2156125000
+  version_requirements: *2156125140
 - !ruby/object:Gem::Dependency
   name: watchr
-  requirement: &2156060580 !ruby/object:Gem::Requirement
+  requirement: &2156060480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156060580
+  version_requirements: *2156060480
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2156059520 !ruby/object:Gem::Requirement
+  requirement: &2156059540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156059520
+  version_requirements: *2156059540
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &2156057800 !ruby/object:Gem::Requirement
+  requirement: &2156056920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156057800
+  version_requirements: *2156056920
 - !ruby/object:Gem::Dependency
   name: rdiscount
-  requirement: &2156054720 !ruby/object:Gem::Requirement
+  requirement: &2156054820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156054720
+  version_requirements: *2156054820
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2156054020 !ruby/object:Gem::Requirement
+  requirement: &2156054120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156054020
+  version_requirements: *2156054120
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2156053280 !ruby/object:Gem::Requirement
+  requirement: &2156053380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156053280
+  version_requirements: *2156053380
 description: A simple gem that audit models' attributes or methods by taking snapshots
   and diff them for you. Starting from scratch to work with Rails 3.2.2 onwards
 email: