attune 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a768188791c5cf1b4dbb0d9bb7639c79be622f49
-  data.tar.gz: 0b55667d588255b97df0fc7fbc7d7571f2a3a420
+  metadata.gz: 71b45b8b01601ab2b240d6c5243a39c0991a23d9
+  data.tar.gz: fd29c20cac7f27e6cb3aa00f9a6c8ec4c54070a9
 SHA512:
-  metadata.gz: a90ccfd4d4aa1893c315e161545a3bd04cdddcdaabdc98f7e4daf809a7a8acbefd3e15d03344fd933ae83e290b7ff3f4bdd2c15b0180565d4b00597c4c7d9e74
-  data.tar.gz: 1686b9cfa601e45f89590446c8c69a65f9c6f80b775f4031056fc6f9438c790514f836d7f00622ce31b0562d92e62c643aa19da5a53491c92d08cb2289be1ec8
+  metadata.gz: 830ae6660ed070894351cb69c13da91827fbb9abaa43a79377e527d1f8d339be1c6c20391280f4b9a315363c8cb7d24f344e6e9ccc0ba166d327651cbe9549f5
+  data.tar.gz: b7dd011b6e0003d0fa5d7e7a69cb53666dd3773e1cd50de389e870bb928ba75d9a1e4506d73b4af124d37a8eeac464a1b14cf66bf7473241fe7bbc618201844b

data/README.md

@@ -64,7 +64,7 @@ class ProductsController
 
   private
   def sorted products
-    ranking = attune_client.get_ranking(
+    ranking = attune_client.get_rankings(
       id: session[:attune_id],
       view: request.fullpath,
       collection: 'products',

data/lib/attune/client.rb

@@ -42,7 +42,7 @@ module Attune
     # @option options [String] :user_agent The user agent for the application used by the anonymous users
     # @return id [String]
     # @raise [ArgumentError] if user_agent is not provided
-    # @raise [Faraday::Error] if the request fails or exceeds the timeout
+    # @raise [Faraday::Error::ClientError] if the request fails or exceeds the timeout
     def create_anonymous(options)
       raise ArgumentError, "user_agent required" unless options[:user_agent]
       if id = options[:id]
@@ -76,7 +76,7 @@ module Attune
     # @option options [String] :customer id of customer (optional)
     # @return ranking [Array<String>] The entities in their ranked order
     # @raise [ArgumentError] if required parameters are missing
-    # @raise [Faraday::Error] if the request fails or exceeds the timeout
+    # @raise [Faraday::Error::ClientError] if the request fails or exceeds the timeout
     def get_rankings(options)
       qs = encoded_ranking_params(options)
       if response = get("rankings/#{qs}", customer: options.fetch(:customer, 'none'))
@@ -90,7 +90,7 @@ module Attune
     # Get multiple rankings in one call
     #
     # @example
-    #   rankings = client.get_rankings([
+    #   rankings = client.multi_get_rankings([
     #     {
     #       id: '0cddbc0-6114-11e3-949a-0800200c9a66',
     #       view: 'b/mens-pants',
@@ -106,15 +106,20 @@ module Attune
     #   ])
     # @param [Array<Hash>] multi_options An array of options (see #get_rankings)
     # @return [Array<Array<String>>] rankings
-    # @raise [Faraday::Error] if the request fails or exceeds the timeout
+    # @raise [Faraday::Error::ClientError] if the request fails or exceeds the timeout
     def multi_get_rankings(multi_options)
       requests = multi_options.map do |options|
         encoded_ranking_params(options)
       end
       if response = get("rankings", ids: requests)
         results = JSON.parse(response.body)['results']
-        results.values.map do |result|
-          result['ranking']
+
+        # Order of encoded paramaters may change, so we must parse them
+        results = Hash[results.map do |request, result|
+          [CGI.parse(request), result]
+        end]
+        requests.map do |request|
+          results[CGI.parse(request)]['ranking']
         end
       else
         # In mock mode: return the entities in the order passed in
@@ -133,7 +138,7 @@ module Attune
     #     '25892e17-80f6-415f-9c65-7395632f022',
     #     'cd171f7c-560d-4a62-8d65-16b87419a58'
     #   )
-    # @raise [Faraday::Error] if the request fails or exceeds the timeout
+    # @raise [Faraday::Error::ClientError] if the request fails or exceeds the timeout
     def bind(id, customer_id)
       put("bindings/anonymous=#{id}&customer=#{customer_id}")
       true

data/lib/attune/version.rb

@@ -1,3 +1,3 @@
 module Attune
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/attune/client_spec.rb

@@ -116,9 +116,33 @@ describe Attune::Client do
     expect(rankings).to eq(%W[1004 1003 1002 1001])
   end
 
+  let(:req1){ CGI::escape 'anonymous=0cddbc0-6114-11e3-949a-0800200c9a66&view=b%2Fmens-pants&entity_collection=products&entities=1001%2C%2C1002%2C%2C1003%2C%2C1004&ip=none' }
+  let(:req2){ CGI::escape 'anonymous=0cddbc0-6114-11e3-949a-0800200c9a66&view=b%2Fmens-pants&entity_collection=products&entities=2001%2C%2C2002%2C%2C2003%2C%2C2004&ip=none' }
   it "can multi_get_rankings" do
     stubs.get("/rankings?ids=anonymous%3D0cddbc0-6114-11e3-949a-0800200c9a66%26view%3Db%252Fmens-pants%26entity_collection%3Dproducts%26entities%3D1001%252C%252C1002%252C%252C1003%252C%252C1004%26ip%3Dnone&ids=anonymous%3D0cddbc0-6114-11e3-949a-0800200c9a66%26view%3Db%252Fmens-pants%26entity_collection%3Dproducts%26entities%3D2001%252C%252C2002%252C%252C2003%252C%252C2004%26ip%3Dnone") do
-      [200, {}, %[{"results":{"fake0":{"ranking":["1004","1003","1002","1001"]},"fake1":{"ranking":["2004","2003","2002","2001"]}}}]]
+      [200, {}, <<-JSON]
+{
+    "errors": {},
+    "results": {
+        "anonymous=0cddbc0-6114-11e3-949a-0800200c9a66&entities=1001%2C%2C1002%2C%2C1003%2C%2C1004&entity_collection=products&ip=none&view=b%2Fmens-pants": {
+            "ranking": [
+                "1004",
+                "1003",
+                "1002",
+                "1001"
+            ]
+        },
+        "anonymous=0cddbc0-6114-11e3-949a-0800200c9a66&entities=2001%2C%2C2002%2C%2C2003%2C%2C2004&entity_collection=products&ip=none&view=b%2Fmens-pants": {
+            "ranking": [
+                "2004",
+                "2003",
+                "2002",
+                "2001"
+            ]
+        }
+    }
+}
+      JSON
     end
     rankings = client.multi_get_rankings([
       {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attune
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - John Hawthorn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-31 00:00:00.000000000 Z
+date: 2014-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday