attributes_sort 0.2.2 → 0.2.3

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/lib/attributes_sort.rb

@@ -1,13 +1,8 @@
 module AttributesSort
   def self.included(receiver)
     receiver.instance_eval do
-      def build_attributes(attributes)
-        "[" << attributes.map!{|attribute| "object.#{attribute}"}.join(",") << "]"
-      end
-
-      def do_attributes_sort(collection, attributes)
-				attribute_array_string = build_attributes(attributes)
-        collection.sort_by{|object| eval(attribute_array_string)}
+      def do_attributes_sort(collection, attributes)	
+				collection.sort_by { |object| attributes.map { |attribute| object.send(attribute) }}				
       end
     end
     Array.class_eval do
@@ -17,11 +12,6 @@ module AttributesSort
 
       def class_type
         klass = self.first.class
-
-        #use duck type check respond to check instead				
-        #is_same = self.all?{|object| object.class == klass}
-				#raise "All objects must be of the same class type" unless is_same
-
 				raise "All objects must respond to sort criteria"unless sortable_attributes?	
         klass
       end

data/spec/attributes_sort_spec.rb

@@ -38,11 +38,6 @@ describe "AttributesSort" do
     p.should respond_to(:age)
   end
 
-  it "build attributes string array to be eval'd at deferred time in sort_by block'" do
-    criteria = [:lastname, :age, :firstname]
-    Person.build_attributes(criteria).should == "[object.lastname,object.age,object.firstname]"
-  end
-
   it "sort by last name" do
     test_sort([:lastname], [@p1, @p2, @p5, @p4, @p3])
   end
@@ -71,12 +66,6 @@ describe "AttributesSort" do
     lambda {test_sort([:blah], [@p1, @p2, @p5, @p4, @p3])}.should raise_error("All objects must respond to sort criteria")
   end
 
-  it "raise error if objects are not of same class type" do
-		pending "using duck type check instead"
-    @people << "some other object"
-    lambda {test_sort([:age],[@p1, @p2, @p5, @p4, @p3])}.should raise_error("All objects must be of the same class type")
-  end
-
 	class Dog
 		attr_accessor :firstname,:lastname,:age
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 2
-  version: 0.2.2
+  - 3
+  version: 0.2.3
 platform: ruby
 authors: 
 - Karmen Blake