attribute_predicates 0.2.0 → 0.2.1

data/CHANGELOG.rdoc

@@ -1,5 +1,10 @@
 == master
 
+== 0.2.1 / 2010-03-07
+
+* Release gems via rake-gemcutter instead of rubyforge
+* Fix define_method usage causing all attributes to be private in Ruby 1.9+
+
 == 0.2.0 / 2008-12-14
 
 * Remove the PluginAWeek namespace

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2006-2008 Aaron Pfeifer
+Copyright (c) 2006-2010 Aaron Pfeifer
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/Rakefile

@@ -1,13 +1,15 @@
+require 'rubygems'
+require 'rake'
 require 'rake/testtask'
 require 'rake/rdoctask'
 require 'rake/gempackagetask'
-require 'rake/contrib/sshpublisher'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'attribute_predicates'
-  s.version           = '0.2.0'
+  s.version           = '0.2.1'
   s.platform          = Gem::Platform::RUBY
-  s.summary           = 'Adds automatic generation of predicate methods for attributes.'
+  s.summary           = 'Adds automatic generation of predicate methods for attributes'
+  s.description       = s.summary
   
   s.files             = FileList['{lib,test}/**/*'] + %w(CHANGELOG.rdoc init.rb LICENSE Rakefile README.rdoc)
   s.require_path      = 'lib'
@@ -49,23 +51,30 @@ Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = spec.name
   rdoc.template = '../rdoc_template.rb'
-  rdoc.options << '--line-numbers'
+  rdoc.options << '--line-numbers' << '--inline-source'
   rdoc.rdoc_files.include('README.rdoc', 'CHANGELOG.rdoc', 'LICENSE', 'lib/**/*.rb')
 end
-  
+
+desc 'Generate a gemspec file.'
+task :gemspec do
+  File.open("#{spec.name}.gemspec", 'w') do |f|
+    f.write spec.to_ruby
+  end
+end
+
 Rake::GemPackageTask.new(spec) do |p|
   p.gem_spec = spec
-  p.need_tar = true
-  p.need_zip = true
 end
 
 desc 'Publish the beta gem.'
 task :pgem => [:package] do
+  require 'rake/contrib/sshpublisher'
   Rake::SshFilePublisher.new('aaron@pluginaweek.org', '/home/aaron/gems.pluginaweek.org/public/gems', 'pkg', "#{spec.name}-#{spec.version}.gem").upload
 end
 
 desc 'Publish the API documentation.'
 task :pdoc => [:rdoc] do
+  require 'rake/contrib/sshpublisher'
   Rake::SshDirPublisher.new('aaron@pluginaweek.org', "/home/aaron/api.pluginaweek.org/public/#{spec.name}", 'rdoc').upload
 end
 
@@ -74,15 +83,8 @@ task :publish => [:pgem, :pdoc, :release]
 
 desc 'Publish the release files to RubyForge.'
 task :release => [:gem, :package] do
-  require 'rubyforge'
-  
-  ruby_forge = RubyForge.new.configure
-  ruby_forge.login
+  require 'rake/gemcutter'
   
-  %w(gem tgz zip).each do |ext|
-    file = "pkg/#{spec.name}-#{spec.version}.#{ext}"
-    puts "Releasing #{File.basename(file)}..."
-    
-    ruby_forge.add_release(spec.rubyforge_project, spec.name, spec.version, file)
-  end
+  Rake::Gemcutter::Tasks.new(spec)
+  Rake::Task['gem:push'].invoke
 end

data/lib/attribute_predicates/extensions/module.rb

@@ -55,21 +55,21 @@ module AttributePredicates
         end
       end
       
-      private
-        # Returns true if the specified variable is not blank, otherwise false
-        def attr_predicate(symbol)
-          define_method("#{symbol}?") do
-            value = instance_variable_get("@#{symbol}")
-            if value.respond_to?(:blank?)
-              # Use ActiveSupport's implementation
-              !value.blank?
-            elsif value.respond_to?(:empty?)
-              !value.empty?
-            else
-              !!value
-            end
+      # Returns true if the specified variable is not blank, otherwise false
+      def attr_predicate(symbol)
+        define_method("#{symbol}?") do
+          value = instance_variable_get("@#{symbol}")
+          if value.respond_to?(:blank?)
+            # Use ActiveSupport's implementation
+            !value.blank?
+          elsif value.respond_to?(:empty?)
+            !value.empty?
+          else
+            !!value
           end
         end
+      end
+      private :attr_predicate
     end
   end
 end

data/test/module_test.rb

@@ -16,18 +16,18 @@ class ModuleAttrTest < Test::Unit::TestCase
   def test_should_create_predicate_for_readonly_attr
     @module.attr(:foo)
     %w(foo foo?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
     
     %w(foo=).each do |method|
-      assert !@module.instance_methods.include?(method), "#{method} exists"
+      assert !@module.method_defined?(method), "#{method} exists"
     end
   end
   
   def test_should_create_predicate_for_readwrite_attr
     @module.attr(:foo, true)
     %w(foo foo= foo?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
   end
 end
@@ -40,22 +40,22 @@ class ModuleAttrReaderTest < Test::Unit::TestCase
   def test_should_create_predicate
     @module.attr_reader(:foo)
     %w(foo foo?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
     
     %w(foo=).each do |method|
-      assert !@module.instance_methods.include?(method), "#{method} exists"
+      assert !@module.method_defined?(method), "#{method} exists"
     end
   end
   
   def test_should_create_predicate_for_multiple_attributes
     @module.attr_reader(:foo, :bar)
     %w(foo foo? bar bar?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
     
     %w(foo= bar=).each do |method|
-      assert !@module.instance_methods.include?(method), "#{method} exists"
+      assert !@module.method_defined?(method), "#{method} exists"
     end
   end
 end
@@ -68,14 +68,14 @@ class ModuleAttrAccessorTest < Test::Unit::TestCase
   def test_should_create_predicate
     @module.attr_accessor(:foo)
     %w(foo foo= foo?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
   end
   
   def test_should_create_predicate_for_multiple_attributes
     @module.attr_accessor(:foo, :bar)
     %w(foo foo= foo? bar bar= bar?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
   end
 end
@@ -88,22 +88,22 @@ class ModuleAttrWriterTest < Test::Unit::TestCase
   def test_should_create_predicate
     @module.attr_writer(:foo)
     %w(foo= foo?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
     
     %w(foo).each do |method|
-      assert !@module.instance_methods.include?(method), "#{method} exists"
+      assert !@module.method_defined?(method), "#{method} exists"
     end
   end
   
   def test_should_create_predicate_for_multiple_attributes
     @module.attr_writer(:foo, :bar)
     %w(foo= foo? bar= bar?).each do |method|
-      assert @module.instance_methods.include?(method), "#{method} does not exist"
+      assert @module.method_defined?(method), "#{method} does not exist"
     end
     
     %w(foo bar).each do |method|
-      assert !@module.instance_methods.include?(method), "#{method} exists"
+      assert !@module.method_defined?(method), "#{method} exists"
     end
   end
 end
@@ -115,7 +115,7 @@ class ModuleAttrPredicateTest < Test::Unit::TestCase
   
   def test_should_create_predicate
     @module.attr_predicate(:foo)
-    assert @module.instance_methods.include?('foo?'), 'foo? does not exist'
+    assert @module.method_defined?('foo?'), 'foo? does not exist'
   end
 end
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: attribute_predicates
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,11 +9,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-12-14 00:00:00 -05:00
+date: 2010-03-07 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
-description: 
+description: Adds automatic generation of predicate methods for attributes
 email: aaron@pluginaweek.org
 executables: []
 
@@ -22,14 +22,12 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
-- lib/attribute_predicates.rb
-- lib/attribute_predicates
-- lib/attribute_predicates/extensions
 - lib/attribute_predicates/extensions/module.rb
 - lib/attribute_predicates/extensions/active_record.rb
+- lib/attribute_predicates.rb
+- test/active_record_test.rb
 - test/test_helper.rb
 - test/module_test.rb
-- test/active_record_test.rb
 - CHANGELOG.rdoc
 - init.rb
 - LICENSE
@@ -37,6 +35,8 @@ files:
 - README.rdoc
 has_rdoc: true
 homepage: http://www.pluginaweek.org
+licenses: []
+
 post_install_message: 
 rdoc_options: []
 
@@ -57,10 +57,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: pluginaweek
-rubygems_version: 1.2.0
+rubygems_version: 1.3.5
 signing_key: 
-specification_version: 2
-summary: Adds automatic generation of predicate methods for attributes.
+specification_version: 3
+summary: Adds automatic generation of predicate methods for attributes
 test_files: 
-- test/module_test.rb
 - test/active_record_test.rb
+- test/module_test.rb