attribute_normalizer-extras 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: beb68db8e9ad83583260876034337efe70bd1e7e
-  data.tar.gz: f4a7f569158487f8bbbd1b3173a47ebd7d1160ad
+  metadata.gz: 198d6ba06e3bf0684606c59ab78c5ec48b7c66cd
+  data.tar.gz: 2c56bc94c71b061a1176b3104a0ee13532aa0d7a
 SHA512:
-  metadata.gz: 06804e8594de2739324784966cf364f5826e899677109c3eaad443c03b4d5f80d82320b71428448a855aa6a6d36b6d1d1eea989dc1f5fe92880472110708f2be
-  data.tar.gz: f0d0cbd95948eb656a10b57d154eba5697ac38670f24690d56623dff44164b189a4f37e46da3fa03f9c244fac36e64f7083bf87e81c175b32a3cdb2277a91db9
+  metadata.gz: be01b427c0cd5950265ba50e8f589db39935be9e624145079996420b014bc3b319a49d2d89d0f4840f783eaaca234a836ef45ff5c2862e0bd2b78f983a28006e
+  data.tar.gz: cfad5fcaea65ec6b8075a5a8b8a0cd1b145b73e77f0c1cb5f026c06040faad4ce6fae823eca943b3c387fc5f0dd68098e3b5018bec9c3c5677c9315b9a66154a

data/attribute_normalizer-extras.gemspec

@@ -6,8 +6,8 @@ require 'attribute_normalizer/extras/version'
 Gem::Specification.new do |spec|
   spec.name          = "attribute_normalizer-extras"
   spec.version       = AttributeNormalizer::Extras::VERSION
-  spec.authors       = ["Darko Dosenovic", "Michael van den Beuken", "Ruben Estevez", "Jordan Babe", "Mathieu Gilbert", "Ryan Jones", "Jonathan Weyermann"]
-  spec.email         = ["darko.dosenovic@ama.ab.ca", "michael.vandenbeuken@ama.ab.ca", "ruben.estevez@ama.ab.ca", "jordan.babe@ama.ab.ca", "mathieu.gilbert@ama.ab.ca", "ryan.jones@ama.ab.ca", "jonathan.weyermann@ama.ab.ca"]
+  spec.authors       = ["Darko Dosenovic", "Michael van den Beuken", "Ruben Estevez", "Jordan Babe", "Mathieu Gilbert", "Ryan Jones", "Jonathan Weyermann", "Jesse Doyle"]
+  spec.email         = ["darko.dosenovic@ama.ab.ca", "michael.vandenbeuken@ama.ab.ca", "ruben.estevez@ama.ab.ca", "jordan.babe@ama.ab.ca", "mathieu.gilbert@ama.ab.ca", "ryan.jones@ama.ab.ca", "jonathan.weyermann@ama.ab.ca", "jesse.doyle@ama.ab.ca"]
   spec.summary       = %q{attribute_normalizer gem extras}
   spec.description   = %q{Specific normalizers that we commonly use in our apps}
   spec.homepage      = ""
@@ -18,13 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "pry", "~> 0.10"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "pry"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "rspec-instafail"
   spec.add_development_dependency "simplecov"
 
   spec.add_runtime_dependency "attribute_normalizer", "~> 1.0"
 end
-

data/lib/attribute_normalizer/extras.rb

@@ -3,11 +3,13 @@ require "attribute_normalizer/extras/version"
 require "attribute_normalizer/normalizers/gsub_normalizer"
 require "attribute_normalizer/normalizers/spaceless_normalizer"
 require "attribute_normalizer/normalizers/postal_code_normalizer"
+require "attribute_normalizer/normalizers/float_normalizer"
 
 extras = {
- gsub:  AttributeNormalizer::Normalizers::GsubNormalizer,
- postal_code: AttributeNormalizer::Normalizers::PostalCodeNormalizer,
- spaceless: AttributeNormalizer::Normalizers::SpacelessNormalizer
+  gsub:  AttributeNormalizer::Normalizers::GsubNormalizer,
+  postal_code: AttributeNormalizer::Normalizers::PostalCodeNormalizer,
+  spaceless: AttributeNormalizer::Normalizers::SpacelessNormalizer,
+  float: AttributeNormalizer::Normalizers::FloatNormalizer
 }
 
 AttributeNormalizer.configuration.normalizers.merge! extras

data/lib/attribute_normalizer/extras/version.rb

@@ -1,5 +1,5 @@
 module AttributeNormalizer
   module Extras
-    VERSION = "0.0.3"
+    VERSION = "0.1.0"
   end
 end

data/lib/attribute_normalizer/normalizers/float_normalizer.rb

@@ -0,0 +1,69 @@
+module AttributeNormalizer
+  module Normalizers
+    # Accept an input value of various types and coerce it into a float.
+    #
+    # Valid types for coersion are: String, Numeric, and NilClass.
+    #
+    # = Options
+    # allow_blank::
+    #   Will not attempt to coerce nil or '' to a float if this evaluates to a
+    #   truthy value. DEFAULT: false
+    #
+    # = Notes
+    #   This normalizer does not handle negative values, or perform any rounding
+    #
+    # = Usage
+    # AttributeNormalizer::Normalizers::FloatNormalizer.normalize('$1,500.00')
+    module FloatNormalizer
+      DEFAULTS = {
+        blank: false
+      }.freeze
+
+      class << self
+        def normalize(value, opts = {})
+          case value
+          when String
+            handle_string(value, opts)
+          when Numeric
+            value.to_f
+          when NilClass
+            handle_nil(opts)
+          else
+            invalid_type!(value)
+          end
+        end
+
+        private
+
+        def handle_string(value, opts = {})
+          if opts.fetch(:allow_blank, DEFAULTS[:blank]) && blank?(value)
+            value
+          else
+            # Strip all characters except digits or '.'.
+            # Be warned that this will coerce '' or nil to 0.00.
+            # Use allow_blank: true if you don't want this behaviour.
+            value.gsub(/[^\d.]/, '').to_f
+          end
+        end
+
+        def handle_nil(opts = {})
+          if opts.fetch(:allow_blank, DEFAULTS[:blank])
+            nil
+          else
+            nil.to_f
+          end
+        end
+
+        def invalid_type!(value)
+          raise ArgumentError, "must pass a Numeric or a String, got: #{value.class}"
+        end
+
+        # This gem doesn't have a dependency on ActiveSupport - I'd rather not add
+        # the dependency just for String#blank?.
+        def blank?(value)
+          value.nil? || value.empty?
+        end
+      end
+    end
+  end
+end

data/lib/attribute_normalizer/normalizers/postal_code_normalizer.rb

@@ -2,7 +2,9 @@ module AttributeNormalizer
   module Normalizers
     module PostalCodeNormalizer
       def self.normalize(value, options)
-        GsubNormalizer.normalize value.upcase, pattern: /\W+|_/, replacement: '' unless value==nil
+        if value
+          GsubNormalizer.normalize value.upcase, pattern: /\W+|_/, replacement: ''
+        end
       end
     end
   end

data/spec/models/float_normalizer_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe AttributeNormalizer::Normalizers::FloatNormalizer do
+  describe '#normalize' do
+    let(:normalized) { described_class.normalize(value, opts) }
+
+    context 'with an Integer' do
+      let(:value) { 2 }
+      let(:opts) { Hash.new }
+
+      it 'returns a float' do
+        expect(normalized).to eq(2.0) # be careful: 2 == 2.to_f
+        expect(normalized).to be_a(Float)
+      end
+    end
+
+    context 'with nil' do
+      let(:value) { nil }
+
+      context 'with allow_blank: false' do
+        let(:opts) { { allow_blank: false } }
+
+        it 'returns nil.to_f (0.00)' do
+          expect(normalized).to eq(nil.to_f)
+        end
+      end
+
+      context 'with allow_blank: true' do
+        let(:opts) { { allow_blank: true } }
+
+        it 'returns nil' do
+          expect(normalized).to be nil
+        end
+      end
+    end
+
+    context 'with a String' do
+      let(:value) { '$1,500.01' }
+      let(:opts) { Hash.new }
+
+      it 'strips out invalid characters' do
+        expect(normalized).to eq(1500.01)
+      end
+    end
+
+    context 'with an empty String' do
+      let(:value) { '' }
+
+      context 'with allow_blank: false' do
+        let(:opts) { { allow_blank: false } }
+
+        it 'returns "".to_f (0.00)' do
+          expect(normalized).to eq(''.to_f)
+        end
+      end
+
+      context 'with allow_blank: true' do
+        let(:opts) { { allow_blank: true } }
+
+        it 'returns the empty string' do
+          expect(normalized).to eq('')
+        end
+      end
+    end
+
+    context 'with an invalid type' do
+      let(:value) { Array.new }
+      let(:opts) { Hash.new }
+
+      it 'raises ArgumentError' do
+        expect{ normalized }.to raise_error(ArgumentError)
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attribute_normalizer-extras
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Darko Dosenovic
@@ -11,107 +11,108 @@ authors:
 - Mathieu Gilbert
 - Ryan Jones
 - Jonathan Weyermann
+- Jesse Doyle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2017-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-instafail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: attribute_normalizer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 description: Specific normalizers that we commonly use in our apps
@@ -123,23 +124,25 @@ email:
 - mathieu.gilbert@ama.ab.ca
 - ryan.jones@ama.ab.ca
 - jonathan.weyermann@ama.ab.ca
+- jesse.doyle@ama.ab.ca
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- attribute_normalizer-extras-0.0.2.gem
 - attribute_normalizer-extras.gemspec
 - lib/attribute_normalizer/extras.rb
 - lib/attribute_normalizer/extras/version.rb
+- lib/attribute_normalizer/normalizers/float_normalizer.rb
 - lib/attribute_normalizer/normalizers/gsub_normalizer.rb
 - lib/attribute_normalizer/normalizers/postal_code_normalizer.rb
 - lib/attribute_normalizer/normalizers/spaceless_normalizer.rb
+- spec/models/float_normalizer_spec.rb
 - spec/models/gsub_normalizer_spec.rb
 - spec/models/postal_code_normalizer_spec.rb
 - spec/models/spaceless_normalizer_spec.rb
@@ -154,21 +157,22 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: attribute_normalizer gem extras
 test_files:
+- spec/models/float_normalizer_spec.rb
 - spec/models/gsub_normalizer_spec.rb
 - spec/models/postal_code_normalizer_spec.rb
 - spec/models/spaceless_normalizer_spec.rb