attr_pouch 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bc7099e267a11a0723eaa8b16654b6221e928bc
-  data.tar.gz: 79fad57b11a02ac0b0093c4d579c7fc109dbbb70
+  metadata.gz: 6792e976af41ddb0abe8289d8e69531052566041
+  data.tar.gz: 829f407d909836b525d760c9e9cd5f392f7eadee
 SHA512:
-  metadata.gz: 4700d4f626b53b6d3dae2211d16e14288b8d51327f8059f8520356bf0de0f977b023fc9d6e1b32c8ec13f6b70093cb9fab0a80e09c05ef19b7e7772afc82f808
-  data.tar.gz: 83accbe6882fef94e44d1ab5aae58a2d66c811b792ce68b0a19f99032158a96e42d9547ed7305b147bd6d2035410948d1c75a84393dc0ced0e7d4c9178be41bd
+  metadata.gz: '0975551cc8167bba0327fcc9177de6891da3da649174a98518757b1f75cc0d6eba5511ab2dfe64fb19e14ff6d2787b239986c7861a2f8d51f620cbeeef8eec7b'
+  data.tar.gz: 2a10e8e7608f667fb0f4f819cbc223dd8921df54995e5319469721681923ed79138af64c4fa41b23c5911b03bc768878bf1cff076d65cac6bc514bfdef4d2e7a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    attr_pouch (0.1.1)
+    attr_pouch (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -230,7 +230,7 @@ abbas.lucky = false # raises ImmutableFieldUpdateError
 
 #### Renaming fields
 
-Fields can be renamed by providing an a previous name or array of
+Fields can be renamed by providing a previous name or an array of
 previous names under the `was` option.
 
 ```ruby
@@ -245,7 +245,7 @@ end
 
 nils = User[name: 'nils'] # in db we have `{ ssl?: true, byzantion?: true }`
 nils.tls?                 # true
-nils.constantinople?      # true
+nils.istanbul?            # true
 ```
 
 Note that no direct accessors are defined for the old names, and if
@@ -253,22 +253,23 @@ the value is updated, it is written under the new name and any old
 values in the pouch are deleted:
 
 ```ruby
+nils.byzantion?       # raises NoMethodError
 nils.istanbul = false
-nils.tls?         # true
-nils.instanbul?   # false
-nils.save_changes # now in db as `{ tls?: true, instanbul?: false }`
+nils.tls?             # true
+nils.instanbul?       # false
+nils.save_changes     # now in db as `{ tls?: true, instanbul?: false }`
 ```
 
 #### Raw value access
 
 Any field can be accessed directly, bypassing the encoder and decoder,
 by specifying the `raw_field` option to provide the name of the setter
-and getter that will directly manipulate the underlying value.
-Required fields are still required when read via `raw_field`, and
-immutable fields are still immutable, but if a `default` is set, the
-raw value will be `nil`, rather than the default itself, to allow the
-user to distinguish between a field value equal to the default and an
-absent field value deferring to the default:
+and getter that will be created to manipulate the underlying value
+directly. Required fields are still required when read via
+`raw_field`, and immutable fields are still immutable, but if a
+`default` is set, the raw value will be `nil`, rather than the default
+itself, to allow the user to distinguish between a field value equal
+to the default and an absent field value deferring to the default:
 
 ```ruby
 class User < Sequel::Model

data/lib/attr_pouch.rb

@@ -308,10 +308,6 @@ module AttrPouch
       end
     end
 
-    def default_pouch
-      wrap({})
-    end
-
     def field(name, opts={})
       unless VALID_FIELD_NAME_REGEXP.match(name)
         raise InvalidFieldError, "Field name must match #{VALID_FIELD_NAME_REGEXP}"
@@ -321,7 +317,7 @@ module AttrPouch
       @fields[name.to_s] = field
 
       storage_field = @storage_field
-      default = default_pouch
+      default_store = wrap({})
 
       @host.class_eval do
         define_method(name) do
@@ -332,7 +328,7 @@ module AttrPouch
         define_method("#{name.to_s.sub(/\?\z/, '')}=") do |value|
           store = self[storage_field]
           was_nil = store.nil?
-          store = default if was_nil
+          store = default_store.dup if was_nil
           changed = field.write(store, value)
           if was_nil
             self[storage_field] = store
@@ -368,7 +364,7 @@ module AttrPouch
           define_method("#{raw_name.to_s.sub(/\?\z/, '')}=") do |value|
             store = self[storage_field]
             was_nil = store.nil?
-            store = default if was_nil
+            store = default_store.dup if was_nil
             changed = field.write(store, value, encode: false)
             if was_nil
               self[storage_field] = store

data/lib/attr_pouch/version.rb

@@ -1,3 +1,3 @@
 module AttrPouch
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/spec/attr_pouch_spec.rb

@@ -57,6 +57,14 @@ describe AttrPouch do
           expect(pouchy.foo).to eq('bar')
         end
 
+        it "does not share stores across object instances" do
+          pouchy1 = pouchy.class.new(foo: "bar")
+          pouchy2 = pouchy.class.new(foo: "baz")
+          pouch1_id = pouchy1[column_name].object_id
+          pouch2_id = pouchy2[column_name].object_id
+          expect(pouch1_id).not_to eq(pouch2_id)
+        end
+
         it "avoids marking the field as modified if it is not changing" do
           pouchy.foo = 'bar'
           expect(pouchy.save_changes).to_not be_nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_pouch
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Maciek Sakrejda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-22 00:00:00.000000000 Z
+date: 2017-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec