attr_keyring 0.5.4 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2af6cd51b5b53137780ac69ddf709a3e0b6f31c4381e0425be63579fce0be85d
-  data.tar.gz: 6c3ac6b0b56ecceeecce9e098d8424f5659d8c5d75d26201f87cc669accfe478
+  metadata.gz: ee86bffa6e27d8523d423c8e8bfefa90a15733fdda28a60155a71fd67a794917
+  data.tar.gz: 340174053331dc2447f2d980ec97d3a4b429f09ed8052ef991908a2de90ad872
 SHA512:
-  metadata.gz: 151441f7e84eb4145206b96635b07b2e55f83eabe7f855fe03a0e880d65030c9165a5bf09646066ecfd6ef28e0de6b90be8449831858893cf325b6d8b2068027
-  data.tar.gz: 4b7bb84692b69a794ac42ca1e5674f6c00659de1c77dcfa0f00111f6d6537719e9cf2ed93122562b79d8f9b8a47ff572b0330410c724065c4d5cfab22d8efa28
+  metadata.gz: 3f4d6593813ab7f4e2e8672108d40b44f068c70fc8ccc59c83eae84bba0851ba3e6996633ef66b87b83f2f5c93038b573062b446e93045902623aba5dbcd653c
+  data.tar.gz: e2379acd02af797c2dcf900957404eb6f8552fe1b11f472c4ea8b5a140b06fbda868eec13e65fa998cc27d11274435e329aec3a12b59f516ecc1dddf779b4f4e

data/.rubocop.yml

@@ -8,7 +8,7 @@ AllCops:
 Metrics/AbcSize:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Exclude:
     - test/**/*
 

data/README.md

@@ -10,7 +10,10 @@
 
 N.B.: attr_keyring is *not* for encrypting passwords--for that, you should use something like [bcrypt](https://github.com/codahale/bcrypt-ruby). It's meant for encrypting sensitive data you will need to access in plain text (e.g. storing OAuth token from users). Passwords do not fall in that category.
 
-This library is heavily inspired by [attr_vault](https://github.com/uhoh-itsmaciek/attr_vault), and can read encrypted messages if you encode them in base64 (e.g. `Base64.strict_encode64(encrypted_by_attr_vault)`).
+This library is heavily inspired by
+[attr_vault](https://github.com/uhoh-itsmaciek/attr_vault), and can read
+encrypted messages if you encode them in base64
+(e.g. `Base64.strict_encode64(encrypted_by_attr_vault)`).
 
 ## Installation
 
@@ -36,7 +39,10 @@ Or install it yourself as:
 gem "attr_keyring"
 require "keyring"
 
-keyring = Keyring.new("1" => "uDiMcWVNTuz//naQ88sOcN+E40CyBRGzGTT7OkoBS6M=")
+keyring = Keyring.new(
+  {"1" => "uDiMcWVNTuz//naQ88sOcN+E40CyBRGzGTT7OkoBS6M="},
+  digest_salt: "<custom salt>"
+)
 
 # STEP 1: Encrypt message using latest encryption key.
 encrypted, keyring_id, digest = keyring.encrypt("super secret")
@@ -52,30 +58,37 @@ puts "✉️ #{decrypted}"
 
 #### Change encryption algorithm
 
-You can choose between `AES-128-CBC`, `AES-192-CBC` and `AES-256-CBC`. By default, `AES-128-CBC` will be used.
-
-To specify the encryption algorithm, set the `encryption` option. The following example uses `AES-256-CBC`.
+You can choose between `AES-128-CBC`, `AES-192-CBC` and `AES-256-CBC`. By
+default, `AES-128-CBC` will be used.
 
-```js
-import { keyring } from "@fnando/keyring";
+To specify the encryption algorithm, set the `encryption` option. The following
+example uses `AES-256-CBC`.
 
-const keys = {"1": "uDiMcWVNTuz//naQ88sOcN+E40CyBRGzGTT7OkoBS6M="};
-const encryptor = keyring(keys, {encryption: "aes-256-cbc"});
+```ruby
+keyring = Keyring.new(
+  "1" => "uDiMcWVNTuz//naQ88sOcN+E40CyBRGzGTT7OkoBS6M=",
+  encryptor: Keyring::Encryptor::AES256CBC,
+  digest_salt: "<custom salt>"
+)
 ```
 
 ### Configuration
 
 As far as database schema goes:
 
-1. You'll need a column to track the key that was used for encryption; by default it's called `keyring_id`.
-2. Every encrypted columns must follow the name `encrypted_<column name>`.
-3. Optionally, you can also have a `<column name>_digest` to help with searching (see Lookup section below).
+1. You'll need a column to track the key that was used for encryption; by
+   default it's called `keyring_id`.
+2. Every encrypted column must follow the name `encrypted_<column name>`.
+3. Optionally, you can also have a `<column name>_digest` to help with searching
+   (see Lookup section below).
 
-As far as model configuration goes, they're pretty similar, as you can see below:
+As far as model configuration goes, they're pretty similar, as you can see
+below:
 
 #### ActiveRecord
 
-From Rails 5+, ActiveRecord models now inherit from `ApplicationRecord` instead. This is how you set it up:
+From Rails 5+, ActiveRecord models now inherit from `ApplicationRecord` instead.
+This is how you set it up:
 
 ```ruby
 class ApplicationRecord < ActiveRecord::Base
@@ -86,7 +99,8 @@ end
 
 #### Sequel
 
-Sequel doesn't have an abstract model class (but it could), so you can set up the model class directly like the following:
+Sequel doesn't have an abstract model class (but it could), so you can set up
+the model class directly like the following:
 
 ```ruby
 class User < Sequel::Model
@@ -96,16 +110,20 @@ end
 
 ### Defining encrypted attributes
 
-To set up your model, you have to define the keyring (set of encryption keys) and the attributes that will be encrypted. Both ActiveRecord and Sequel have the same API, so the examples below work for both ORMs.
+To set up your model, you have to define the keyring (set of encryption keys)
+and the attributes that will be encrypted. Both ActiveRecord and Sequel have the
+same API, so the examples below work for both ORMs.
 
 ```ruby
 class User < ApplicationRecord
-  attr_keyring ENV["USER_KEYRING"]
+  attr_keyring ENV["USER_KEYRING"],
+               digest_salt: "<custom salt>"
   attr_encrypt :twitter_oauth_token, :social_security_number
 end
 ```
 
-The code above will encrypt your columns with the current key. If you're updating a record, then the column will be migrated to the latest key available.
+The code above will encrypt your columns with the current key. If you're
+updating a record, then the column will be migrated to the latest key available.
 
 You can use the model as you would normally do.
 
@@ -126,20 +144,27 @@ user.encrypted_email
 
 ### Encryption
 
-By default, AES-128-CBC is the algorithm used for encryption. This algorithm uses 16 bytes keys, but you're required to use a key that's double the size because half of that keys will be used to generate the HMAC. The first 16 bytes will be used as the encryption key, and the last 16 bytes will be used to generate the HMAC.
+By default, AES-128-CBC is the algorithm used for encryption. This algorithm
+uses 16 bytes keys, but you're required to use a key that's double the size
+because half of that keys will be used to generate the HMAC. The first 16 bytes
+will be used as the encryption key, and the last 16 bytes will be used to
+generate the HMAC.
 
-Using random data base64-encoded is the recommended way. You can easily generate keys by using the following command:
+Using random data base64-encoded is the recommended way. You can easily generate
+keys by using the following command:
 
 ```console
 $ dd if=/dev/urandom bs=32 count=1 2>/dev/null | openssl base64 -A
 qUjOJFgZsZbTICsN0TMkKqUvSgObYxnkHDsazTqE5tM=
 ```
 
-Include the result of this command in the `value` section of the key description in the keyring. Half this key is used for encryption, and half for the HMAC.
+Include the result of this command in the `value` section of the key description
+in the keyring. Half this key is used for encryption, and half for the HMAC.
 
 #### Key size
 
-The key size depends on the algorithm being used. The key size should be double the size as half of it is used for HMAC computation.
+The key size depends on the algorithm being used. The key size should be double
+the size as half of it is used for HMAC computation.
 
 - `aes-128-cbc`: 16 bytes (encryption) + 16 bytes (HMAC).
 - `aes-192-cbc`: 24 bytes (encryption) + 24 bytes (HMAC).
@@ -147,13 +172,24 @@ The key size depends on the algorithm being used. The key size should be double
 
 #### About the encrypted message
 
-Initialization vectors (IV) should be unpredictable and unique; ideally, they will be cryptographically random. They do not have to be secret: IVs are typically just added to ciphertext messages unencrypted. It may sound contradictory that something has to be unpredictable and unique, but does not have to be secret; it is important to remember that an attacker must not be able to predict ahead of time what a given IV will be.
+Initialization vectors (IV) should be unpredictable and unique; ideally, they
+will be cryptographically random. They do not have to be secret: IVs are
+typically just added to ciphertext messages unencrypted. It may sound
+contradictory that something has to be unpredictable and unique, but does not
+have to be secret; it is important to remember that an attacker must not be able
+to predict ahead of time what a given IV will be.
 
-With that in mind, _attr_keyring_ uses `base64(hmac(unencrypted iv + encrypted message) + unencrypted iv + encrypted message)` as the final message. If you're planning to migrate from other encryption mechanisms or read encrypted values from the database without using _attr_keyring_, make sure you account for this. The HMAC is 32-bytes long and the IV is 16-bytes long.
+With that in mind, _attr_keyring_ uses `base64(hmac(unencrypted iv + encrypted
+message) + unencrypted iv + encrypted message)` as the final message. If you're
+planning to migrate from other encryption mechanisms or read encrypted values
+from the database without using _attr_keyring_, make sure you account for this.
+The HMAC is 32-bytes long and the IV is 16-bytes long.
 
 ### Keyring
 
-Keys are managed through a keyring--a short JSON document describing your encryption keys. The keyring must be a JSON object mapping numeric ids of the keys to the key values. A keyring must have at least one key. For example:
+Keys are managed through a keyring--a short JSON document describing your
+encryption keys. The keyring must be a JSON object mapping numeric ids of the
+keys to the key values. A keyring must have at least one key. For example:
 
 ```json
 {
@@ -162,11 +198,14 @@ Keys are managed through a keyring--a short JSON document describing your encryp
 }
 ```
 
-The `id` is used to track which key encrypted which piece of data; a key with a larger id is assumed to be newer. The value is the actual bytes of the encryption key.
+The `id` is used to track which key encrypted which piece of data; a key with a
+larger id is assumed to be newer. The value is the actual bytes of the
+encryption key.
 
 #### Dynamically loading keyring
 
-If you're using Rails 5.2+, you can use credentials to define your keyring. Your `credentials.yml` must be define like the following:
+If you're using Rails 5.2+, you can use credentials to define your keyring.
+Your `credentials.yml` must be define like the following:
 
 ```yaml
 user_keyring:
@@ -174,12 +213,14 @@ user_keyring:
   2: "r6AfOeilPDJomFsiOXLdfQ=="
 ```
 
-Then you can setup your model by using `attr_keyring Rails.application.credentials.user_keyring`.
+Then you can setup your model by using
+`attr_keyring Rails.application.credentials.user_keyring`.
 
-Other possibilities (e.g. the keyring file is provided by configuration management):
+Other possibilities (e.g. the keyring file is provided by configuration
+management):
 
-- `attr_keyring YAML.load_file(keyring_file)`
-- `attr_keyring JSON.parse(File.read(keyring_file))`.
+- `attr_keyring YAML.load_file(keyring_file), digest_salt: "<custom salt>"`
+- `attr_keyring JSON.parse(File.read(keyring_file)), digest_salt: "<custom salt>"`.
 
 ### Lookup
 
@@ -189,17 +230,25 @@ One tricky aspect of encryption is looking up records by known secret. E.g.,
 User.where(email: "john@example.com")
 ```
 
-is trivial with plain text fields, but impossible with the model defined as above.
+is trivial with plain text fields, but impossible with the model defined as
+above.
 
-If a column `<attribute>_digest` exists, then a SHA1 digest from the value will be saved. This will allow you to lookup by that value instead and add unique indexes.
+If a column `<attribute>_digest` exists, then a SHA1 digest from the value will
+be saved. This will allow you to lookup by that value instead and add unique
+indexes. You don't have to use a hashing salt, but it's highly recommended; this
+way you can avoid leaking your users' info via rainbow tables.
 
 ```ruby
-User.where(email: Digest::SHA1.hexdigest("john@example.com"))
+User.where(email: User.keyring.digest("john@example.com")).first
 ```
 
 ### Key Rotation
 
-Because attr_keyring uses a keyring, with access to multiple keys at once, key rotation is fairly straightforward: if you add a key to the keyring with a higher id than any other key, that key will automatically be used for encryption when records are either created or updated. Any keys that are no longer in use can be safely removed from the keyring.
+Because attr_keyring uses a keyring, with access to multiple keys at once, key
+rotation is fairly straightforward: if you add a key to the keyring with a
+higher id than any other key, that key will automatically be used for encryption
+when records are either created or updated. Any keys that are no longer in use
+can be safely removed from the keyring.
 
 To check if an existing key with id `123` is still in use, run:
 
@@ -208,7 +257,8 @@ To check if an existing key with id `123` is still in use, run:
 User.where(keyring_id: 123).empty?
 ```
 
-You may not want to wait for records to be updated (e.g. key leaking). In that case, you can rollout a key rotation:
+You may not want to wait for records to be updated (e.g. key leaking). In that
+case, you can rollout a key rotation:
 
 ```ruby
 User.where(keyring_id: 1234).find_each do |user|
@@ -218,12 +268,18 @@ end
 
 ### What if I don't use ActiveRecord/Sequel?
 
-You can also leverage the encryption mechanism of `attr_keyring` totally decoupled from ActiveRecord/Sequel. First, make sure you load `keyring` instead. Then you can create a keyring to encrypt/decrypt strings, without even touching the database.
+You can also leverage the encryption mechanism of `attr_keyring` totally
+decoupled from ActiveRecord/Sequel. First, make sure you load `keyring` instead.
+Then you can create a keyring to encrypt/decrypt strings, without even touching
+the database.
 
 ```ruby
 require "keyring"
 
-keyring = Keyring.new("1" => "QSXyoiRDPoJmfkJUZ4hJeQ==")
+keyring = Keyring.new(
+  {"1" => "QSXyoiRDPoJmfkJUZ4hJeQ=="},
+  digest_salt: "<custom salt>"
+)
 
 encrypted, keyring_id, digest = keyring.encrypt("super secret")
 
@@ -244,26 +300,42 @@ puts decrypted
 
 ### Exchange data with Node.js
 
-If you use Node.js, you may be interested in <https://github.com/fnando/keyring-node>, which is able to read and write messages using the same format.
+If you use Node.js, you may be interested in
+<https://github.com/fnando/keyring-node>, which is able to read and write
+messages using the same format.
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. Then, run
+`rake test` to run the tests. You can also run `bin/console` for an interactive
+prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`. To
+release a new version, update the version number in `version.rb`, and then run
+`bundle exec rake release`, which will create a git tag for the version, push
+git commits and tags, and push the `.gem` file to
+[rubygems.org](https://rubygems.org).
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/fnando/attr_keyring. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at
+https://github.com/fnando/attr_keyring. This project is intended to be a safe,
+welcoming space for collaboration, and contributors are expected to adhere to
+the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
 
-The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+The gem is available as open source under the terms of the
+[MIT License](https://opensource.org/licenses/MIT).
 
 ## Icon
 
-Icon made by [Icongeek26](https://www.flaticon.com/authors/icongeek26) from [Flaticon](https://www.flaticon.com/) is licensed by Creative Commons BY 3.0.
+Icon made by [Icongeek26](https://www.flaticon.com/authors/icongeek26)
+from [Flaticon](https://www.flaticon.com/) is licensed by Creative Commons BY
+3.0.
 
 ## Code of Conduct
 
-Everyone interacting in the attr_keyring project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/fnando/attr_keyring/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the attr_keyring project’s codebases, issue trackers,
+chat rooms and mailing lists is expected to follow the
+[code of conduct](https://github.com/fnando/attr_keyring/blob/master/CODE_OF_CONDUCT.md).

data/lib/attr_keyring.rb

@@ -26,7 +26,7 @@ module AttrKeyring
       end
 
       self.encrypted_attributes = []
-      self.keyring = Keyring.new({})
+      self.keyring = Keyring.new({}, digest_salt: "")
       self.keyring_column_name = :keyring_id
     end
   end
@@ -40,8 +40,8 @@ module AttrKeyring
       subclass.keyring_column_name = keyring_column_name
     end
 
-    def attr_keyring(keyring, encryptor: Keyring::Encryptor::AES::AES128CBC)
-      self.keyring = Keyring.new(keyring, encryptor)
+    def attr_keyring(keyring, options = {})
+      self.keyring = Keyring.new(keyring, options)
     end
 
     def attr_encrypt(*attributes)

data/lib/attr_keyring/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AttrKeyring
-  VERSION = "0.5.4"
+  VERSION = "0.6.0"
 end

data/lib/keyring.rb

@@ -12,10 +12,19 @@ module Keyring
   InvalidSecret = Class.new(StandardError)
   EmptyKeyring = Class.new(StandardError)
   InvalidAuthentication = Class.new(StandardError)
+  MissingDigestSalt = Class.new(StandardError) do
+    def message
+      %w[
+        Please provide :digest_salt;
+        you can disable this error by explicitly passing an empty string.
+      ].join(" ")
+    end
+  end
 
   class Base
-    def initialize(keyring, encryptor)
-      @encryptor = encryptor
+    def initialize(keyring, options)
+      @encryptor = options[:encryptor]
+      @digest_salt = options[:digest_salt]
       @keyring = keyring.map do |id, value|
         Key.new(id, value, @encryptor.key_size)
       end
@@ -44,13 +53,12 @@ module Keyring
 
     def encrypt(message, keyring_id = nil)
       keyring_id ||= current_key&.id
-      digest = Digest::SHA1.hexdigest(message)
       key = self[keyring_id]
 
       [
         @encryptor.encrypt(key, message),
         keyring_id,
-        digest
+        digest(message)
       ]
     end
 
@@ -58,9 +66,19 @@ module Keyring
       key = self[keyring_id]
       @encryptor.decrypt(key, message)
     end
+
+    def digest(message)
+      Digest::SHA1.hexdigest("#{message}#{@digest_salt}")
+    end
   end
 
-  def self.new(keyring, encryptor = Encryptor::AES::AES128CBC)
-    Base.new(keyring, encryptor)
+  def self.new(keyring, options = {})
+    options = {
+      encryptor: Encryptor::AES::AES128CBC
+    }.merge(options)
+
+    raise MissingDigestSalt if options[:digest_salt].nil?
+
+    Base.new(keyring, options)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_keyring
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.6.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-27 00:00:00.000000000 Z
+date: 2020-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -229,7 +229,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Simple encryption-at-rest plugin for ActiveRecord.