attr_json 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 979ced874e097dcf41e911b60320b8cf05dde0a3fce0256b7127d0ad28de4854
-  data.tar.gz: cfa4e62ba695c5f952adcef69a47453781891f91e854bbe83cf83d4360364773
+  metadata.gz: cd9c25a736bb3b1ce26527c555718efcff2967204d853962048ffc2471af243c
+  data.tar.gz: dc022d69b43b4576d2939bb90f2e172b65b8dd45708b361758554561dc61f44f
 SHA512:
-  metadata.gz: 054c84ddcd6d63b3020656ba64a200c43a8994d28be693a61d37dee5a25352b215e375354ca55ea3cd8f3e80b6427639ba279d2075a52aaa9f9b7a4364506d75
-  data.tar.gz: f2fe2af4a190f7e6c7fe18f2fff235158f209929a0ded8d66543833b8d8b2ca55b93dece3363f71b93000e4c174c48ce3516ab291948dad88b109d0d973987a5
+  metadata.gz: 6457f06b9aed14481b7dd1543929d7010b54d232473f64cde811452083279ab72bbeb92f7a972e903d8994f21f3e263c5163044aa363db4c35a7eadd42710f24
+  data.tar.gz: 8dd0bad4eb89aad50ceb084ecb48a08d0f4b19d67f9421250fb808a2238c159fce891d1e07d37568b6ba6c65c284a9b2b600e1156cf32334a2c7d518d468994d

data/Appraisals

@@ -37,11 +37,5 @@ appraise "rails-edge" do
   # Edge rails, future Rails 7.1 currently allows rack 3 -- but rails itself
   # and some of our other dependencies may not actually work with rack 3 yet,
   # let's test under rack 2. (Nothing in this gem deals with levels as low as rack)
-  #
-  # Bundler was having trouble resolving unless we specified rackup and rack-session
-  # limits too, I think it was a bundler failure, we actually only care about
-  # rack < 3 here.
   gem "rack", "~> 2.0"
-  gem "rackup", "< 2"
-  gem "rack-session", "< 2"
 end

data/CHANGELOG.md

@@ -4,9 +4,9 @@ Notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased](https://github.com/jrochkind/attr_json/compare/v2.0.0...HEAD)
+## [Unreleased](https://github.com/jrochkind/attr_json/compare/v2.0.1...HEAD)
 
-### Changed
+### Fixed
 
 *
 
@@ -22,6 +22,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 *
 
+## [2.0.1](https://github.com/jrochkind/attr_json/compare/v2.0.0...v2.0.1)
+
+
+### Fixed
+
+* You can now do a specified ActiveRecord `.select` without your json containers, to fetch an object with other attributes that you can access. https://github.com/jrochkind/attr_json/pull/193
+
+### Changed
+
+* Refactor #attr_json_sync_to_rails_attributes for slightly improved performance. https://github.com/jrochkind/attr_json/pull/192
+
+* Safety guard in sync_to_rails_attributes against unknown edge case where container is nil https://github.com/jrochkind/attr_json/pull/194
+
 
 ## [2.0.0](https://github.com/jrochkind/attr_json/compare/v1.5.0...v2.0.0)
 

data/gemfiles/rails_edge.gemfile

@@ -16,7 +16,5 @@ gem "webdrivers", "~> 5.0"
 gem "selenium-webdriver"
 gem "byebug"
 gem "rack", "~> 2.0"
-gem "rackup", "< 2"
-gem "rack-session", "< 2"
 
 gemspec path: "../"

data/lib/attr_json/record.rb

@@ -48,23 +48,33 @@ module AttrJson
     # mutation of mutable object will effect both places, for instance for dirty
     # tracking.
     def attr_json_sync_to_rails_attributes
-      self.class.attr_json_registry.attribute_names.each do |attr_name|
+      self.class.attr_json_registry.definitions.group_by(&:container_attribute).each_pair do |container_attribute, definitions|
         begin
-          attribute_def = self.class.attr_json_registry.fetch(attr_name.to_sym)
-          json_value    = public_send(attribute_def.container_attribute)
-          value         = json_value[attribute_def.store_key]
+          # column may have eg been left out of an explicit 'select'
+          next unless has_attribute?(container_attribute)
 
-          if value
-            # TODO, can we just make this use the setter?
-            write_attribute(attr_name, value)
+          container_value    = public_send(container_attribute)
 
-            clear_attribute_change(attr_name) if persisted?
+          # isn't expected to be possible to be nil rather than empty hash, but
+          # if it is from some edge case, well, we don't have values to sync, fine
+          next if container_value.nil?
 
-            # writing and clearning will result in a new object stored in
-            # rails attributes, we want
-            # to make sure the exact same object is in the json attribute,
-            # so in-place mutation changes to it are reflected in both places.
-            json_value[attribute_def.store_key] = read_attribute(attr_name)
+          definitions.each do |attribute_def|
+            attr_name     = attribute_def.name
+            value         = container_value[attribute_def.store_key]
+
+            if value
+              # TODO, can we just make this use the setter?
+              write_attribute(attr_name, value)
+
+              clear_attribute_change(attr_name) if persisted?
+
+              # writing and clearning will result in a new object stored in
+              # rails attributes, we want
+              # to make sure the exact same object is in the json attribute,
+              # so in-place mutation changes to it are reflected in both places.
+              container_value[attribute_def.store_key] = read_attribute(attr_name)
+            end
           end
         rescue AttrJson::Type::Model::BadCast, AttrJson::Type::PolymorphicModel::TypeError => e
           # There was bad data in the DB, we're just going to skip the Rails attribute sync.

data/lib/attr_json/version.rb

@@ -1,3 +1,3 @@
 module AttrJson
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_json
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Jonathan Rochkind
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-30 00:00:00.000000000 Z
+date: 2023-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -206,7 +206,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.5
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: ActiveRecord attributes stored serialized in a json column, super smooth.