attr_json 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05247aceb96f0df4ce9f36a4f6c56099700a33aeddcc0d2a9596330f0ecb23c9
-  data.tar.gz: ed213264805ed42866d00c6e03e5504a63c96763ac1f83a3518302dbb5c51954
+  metadata.gz: 80130e194fdf715bf967ea25fc6fff1d7e043f53479c1e539d9b9e2122233404
+  data.tar.gz: df2d7d442df1dfec49becd935321a0fbdc8aebec5892e34d84d415c4f5a87471
 SHA512:
-  metadata.gz: 193073a8b1ac277d2f062bb8fae958ec2be300e53216e29fd7af5cf8e70db96e39da92c23ee2f452907b31e55fca0966dff7dd6e45c270028dd2c400a4f53477
-  data.tar.gz: d92e6761a2dfab4db80931a5af85bbad112631b12f0c62536fcd5ff532df41ffb475a0bea3cd10ac7d013b7ab4d779a19e2af980ab00fa320168715840e32fcc
+  metadata.gz: 1e2712bca13ff4fa2b874b5f141070cd5f8e5ab306c6ff9f5e41a7129c4a7b740f6ce0a79a7f9cdf759195cb1c7d144bd0d8ea7ef6d46682487f8d75a47a1c25
+  data.tar.gz: 1c86d1e8cea7a9413960fa357507fd5ba25e55c6f27820fb091bd8f4921c3aa7aa3274c90bd30f93b8cdde521d177d6a3cebe9154757038f2b30ba5cebbf970e

data/lib/attr_json/attribute_definition.rb

@@ -12,7 +12,9 @@
     attr_reader :name, :type, :original_args, :container_attribute
 
     # @param name [Symbol,String]
-    # @param type [Symbol,ActiveModel::Type::Value]
+    # @param type [Symbol,ActiveModel::Type::Value] Symbol is looked up in
+    #   ActiveRecord::Type.lookup, but with `adapter: nil` for no custom
+    #   adapter-specific lookup.
     #
     # @option options store_key [Symbol,String]
     # @option options container_attribute [Symbol,ActiveModel::Type::Value]
@@ -40,7 +42,12 @@
         # ActiveModel::Type.lookup may make more sense, but ActiveModel::Type::Date
         # seems to have a bug with multi-param assignment. Mostly they return
         # the same types, but ActiveRecord::Type::Date works with multi-param assignment.
-        type = ActiveRecord::Type.lookup(type)
+        #
+        # We pass `adapter: nil` to avoid triggering a db connection.
+        # See: https://github.com/jrochkind/attr_json/issues/41
+        # This is at the "cost" of not using any adapter-specific types... which
+        # maybe preferable anyway?
+        type = ActiveRecord::Type.lookup(type, adapter: nil)
       elsif ! type.is_a? ActiveModel::Type::Value
         raise ArgumentError, "Second argument (#{type}) must be a symbol or instance of an ActiveModel::Type::Value subclass"
       end

data/lib/attr_json/record.rb

@@ -18,7 +18,7 @@ module AttrJson
     extend ActiveSupport::Concern
 
     included do
-      unless self < ActiveRecord::Base
+      unless self <= ActiveRecord::Base
         raise TypeError, "AttrJson::Record can only be used with an ActiveRecord::Base model. #{self} does not appear to be one. Are you looking for ::AttrJson::Model?"
       end
 

data/lib/attr_json/type/model.rb

@@ -8,6 +8,8 @@ module AttrJson
     # but normally that's only done in AttrJson::Model.to_type, there isn't
     # an anticipated need to create from any other place.
     class Model < ::ActiveModel::Type::Value
+      class BadCast < ArgumentError ; end
+
       attr_accessor :model
       def initialize(model)
         #TODO type check, it really better be a AttrJson::Model. maybe?
@@ -34,10 +36,11 @@ module AttrJson
           # TODO Maybe we ought not to do this on #to_h?
           model.new_from_serializable(v.to_h)
         else
-          # Bad input? Most existing ActiveModel::Types seem to decide
-          # either nil, or a base value like the empty string. They don't
-          # raise. So we won't either, just nil.
-          nil
+          # Bad input. Originally we were trying to return nil, to be like
+          # existing ActiveRecord which kind of silently does a basic value
+          # with null input. But that ended up making things confusing, let's
+          # just raise.
+          raise BadCast.new("Can not cast from #{v.inspect} to #{self.type}")
         end
       end
 

data/lib/attr_json/version.rb

@@ -1,3 +1,3 @@
 module AttrJson
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_json
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Jonathan Rochkind
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2019-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: ActiveRecord attributes stored serialized in a json column, super smooth.