attr_extras 4.6.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38b2b1b3e247d7f1dbc20e44110939f9ff6366e0
-  data.tar.gz: df85b55e2c60037a153f6127dc9758ce329b9b2b
+  metadata.gz: fd15c690db7cddf4aa28a7bd1c461d01b07883e5
+  data.tar.gz: 02a2356ba8d7a3ebd8a5dc944a92cd3a337df577
 SHA512:
-  metadata.gz: c1a61d4507ca8ce8f60e0def7521cde84e6918025125f0573add4b3271b1edcd0cf831d7c9f34a37970951abe8051339ebe83b1e33aa9fcf9efa4b86e4f46731
-  data.tar.gz: 9c17ccb154eda8c4790654c80ab32a5ccd34e4dbf06dc31717e3b6511b8e8ee19d2370f50496b04beb17af582689c930e2eb77d1a753de9223a09deb753782f0
+  metadata.gz: c7fe4495e99a5bfde538d23bb1d39e48add881babe4da8c9b3d819bb3803db465c7a8452070a4e02c1ca772ac1a8572c1b5b83c36df9ad3bf38dd5b218a5ff6c
+  data.tar.gz: 0c3f59b421f30e9ac25702851ce9fae3c56f4286b4d9e27fef241a2f0753162bdbd3cb067704999fb28f34e29661c2d62d83293030d57a48664ce834d6b47942

data/README.md

@@ -58,6 +58,8 @@ Also provides conveniences for creating value objects, method objects, query met
 
 `attr_initialize [:bar, :baz!]` defines an initializer that takes one hash argument, assigning `@bar` (optional) and `@baz` (required).
 
+If you pass unknown hash arguments, you will get an `ArgumentError`.
+
 `attr_initialize` can also accept a block which will be invoked after initialization. This is useful for e.g. initializing private data as necessary.
 
 

data/lib/attr_extras/attr_initialize.rb

@@ -21,6 +21,12 @@ class AttrExtras::AttrInitialize
         if name_or_names.is_a?(Array)
           hash = value || {}
 
+          known_keys = name_or_names.map { |name| name.to_s.sub(/!\z/, "").to_sym }
+          unknown_keys = hash.keys - known_keys
+          if unknown_keys.any?
+            raise ArgumentError, "Got unknown keys: #{unknown_keys.inspect}; allowed keys: #{known_keys.inspect}"
+          end
+
           name_or_names.each do |name|
             set_ivar_from_hash.call(self, name, hash)
           end

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "4.6.0"
+  VERSION = "5.0.0"
 end

data/spec/attr_extras/attr_initialize_spec.rb

@@ -56,6 +56,18 @@ describe Object, ".attr_initialize" do
     lambda { klass.new(:optional => "X") }.must_raise KeyError
   end
 
+  it "complains about unknown hash values" do
+    klass = Class.new do
+      attr_initialize :foo, [:bar]
+    end
+
+    # Should not raise.
+    klass.new("Foo", :bar => "Bar")
+
+    exception = lambda { klass.new("Foo", :bar => "Bar", :baz => "Baz") }.must_raise ArgumentError
+    exception.message.must_include "baz"
+  end
+
   it "accepts a block for initialization" do
     klass = Class.new do
       attr_initialize :value do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-16 00:00:00.000000000 Z
+date: 2016-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest