attr_extras 4.2.0 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 02abc2f4fe382b84b370d6f777be15a50bf136c7
-  data.tar.gz: bfee4d693acfdb8c1a15f9ed50677be6f21149a5
+  metadata.gz: 7a2e11ff4aab1d128893a0145fb72ebc026ac4b5
+  data.tar.gz: 2bf233446caf0aefb3f7e16db7e388bc216cde34
 SHA512:
-  metadata.gz: 5a44ccd28222d3708b7f4b87d74f7f1a605b462ef8980e6b510844e8eca0aa2db9e4f0ae12df38f33b66bf9bbf4a48b08321763ba223ab8bea0abd2eb5c9bfe0
-  data.tar.gz: eff2da3b058ff22016362fec1e5a92e5a9c3cc5c1d88eea67341cc4bfec9b421b572d4296996c63b3baf50dbe168f150aae5111523ac0cee72afaad9f707dcb2
+  metadata.gz: 2d61715715969959cf37ee1e7c6ba1a553675e14bd516cfddd76ea5c0758cb7518af05e3a437407392152e7960c5b3e389350a52c57f3b4297caa29b4c9a36c6
+  data.tar.gz: ac7e05c8f8cb05e554b59b644e5d0115f195b0bb9555e06d5918c1c0f46995c2c96224b94ccb52b203410df7696a04ec931fe2c5622f4b5a5d228ba0e558f664

data/README.md

@@ -1,4 +1,5 @@
 [![Build status](https://secure.travis-ci.org/barsoom/attr_extras.png)](https://travis-ci.org/#!/barsoom/attr_extras/builds)
+[![Code Climate](https://codeclimate.com/github/barsoom/attr_extras/badges/gpa.svg)](https://codeclimate.com/github/barsoom/attr_extras)
 
 # attr\_extras
 

data/lib/attr_extras.rb

@@ -1,9 +1,13 @@
 require "attr_extras/version"
 require "attr_extras/attr_initialize"
+require "attr_extras/attr_value"
 require "attr_extras/attr_query"
 require "attr_extras/utils"
 
 module AttrExtras
+  # To avoid masking coding errors, we don't inherit from StandardError (which would be implicitly rescued). Forgetting to define a requisite method isn't just some runtime error.
+  class MethodNotImplementedError < Exception; end
+
   module ModuleMethods
     def attr_initialize(*names, &block)
       AttrInitialize.new(self, names, block).apply
@@ -19,21 +23,7 @@ module AttrExtras
     end
 
     def attr_value(*names)
-      attr_reader(*names)
-
-      define_method(:==) do |other|
-        return false unless other.is_a?(self.class)
-
-        names.all? { |attr| self.public_send(attr) == other.public_send(attr) }
-      end
-
-      # Both #eql? and #hash are required for hash identity.
-
-      alias_method :eql?, :==
-
-      define_method(:hash) do
-        [ self.class, *names.map { |attr| public_send(attr) } ].hash
-      end
+      AttrValue.new(self, *names).apply
     end
 
     def pattr_initialize(*names, &block)
@@ -90,7 +80,7 @@ module AttrExtras
               raise ArgumentError, "wrong number of arguments (#{provided_arity} for #{arity})"
             end
 
-            raise "Implement a '#{name}(#{arg_names.join(", ")})' method"
+            raise MethodNotImplementedError, "Implement a '#{name}(#{arg_names.join(", ")})' method"
           else
             super(name, *args)
           end

data/lib/attr_extras/attr_value.rb

@@ -0,0 +1,42 @@
+class AttrExtras::AttrValue
+  def initialize(klass, *names)
+    @klass, @names = klass, names
+  end
+
+  attr_reader :klass, :names
+  private :klass, :names
+
+  def apply
+    define_readers
+    define_equals
+    define_hash_identity
+  end
+
+  private
+
+  def define_readers
+    klass.send(:attr_reader, *names)
+  end
+
+  def define_equals
+    names = @names  # Make available within block.
+
+    klass.send(:define_method, :==) do |other|
+      return false unless other.is_a?(self.class)
+
+      names.all? { |attr| self.public_send(attr) == other.public_send(attr) }
+    end
+  end
+
+  def define_hash_identity
+    names = @names  # Make available within block.
+
+    # Both #eql? and #hash are required for hash identity.
+
+    klass.send(:alias_method, :eql?, :==)
+
+    klass.send(:define_method, :hash) do
+      [ self.class, *names.map { |attr| public_send(attr) } ].hash
+    end
+  end
+end

data/lib/attr_extras/version.rb

@@ -1,3 +1,3 @@
 module AttrExtras
-  VERSION = "4.2.0"
+  VERSION = "4.3.0"
 end

data/spec/attr_implement_spec.rb

@@ -7,7 +7,7 @@ describe Object, ".attr_implement" do
     end
 
     example = klass.new
-    exception = lambda { example.foo }.must_raise RuntimeError
+    exception = lambda { example.foo }.must_raise AttrExtras::MethodNotImplementedError
     exception.message.must_equal "Implement a 'foo()' method"
   end
 
@@ -18,7 +18,7 @@ describe Object, ".attr_implement" do
 
     example = klass.new
 
-    exception = lambda { example.foo(1, 2) }.must_raise RuntimeError
+    exception = lambda { example.foo(1, 2) }.must_raise AttrExtras::MethodNotImplementedError
     exception.message.must_equal "Implement a 'foo(name, age)' method"
 
     lambda { example.foo }.must_raise ArgumentError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: attr_extras
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.3.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-15 00:00:00.000000000 Z
+date: 2015-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -58,6 +58,7 @@ files:
 - lib/attr_extras.rb
 - lib/attr_extras/attr_initialize.rb
 - lib/attr_extras/attr_query.rb
+- lib/attr_extras/attr_value.rb
 - lib/attr_extras/utils.rb
 - lib/attr_extras/version.rb
 - script/test