attr_cleaner 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13fd121c241acea325b5ab89c95aefdaabc91a22
-  data.tar.gz: f4dd8fca1416c874e971899ab4559a62717a1beb
+  metadata.gz: a648298a58351a7c51cdc84c70a7dc82d18d5dba
+  data.tar.gz: b95bc98b3b3d6d3d5e9a60afb18d6d5e6bb2a595
 SHA512:
-  metadata.gz: 02dbd6aab1d253c9a137e03a6edeed70b0f76242b8c5af4cb737173b4da15cdb7bba2c343fcb1f9fb6c09ecade4651ad0e19de7a52f4d47b11b78d3a4faa7d75
-  data.tar.gz: b0206eee8379393eb280f870ea2748933483ccfe87c2bb81804d464e89b825dea011abea2ec12566cbd2f7e7a70294c1f99a575bd71f37a87128d3394be98202
+  metadata.gz: 3bcae6cf34caa84c58f0a9593ec45d7d5174650a054177537ac2467c7b255ba111988eb6ab23d48552e7eb3e9e31ee58fe503382e79fa53ab6d2c31291e055c7
+  data.tar.gz: bc129d4fb179183f7004c9c8c568d7e2afd25f94909cd2feb56382301dcff87bec388704fb47344affd05c6ffd0353450bda879424239d04882d6c7a89324d33

data/.ruby-version

@@ -1 +1 @@
-ruby-2.3.3
+ruby-2.4.3

data/.travis.yml

@@ -9,16 +9,20 @@ env:
 
 rvm:
   - 1.9.3
-  - 2.3.3
+  - 2.4.3
+  - 2.5.0
 
 gemfile:
   - gemfiles/rails_4.2.gemfile
   - gemfiles/rails_5.0.gemfile
+  - gemfiles/rails_5.1.gemfile
 
 matrix:
   exclude:
   - rvm: 1.9.3
     gemfile: gemfiles/rails_5.0.gemfile
+  - rvm: 1.9.3
+    gemfile: gemfiles/rails_5.1.gemfile
 
 before_install: gem update bundler
 bundler_args: --without tools

data/Appraisals

@@ -1,4 +1,4 @@
-["4.2", "5.0"].each do |rails|
+["4.2", "5.0", "5.1"].each do |rails|
   appraise "rails-#{rails}" do
     gem "activerecord", "~> #{rails}", require: "active_record"
   end

data/README.md

@@ -1,11 +1,11 @@
 # AttrCleaner
 
+[![Travis CI](https://travis-ci.org/thomasfedb/attr_cleaner.svg?branch=master)](https://travis-ci.org/thomasfedb/attr_cleaner)
+
 Cleans up your model attributes. Strips leading and trailing space, and turns
 empty strings into `nil`.
 
-Tested against Rails 4.2 and 5.0.
-
-![Travis CI](https://travis-ci.org/thomasfedb/attr_cleaner.svg?branch=master)
+Tested against Rails 4.2, 5.0, and 5.1.
 
 ## Install
 
@@ -15,44 +15,26 @@ If you're using Rails with ActiveRecord all you need to do is:
 gem "attr_cleaner"
 ```
 
-AttrCleaner will also work with any ORM that writes attributes via a method
-called `write_attribute`.
-
-To get AttrCleaner working with your ORM just include it into your models:
-
-```ruby
-include AttrCleaner::Model
-```
-
-AttrCleaner can also be used outside of Rails if ActiveSupport 3 is avalable.
-If you're using AttrCleaner outside of Rails, and it detects ActiveRecord is
-allready loaded, it will include itself into ActiveRecod. Make sure ActiveRecord
-is loaded first.
-
 ## Usage
 
-Simply add this to any model you want to clean:
+Simply pass a list of attributes that you want to clean:
 
 ```ruby
-attr_cleaner
+attr_cleaner :title, :body
 ```
 
-You can restrict the cleaning to specific attributes with `:only` and `:except`:
+Child models will inherit the attribute writers from their parent.
 
-```ruby
-attr_cleaner only: :name
-attr_cleaner only: [:name, :age]
-attr_cleaner except: :age
-attr_cleaner except: [:age, :price]
-```
+## Other ORMs
 
-Settings are be inherited, so sometimes you may need both `:only` and `:except`:
+AttrCleaner works by generating attribute setters and should work with most ORMs.
+
+To get AttrCleaner working with your ORM just include it into your models:
 
 ```ruby
-# Remove :age from the list, add :name
-attr_cleaner only: :name, except: :age
+include AttrCleaner::Model
 ```
 
 ## Copyright
 
-Copyright © 2010 Thomas Drake-Brockman
+Copyright © 2018 Thomas Drake-Brockman

data/gemfiles/rails_5.1.gemfile

@@ -0,0 +1,14 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rspec"
+gem "jamjar"
+gem "activerecord", "~> 5.1", :require => "active_record"
+
+group :tools do
+  gem "appraisal"
+  gem "byebug"
+end
+
+gemspec :path => "../"

data/lib/attr_cleaner/model.rb

@@ -1,24 +1,23 @@
 module AttrCleaner
   module Model
     extend ActiveSupport::Concern
-
-    included do
-      alias_method_chain :write_attribute, :cleaner
-      class_attribute :attr_cleaners
-    end
-
-    def write_attribute_with_cleaner(attr_name, value)
-      if Array(attr_cleaners).include?(attr_name.to_sym) && value.is_a?(String)
-        value = value.strip
-        value = nil if value.empty?
+    
+    module ClassMethods
+      def attr_cleaner(*columns)
+        columns.each do |column|
+          define_attr_cleaner(column)
+        end
       end
 
-      write_attribute_without_cleaner(attr_name, value)
-    end
+      def define_attr_cleaner(column)
+        define_method "#{column}=" do |value|
+          if value.is_a?(String)
+            value = value.strip
+            value = nil if value.empty?
+          end
 
-    module ClassMethods
-      def attr_cleaner(*columns)
-        self.attr_cleaners = columns
+          super(value)
+        end
       end
     end
   end

data/lib/attr_cleaner/version.rb

@@ -1,3 +1,3 @@
 module AttrCleaner
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/spec/attr_cleaner/model_spec.rb

@@ -10,14 +10,6 @@ describe AttrCleaner::Model do
 
   let(:instance) { model.new }
 
-  describe ".attr_cleaner" do
-    context "called with attributes" do
-      before { model.attr_cleaner :title, :body }
-
-      specify { expect(model.attr_cleaners).to eq [:title, :body] }
-    end
-  end
-
   describe "#write_attribute_with_cleaner" do
     context "with no cleaners" do
       context "a padding string is assigned" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: attr_cleaner
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Thomas Drake-Brockman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-29 00:00:00.000000000 Z
+date: 2018-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -43,6 +43,7 @@ files:
 - attr_cleaner.gemspec
 - gemfiles/rails_4.2.gemfile
 - gemfiles/rails_5.0.gemfile
+- gemfiles/rails_5.1.gemfile
 - lib/attr_cleaner.rb
 - lib/attr_cleaner/model.rb
 - lib/attr_cleaner/railtie.rb
@@ -68,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Cleans up model attributes.