attr_bucket 0.1.2 → 0.2.0

data/Rakefile

@@ -1,2 +1,8 @@
 require 'bundler'
+require 'rspec/core/rake_task'
+
 Bundler::GemHelper.install_tasks
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/attr_bucket.gemspec

@@ -12,7 +12,9 @@ Gem::Specification.new do |s|
   s.summary     = %q{Your model can has a bucket (for its attributes).}
   s.description = %q{Store a few extra (non-searchable) attributes away in a bucket. This is probably a horrible idea, but try it anyway.}
 
-  s.add_runtime_dependency(%q<activerecord>, ["~> 3.0.0"])
+  s.add_runtime_dependency 'activerecord', '~> 3.0.0'
+  s.add_development_dependency 'rspec', '~> 2.4.0'
+  s.add_development_dependency 'sqlite3'
 
   s.rubyforge_project = "attr_bucket"
 

data/lib/attr_bucket.rb

@@ -14,6 +14,22 @@ module AttrBucket
     read_attribute(name)
   end
 
+  def valid_class(value, type)
+    case type
+      when :integer       then Fixnum === value
+      when :float         then Float === value
+      when :decimal       then BigDecimal === value
+      when :datetime      then Time === value
+      when :date          then Date === value
+      when :timestamp     then Time === value
+      when :time          then Time === value
+      when :text, :string then String === value
+      when :binary        then String === value
+      when :boolean       then [TrueClass, FalseClass].grep value
+      else false
+    end
+  end
+
   # Swipe the nifty column typecasting from the column class
   # underlying the bucket column, or use the call method of
   # the object supplied for +type+ if it responds to call.
@@ -25,7 +41,7 @@ module AttrBucket
 
     return type.call(value) if type.respond_to?(:call)
 
-    case type
+    typecasted = case type
       when :string    then value.to_s
       when :text      then value.to_s
       when :integer   then value.to_i rescue value ? 1 : 0
@@ -39,6 +55,10 @@ module AttrBucket
       when :boolean   then column_class.value_to_boolean(value)
       else value
     end
+
+    raise ArgumentError, "Unable to typecast #{value} to #{type}" unless valid_class(typecasted, type)
+
+    typecasted
   end
 
   module ClassMethods
@@ -107,6 +127,7 @@ module AttrBucket
       define_method "#{attr_name}=" do |val|
         # TODO: Make this more resilient/granular for multiple bucketed changes
         send("#{bucket_name}_will_change!")
+        typecasted = explicitly_type_cast(val, attr_type, column_class)
         get_attr_bucket(bucket_name)[attr_name] = explicitly_type_cast(val, attr_type, column_class)
       end unless method_defined? "#{attr_name}="
     end

data/lib/attr_bucket/version.rb

@@ -1,3 +1,3 @@
 module AttrBucket
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/attr_bucket_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+
+describe AttrBucket do
+
+  it 'should define an private attr_bucket method in AR::Base' do
+    ActiveRecord::Base.private_methods.should include :attr_bucket
+  end
+
+  it 'should define an i_has_a_bucket alias in AR::Base' do
+    ActiveRecord::Base.private_methods.should include :i_has_a_bucket
+  end
+
+  it 'should raise an ArgumentError when defining a bucket on a non-text column' do
+    expect { a_class_with_bucket :name => :blah }.to raise_error ArgumentError
+  end
+
+  context 'object with a bucketed attribute named "nickname"' do
+    before do
+      @o = an_object_with_bucket :bucket => :nickname
+    end
+
+    it 'should cast nickname to string' do
+      @o.nickname = 42
+      @o.nickname.should eq '42'
+    end
+
+    it 'should support validations' do
+      @o.class.validates_presence_of :nickname
+      expect { @o.save! }.to raise_error ActiveRecord::RecordInvalid
+    end
+
+    it 'should maintain bucketed attributes when saved' do
+      @o.nickname = 'Headly von Headenstein'
+      @o.save
+
+      persisted_item.nickname.should eq 'Headly von Headenstein'
+    end
+  end
+
+  context 'object with bucketed attributes in array format' do
+    before do
+      @o = an_object_with_bucket :bucket => [:quest, :favorite_color]
+    end
+
+    it 'should cast all values to strings' do
+      @o.quest = 1
+      @o.favorite_color = 2
+
+      [@o.quest, @o.favorite_color].should eq ['1', '2']
+    end
+  end
+
+  context 'object with bucketed attributes in hash format' do
+    before do
+      @o = an_object_with_bucket :bucket => {
+        :summary           => :text,
+        :age               => :integer,
+        :body_temp         => :float,
+        :salary            => :decimal,
+        :hired_at          => :datetime,
+        :stamp             => :timestamp,
+        :workday_starts_at => :time,
+        :birthday          => :date,
+        :binary_data       => :binary,
+        :is_awesome        => :boolean,
+        :processed_name    => proc { |val| "PROCESSED: #{val}" }
+      }
+    end
+
+    it 'typecasts to String for :text' do
+      @o.summary = 12345
+      @o.summary.should be_a String
+      @o.summary.should eq '12345'
+    end
+
+    it 'typecasts to Fixnum for :integer' do
+      @o.age = '33'
+      @o.age.should be_a Fixnum
+      @o.age.should eq 33
+    end
+
+    it 'typecasts to Float for :float' do
+      @o.body_temp = '98.6'
+      @o.body_temp.should be_a Float
+      @o.body_temp.should eq 98.6
+    end
+
+    it 'typecasts to BigDecimal for :decimal' do
+      @o.salary = '50000.23'
+      @o.salary.should be_a BigDecimal
+      @o.salary.should eq 50000.23
+    end
+
+    it 'typecasts to Time for :datetime' do
+      @o.hired_at = '2011-01-01 08:00:00'
+      @o.hired_at.should be_a Time
+      @o.hired_at.should eq Time.parse '2011-01-01 08:00:00'
+    end
+
+    it 'typecasts to Time for :timestamp' do
+      @o.stamp = '2011-01-01 08:00:00'
+      @o.stamp.should be_a Time
+      @o.stamp.should eq Time.parse '2011-01-01 08:00:00'
+    end
+
+    it 'typecasts to dummy Time for :time' do
+      @o.workday_starts_at = '08:00:00'
+      @o.workday_starts_at.should be_a Time
+      @o.workday_starts_at.should eq Time.parse '2000-01-01 08:00:00'
+    end
+
+    it 'typecasts to Date for :date in string format' do
+      @o.birthday = '1977/8/29'
+      @o.birthday.should be_a Date
+      @o.birthday.should eq Date.new(1977, 8, 29)
+    end
+
+    it 'typecasts to String for :binary' do
+      @o.binary_data = File.read(__FILE__)
+      @o.binary_data.should be_a String
+      @o.binary_data.should match /@o.binary_data.should match/  # ooh, meta.
+    end
+
+    it 'typecasts to TrueClass/FalseClass for :boolean' do
+      @o.is_awesome = '1'
+      @o.should be_awesome
+    end
+
+    it 'performs custom processing when an attribute has a proc "type"' do
+      @o.processed_name = 'Ernie'
+      @o.processed_name.should be_a String
+      @o.processed_name.should eq 'PROCESSED: Ernie'
+    end
+
+    it 'should raise ArgumentError if unable to typecast a value' do
+      expect { @o.stamp = 123456 }.to raise_error ArgumentError
+    end
+  end
+end

data/spec/helpers/attr_bucket_helper.rb

@@ -0,0 +1,15 @@
+module AttrBucketHelper
+  def a_class_with_bucket(opts)
+    Item.delete_all
+    Object.send :remove_const, :AttrBucketItem if Object.const_defined? :AttrBucketItem
+    Object.const_set :AttrBucketItem, Class.new(Item) { attr_bucket opts }
+  end
+
+  def an_object_with_bucket(opts)
+    a_class_with_bucket(opts).new
+  end
+
+  def persisted_item
+    AttrBucketItem.first
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+require 'rubygems'
+require 'bundler/setup'
+require 'attr_bucket'
+
+Dir[File.expand_path('../{helpers,support}/*.rb', __FILE__)].each do |f|
+  require f
+end
+
+RSpec.configure do |config|
+  config.before :suite do
+    Schema.create
+  end
+
+  config.include AttrBucketHelper
+end

data/spec/support/schema.rb

@@ -0,0 +1,27 @@
+ActiveRecord::Base.establish_connection(
+  :adapter  => 'sqlite3',
+  :database => ':memory:'
+)
+
+class Item < ActiveRecord::Base
+  def awesome?
+    respond_to?(:is_awesome) && is_awesome
+  end
+end
+
+module Schema
+  def self.create
+    ActiveRecord::Base.silence do
+      ActiveRecord::Migration.verbose = false
+
+      ActiveRecord::Schema.define do
+        create_table :items, :force => true do |t|
+          t.string   :name
+          t.string   :type
+          t.text     :bucket
+          t.text     :other_bucket
+        end
+      end
+    end
+  end
+end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 1
   - 2
-  version: 0.1.2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: 
 - Ernie Miller
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-28 00:00:00 -05:00
+date: 2011-01-29 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -32,6 +32,34 @@ dependencies:
         version: 3.0.0
   type: :runtime
   version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 4
+        - 0
+        version: 2.4.0
+  type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: sqlite3
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id003
 description: Store a few extra (non-searchable) attributes away in a bucket. This is probably a horrible idea, but try it anyway.
 email: 
 - ernie@metautonomo.us
@@ -50,6 +78,10 @@ files:
 - attr_bucket.gemspec
 - lib/attr_bucket.rb
 - lib/attr_bucket/version.rb
+- spec/attr_bucket_spec.rb
+- spec/helpers/attr_bucket_helper.rb
+- spec/spec_helper.rb
+- spec/support/schema.rb
 has_rdoc: true
 homepage: http://metautonomo.us
 licenses: []
@@ -82,5 +114,8 @@ rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Your model can has a bucket (for its attributes).
-test_files: []
-
+test_files: 
+- spec/attr_bucket_spec.rb
+- spec/helpers/attr_bucket_helper.rb
+- spec/spec_helper.rb
+- spec/support/schema.rb