atompark-sms-api 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74d7bbb7fdbbc9c57af816e4fe3148caa52a5a15
-  data.tar.gz: 2cf1c24001c9175021b3b5433e9e36d1e87b68d9
+  metadata.gz: 1fe14b3d81e256c5ee664d9e09a53e5cdf959888
+  data.tar.gz: 213c36795e4c1a4f4a226642350c7d10f5979de8
 SHA512:
-  metadata.gz: e4538d4846c9ba66034f637d77dd19c4856022af33435288e48bdd2aa8e7a19938680e09b49801d3b2f259a3901655205f66922d9b36648f94d8d8aad864ba99
-  data.tar.gz: b2d06f8e31c92307ae46acb96b250504da71cb322bd10287dbbfc49cf16830654654f3ed812418ec0e9bcc1b53cdb9c4101de59454297ae95702ec4db93d1a1a
+  metadata.gz: 206b6b336d32e994df41b44f53a34f6f1f408d0669bbb15d440a72864295d569a19fab4afdb2b83bc49a41102e0bfd10d6bbd597c0bd2090d0476d8765041472
+  data.tar.gz: 637db40716cd253a52ea17031433168fbc6c08031f806d1655968ec1934096b046cd95f439612bba966aac06aa340bd1380a35f34dd0a30683291aa071cdcbf3

data/lib/atompark-sms-api/configuration.rb

@@ -8,12 +8,13 @@ module AtomparkSmsApi
   end
 
   class Configuration
-    attr_accessor :pubkey, :pvtkey, :base_url, :sender
+    attr_accessor :pubkey, :pvtkey, :base_url, :sender, :test
 
     def initialize
       @pubkey = ''
       @pvtkey = ''
       @sender = ''
+      @test = false
       @base_url = 'http://api.atompark.com/sms/3.0/'
     end
   end

data/lib/atompark-sms-api/gateway.rb

@@ -1,3 +1,5 @@
+require 'faraday'
+
 class AtomparkSmsApi::Gateway
   def self.perform(*args)
     fail "Don't call me that way"
@@ -6,10 +8,9 @@ class AtomparkSmsApi::Gateway
   def initialize(method, params)
     @method = method
     @params = params.merge(action: method, key: AtomparkSmsApi.config.pubkey, version: '3.0')
+    @params.merge!(test: true) if AtomparkSmsApi.config.test
+
     @conn = Faraday.new(url: AtomparkSmsApi.config.base_url)
-#    do |faraday|
-#      faraday.response(:logger)
- #   end
   end
 
   def perform

data/lib/atompark-sms-api/response.rb

@@ -1,3 +1,5 @@
+require 'json'
+
 class AtomparkSmsApi::Response
   def initialize(data)
     @response = JSON.parse(data)
@@ -11,11 +13,22 @@ class AtomparkSmsApi::Response
     response.has_key?('error')
   end
 
-  def message
-    "<#{response['code']}> #{response['error']}"
+  def error
+    "<#{response['code']}:#{response['result']}> #{response['error']}"
+  end
+
+  %w(id price currency).each do |key|
+    define_method(key) do
+      result[key]
+    end
   end
 
   private
 
   attr_reader :response
+
+  def result
+    fail error if error?
+    response['result']
+  end
 end

data/lib/atompark-sms-api/version.rb

@@ -1,4 +1,3 @@
 module AtomparkSmsApi
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end
-

data/spec/configuration_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe AtomparkSmsApi::Configuration do
+  subject { AtomparkSmsApi.config }
+
+  it { expect(subject.pubkey).to eq('') }
+  it { expect(subject.pvtkey).to eq('') }
+  it { expect(subject.sender).to eq('') }
+  it { expect(subject.base_url).to eq('http://api.atompark.com/sms/3.0/') }
+  it { expect(subject.test).to be_falsey }
+
+  shared_examples_for 'set variable' do |var, val|
+    before { AtomparkSmsApi.configure { |c| c.send(:"#{var}=", val) } }
+    it { expect(subject.send(var)).to eq(val) }
+  end
+
+  it_behaves_like 'set variable', :pubkey, 'public key'
+  it_behaves_like 'set variable', :pvtkey, 'private key'
+  it_behaves_like 'set variable', :sender, 'IvanPteroff'
+  it_behaves_like 'set variable', :test, true
+  it_behaves_like 'set variable', :base_url, '/dev/null'
+end

data/spec/gateway_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe AtomparkSmsApi::Gateway do
+  it { expect{described_class.perform}.to raise_error(RuntimeError, "Don't call me that way") }
+
+  describe '#perform' do
+    let(:faraday) { double }
+    let(:method) { :some_call }
+    let(:params) { { } }
+
+    before do
+      expect(Faraday).to receive(:new).with(url: AtomparkSmsApi.config.base_url).and_return(faraday)
+    end
+
+    subject { described_class.new(method, params) }
+
+    describe '#checksum' do
+      let(:params) { {foo: 'bar'} }
+      before do
+        AtomparkSmsApi.configure do |c|
+          c.pubkey = 'X'
+          c.pvtkey = 'Y'
+          c.test = false
+        end
+      end
+
+      # some_callbarX3.0Y - md5 sum, params in order: action, foo, pubkey, version, pvtkey
+      it { expect(subject.send(:checksum)).to eq('72c28714005950deb5ed6ed80d20a9ad') }
+    end
+
+    describe '#perform' do
+      context 'success' do
+        before do
+          expect(faraday).to receive(:post).and_return(double(body: %Q{{"result" : {"id" : 10}}}))
+        end
+
+        it { expect{subject.perform}.to_not raise_error }
+        it { expect(subject.perform).to be_kind_of(AtomparkSmsApi::Response) }
+        it { expect(subject.perform.success?).to be_truthy }
+        it { expect(subject.perform.id).to eq(10) }
+      end
+
+      context 'failed' do
+        before do
+          expect(faraday).to receive(:post).and_return(double(body: %Q{{"result" : 1, "code" : 2, "error" : "some error"}}))
+        end
+
+        it { expect{subject.perform}.to_not raise_error }
+        it { expect(subject.perform).to be_kind_of(AtomparkSmsApi::Response) }
+        it { expect(subject.perform.success?).to be_falsey }
+        it { expect(subject.perform.error).to eq("<2:1> some error") }
+      end
+    end
+  end
+end

data/spec/response_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe AtomparkSmsApi::Response do
+  subject { described_class.new(response) }
+
+  describe 'invalid' do
+    let(:response) { 'foo' }
+
+    it { expect{subject}.to raise_error(JSON::ParserError, "776: unexpected token at 'foo'") }
+  end
+
+  describe '#error' do
+    let(:response) { %Q{{"error" : "some error", "code" : "-1", "result" : 2}} }
+
+    it { expect{subject}.to_not raise_error }
+    it { expect(subject.error?).to be_truthy }
+    it { expect(subject.success?).to be_falsey }
+    it { expect(subject.error).to eq('<-1:2> some error') }
+
+    it { expect{subject.id}.to raise_error(RuntimeError, '<-1:2> some error') }
+    it { expect{subject.price}.to raise_error(RuntimeError, '<-1:2> some error') }
+    it { expect{subject.currency}.to raise_error(RuntimeError, '<-1:2> some error') }
+  end
+
+  describe '#success' do
+    let(:response) { %Q{{"result" : {"id" : 1, "price" : 2.5, "currency" : "USD"}}} }
+
+    it { expect{subject}.to_not raise_error }
+    it { expect(subject.error?).to be_falsey }
+    it { expect(subject.success?).to be_truthy }
+    it { expect(subject.id).to eq(1) }
+    it { expect(subject.price).to eq(2.5) }
+    it { expect(subject.currency).to eq("USD") }
+  end
+end

data/spec/send_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe AtomparkSmsApi::Send do
+  subject { described_class.perform(params) }
+  let(:faraday) { double }
+
+  before do
+    AtomparkSmsApi.configure do |c|
+      c.pubkey = 'X'
+      c.pvtkey = 'Y'
+      c.test = false
+      c.sender = 'Pupkin'
+    end
+  end
+
+  let(:params) { {phone: '000', text: 'xxx'} }
+
+  context 'correct gw call' do
+    before do
+      expect(described_class).to receive(:new)
+        .with(:sendSMS, {sender: 'Pupkin', datetime: '', sms_lifetime: 0, phone: '000', text: 'xxx'})
+        .and_return(double(perform: 'performed'))
+    end
+
+    it { expect{subject}.to_not raise_error }
+    it { expect(subject).to eq("performed") }
+  end
+
+  describe '#perform' do
+    before do
+      expect(Faraday).to receive(:new).with(url: AtomparkSmsApi.config.base_url).and_return(faraday)
+      expect(faraday).to receive(:post).and_return(double(body: response))
+    end
+
+    context 'success' do
+      let(:response) { %Q{{"result" : { "id" : 1 }}} }
+      it { expect{subject}.to_not raise_error }
+      it { expect(subject.success?).to be_truthy }
+      it { expect(subject.id).to eq(1) }
+    end
+
+    context 'failed' do
+      let(:response) { %Q{{"result" : 1, "code" : 2, "error" : "woops"}} }
+      it { expect{subject}.to_not raise_error }
+      it { expect(subject.success?).to be_falsey }
+      it { expect(subject.error).to eq("<2:1> woops") }
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: atompark-sms-api
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - uno4ki
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-12 00:00:00.000000000 Z
+date: 2016-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -85,6 +85,10 @@ files:
 - lib/atompark-sms-api/response.rb
 - lib/atompark-sms-api/send.rb
 - lib/atompark-sms-api/version.rb
+- spec/configuration_spec.rb
+- spec/gateway_spec.rb
+- spec/response_spec.rb
+- spec/send_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/the-furnish/atompark-sms-api
 licenses:
@@ -111,4 +115,8 @@ signing_key:
 specification_version: 4
 summary: Atompark SMS API wrapper. Works only with v3 api
 test_files:
+- spec/configuration_spec.rb
+- spec/gateway_spec.rb
+- spec/response_spec.rb
+- spec/send_spec.rb
 - spec/spec_helper.rb