atomically 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 109b9c9c0f457809981bf9f0ddccc0373cfc9419f5d76246100b788fd4063889
-  data.tar.gz: 74814d48c0e2b4d01bd9992157374e0901f7729c0ed3076d3da6587166839423
+  metadata.gz: fbb0af3b3a4baf323b17773ab9572ba0e89935eea46de17cbb5bd62ca82ae7ce
+  data.tar.gz: 7815d478fd7d3cf46d1e21c65a32e0bd0942350c1f7364a7dbc81144dafe5355
 SHA512:
-  metadata.gz: 01a27991eda8e03792ef5b11b2f5d3f596e4fc2086f6a75eca848d89c3d4dd550a53b5bbc5304f4e933174e30fc27a84ded106d7bd27fd0511e1a20081f3b575
-  data.tar.gz: 738a6704402e6611f6c1451642f40472dc7ddc3a2f637b52924b96e3a9a2b8b7aa007b7ac23ce9a141c198aae7a6c44a4e0dd49a26ead7481f3b6a02e7d4f10c
+  metadata.gz: 0fbe27d9450a49fed06b3c29cdc38efd9c44d84da6bacb1aadaa43cdf62649c653ecc65541dea4e8b5a6b51ae4b35a4327ab9f33ad0032c2227dd22913c8ef0e
+  data.tar.gz: 907a4f8452b56e20126cb888d59b3cde2f394b706b9ffc6d946fb5e4fe3d2459a807f0dbf2cc09675ff2fd0476da780b7e8967c3ce6f408974cf9f1fbb76bd23

data/.github/workflows/ruby.yml

@@ -28,6 +28,7 @@ jobs:
           - 2.6
           - 2.7
           - 3.0
+          - 3.2
         gemfile:
           - 3.2.gemfile
           - 4.2.gemfile
@@ -35,25 +36,44 @@ jobs:
           - 5.1.gemfile
           - 5.2.gemfile
           - 6.0.gemfile
+          - 7.2.gemfile
         exclude:
           - gemfile: 3.2.gemfile
             ruby: 2.6
           - gemfile: 3.2.gemfile
             ruby: 3.0
+          - gemfile: 3.2.gemfile
+            ruby: 3.2
           - gemfile: 3.2.gemfile
             ruby: 2.7
           - gemfile: 4.2.gemfile
             ruby: 2.7
           - gemfile: 4.2.gemfile
             ruby: 3.0
+          - gemfile: 4.2.gemfile
+            ruby: 3.2
           - gemfile: 5.0.gemfile
             ruby: 3.0
+          - gemfile: 5.0.gemfile
+            ruby: 3.2
           - gemfile: 5.1.gemfile
             ruby: 3.0
+          - gemfile: 5.1.gemfile
+            ruby: 3.2
           - gemfile: 5.2.gemfile
             ruby: 3.0
+          - gemfile: 5.2.gemfile
+            ruby: 3.2
           - gemfile: 6.0.gemfile
             ruby: 2.2
+          - gemfile: 7.2.gemfile
+            ruby: 2.2
+          - gemfile: 7.2.gemfile
+            ruby: 2.6
+          - gemfile: 7.2.gemfile
+            ruby: 2.7
+          - gemfile: 7.2.gemfile
+            ruby: 3.0
         include:
           - db: makara_mysql
             gemfile: 6.0.gemfile

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## Change Log
 
+### [v1.1.4](https://github.com/khiav223577/atomically/compare/v1.1.3...v1.1.4) 2023/09/04
+- [#23](https://github.com/khiav223577/atomically/pull/23) Fix - `from(nil)` did not generate the expected SQL (@ff2248)
+- [#24](https://github.com/khiav223577/atomically/pull/24) Skip the step of publishing code coverage for the PR from forked repos (@khiav223577)
+
 ### [v1.1.3](https://github.com/khiav223577/atomically/compare/v1.1.2...v1.1.3) 2023/08/19
 - [#22](https://github.com/khiav223577/atomically/pull/22) Support Ruby 3.0 (@khiav223577)
 - [#21](https://github.com/khiav223577/atomically/pull/21) Migrating from Travis CI to GitHub Actions (@khiav223577)

data/README.md

@@ -11,8 +11,8 @@
 All methods are defined in `Atomically::QueryService` instead of defining in `ActiveRecord` directly, in order not to pollute the model instance.
 
 ## Supports
-- Ruby 2.2 ~ 2.7, 3.0
-- Rails 3.2, 4.2, 5.0, 5.1, 5.2, 6.0
+- Ruby 2.2 ~ 2.7, 3.0, 3.2
+- Rails 3.2, 4.2, 5.0, 5.1, 5.2, 6.0, 7.2
 - MySQL, PostgreSQL
 
 ## Table of contents

data/atomically.gemspec

@@ -1,50 +1,51 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'atomically/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'atomically'
-  spec.version       = Atomically::VERSION
-  spec.authors       = ['khiav reoy']
-  spec.email         = ['mrtmrt15xn@yahoo.com.tw']
-
-  spec.summary       = 'An ActiveRecord extension for writing commonly useful atomic SQL statements to avoid race condition.'
-  spec.description   = 'An ActiveRecord extension for writing commonly useful atomic SQL statements to avoid race condition.'
-  spec.homepage      = 'https://github.com/khiav223577/atomically'
-  spec.license       = 'MIT'
-
-  # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
-  # delete this section to allow pushing this gem to any host.
-  # if spec.respond_to?(:metadata)
-  #   spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
-  # else
-  #   raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
-  # end
-
-  spec.files         = `git ls-files -z`.split("\x0").reject{|f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}){|f| File.basename(f) }
-  spec.require_paths = ['lib']
-  spec.metadata      = {
-    'homepage_uri'      => 'https://github.com/khiav223577/atomically',
-    'changelog_uri'     => 'https://github.com/khiav223577/atomically/blob/master/CHANGELOG.md',
-    'source_code_uri'   => 'https://github.com/khiav223577/atomically',
-    'documentation_uri' => 'https://www.rubydoc.info/gems/atomically',
-    'bug_tracker_uri'   => 'https://github.com/khiav223577/atomically/issues',
-  }
-
-  spec.add_development_dependency 'bundler', '>= 1.17', '< 3.x'
-  spec.add_development_dependency 'rake', '~> 12.0'
-  spec.add_development_dependency 'sqlite3', '~> 1.3'
-  spec.add_development_dependency 'minitest', '~> 5.0'
-  spec.add_development_dependency 'mysql2', '>= 0.3'
-  spec.add_development_dependency 'pg', '~> 0.18'
-  spec.add_development_dependency 'pluck_all', '>= 2.0.3'
-  spec.add_development_dependency 'timecop', '~> 0.9.1'
-
-  spec.add_dependency 'activerecord', '>= 3'
-  spec.add_dependency 'activerecord-import', '>= 0.27.0'
-  spec.add_dependency 'rails_or', '>= 1.1.8'
-  spec.add_dependency 'update_all_scope', '~> 0.1.0'
-end
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'atomically/version'
+
+Gem::Specification.new do |spec|
+  spec.name          = 'atomically'
+  spec.version       = Atomically::VERSION
+  spec.authors       = ['khiav reoy']
+  spec.email         = ['mrtmrt15xn@yahoo.com.tw']
+
+  spec.summary       = 'An ActiveRecord extension for writing commonly useful atomic SQL statements to avoid race condition.'
+  spec.description   = 'An ActiveRecord extension for writing commonly useful atomic SQL statements to avoid race condition.'
+  spec.homepage      = 'https://github.com/khiav223577/atomically'
+  spec.license       = 'MIT'
+
+  # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
+  # delete this section to allow pushing this gem to any host.
+  # if spec.respond_to?(:metadata)
+  #   spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
+  # else
+  #   raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
+  # end
+
+  spec.files         = `git ls-files -z`.split("\x0").reject{|f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir        = 'exe'
+  spec.executables   = spec.files.grep(%r{^exe/}){|f| File.basename(f) }
+  spec.require_paths = ['lib']
+  spec.metadata      = {
+    'homepage_uri'      => 'https://github.com/khiav223577/atomically',
+    'changelog_uri'     => 'https://github.com/khiav223577/atomically/blob/master/CHANGELOG.md',
+    'source_code_uri'   => 'https://github.com/khiav223577/atomically',
+    'documentation_uri' => 'https://www.rubydoc.info/gems/atomically',
+    'bug_tracker_uri'   => 'https://github.com/khiav223577/atomically/issues',
+  }
+
+  spec.add_development_dependency 'bundler', '>= 1.17', '< 3.x'
+  spec.add_development_dependency 'rake', '~> 12.0'
+  spec.add_development_dependency 'sqlite3', '~> 1.3'
+  spec.add_development_dependency 'minitest', '~> 5.0'
+  spec.add_development_dependency 'mysql2', '>= 0.3'
+  spec.add_development_dependency 'pg', '~> 0.18'
+  spec.add_development_dependency 'pluck_all', '>= 2.0.3'
+  spec.add_development_dependency 'timecop', '~> 0.9.1'
+  spec.add_development_dependency 'rails_compatibility', '>= 0.0.8'
+
+  spec.add_dependency 'activerecord', '>= 3'
+  spec.add_dependency 'activerecord-import', '>= 0.27.0'
+  spec.add_dependency 'rails_or', '>= 1.1.8'
+  spec.add_dependency 'update_all_scope', '~> 0.1.0'
+end

data/gemfiles/3.2.gemfile

@@ -11,6 +11,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.3'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/4.2.gemfile

@@ -11,6 +11,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.3'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/5.0.gemfile

@@ -11,6 +11,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.3'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/5.1.gemfile

@@ -11,6 +11,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.3'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/5.2.gemfile

@@ -11,6 +11,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.3'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/6.0.gemfile

@@ -10,6 +10,7 @@ group :test do
   gem 'pluck_all', '>= 2.0.4'
   gem 'timecop', '~> 0.9.1'
   gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
 end
 
 gemspec path: '../'

data/gemfiles/7.2.gemfile

@@ -0,0 +1,17 @@
+source 'https://rubygems.org'
+
+gem 'activerecord', '~> 7.2.1'
+
+group :test do
+  gem 'mysql2', '0.5.1' if %w[mysql makara_mysql].include?(ENV['DB'])
+  gem 'pg', '~> 1.4.6' if %w[pg makara_pg].include?(ENV['DB'])
+  gem 'makara', '~> 0.4.1' if %w[makara_mysql makara_pg].include?(ENV['DB'])
+  gem 'simplecov', '< 0.18'
+  gem 'pluck_all', '>= 2.0.4'
+  gem 'timecop', '~> 0.9.1'
+  gem 'update_all_scope', '~> 0.1.0'
+  gem 'rails_compatibility', '>= 0.0.8'
+  gem 'zeitwerk', '~> 2.6.18'
+end
+
+gemspec path: '../'

data/lib/atomically/query_service.rb

@@ -87,7 +87,7 @@ class Atomically::QueryService
     id_column = quote_column_with_table(:id)
     @klass.transaction do
       @relation.connection.execute('SET @ids := NULL')
-      @relation.where("(SELECT @ids := CONCAT_WS(',', #{id_column}, @ids))").update_all(*args) # 撈出有真的被更新的 id，用逗號串在一起
+      @relation.where("((@ids := CONCAT_WS(',', #{id_column}, @ids)) IS NOT NULL)").update_all(*args) # 撈出有真的被更新的 id，用逗號串在一起
       ids = @klass.from(Arel.sql('DUAL')).pluck(Arel.sql('@ids')).first
     end
     return ids.try{|s| s.split(',').map(&:to_i).uniq.sort } || [] # 將 id 從字串取出來 @id 的格式範例: '1,4,12'

data/lib/atomically/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Atomically
-  VERSION = '1.1.4'
+  VERSION = '1.1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: atomically
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - khiav reoy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-09-04 00:00:00.000000000 Z
+date: 2024-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -128,6 +128,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
+- !ruby/object:Gem::Dependency
+  name: rails_compatibility
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.8
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.0.8
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -210,6 +224,7 @@ files:
 - gemfiles/5.1.gemfile
 - gemfiles/5.2.gemfile
 - gemfiles/6.0.gemfile
+- gemfiles/7.2.gemfile
 - lib/atomically.rb
 - lib/atomically/active_record/extension.rb
 - lib/atomically/adapter_check_service.rb
@@ -243,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.14
+rubygems_version: 3.5.18
 signing_key: 
 specification_version: 4
 summary: An ActiveRecord extension for writing commonly useful atomic SQL statements