atomic_cache 0.5.2.rc1 → 0.5.3.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47216ee7b28e97d5a2a0d45ec7a7831d6ee05038f2029498654006b7ad42171c
-  data.tar.gz: 025c598a7d72bd3387c0fe0057a3047227ad9c6ae67ed818912a98d3a3f21e05
+  metadata.gz: 508ff6dd988d3b864438c2c54d3bca4cba2490a62c2ae97ed2b313522d5e8694
+  data.tar.gz: e0cd9a214c089780758955d2642c406484e0404c669d87faf347de1d8cb3a781
 SHA512:
-  metadata.gz: d575cb83f4bd7a97d902ad8b15d2da5063ea12edfcadc4d4b6c21f9ea1600413635cb84ee98025747bf49a82a7f97a91a73a5ba6152d7c5095ce19b556c5b7ad
-  data.tar.gz: 19486f04dfeb751f70b8e1c828b6affa6619829f2a467b87070b4c81a38d7656a57d7ceb02d935d1cf33e3bf4fc47f1356769cb27a19ae177a73cd0af86dbb6b
+  metadata.gz: f5e751211a50a029cf4043fa89bf74e50cb200835985c884b5a0faa782b9fc3b8b4c9a0b55be561763363c6625e124c9c11bee75cb15596ddea7b7213bb20bc7
+  data.tar.gz: b3fa0f5bed38fe417103a02409fcb1bf9ccb7611d69887ac6b5cc565e1440a6148ab9f306cb3283fbce2369bf26012f2532a21e889871a47e22d3a517f8b9b84

data/docs/USAGE.md

@@ -38,6 +38,12 @@ The ideal `generate_ttl_ms` time is just slightly longer than the average genera
 
 If metrics are enabled, the `<namespace>.generate.run` can be used to determine the min/max/average generate time for a particular cache and the `generate_ttl_ms` tuned using that.
 
+##### ⚠️ TTL Rounding
+When using atomic_cache with memcached, be aware that the TTL will be rounded down to the nearest whole seconds. For example, a `generate_ttl_ms` value of 3500 will result in a 3s TTL with memcache.
+
+##### ⚠️ Max Rate of Change
+Atomic_cache will *not* remove the lock after the generation process is done. This is both more efficient, and allows the `generate_ttl_ms` to be used to limit the total rate of change. For example, if the typical database query behind the cache takes 2s to run, but `generate_ttl_ms` is set to 10s, then the lock will live on for 8s after the generate process finishes, preventing other processes from querying for a new value. In many ways, `generate_ttl_ms` is the amount of time that the system will be un-allowed to make additional queries.  
+
 #### `max_retries` & `backoff_duration_ms`
 _`max_retries` defaults to 5._
 _`backoff_duration_ms` defaults to 50ms._

data/lib/atomic_cache/atomic_cache_client.rb

@@ -144,16 +144,6 @@ module AtomicCache
         if !value.nil?
           metrics(:increment, 'wait.present', tags: metrics_tags)
           return value
-        else
-          # if we didn't get a fresh value this go-round, check if there's a last known value
-          # if expirations were to come in rapidly, it's possible that the expiration which caused
-          # the wait cycle wrote a value, and it's now in LKV, and a new expiration came in, which
-          # has moved the LMT forward
-          value = last_known_value(keyspace, options, tags)
-          if !value.nil?
-            metrics(:increment, 'wait.lkv.present', tags: metrics_tags)
-            return value
-          end
         end
       end
 

data/lib/atomic_cache/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicCache
-  VERSION = "0.5.2.rc1"
+  VERSION = "0.5.3.rc1"
 end

data/spec/atomic_cache/atomic_cache_client_spec.rb

@@ -163,26 +163,6 @@ describe 'AtomicCacheClient' do
               expect(result).to eq(new_value)
             end
 
-            it 'uses the last known value if the LMT increments while waiting' do
-              key_storage.set(timestamp_manager.last_modified_time_key, '1420090000')
-              key_storage.set(keyspace.last_known_key_key, 'lkk_key')
-              last_known_value = 'value from another thread'
-
-              # fetching the 'fresh' value continually returns nil (because LMT is incrementing forward)
-              allow(cache_storage).to receive(:read)
-                                        .with(timestamp_manager.current_key(keyspace), anything)
-                                        .and_return(nil, nil, nil, nil)
-
-              # multiple returned values are faking what it would look like if another process
-              # promoted a value (wrote LKV) but then the cache expired right after
-              allow(cache_storage).to receive(:read)
-                                        .with(timestamp_manager.last_known_key(keyspace), anything)
-                                        .and_return(nil, nil, nil, last_known_value)
-
-              result = subject.fetch(keyspace, backoff_duration_ms: 5) { 'value from generate' }
-              expect(result).to eq(last_known_value)
-            end
-
             it 'stops waiting when the max retry count is reached' do
               timestamp_manager.promote(keyspace, last_known_key: 'asdf', timestamp: 1420090000)
               result = subject.fetch(keyspace, backoff_duration_ms: 5) { 'value from generate' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic_cache
 version: !ruby/object:Gem::Version
-  version: 0.5.2.rc1
+  version: 0.5.3.rc1
 platform: ruby
 authors:
 - Ibotta Developers
@@ -9,22 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-13 00:00:00.000000000 Z
+date: 2021-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: gems
   requirement: !ruby/object:Gem::Requirement
@@ -144,9 +144,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -154,9 +151,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6'
 - !ruby/object:Gem::Dependency
   name: murmurhash3
   requirement: !ruby/object:Gem::Requirement