atomic_cache 0.5.1.rc1 → 0.5.2.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f03b8f8d9294f3a40ea719ea5165d4c6789c3eebb36459768c8fbd0c57d8fc3a
-  data.tar.gz: b2a320b8323c57785e0202e29d89922b33e63fc9ebd898d6df61f76fb5e2600c
+  metadata.gz: 47216ee7b28e97d5a2a0d45ec7a7831d6ee05038f2029498654006b7ad42171c
+  data.tar.gz: 025c598a7d72bd3387c0fe0057a3047227ad9c6ae67ed818912a98d3a3f21e05
 SHA512:
-  metadata.gz: f461c2bf7d903c6f7940334b8f5d11672c7ed04d1d55ad5d25c2337c07906d24a39f8958ddf04a2dd5d5dc690c9a0920121fb99c9f25c809c08959e48ee13ae3
-  data.tar.gz: 9100ad9f5e5012c3729e3bc3a3b95ca64705c562f14e5d610df9f223436ee9351ec58cddc64b61c87c186a588f18e6158e891308aa5d431739f56aa2562744fa
+  metadata.gz: d575cb83f4bd7a97d902ad8b15d2da5063ea12edfcadc4d4b6c21f9ea1600413635cb84ee98025747bf49a82a7f97a91a73a5ba6152d7c5095ce19b556c5b7ad
+  data.tar.gz: 19486f04dfeb751f70b8e1c828b6affa6619829f2a467b87070b4c81a38d7656a57d7ceb02d935d1cf33e3bf4fc47f1356769cb27a19ae177a73cd0af86dbb6b

data/lib/atomic_cache/atomic_cache_client.rb

@@ -93,8 +93,8 @@ module AtomicCache
         end
 
         new_key = @timestamp_manager.next_key(keyspace, lmt)
-        @timestamp_manager.promote(keyspace, last_known_key: new_key, timestamp: lmt)
         @storage.set(new_key, new_value, options)
+        @timestamp_manager.promote(keyspace, last_known_key: new_key, timestamp: lmt)
 
         metrics(:increment, 'generate.current-thread', tags: tags)
         log(:debug, "Generating new value for `#{new_key}`")
@@ -144,6 +144,16 @@ module AtomicCache
         if !value.nil?
           metrics(:increment, 'wait.present', tags: metrics_tags)
           return value
+        else
+          # if we didn't get a fresh value this go-round, check if there's a last known value
+          # if expirations were to come in rapidly, it's possible that the expiration which caused
+          # the wait cycle wrote a value, and it's now in LKV, and a new expiration came in, which
+          # has moved the LMT forward
+          value = last_known_value(keyspace, options, tags)
+          if !value.nil?
+            metrics(:increment, 'wait.lkv.present', tags: metrics_tags)
+            return value
+          end
         end
       end
 

data/lib/atomic_cache/key/last_mod_time_key_manager.rb

@@ -44,8 +44,7 @@ module AtomicCache
     # @param last_known_key [String] a key with a known value to refer other processes to
     # @param timestamp [String, Numeric, Time] the timestamp with which the last_known_key was updated at
     def promote(keyspace, last_known_key:, timestamp:)
-      key = keyspace.last_known_key_key
-      @storage.set(key, last_known_key)
+      @storage.set(keyspace.last_known_key_key, last_known_key)
       @storage.set(last_modified_time_key, self.format(timestamp))
     end
 

data/lib/atomic_cache/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AtomicCache
-  VERSION = "0.5.1.rc1"
+  VERSION = "0.5.2.rc1"
 end

data/spec/atomic_cache/atomic_cache_client_spec.rb

@@ -163,6 +163,26 @@ describe 'AtomicCacheClient' do
               expect(result).to eq(new_value)
             end
 
+            it 'uses the last known value if the LMT increments while waiting' do
+              key_storage.set(timestamp_manager.last_modified_time_key, '1420090000')
+              key_storage.set(keyspace.last_known_key_key, 'lkk_key')
+              last_known_value = 'value from another thread'
+
+              # fetching the 'fresh' value continually returns nil (because LMT is incrementing forward)
+              allow(cache_storage).to receive(:read)
+                                        .with(timestamp_manager.current_key(keyspace), anything)
+                                        .and_return(nil, nil, nil, nil)
+
+              # multiple returned values are faking what it would look like if another process
+              # promoted a value (wrote LKV) but then the cache expired right after
+              allow(cache_storage).to receive(:read)
+                                        .with(timestamp_manager.last_known_key(keyspace), anything)
+                                        .and_return(nil, nil, nil, last_known_value)
+
+              result = subject.fetch(keyspace, backoff_duration_ms: 5) { 'value from generate' }
+              expect(result).to eq(last_known_value)
+            end
+
             it 'stops waiting when the max retry count is reached' do
               timestamp_manager.promote(keyspace, last_known_key: 'asdf', timestamp: 1420090000)
               result = subject.fetch(keyspace, backoff_duration_ms: 5) { 'value from generate' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: atomic_cache
 version: !ruby/object:Gem::Version
-  version: 0.5.1.rc1
+  version: 0.5.2.rc1
 platform: ruby
 authors:
 - Ibotta Developers
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-12 00:00:00.000000000 Z
+date: 2021-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler