async-io 1.18.4 → 1.18.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9b90003500ec4d5f02d1f8ff39fd03ddd75c05988002ed38518e3f41b310e19
-  data.tar.gz: 6f2963634feaa4adb76146cf69ef981e3d5d184e53afe75026041f9ff0bebe8b
+  metadata.gz: 4521c94506778f0d7e6f5dec2fe76bf6b6f0374ae3c327e29775063bd3393aaa
+  data.tar.gz: 56d1f0388b1d1a64a87dbb5086bcbd209602933ab805fae44ea6e699cc3eba8b
 SHA512:
-  metadata.gz: 476989a61aaf04cbde81d7b470e536670ac1a86e5309355dc2712915ee2977999bb8ae2618f34d5d9ef6679dfcc7f0c7ec4b480b671e7129472d3e66075a57a5
-  data.tar.gz: 2ad64389173a06b27db796bf61c2310348c8c79b9c09e2146cd5ed63ffd9c3bd2d3d12a058f41c531bcfb5918764a92e91077a28a7ec572c3869b45a65aaf793
+  metadata.gz: 7c84cb8f453e9b7c7f80af18443d04eaeca38e46172afbc1ec4f6c219123449a5b8744d72db0c282e2d3da8826f29aa64f331698608a589c9c35a761bc6531f4
+  data.tar.gz: 027bf4fc6e910b3e1fdf883f7aa6a98045131f43318a014f77bb6e1734d9e932f95bd54fb23b9237e9ef78bccb1f70fc52c424ece21020e31663ea3a6b151ffe

data/lib/async/io/host_endpoint.rb

@@ -49,6 +49,7 @@ module Async
 				Addrinfo.foreach(*@specification) do |address|
 					begin
 						return Socket.connect(address, **@options, &block)
+					# This is a little bit risky. In theory, what it is supposed to do is catch the failed connection, and try the next address. In practice, it can catch other kinds of failures. Ideally, it only applies to `#connect`, but it also applies to what's executed in `&block`.
 					rescue
 						last_error = $!
 					end

data/lib/async/io/tcp_socket.rb

@@ -92,8 +92,14 @@ module Async
 				super
 			end
 			
-			def read(size)
-				@buffer.read_partial(size)
+			def read(size, outbuf = nil)
+				buffer = @buffer.read_partial(size)
+				
+				if outbuf
+					outbuf.replace(buffer)
+				end
+				
+				return buffer
 			end
 		end
 		

data/lib/async/io/version.rb

@@ -20,6 +20,6 @@
 
 module Async
 	module IO
-		VERSION = "1.18.4"
+		VERSION = "1.18.5"
 	end
 end

data/spec/async/io/tcp_socket_spec.rb

@@ -33,10 +33,11 @@ RSpec.describe Async::IO::TCPSocket do
 	
 	describe Async::IO::TCPServer do
 		it_should_behave_like Async::IO::Generic
-		
-		it "should start server and send data" do
-			# Accept a single incoming connection and then finish.
-			server_task = reactor.async do |task|
+	end
+	
+	describe Async::IO::TCPServer do
+		let!(:server_task) do
+			reactor.async do |task|
 				server = Async::IO::TCPServer.new("localhost", 6788)
 				
 				peer, address = server.accept
@@ -47,9 +48,26 @@ RSpec.describe Async::IO::TCPSocket do
 				peer.close
 				server.close
 			end
+		end
+		
+		let(:client) {Async::IO::TCPSocket.new("localhost", 6788)}
+		
+		it "can read into outbuf" do
+			client.puts("Hello World")
+			
+			outbuf = String.new
+			# 20 is bigger than echo response...
+			data = client.read(20, outbuf)
 			
-			client = Async::IO::TCPSocket.new("localhost", 6788)
+			expect(outbuf).to_not be_empty
+			expect(outbuf).to be == data
 			
+			client.close
+			server_task.wait
+		end
+		
+		it "should start server and send data" do
+			# Accept a single incoming connection and then finish.
 			client.puts(data)
 			expect(client.gets).to be == data
 			

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async-io
 version: !ruby/object:Gem::Version
-  version: 1.18.4
+  version: 1.18.5
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-21 00:00:00.000000000 Z
+date: 2019-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async