async-http 0.46.5 → 0.47.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9fb9d8fd91de95c63e2a7fc133902457a812394c80bb37773ddd04a74592cda
-  data.tar.gz: 460f4a0505a7fe53ee91246728ed601464f86c85eb01db3bc1f3c1ee322b7834
+  metadata.gz: 27b6378ebb80f14051f9869d2409de28292dac437c14d7b4188edcd45c7d9971
+  data.tar.gz: a52c8f9553effe5e0e1bdf0e90a9eaa529e3f4cc1e1c53d06e7606fe16966e16
 SHA512:
-  metadata.gz: f356561f16a0829428ca4733cb9af6cde0f871ce2df662871e0c78b299d16d4a25be5f562719e752037f64dbaba3ab2328a1deb7579e66c06c4452a9269462aa
-  data.tar.gz: 914b845234e8c98eac84ee45dbc9f5e745bc07e61f23bbaf6017cab898b8455e70b978e31735a5b898cb22b7e4918fb3705d51e258ac5632c7a4f2f5e1cb8cc3
+  metadata.gz: 4ed7257439e6e3829c88cedefc78df137551b9c0183abaa76e59a7d39d0ae399af9a5fec7b66ece4a22648099ef6e29abe9d1c2f93ba83d80622c17edf0f604d
+  data.tar.gz: 35906d4412cf80f45a3ef074b0f29ec9076f40f73b74c542353d60a2dfb1509aba95c27e5b8fe340d49c0e6a873998adbc49920622f28439b9a4f360f0f4350c

data/async-http.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
 	spec.add_dependency("async", "~> 1.19")
 	spec.add_dependency("async-io", "~> 1.24")
 	
-	spec.add_dependency("protocol-http", "~> 0.11.0")
+	spec.add_dependency("protocol-http", "~> 0.12.0")
 	spec.add_dependency("protocol-http1", "~> 0.8.0")
 	spec.add_dependency("protocol-http2", "~> 0.9.0")
 	

data/lib/async/http/protocol/http1/server.rb

@@ -68,12 +68,17 @@ module Async
 								
 								write_response(@version, response.status, response.headers)
 								
-								if body = response.body and protocol = response.protocol
+								body = response.body
+								
+								if body and protocol = response.protocol
 									stream = write_upgrade_body(protocol)
 									
 									# At this point, the request body is hijacked, so we don't want to call #finish below.
 									request = nil
 									
+									# We also don't want to hold on to the response object:
+									response = nil
+									
 									body.call(stream)
 								else
 									write_body(@version, body, head)

data/lib/async/http/protocol/http2/response.rb

@@ -25,7 +25,7 @@ module Async
 	module HTTP
 		module Protocol
 			module HTTP2
-				# Typically used on the client side to represent a request and the incoming response.
+				# Typically used on the client side  for writing a request and reading the incoming response.
 				class Response < Protocol::Response
 					class Stream < HTTP2::Stream
 						def initialize(*)
@@ -39,6 +39,14 @@ module Async
 						
 						attr :response
 						
+						def wait_for_input
+							# The input isn't ready until the response headers have been received:
+							@response.wait
+							
+							# There is a possible race condition if you try to access @input - it might already be closed and nil.
+							return @response.body
+						end
+						
 						def accept_push_promise_stream(promised_stream_id, headers)
 							stream = @connection.accept_push_promise_stream(promised_stream_id, &Stream.method(:accept))
 							
@@ -81,9 +89,9 @@ module Async
 						
 						# Notify anyone waiting on the response headers to be received (or failure).
 						def notify!
-							if @notification
-								@notification.signal
+							if notification = @notification
 								@notification = nil
+								notification.signal
 							end
 						end
 						
@@ -165,7 +173,7 @@ module Async
 					end
 					
 					# Send a request and read it into this response.
-					def send_request(request, task: Async::Task.current)
+					def send_request(request)
 						@request = request
 						
 						# https://http2.github.io/http2-spec/#rfc.section.8.1.2.3

data/lib/async/http/protocol/http2/stream.rb

@@ -26,6 +26,7 @@ module Async
 		module Protocol
 			module HTTP2
 				class Stream < ::Protocol::HTTP2::Stream
+					# A writable body which requests window updates when data is read from it.
 					class Input < Body::Writable
 						def initialize(stream, length)
 							super(length)
@@ -113,7 +114,9 @@ module Async
 						def stream(task)
 							task.annotate("Streaming #{@body} to #{@stream}.")
 							
-							@body.call(Body::Stream.new(@stream.input, self))
+							input = @stream.wait_for_input
+							
+							@body.call(Body::Stream.new(input, self))
 						rescue Async::Stop
 							# Ignore.
 						end
@@ -212,6 +215,12 @@ module Async
 						send_reset_stream(error.code)
 					end
 					
+					def wait_for_input
+						return @input
+					end
+					
+					# Prepare the input stream which will be used for incoming data frames.
+					# @return [Input] the input body.
 					def prepare_input(length)
 						if @input.nil?
 							@input = Input.new(self, length)
@@ -223,7 +232,7 @@ module Async
 					def update_local_window(frame)
 						consume_local_window(frame)
 						
-						# This is done on demand.
+						# This is done on demand in `Input#read`:
 						# request_window_update
 					end
 					

data/lib/async/http/version.rb

@@ -20,6 +20,6 @@
 
 module Async
 	module HTTP
-		VERSION = "0.46.5"
+		VERSION = "0.47.0"
 	end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: async-http
 version: !ruby/object:Gem::Version
-  version: 0.46.5
+  version: 0.47.0
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-19 00:00:00.000000000 Z
+date: 2019-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.12.0
 - !ruby/object:Gem::Dependency
   name: protocol-http1
   requirement: !ruby/object:Gem::Requirement