association_callbacks 0.3.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d04834ffb4dcf18cac5a179431b424fdb1fa012
-  data.tar.gz: 02704f9f3348dba55e60b50176aa5e4e8c0c9507
+  metadata.gz: 2994cec2c46bbf3f85cf7c87164276185678571a
+  data.tar.gz: b0e8f30e500e5cacec58cda454647f9a93775fa4
 SHA512:
-  metadata.gz: 9f67033c54cd5eec79e847bceed54b34ae116cc6345b22eadc988c1f151a6d0950be468f169d3256f56a8dc1653bcb8780c6273b44577f5b8814bf406ac3bef2
-  data.tar.gz: f2b63a51477205f07b972979e87d6c1e4c81a21309aa07d95b64620ff7d3f3e4531014e94033fa9e90ff9eecaedecad87786766dd1fca82589ab0342b5a75ed4
+  metadata.gz: cce917363779bc6b2c8b4fc5ef7524adf7c516bbcb289514276cc76ed5a935cdbac71090d792c9310e8f0140022b6a2d78028f3595c9cde6ef1e4e6ccea9eb42
+  data.tar.gz: b6e9141678292d4963239b66854236db1d3da84996fe1652b5c8805db2636a8f5eed7d06bcd2e58c08c03f5cafd338f83537edb87851dc11273a45a5c26eb998

data/.gitignore

@@ -1,6 +1,6 @@
 .DS_Store
-.bundle
-.ruby-version
-Gemfile.lock
-pkg/*
-spec/test.sqlite3
+/.bundle/
+/.ruby-version
+/Gemfile.lock
+/pkg/
+/spec/test.sqlite3

data/README.mdown

@@ -8,27 +8,31 @@ model into an associated one.
 
 First, two simple `Article` and `Comment` models:
 
-    class Article < ActiveRecord::Base
-      has_many :comments
-    end
+```ruby
+class Article < ActiveRecord::Base
+  has_many :comments
+end
 
-    class Comment < ActiveRecord::Base
-      belongs_to :article
-    end
+class Comment < ActiveRecord::Base
+  belongs_to :article
+end
+```
 
 Then, you often need to denormalize `Comment` stuff into `Post` or vice versa.
 Here is the standard way to denormalize `last_comment_at` on posts:
 
-    class Comment < ActiveRecord::Base
-      belongs_to :article
+```ruby
+class Comment < ActiveRecord::Base
+  belongs_to :article
 
-      after_create :update_post_last_comment_at
-      after_destroy :update_post_last_comment_at
+  after_create :update_post_last_comment_at
+  after_destroy :update_post_last_comment_at
 
-      def update_post_last_comment_at
-        post.update_attributes!(last_comment_at: post.comments.order('created_at').last.try(:created_at))
-      end
-    end
+  def update_post_last_comment_at
+    post.update_attributes!(last_comment_at: post.comments.order('created_at').last.try(:created_at))
+  end
+end
+```
 
 But, there is a problem here: we define `Post` denormalization callbacks into
 `Comment` model. IMHO, this is the wrong place. `Post` denormalization
@@ -37,16 +41,18 @@ models.
 
 Here is how to do it with `association_callabacks`:
 
-    class Post < ActiveRecord::Base
-      has_many :comments
+```ruby
+class Post < ActiveRecord::Base
+  has_many :comments
 
-      after_create :update_last_comment_at, source: :comments
-      after_destroy :update_last_comment_at, source: :comments
+  after_create :update_last_comment_at, source: :comments
+  after_destroy :update_last_comment_at, source: :comments
 
-      def update_last_comment_at
-        update_attributes!(last_comment_at: comments.order('created_at').last.try(:created_at))
-      end
-    end
+  def update_last_comment_at
+    update_attributes!(last_comment_at: comments.order('created_at').last.try(:created_at))
+  end
+end
+```
 
 You just have to specify `:source` option to your callbacks, and that's all!
 Note that `:source` option must be an existing association name.
@@ -54,25 +60,29 @@ Note that `:source` option must be an existing association name.
 Note that association callbacks methods can take associated record as
 argument, above code can be:
 
-    class Post < ActiveRecord::Base
-      has_many :comments
+```ruby
+class Post < ActiveRecord::Base
+  has_many :comments
 
-      after_create :update_last_comment_at
+  after_create :update_last_comment_at
 
-      def update_last_comment_at(comment)
-        update_attributes!(last_comment_at: comment.created_at)
-      end
-    end
+  def update_last_comment_at(comment)
+    update_attributes!(last_comment_at: comment.created_at)
+  end
+end
+```
 
 Association callbacks can also be defined as block:
 
-    class Post < ActiveRecord::Base
-      has_many :comments
+```ruby
+class Post < ActiveRecord::Base
+  has_many :comments
 
-      after_destroy source: :comments do |post|
-        post.decrement!(:comments_count)
-      end
-    end
+  after_destroy source: :comments do |post|
+    post.decrement!(:comments_count)
+  end
+end
+```
 
 Another solution is to use [ActiveModel Observers](http://api.rubyonrails.org/classes/ActiveModel/Observer.html),
 but for a better project comprehension, I really prefer placing denormalization
@@ -83,7 +93,9 @@ cache sweepers, etc.
 
 Just add this into your `Gemfile`:
 
-    gem 'association_callabacks'
+```ruby
+gem 'association_callabacks'
+```
 
 Then, just run `bundle install`.
 

data/VERSION

@@ -1 +1 @@
-0.3.0
+1.0.0

data/association_callbacks.gemspec

@@ -16,8 +16,8 @@ Gem::Specification.new do |s|
   s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.add_dependency 'activerecord', '>= 4.1.0', '< 4.3.0'
-  s.add_dependency 'activesupport', '>= 4.1.0', '< 4.3.0'
+  s.add_dependency 'activerecord', '>= 5.0.0', '< 5.1.0'
+  s.add_dependency 'activesupport', '>= 5.0.0', '< 5.1.0'
 
   s.add_development_dependency 'byebug', '>= 3.2.0', '< 3.6.0'
   s.add_development_dependency 'rake', '>= 10.3.0', '< 10.5.0'

data/lib/association_callbacks.rb

@@ -1,6 +1,7 @@
 require 'rubygems'
 require 'bundler/setup'
 require 'active_record'
+require 'active_support'
 require 'active_support/concern'
 
 module AssociationCallbacks

data/lib/association_callbacks/active_record.rb

@@ -23,22 +23,24 @@ module AssociationCallbacks
         base.class_eval <<-EOS
           class << self
 
-            def #{callback}_with_association(*args, &block)
-              if args.last.is_a?(Hash) && args.last.key?(:source)
-                options = args.extract_options!
-                define_callback_with_association(:#{callback}, args, options, &block)
-              else
-                #{callback}_without_association(*args, &block)
+            mod = Module.new do
+              def #{callback}(*args, &block)
+                if args.last.is_a?(Hash) && args.last.key?(:source)
+                  options = args.extract_options!
+                  define_callback_with_association(:#{callback}, args, options, &block)
+                else
+                  super(*args, &block)
+                end
               end
             end
-            alias_method_chain :#{callback}, :association
+            prepend(mod)
 
           end
         EOS
       end
     end
 
-    module ClassMethods
+    class_methods do
 
       private
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: association_callbacks
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Alexis Toulotte
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-28 00:00:00.000000000 Z
+date: 2016-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,40 +16,40 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 5.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.3.0
+        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -173,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: association_callbacks
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Callbacks for ActiveRecord associations