assignable_values 0.5.2 → 0.5.3

data/README.md

@@ -193,7 +193,10 @@ Listing and validating als works the same:
     song.artist = lt2
     song.valid? # => false
 
-Similiar to scalar attributes, associations are only validated when the foreign key (`artist_id` in the example) changes. Previously saved values will remain assignable until another association has been saved.
+Similiar to scalar attributes, associations are only validated when the foreign key (`artist_id` in the example above) changes.
+Previously saved values will remain assignable until another association has been saved.
+
+Validation errors will be attached to the association's foreign key (`artist_id` in the example above).
 
 
 How assignable values are evaluated

data/lib/assignable_values/active_record/restriction/base.rb

@@ -21,7 +21,7 @@ module AssignableValues
           unless allow_blank? && value.blank?
             begin
               unless assignable_value?(record, value)
-                record.errors.add(property, not_included_error_message)
+                record.errors.add(error_property, not_included_error_message)
               end
             rescue DelegateUnavailable
               # if the delegate is unavailable, the validation is skipped
@@ -29,6 +29,10 @@ module AssignableValues
           end
         end
 
+        def error_property
+          property
+        end
+
         def not_included_error_message
           I18n.t('errors.messages.inclusion', :default => 'is not included in the list')
         end

data/lib/assignable_values/active_record/restriction/belongs_to_association.rb

@@ -13,6 +13,10 @@ module AssignableValues
           "#{property}_id"
         end
 
+        def error_property
+          association_id_method
+        end
+
         def association_id(record)
           record.send(association_id_method)
         end

data/lib/assignable_values/version.rb

@@ -1,3 +1,3 @@
 module AssignableValues
-  VERSION = '0.5.2'
+  VERSION = '0.5.3'
 end

data/spec/rails-2.3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    assignable_values (0.5.1)
+    assignable_values (0.5.2)
       activerecord
 
 GEM

data/spec/rails-3.0/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    assignable_values (0.5.1)
+    assignable_values (0.5.2)
       activerecord
 
 GEM

data/spec/rails-3.2/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    assignable_values (0.5.1)
+    assignable_values (0.5.2)
       activerecord
 
 GEM

data/spec/shared/assignable_values/active_record_spec.rb

@@ -105,6 +105,21 @@ describe AssignableValues::ActiveRecord do
         klass.new(:artist => disallowed_association).should_not be_valid
       end
 
+      it 'should attach errors to the foreign key of the association, not the association itself ' do
+        allowed_association = Artist.create!
+        disallowed_association = Artist.create!
+        klass = Song.disposable_copy do
+          assignable_values_for :artist do
+            [allowed_association]
+          end
+        end
+        record = klass.new(:artist => disallowed_association)
+        record.valid?
+        errors = record.errors[:artist_id]
+        error = errors.is_a?(Array) ? errors.first : errors # the return value sometimes was a string, sometimes an Array in Rails
+        error.should == I18n.t('errors.messages.inclusion')
+      end
+
       it 'should allow a nil association if the :allow_blank option is set' do
         klass = Song.disposable_copy do
           assignable_values_for :artist, :allow_blank => true do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: assignable_values
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 5
-  - 2
-  version: 0.5.2
+  - 3
+  version: 0.5.3
 platform: ruby
 authors: 
 - Henning Koch
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-05 00:00:00 +01:00
+date: 2012-12-19 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency