assignable_values 0.16.2 → 0.16.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9fa8864bca68f5d9a2c7199bd08a2c3f97bb46cc3e40b0b7860c62d9bb563bb
-  data.tar.gz: fe00de9f990305f33905cbd8b0dcaf9fc318521b4378c344aa33bc94a536b63b
+  metadata.gz: 400d27572075ed4ae3361303c97ccb7acf0afb00e63cfdc8e3a667d8da73b874
+  data.tar.gz: 20e2628282f45a9265d036a0b3ca1078a5bb5532cf06654d05c79bd67c878d96
 SHA512:
-  metadata.gz: 815643f34c5d95f2ed47ae5ebdec2dd31c7da83ae1ded589efebf6409789bf30f002315d94468a5e8c14f2f64412fbae025f8a0dec7c057a66826417282a0ca9
-  data.tar.gz: 500c291826c51db9bfad4d3f222052a1b0e3c2cd59260a7db2f9ee58368d5574734cf58db92c42ec6aa34f1c5a5657d57919e8e1df2c97b05da4b4e69bb9d384
+  metadata.gz: 0d8d5c406b2829863c62fe04851341667ce4f49cc2e6f3c29e6e58cc4710fe70d123ac7cbc315f56f8fdd1734dcab7c5b9693186bd9b12033db3df03fd686261
+  data.tar.gz: d0e460d55fa4ce7d26207a239778177f56a4c1dcd73a8f7ee7aa6167094b55b75af84a0a8a9cc9e9e3a371c693b4fb813df16978057e545b4dbaa50415926668

data/CHANGELOG.md

@@ -8,6 +8,12 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 
 ### Compatible changes
 
+## 0.16.3 - 2020-10-15
+
+### Compatible changes
+
+- No longer crashes when assigning `nil` to an attribute with assignable values that are provided as a scope.
+
 ## 0.16.2 - 2020-10-06
 
 ### Compatible changes

data/Gemfile.2.3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.3.2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.4.2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.5.0.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.5.1.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.5.1.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/Gemfile.6.0.pg.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    assignable_values (0.16.2)
+    assignable_values (0.16.3)
       activerecord (>= 2.3)
 
 GEM

data/lib/assignable_values/active_record/restriction/base.rb

@@ -107,7 +107,7 @@ module AssignableValues
           values_or_scope = assignable_values(record, :include_old_value => false)
 
           if is_scope?(values_or_scope)
-            values_or_scope.exists?(value.id)
+            values_or_scope.exists?(value.id) unless value.nil?
           else
             values_or_scope.include?(value)
           end

data/lib/assignable_values/version.rb

@@ -1,3 +1,3 @@
 module AssignableValues
-  VERSION = '0.16.2'
+  VERSION = '0.16.3'
 end

data/spec/assignable_values/active_record_spec.rb

@@ -510,44 +510,60 @@ describe AssignableValues::ActiveRecord do
         record.valid?
       end
 
-      it 'should not load all records to memory when assignable values are scoped' do
-        unless ::ActiveRecord::VERSION::MAJOR < 3 # somehow rails 2 still initializes Objects during the scope.exists?-call
-          initialized_artists_count = 0
-          MyArtist = Artist.disposable_copy
-
-          MyArtist.class_eval do
-            after_initialize :increase_initialized_count
-
-            define_method :increase_initialized_count do
-              initialized_artists_count += 1
-            end
-          end
-
-          klass = Song.disposable_copy
+      context 'when assignable values are provided as an ActiveRecord scope' do
+        MyArtist = Artist.disposable_copy
+        let(:klass) { Song.disposable_copy }
 
+        before do
           klass.class_eval do
             assignable_values_for :artist do
               if ::ActiveRecord::VERSION::MAJOR < 4
-                MyArtist.scoped
+                MyArtist.scoped({})
               else
                 MyArtist.all
               end
             end
           end
+        end
 
+        it 'allows assigning a record from the scope' do
           artist = MyArtist.create!
-          initialized_artists_count.should == 1
-
           song = klass.new(:artist => artist)
+          song.should be_valid
+        end
+
+        it 'will not crash during validation when the assigned value is nil' do
+          song = klass.new
+          expect { song.valid? }.to_not raise_error
+          song.errors[:artist_id].should be_present
+        end
+
+        it 'should not load all records into memory' do
+          unless ::ActiveRecord::VERSION::MAJOR < 3 # somehow rails 2 still initializes Objects during the scope.exists?-call
+            initialized_artists_count = 0
+
+            MyArtist.class_eval do
+              after_initialize :increase_initialized_count
 
-          song.valid?
-          initialized_artists_count.should == 1
+              define_method :increase_initialized_count do
+                initialized_artists_count += 1
+              end
+            end
 
-          song.assignable_artists
-          initialized_artists_count.should == 1
+            artist = MyArtist.create!
+            initialized_artists_count.should == 1
 
-          song.assignable_artists.to_a
-          initialized_artists_count.should == 2
+            song = klass.new(:artist => artist)
+
+            song.valid?
+            initialized_artists_count.should == 1
+
+            song.assignable_artists
+            initialized_artists_count.should == 1
+
+            song.assignable_artists.to_a
+            initialized_artists_count.should == 2
+          end
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: assignable_values
 version: !ruby/object:Gem::Version
-  version: 0.16.2
+  version: 0.16.3
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-06 00:00:00.000000000 Z
+date: 2020-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -91,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Restrict the values assignable to ActiveRecord attributes or associations