assignable_values 0.13.2 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 80416120490eb1fa174ee1af4318c93ce18fd432
-  data.tar.gz: e4379495924e83d42bb9b610b9adef3ba4ca3b01
+SHA256:
+  metadata.gz: dd2475ca27683328810e810b40276043bf60b442c621be57f29885e58647183a
+  data.tar.gz: f3e17c9e48ce5e73faf2dfe3b3529b8275c603beef2551c6b3d83cac01a3343e
 SHA512:
-  metadata.gz: efb7a94db723785ea7e3eab7c2a8919aa32cd16441c3f4b60d63d7463f63720a35d2f46c97fb81dd7c876d55337f7982f6a9fc525905401393abbf56fe94dedf
-  data.tar.gz: d7094fe9d1419a44aa156e3b315ffcb981b449b1c419a8e5d52500389d2be0bbf14ab7cc8db79cca895931ac3a3027556de7a8d58957ac98001b822074f9209e
+  metadata.gz: d2f513338f30247aba1d2b8f436266e3f8865c3c367a0367268131f4f61df7ee80a21e049a4a96b7ce65e90e38068ee759ca6829e23e620635d4595cfa6cc825
+  data.tar.gz: be46b3706a7fc5fece9c43b4ac47164ae9b1cd67a43227707c6182d8ae5755eed601aed0f79d25a5fbfdca88519df64f1323104999265725f0992fb6662417f5

data/.travis.yml

@@ -12,6 +12,7 @@ gemfile:
   - gemfiles/Gemfile.4.2
   - gemfiles/Gemfile.5.0
   - gemfiles/Gemfile.5.1
+  - gemfiles/Gemfile.5.1.pg
 
 matrix:
   exclude:
@@ -37,6 +38,10 @@ matrix:
       rvm: 2.1.8
     - gemfile: gemfiles/Gemfile.5.1
       rvm: 1.8.7
+    - gemfile: gemfiles/Gemfile.5.1.pg
+      rvm: 2.1.8
+    - gemfile: gemfiles/Gemfile.5.1.pg
+      rvm: 1.8.7
 
 sudo: false
 
@@ -47,8 +52,8 @@ notifications:
     - fail@makandra.de
 
 before_script:
+  - psql -c 'create database assignable_values_test;' -U postgres
   - mysql -e 'create database IF NOT EXISTS assignable_values_test;'
-  - mysql -e "GRANT ALL PRIVILEGES ON assignable_values_test.* TO 'travis'@'%';"
 
 install:
   # Old Travis CI bundler explodes when lockfile version doesn't match recently bumped version

data/CHANGELOG.md

@@ -0,0 +1,56 @@
+All notable changes to this project will be documented in this file.
+
+This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## Unreleased
+
+### Breaking changes
+
+-
+
+### Compatible changes
+
+-
+
+
+## 0.14.0 - 2018-09-17
+
+### Compatible changes
+
+- Add support for Array columns using `multiple: true`.
+
+
+## 0.13.2 - 2018-01-23
+
+### Compatible changes
+
+- Get rid of deprecation warnings on Rails 5.1+.
+
+Thanks to irmela.
+
+
+## 0.13.1 - 2017-10-24
+
+### Compatible changes
+
+- Add Rails 5.1 compatibility.
+
+Thanks to GuidoSchweizer.
+
+
+## 0.13.0 - 2017-09-08
+
+### Breaking changes
+
+- No longer support providing humanized values as a hash in favour of always using I18n.
+
+### Compatible changes
+
+- Fix a bug with a `has_many :through` when return a nil object.
+
+Thanks to foobear.
+
+
+## Older releases
+
+Please check commits.

data/README.md

@@ -21,8 +21,8 @@ The basic usage to restrict the values assignable to strings, integers, etc. is
 
 The assigned value is checked during validation:
 
-    Song.new(:genre => 'rock').valid?     # => true
-    Song.new(:genre => 'elephant').valid? # => false
+    Song.new(genre: 'rock').valid?     # => true
+    Song.new(genre: 'elephant').valid? # => false
 
 The validation error message is the same as the one from `validates_inclusion_of` (`errors.messages.inclusion` in your I18n dictionary).
 You can also set a custom error message with the `:message` option.
@@ -79,7 +79,7 @@ A good way to populate a `<select>` tag with pairs of internal values and human
 You can define a default value by using the `:default` option:
 
     class Song < ActiveRecord::Base
-      assignable_values_for :genre, :default => 'rock' do
+      assignable_values_for :genre, default: 'rock' do
         ['pop', 'rock', 'electronic']
       end
     end
@@ -91,7 +91,7 @@ The default is applied to new records:
 Defaults can be procs:
 
     class Song < ActiveRecord::Base
-      assignable_values_for :genre, :default => proc { Date.today.year } do
+      assignable_values_for :genre, default: proc { Date.today.year } do
         1980 .. 2011
       end
     end
@@ -101,7 +101,7 @@ The proc will be evaluated in the context of the record instance.
 You can also default a secondary default that is only set if the primary default value is not assignable:
 
     class Song < ActiveRecord::Base
-      assignable_values_for :year, :default => 1999, :secondary_default => lambda { Date.today.year } do
+      assignable_values_for :year, default: 1999, secondary_default: proc { Date.today.year } do
         (Date.today.year - 2) .. Date.today.year
       end
     end
@@ -119,14 +119,14 @@ will get a validation error.
 If you would like to change this behavior and allow blank values to be valid, use the `:allow_blank` option:
 
     class Song < ActiveRecord::Base
-      assignable_values_for :genre, :default => 'rock', :allow_blank => true do
+      assignable_values_for :genre, default: 'rock', allow_blank: true do
         ['pop', 'rock', 'electronic']
       end
     end
 
 The `:allow_blank` option can be a symbol, in which case a method of that name will be called on the record.
 
-The `:allow_blank` option can also be a lambda, in which case the lambda will be called in the context of the record.
+The `:allow_blank` option can also be a proc, in which case the proc will be called in the context of the record.
 
 
 ### Values are only validated when they change
@@ -141,7 +141,7 @@ Values are only validated when they change. This is useful when the list of assi
 
 If a value has been saved before, it will remain valid, even if it is no longer assignable:
 
-    Song.update_all(:year => 1985) # update all records with a value that is no longer valid
+    Song.update_all(year: 1985) # update all records with a value that is no longer valid
     song = Song.last
     song.year # => 1985
     song.valid?  # => true
@@ -164,6 +164,24 @@ Once a changed value has been saved, the previous value disappears from the list
 
 This is to prevent records from becoming invalid as the list of assignable values evolves. This also prevents `<select>` menus with blank selections when opening an old record in a web form.
 
+### Array values
+
+Assignable values can also be used for array values. This works when you use Rails 5+ and PostgreSQL with an array column, or with ActiveRecord's `serialize`.
+
+To validate array values, pass `multiple: true`:
+
+```
+class Song < ActiveRecord::Base
+  serialize :genres   # skip this when you use PostgreSQL and an array type column
+
+  assignable_values_for :genres, multiple: true do
+    ['pop', 'rock', 'electronic']
+  end
+end
+```
+
+In this case, every *subset* of the given values is valid, for example `['pop', 'electronic']`.
+
 
 Restricting belongs_to associations
 -----------------------------------
@@ -175,15 +193,15 @@ You can restrict `belongs_to` associations in the same manner as scalar attribut
       belongs_to :artist
 
       assignable_values_for :artist do
-        Artist.where(:signed => true)
+        Artist.where(signed: true)
       end
 
     end
 
 Listing and validating als works the same:
 
-    chicane = Artist.create!(:name => 'Chicane', :signed => true)
-    lt2 = Artist.create!(:name => 'LT2', :signed => false)
+    chicane = Artist.create!(name: 'Chicane', signed: true)
+    lt2 = Artist.create!(name: 'LT2', signed: false)
 
     song = Song.new
 
@@ -225,10 +243,10 @@ Obtaining assignable values from another source
 
 The list of assignable values can be provided by any object that is accessible from your model. This is useful for authorization scenarios like [Consul](https://github.com/makandra/consul) or [CanCan](https://github.com/ryanb/cancan), where permissions are defined in a single class.
 
-You can define the source of assignable values by setting the `:through` option to a lambda:
+You can define the source of assignable values by setting the `:through` option to a proc:
 
     class Story < ActiveRecord::Base
-      assignable_values_for :state, :through => lambda { Power.current }
+      assignable_values_for :state, through: proc { Power.current }
     end
 
 `Power.current` must now respond to a method `assignable_story_states` or `assignable_story_states(story)` which returns an `Enumerable` of state strings:
@@ -251,7 +269,7 @@ You can define the source of assignable values by setting the `:through` option
 
 Listing and validating works the same with delegation:
 
-    story = Story.new(:state => 'accepted')
+    story = Story.new(state: 'accepted')
 
     Power.current = Power.new(:guest)
     story.assignable_states # => ['draft', 'pending']
@@ -263,17 +281,17 @@ Listing and validating works the same with delegation:
 
 Note that delegated validation is skipped when the delegate is `nil`. This way your model remains usable when there is no authorization context, like in batch processes or the console:
 
-    story = Story.new(:state => 'foo')
+    story = Story.new(state: 'foo')
     Power.current = nil
     story.valid? # => true
 
 Think of this as enabling an optional authorization layer on top of your model validations, which can be switched on or off depending on the current context.
 
-Instead of a lambda you can also use the `:through` option to name an instance method:
+Instead of a proc you can also use the `:through` option to name an instance method:
 
     class Story < ActiveRecord::Base
       attr_accessor :power
-      assignable_values_for :state, :through => :power
+      assignable_values_for :state, through: :power
     end
 
 
@@ -303,7 +321,7 @@ You can now delegate validation of assignable values to the current power by say
 This is a shortcut for saying:
 
      class Story < ActiveRecord::Base
-       assignable_values_for :state, :through => lambda { Power.current }
+       assignable_values_for :state, through: proc { Power.current }
      end
 
 Head over to the [Consul README](https://github.com/makandra/consul) for details.

data/gemfiles/Gemfile.2.3

@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 # Runtime dependencies
 gem 'activerecord', '~>2.3.0'
 gem 'i18n', '<0.7' # 0.7 no longer builds for Ruby 1.8.7
-gem 'mysql2', '= 0.2.20'
+gem 'mysql2', '= 0.2.24'
 
 # Development dependencies
 gem 'rake', '=10.0.4'

data/gemfiles/Gemfile.2.3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    assignable_values (0.13.1)
+    assignable_values (0.14.0)
       activerecord (>= 2.3)
 
 GEM
@@ -13,7 +13,7 @@ GEM
     database_cleaner (1.0.1)
     gemika (0.3.2)
     i18n (0.6.11)
-    mysql2 (0.2.20)
+    mysql2 (0.2.24)
     rake (10.0.4)
     rspec (1.3.2)
     rspec_candy (0.2.8)
@@ -31,10 +31,10 @@ DEPENDENCIES
   database_cleaner (~> 1.0.0)
   gemika
   i18n (< 0.7)
-  mysql2 (= 0.2.20)
+  mysql2 (= 0.2.24)
   rake (= 10.0.4)
   rspec (~> 1.3.0)
   rspec_candy
 
 BUNDLED WITH
-   1.15.4
+   1.16.1

data/gemfiles/Gemfile.3.2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    assignable_values (0.13.2)
+    assignable_values (0.14.0)
       activerecord (>= 2.3)
 
 GEM
@@ -62,4 +62,4 @@ DEPENDENCIES
   rspec_candy
 
 BUNDLED WITH
-   1.15.4
+   1.16.1

data/gemfiles/Gemfile.4.2.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    assignable_values (0.13.2)
+    assignable_values (0.14.0)
       activerecord (>= 2.3)
 
 GEM
@@ -67,4 +67,4 @@ DEPENDENCIES
   rspec_candy
 
 BUNDLED WITH
-   1.16.1
+   1.16.4

data/gemfiles/Gemfile.5.0.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    assignable_values (0.13.2)
+    assignable_values (0.14.0)
       activerecord (>= 2.3)
 
 GEM
@@ -64,4 +64,4 @@ DEPENDENCIES
   rspec_candy
 
 BUNDLED WITH
-   1.16.1
+   1.16.4

data/gemfiles/Gemfile.5.1.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    assignable_values (0.13.2)
+    assignable_values (0.14.0)
       activerecord (>= 2.3)
 
 GEM
@@ -65,4 +65,4 @@ DEPENDENCIES
   rspec_candy
 
 BUNDLED WITH
-   1.16.1
+   1.16.4

data/gemfiles/Gemfile.5.1.pg

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+# Runtime dependencies
+gem 'activerecord', '~>5.1.0'
+gem 'i18n'
+gem 'pg', '<1'
+
+# Development dependencies
+gem 'rake'
+gem 'database_cleaner'
+gem 'rspec'
+gem 'rspec_candy'
+gem 'gemika'
+
+# Gem under test
+gem 'assignable_values', :path => '..'

data/gemfiles/Gemfile.5.1.pg.lock

@@ -0,0 +1,68 @@
+PATH
+  remote: ..
+  specs:
+    assignable_values (0.14.0)
+      activerecord (>= 2.3)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.1.4)
+      activesupport (= 5.1.4)
+    activerecord (5.1.4)
+      activemodel (= 5.1.4)
+      activesupport (= 5.1.4)
+      arel (~> 8.0)
+    activesupport (5.1.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    arel (8.0.0)
+    concurrent-ruby (1.0.5)
+    database_cleaner (1.6.1)
+    diff-lcs (1.3)
+    gemika (0.3.2)
+    i18n (0.9.0)
+      concurrent-ruby (~> 1.0)
+    minitest (5.10.3)
+    pg (0.21.0)
+    rake (12.1.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.0)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    rspec_candy (0.4.1)
+      rspec
+      sneaky-save
+    sneaky-save (0.1.2)
+      activerecord (>= 3.2.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 5.1.0)
+  assignable_values!
+  database_cleaner
+  gemika
+  i18n
+  pg (< 1)
+  rake
+  rspec
+  rspec_candy
+
+BUNDLED WITH
+   1.16.4

data/lib/assignable_values/active_record/restriction/base.rb

@@ -29,22 +29,22 @@ module AssignableValues
           end
         end
 
-        def error_property
-          property
-        end
-
-        def not_included_error_message
-          if @options[:message]
-            @options[:message]
-          else
-            I18n.t('errors.messages.inclusion', :default => 'is not included in the list')
+        def set_default(record)
+          if record.new_record? && record.send(property).nil?
+            default_value = evaluate_default(record, default)
+            begin
+              if secondary_default? && !assignable_value?(record, default_value)
+                secondary_default_value = evaluate_default(record, secondary_default)
+                if assignable_value?(record, secondary_default_value)
+                  default_value = secondary_default_value
+                end
+              end
+            rescue AssignableValues::DelegateUnavailable
+              # skip secondary defaults if querying assignable values from a nil delegate
+            end
+            record.send("#{property}=", default_value)
           end
-        end
-
-        def assignable_value?(record, value)
-          (has_previously_saved_value?(record) && value == previously_saved_value(record))  ||
-            (value.blank? && allow_blank?(record)) ||
-            assignable_values(record).include?(value)
+          true
         end
 
         def assignable_values(record, options = {})
@@ -53,7 +53,11 @@ module AssignableValues
 
           if options.fetch(:include_old_value, true) && has_previously_saved_value?(record)
             old_value = previously_saved_value(record)
-            unless old_value.blank? || current_values.include?(old_value)
+            if @options[:multiple]
+              if old_value.is_a?(Array)
+                assignable_values |= old_value
+              end
+            elsif !old_value.blank? && !current_values.include?(old_value)
               assignable_values << old_value
             end
           end
@@ -65,25 +69,42 @@ module AssignableValues
           assignable_values
         end
 
-        def set_default(record)
-          if record.new_record? && record.send(property).nil?
-            default_value = evaluate_default(record, default)
-            begin
-              if secondary_default? && !assignable_value?(record, default_value)
-                secondary_default_value = evaluate_default(record, secondary_default)
-                if assignable_value?(record, secondary_default_value)
-                  default_value = secondary_default_value
-                end
-              end
-            rescue AssignableValues::DelegateUnavailable
-              # skip secondary defaults if querying assignable values from a nil delegate
-            end
-            record.send("#{property}=", default_value)
+        private
+
+        def error_property
+          property
+        end
+
+        def not_included_error_message
+          if @options[:message]
+            @options[:message]
+          else
+            I18n.t('errors.messages.inclusion', :default => 'is not included in the list')
           end
-          true
         end
 
-        private
+        def assignable_value?(record, value)
+          if @options[:multiple]
+            assignable_multi_value?(record, value)
+          else
+            assignable_single_value?(record, value)
+          end
+        end
+
+        def assignable_single_value?(record, value)
+          (has_previously_saved_value?(record) && value == previously_saved_value(record)) ||
+            (value.blank? && allow_blank?(record)) ||
+            assignable_values(record, :include_old_value => false).include?(value)
+        end
+
+        def assignable_multi_value?(record, value)
+          (has_previously_saved_value?(record) && value == previously_saved_value(record)) ||
+            (value.blank? ? allow_blank?(record) : subset?(value, assignable_values(record)))
+        end
+
+        def subset?(array1, array2)
+          array1.is_a?(Array) && array2.is_a?(Array) && (array1 - array2).empty?
+        end
 
         def evaluate_default(record, value_or_proc)
           if value_or_proc.is_a?(Proc)
@@ -177,7 +198,7 @@ module AssignableValues
             define_method validate_method do
               restriction.validate_record(self)
             end
-            validate validate_method
+            validate validate_method.to_sym
           end
         end
 

data/lib/assignable_values/active_record/restriction/belongs_to_association.rb

@@ -3,6 +3,13 @@ module AssignableValues
     module Restriction
       class BelongsToAssociation < Base
 
+        def initialize(*)
+          super
+          if @options[:multiple]
+            raise "Option :multiple is not allowed for restricting belongs_to associations."
+          end
+        end
+
         private
 
         def association_class
@@ -48,8 +55,6 @@ module AssignableValues
           record.send(property)
         end
 
-        private
-
         def association_id_was(record)
           if record.respond_to?(:attribute_in_database)
             record.attribute_in_database(:"#{association_id_method}").presence # Rails >= 5.1

data/lib/assignable_values/version.rb

@@ -1,3 +1,3 @@
 module AssignableValues
-  VERSION = '0.13.2'
+  VERSION = '0.14.0'
 end

data/spec/assignable_values/active_record_spec.rb

@@ -39,6 +39,50 @@ describe AssignableValues::ActiveRecord do
 
     end
 
+    context 'when validating virtual attributes with multiple: true' do
+
+      context 'with allow_blank: false' do
+
+        before :each do
+          @klass = Song.disposable_copy do
+            assignable_values_for :sub_genres,:multiple => true do
+              %w[pop rock]
+            end
+          end
+        end
+
+        it 'should validate that the attribute is a subset' do
+          @klass.new(:sub_genres => ['pop']).should be_valid
+          @klass.new(:sub_genres => ['pop', 'rock']).should be_valid
+          @klass.new(:sub_genres => ['pop', 'disallowed value']).should_not be_valid
+        end
+
+        it 'should not allow nil or [] for allow_blank: false' do
+          @klass.new(:sub_genres => nil).should_not be_valid
+          @klass.new(:sub_genres => []).should_not be_valid
+        end
+
+      end
+
+      context 'with allow_blank: true' do
+
+        before :each do
+          @klass = Song.disposable_copy do
+            assignable_values_for :sub_genres, :multiple => true, :allow_blank => true do
+              %w[pop rock]
+            end
+          end
+        end
+
+        it 'should allow nil or [] for allow_blank: false' do
+          @klass.new(:sub_genres => nil).should be_valid
+          @klass.new(:sub_genres => []).should be_valid
+        end
+
+      end
+
+    end
+
     context 'when validating scalar attributes' do
 
       context 'without options' do
@@ -195,6 +239,76 @@ describe AssignableValues::ActiveRecord do
 
     end
 
+    context 'when validating scalar attributes with multiple: true' do
+
+      context 'without options' do
+
+        before :each do
+          @klass = Song.disposable_copy do
+            assignable_values_for :genres, :multiple => true do
+              %w[pop rock]
+            end
+          end
+        end
+
+        it 'should validate that the attribute is allowed' do
+          @klass.new(:genres => ['pop']).should be_valid
+          @klass.new(:genres => ['pop', 'rock']).should be_valid
+          @klass.new(:genres => ['pop', 'invalid value']).should_not be_valid
+        end
+
+        it 'should not allow a scalar attribute' do
+          @klass.new(:genres => 'pop').should_not be_valid
+        end
+
+        it 'should not allow nil or [] for the attribute value' do
+          @klass.new(:genres => nil).should_not be_valid
+          @klass.new(:genres => []).should_not be_valid
+        end
+
+        it 'should allow a subset of previously saved values even if that value is no longer allowed' do
+          record = @klass.create!(:genres => ['pop'])
+          record.genres = ['pretend', 'previously', 'valid', 'value']
+          if ActiveRecord::VERSION::MAJOR < 3
+            record.save(false)
+          else
+            record.save(:validate => false) # update without validations for the sake of this test
+          end
+          record.reload.should be_valid
+          record.genres = ['valid', 'previously', 'pop']
+          record.should be_valid
+        end
+
+        it 'should allow a previously saved, blank value even if that value is no longer allowed' do
+          record = @klass.create!(:genres => ['pop'])
+          @klass.update_all(:genres => []) # update without validations for the sake of this test
+          record.reload.should be_valid
+        end
+
+      end
+
+      context 'if the :allow_blank option is set to true' do
+
+        before :each do
+          @klass = Song.disposable_copy do
+            assignable_values_for :genres, :multiple => true, :allow_blank => true do
+              %w[pop rock]
+            end
+          end
+        end
+
+        it 'should allow nil for the attribute value' do
+          @klass.new(:genres => nil).should be_valid
+        end
+
+        it 'should allow an empty array as value' do
+          @klass.new(:genres => []).should be_valid
+        end
+
+      end
+
+    end
+
     context 'when validating belongs_to associations' do
 
       it 'should validate that the association is allowed' do
@@ -262,6 +376,27 @@ describe AssignableValues::ActiveRecord do
         record.should be_valid
       end
 
+      it 'should not request the list of assignable values during validation if the association has not changed' do
+        allowed_association = Artist.create!
+        klass = Song.disposable_copy
+        record = klass.create!(:artist => allowed_association)
+
+        request_count = 0
+
+        klass.class_eval do
+          assignable_values_for :artist do
+            request_count += 1
+            [allowed_association]
+          end
+        end
+
+        record.reload
+        request_count.should == 0
+        record.year = 1975 # change any other attribute to make the record dirty
+        record.valid?
+        request_count.should == 0
+      end
+
       it 'should allow nil for an association if the record was saved before with a nil association' do
         allowed_association = Artist.create!
         klass = Song.disposable_copy
@@ -372,6 +507,32 @@ describe AssignableValues::ActiveRecord do
         klass.new.assignable_years.should == [1977, 1980, 1983]
       end
 
+      it 'should not request the list of assignable values during validation if the association has not changed' do
+        allowed_association = Artist.create!
+        klass = Song.disposable_copy
+        request_count = 0
+
+        delegate = Class.new do
+          define_method :assignable_song_artists do
+            request_count += 1
+            [allowed_association]
+          end
+        end.new
+
+        record = klass.create!(:artist => allowed_association)
+
+        klass.class_eval do
+          assignable_values_for :artist, :through => lambda { delegate }
+        end
+
+        request_count.should == 0
+
+        record.reload
+        record.year = 1975 # change any other attribute to make the record dirty
+        record.valid?
+        request_count.should == 0
+      end
+
       context 'when the delegation method returns nil' do
         let(:klass) do
           Song.disposable_copy do

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 $: << File.join(File.dirname(__FILE__), "/../../lib" )
 
 require 'i18n'
-require 'mysql2'
 require 'active_record'
 require 'assignable_values'
 require 'rspec_candy/all'

data/spec/support/database.rb

@@ -1,4 +1,7 @@
-Gemika::Database.new.rewrite_schema! do
+database = Gemika::Database.new
+database.connect
+
+database.rewrite_schema! do
 
   create_table :artists
 
@@ -7,10 +10,11 @@ Gemika::Database.new.rewrite_schema! do
     t.string :genre
     t.integer :year
     t.integer :duration
+    t.string :genres, :array => true
   end
 
   create_table :vinyl_recordings do |t|
     t.integer :year
   end
 
-end
+end

data/spec/support/models.rb

@@ -4,12 +4,16 @@ class Artist < ActiveRecord::Base
 
 end
 
-
 class Song < ActiveRecord::Base
 
   belongs_to :artist
 
-  attr_accessor :sub_genre
+  attr_accessor :sub_genre, :sub_genres
+
+  if ActiveRecord::VERSION::MAJOR < 4 || !Song.new(:genres => ['test']).genres.is_a?(Array)
+    # Rails 4 or not postgres
+    serialize :genres
+  end
 
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: assignable_values
 version: !ruby/object:Gem::Version
-  version: 0.13.2
+  version: 0.14.0
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-23 00:00:00.000000000 Z
+date: 2018-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -34,6 +34,7 @@ files:
 - ".rspec"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -50,6 +51,8 @@ files:
 - gemfiles/Gemfile.5.0.lock
 - gemfiles/Gemfile.5.1
 - gemfiles/Gemfile.5.1.lock
+- gemfiles/Gemfile.5.1.pg
+- gemfiles/Gemfile.5.1.pg.lock
 - lib/assignable_values.rb
 - lib/assignable_values/active_record.rb
 - lib/assignable_values/active_record/restriction/base.rb
@@ -87,7 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Restrict the values assignable to ActiveRecord attributes or associations