assignable_values 0.11.3 → 0.12.0

data/.gitignore

@@ -3,3 +3,4 @@ pkg
 *.gem
 .idea
 spec/*/log/*
+spec/support/database.yml

data/.ruby-version

@@ -1 +1 @@
-1.9.3
+2.1.8

data/.travis.yml

@@ -1,14 +1,46 @@
 language: ruby
+
 rvm:
-  - "1.8.7"
-  - "2.1.0"
-services:
-  - mysql
-script: rake travis:run
+  - 1.8.7
+  - 2.1.8
+  - 2.3.1
+
+gemfile:
+  - gemfiles/Gemfile.2.3
+  - gemfiles/Gemfile.3.2
+  - gemfiles/Gemfile.4.2
+  - gemfiles/Gemfile.5.0
+
+matrix:
+  exclude:
+    - gemfile: gemfiles/Gemfile.2.3
+      rvm: 2.1.8
+    - gemfile: gemfiles/Gemfile.2.3
+      rvm: 2.3.1
+    - gemfile: gemfiles/Gemfile.3.2
+      rvm: 2.3.1
+    - gemfile: gemfiles/Gemfile.4.2
+      rvm: 1.8.7
+    - gemfile: gemfiles/Gemfile.5.0
+      rvm: 2.1.8
+    - gemfile: gemfiles/Gemfile.5.0
+      rvm: 1.8.7
+
+sudo: false
+
+cache: bundler
+
 notifications:
   email:
     - fail@makandra.de
-branches:
-  only:
-    - master
-    - travis-testing
+
+before_script:
+  - mysql -e 'create database IF NOT EXISTS assignable_values_test;'
+
+install:
+  # Old Travis CI bundler explodes when lockfile version doesn't match recently bumped version
+  - gem install bundler --version='=1.12.5'
+  # This is the default Travis CI install step
+  - bundle install --jobs=3 --retry=3 --deployment --path=${BUNDLE_PATH:-vendor/bundle}
+
+script: bundle exec rake current_rspec

data/Gemfile

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+# Runtime dependencies
+gem 'activerecord', '~>4.2.0'
+gem 'i18n', '~>0.7.0'
+gem 'mysql2', '~> 0.3.17'
+
+# Development dependencies
+gem 'rake'
+gem 'database_cleaner'
+gem 'rspec', '~> 3.4'
+gem 'rspec_candy'
+gem 'gemika'
+
+# Gem under test
+gem 'assignable_values', :path => '..'

data/Gemfile.lock

@@ -0,0 +1,70 @@
+PATH
+  remote: ..
+  specs:
+    assignable_values (0.11.3)
+      activerecord (>= 2.3)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (4.2.7.1)
+      activesupport (= 4.2.7.1)
+      builder (~> 3.1)
+    activerecord (4.2.7.1)
+      activemodel (= 4.2.7.1)
+      activesupport (= 4.2.7.1)
+      arel (~> 6.0)
+    activesupport (4.2.7.1)
+      i18n (~> 0.7)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    arel (6.0.3)
+    builder (3.2.2)
+    database_cleaner (1.5.3)
+    diff-lcs (1.2.5)
+    gemika (0.3.2)
+    i18n (0.7.0)
+    json (1.8.3)
+    minitest (5.9.1)
+    mysql2 (0.3.20)
+    rake (10.3.2)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rspec_candy (0.3.1)
+      rspec
+      sneaky-save
+    sneaky-save (0.0.5)
+      activerecord (>= 3.2.0)
+    thread_safe (0.3.5)
+    tzinfo (1.2.2)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 4.2.0)
+  assignable_values!
+  database_cleaner
+  gemika
+  i18n (~> 0.7.0)
+  mysql2 (~> 0.3.17)
+  rake
+  rspec (~> 3.4)
+  rspec_candy
+
+BUNDLED WITH
+   1.12.5

data/README.md

@@ -1,11 +1,11 @@
-assignable_values - Enums on vitamins [![Build Status](https://secure.travis-ci.org/makandra/assignable_values.png?branch=master)](https://travis-ci.org/makandra/assignable_values) [![Code Climate](https://codeclimate.com/github/makandra/assignable_values.png)](https://codeclimate.com/github/makandra/assignable_values)
+assignable_values - Enums on vitamins [![Build Status](https://secure.travis-ci.org/makandra/assignable_values.png?branch=master)](https://travis-ci.org/makandra/assignable_values)
 =====================================
 
 `assignable_values` lets you restrict the values that can be assigned to attributes or associations of ActiveRecord models. You can think of it as enums where the list of allowed values is generated at runtime and the value is checked during validation.
 
 We carefully enhanced the core enum functionality with small tweaks that are useful for web forms, internationalized applications and common authorization patterns.
 
-`assignable_values` is tested with Rails 2.3, 3.2 and 4.1 on Ruby 1.8.7 and 2.1.0.
+`assignable_values` is tested with Rails 2.3, 3.2, 4.2 and 5.0 on Ruby 1.8.7, 2.1 and 2.3.
 
 
 Restricting scalar attributes
@@ -332,9 +332,20 @@ Now run `bundle install` and restart your server. Done.
 Development
 -----------
 
-- Fork the repository.
-- Push your changes with specs. There is a Rails 3 test application in `spec/app_root` if you need to test integration with a live Rails app.
-- Send me a pull request.
+There are tests in `spec`. We only accept PRs with tests. To run tests:
+
+- Install Ruby 2.1.8
+- Create a local test database `assignable_values_test` in both MySQL and PostgreSQL
+- Copy `spec/support/database.sample.yml` to `spec/support/database.yml` and enter your local credentials for the test database
+- Install development dependencies using `bundle install`
+- Run tests using `bundle exec rspec`
+
+We recommend to test large changes against multiple versions of Ruby and multiple dependency sets. Supported combinations are configured in `.travis.yml`. We provide some rake tasks to help with this:
+
+- Install development dependencies using `bundle matrix:install`
+- Run tests using `bundle matrix:spec`
+
+Note that we have configured Travis CI to automatically run tests in all supported Ruby versions and dependency sets after each push. We will only merge pull requests after a green Travis build.
 
 I'm very eager to keep this gem leightweight and on topic. If you're unsure whether a change would make it into the gem, [talk to me beforehand](mailto:henning.koch@makandra.de).
 

data/Rakefile

@@ -1,74 +1,10 @@
 require 'rake'
 require 'bundler/gem_tasks'
 
-desc 'Default: Run all specs.'
-task :default => 'all:spec'
-
-
-namespace :travis do
-  
-  desc 'Run tests on Travis CI'
-  task :run => [:compatible_rubygems, 'all:bundle:install', 'all:spec']
-
-  desc 'Ensure compatible Rubygems version for Ruby 1.8'
-  task :compatible_rubygems do
-    if RUBY_VERSION == '1.8.7'
-      system "rvm rubygems latest-1.8 --force"
-    end
-  end
-
-end
-
-namespace :all do
-
-  desc "Run specs on all spec apps"
-  task :spec do
-    success = true
-    for_each_directory_of('spec/**/Rakefile') do |directory|
-      env = "SPEC=../../#{ENV['SPEC']} " if ENV['SPEC']
-      success &= system("cd #{directory} && #{env} bundle exec rake spec")
-    end
-    fail "Tests failed" unless success
-  end
-
-
-  task :bundle => 'bundle:install'
-
-  namespace :bundle do
-
-    desc "Bundle all spec apps"
-    task :install do
-      for_each_directory_of('spec/**/Gemfile') do |directory|
-        Bundler.with_clean_env do
-          system("cd #{directory} && bundle install --without development")
-        end
-      end
-    end
-
-    desc "Update all gems, or a list of gem given by the GEM environment variable"
-    task :update do
-      for_each_directory_of('spec/**/Gemfile') do |directory|
-        Bundler.with_clean_env do
-          system("cd #{directory} && bundle update #{ENV['GEM']}")
-        end
-      end
-    end
-
-  end
-
+begin
+  require 'gemika/tasks'
+rescue LoadError
+  puts 'Run `gem install gemika` for additional tasks'
 end
 
-def for_each_directory_of(path, &block)
-  Dir[path].sort.each do |rakefile|
-    directory = File.dirname(rakefile)
-    puts '', "\033[4;34m# #{directory}\033[0m" # blue underline
-
-    if directory.include?('rails-2.3') and RUBY_VERSION != '1.8.7'
-      puts 'Skipping - Rails 2.3 requires Ruby 1.8.7'
-    elsif directory.include?('rails-4.1') and RUBY_VERSION == '1.8.7'
-      puts 'Skipping - Rails 4.1 does not support Ruby 1.8'
-    else
-      block.call(directory)
-    end
-  end
-end
+task :default => 'matrix:spec'

data/assignable_values.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.authors = ["Henning Koch"]
   s.email = 'henning.koch@makandra.de'
   s.homepage = 'https://github.com/makandra/assignable_values'
-  s.summary = 'Restrict the values assignable to ActiveRecord attributes or associations. Or enums on steroids.'
+  s.summary = 'Restrict the values assignable to ActiveRecord attributes or associations'
   s.description = s.summary
   s.license = 'MIT'
 
@@ -15,10 +15,5 @@ Gem::Specification.new do |s|
   s.test_files    = s.files.grep(%r{^spec/})
   s.require_paths = ["lib"]
 
-  s.add_dependency('activerecord')
-
-  s.add_development_dependency('rails', '~>3.1')
-  s.add_development_dependency('rspec', '~>2.8')
-  s.add_development_dependency('rspec-rails', '~>2.8')
-  s.add_development_dependency('sqlite3')
+  s.add_dependency('activerecord', '>=2.3')
 end

data/gemfiles/Gemfile.2.3

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+# Runtime dependencies
+gem 'activerecord', '~>2.3.0'
+gem 'i18n', '<0.7' # 0.7 no longer builds for Ruby 1.8.7
+gem 'mysql2', '= 0.2.20'
+
+# Development dependencies
+gem 'rake', '=10.0.4'
+gem 'database_cleaner', '~> 1.0.0'
+gem 'rspec', '~> 1.3.0'
+gem 'rspec_candy'
+gem 'gemika'
+
+# Gem under test
+gem 'assignable_values', :path => '..'

data/gemfiles/Gemfile.2.3.lock

@@ -0,0 +1,40 @@
+PATH
+  remote: ..
+  specs:
+    assignable_values (0.11.3)
+      activerecord (>= 2.3)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activerecord (2.3.17)
+      activesupport (= 2.3.17)
+    activesupport (2.3.17)
+    database_cleaner (1.0.1)
+    gemika (0.3.2)
+    i18n (0.6.11)
+    mysql2 (0.2.20)
+    rake (10.0.4)
+    rspec (1.3.2)
+    rspec_candy (0.2.8)
+      rspec
+      sneaky-save
+    sneaky-save (0.0.2)
+      activerecord (>= 2.3.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 2.3.0)
+  assignable_values!
+  database_cleaner (~> 1.0.0)
+  gemika
+  i18n (< 0.7)
+  mysql2 (= 0.2.20)
+  rake (= 10.0.4)
+  rspec (~> 1.3.0)
+  rspec_candy
+
+BUNDLED WITH
+   1.12.5

data/gemfiles/Gemfile.3.2

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+# Runtime dependencies
+gem 'activerecord', '~>3.2.0'
+gem 'i18n', '<0.7'
+gem 'mysql2', '= 0.3.17'
+
+# Development dependencies
+gem 'rake'
+gem 'database_cleaner', '~> 1.0.0'
+gem 'rspec', '~> 3.4'
+gem 'rspec_candy'
+gem 'gemika'
+
+# Gem under test
+gem 'assignable_values', :path => '..'

data/gemfiles/Gemfile.3.2.lock

@@ -0,0 +1,65 @@
+PATH
+  remote: ..
+  specs:
+    assignable_values (0.11.3)
+      activerecord (>= 2.3)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (3.2.22.5)
+      activesupport (= 3.2.22.5)
+      builder (~> 3.0.0)
+    activerecord (3.2.22.5)
+      activemodel (= 3.2.22.5)
+      activesupport (= 3.2.22.5)
+      arel (~> 3.0.2)
+      tzinfo (~> 0.3.29)
+    activesupport (3.2.22.5)
+      i18n (~> 0.6, >= 0.6.4)
+      multi_json (~> 1.0)
+    arel (3.0.3)
+    builder (3.0.4)
+    database_cleaner (1.0.1)
+    diff-lcs (1.2.5)
+    gemika (0.3.2)
+    i18n (0.6.11)
+    multi_json (1.12.1)
+    mysql2 (0.3.17)
+    rake (10.0.3)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rspec_candy (0.2.8)
+      rspec
+      sneaky-save
+    sneaky-save (0.0.4)
+      activerecord (>= 3.2.0)
+    tzinfo (0.3.52)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 3.2.0)
+  assignable_values!
+  database_cleaner (~> 1.0.0)
+  gemika
+  i18n (< 0.7)
+  mysql2 (= 0.3.17)
+  rake
+  rspec (~> 3.4)
+  rspec_candy
+
+BUNDLED WITH
+   1.12.5

data/gemfiles/Gemfile.4.2

@@ -0,0 +1,16 @@
+source 'https://rubygems.org'
+
+# Runtime dependencies
+gem 'activerecord', '~>4.2.0'
+gem 'i18n', '~>0.7.0'
+gem 'mysql2', '~> 0.3.17'
+
+# Development dependencies
+gem 'rake'
+gem 'database_cleaner'
+gem 'rspec', '~> 3.4'
+gem 'rspec_candy'
+gem 'gemika'
+
+# Gem under test
+gem 'assignable_values', :path => '..'