asset_symlink 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0f653f11927575868c5293b464c465a120147d03
-  data.tar.gz: 1e3b4df540e8af8cda325e4374bb900e6aebf922
+SHA256:
+  metadata.gz: 995bdeda8031a07c821d7d49c77e06e2ed0ce7657d13086f15a83f36b2e99bf7
+  data.tar.gz: 867bab482dea0f5bc0f0274b6265e22eacff2fc7a3af8651d9c518be55550257
 SHA512:
-  metadata.gz: 2259de8c1a1dc937267f9904d495604a95998bce634ec51434da8e109ed476d26795f6f7b6249eadc2e27da903d7cef8588f25d5ace924a1dd07703ab6c75afb
-  data.tar.gz: c5fa5908996b9129b678ba3f18ffe0243a731c0e2b12a1e3dcfda8e83173a7120e972c7e05479d22304da9c4b48d7bacf8018776d443732c467c5e85d399a486
+  metadata.gz: 986054a9a3ff531ea17b0b2bf9c5667dab9c006cfbc9a6681fd00d476e29948d68edb44ff6f96ff45682c3b71fd2bc1d1f88ca567ba61d56979dd82584f2a75b
+  data.tar.gz: a1f8ba4c7dcb1e91b723282c0f2dd3a1279de457adc52fa85169040963d7fa03037e221edb2d59b4c16672e879dc09b50324cf59ad664bdeb253ead8981b25e2

data/.travis.yml

@@ -1,11 +1,12 @@
 language: ruby
 rvm:
-  - 2.2.2
-  - 2.3.5
-  - 2.4.2
+  - 2.4.6
+  - 2.5.5
 install: bundle install
 gemfile:
   - gemfiles/4.2.10.gemfile
   - gemfiles/5.0.gemfile
   - gemfiles/5.1.gemfile
+  - gemfiles/5.2.gemfile
+
 script: "bundle exec rake spec"

data/Appraisals

@@ -2,7 +2,7 @@ appraise "4.2.10" do
   gem "rails", "4.2.10"
 end
 
-(0..1).each do |version|
+(0..2).each do |version|
   appraise "5.#{version}" do
     gem "rails", "~> 5.#{version}.0"
   end

data/asset_symlink.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "appraisal"
-  spec.add_runtime_dependency "rails", '>=4', '<5.2'
+  spec.add_runtime_dependency "rails", '>=4', '< 6.0'
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake", '< 11.0'
   spec.add_development_dependency "rspec", "~>2.14.0"

data/gemfiles/4.2.10.gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: ..
   specs:
     asset_symlink (0.3.0)
-      rails (>= 4, < 5.2)
+      rails (>= 4, <= 5.2)
 
 GEM
   remote: https://rubygems.org/
@@ -125,4 +125,4 @@ DEPENDENCIES
   rspec (~> 2.14.0)
 
 BUNDLED WITH
-   1.16.0
+   1.17.1

data/gemfiles/5.0.gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: ..
   specs:
     asset_symlink (0.3.0)
-      rails (>= 4, < 5.2)
+      rails (>= 4, <= 5.2)
 
 GEM
   remote: https://rubygems.org/
@@ -132,4 +132,4 @@ DEPENDENCIES
   rspec (~> 2.14.0)
 
 BUNDLED WITH
-   1.16.0
+   1.17.1

data/gemfiles/5.1.gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: ..
   specs:
     asset_symlink (0.3.0)
-      rails (>= 4, < 5.2)
+      rails (>= 4, <= 5.2)
 
 GEM
   remote: https://rubygems.org/
@@ -132,4 +132,4 @@ DEPENDENCIES
   rspec (~> 2.14.0)
 
 BUNDLED WITH
-   1.16.0
+   1.17.1

data/gemfiles/5.2.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+gem "appraisal"
+
+gemspec path: "../"

data/gemfiles/5.2.gemfile.lock

@@ -0,0 +1,143 @@
+PATH
+  remote: ..
+  specs:
+    asset_symlink (0.3.0)
+      rails (>= 4, <= 5.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    actioncable (5.2.0)
+      actionpack (= 5.2.0)
+      nio4r (~> 2.0)
+      websocket-driver (>= 0.6.1)
+    actionmailer (5.2.0)
+      actionpack (= 5.2.0)
+      actionview (= 5.2.0)
+      activejob (= 5.2.0)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.2.0)
+      actionview (= 5.2.0)
+      activesupport (= 5.2.0)
+      rack (~> 2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.2.0)
+      activesupport (= 5.2.0)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.0)
+      activesupport (= 5.2.0)
+      globalid (>= 0.3.6)
+    activemodel (5.2.0)
+      activesupport (= 5.2.0)
+    activerecord (5.2.0)
+      activemodel (= 5.2.0)
+      activesupport (= 5.2.0)
+      arel (>= 9.0)
+    activestorage (5.2.0)
+      actionpack (= 5.2.0)
+      activerecord (= 5.2.0)
+      marcel (~> 0.3.1)
+    activesupport (5.2.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    builder (3.2.3)
+    concurrent-ruby (1.1.3)
+    crass (1.0.4)
+    diff-lcs (1.3)
+    erubi (1.7.1)
+    globalid (0.4.1)
+      activesupport (>= 4.2.0)
+    i18n (1.1.1)
+      concurrent-ruby (~> 1.0)
+    loofah (2.2.3)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.1)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.3)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.1)
+    mimemagic (0.3.2)
+    mini_mime (1.0.1)
+    mini_portile2 (2.3.0)
+    minitest (5.11.3)
+    nio4r (2.3.1)
+    nokogiri (1.8.5)
+      mini_portile2 (~> 2.3.0)
+    rack (2.0.6)
+    rack-test (1.1.0)
+      rack (>= 1.0, < 3)
+    rails (5.2.0)
+      actioncable (= 5.2.0)
+      actionmailer (= 5.2.0)
+      actionpack (= 5.2.0)
+      actionview (= 5.2.0)
+      activejob (= 5.2.0)
+      activemodel (= 5.2.0)
+      activerecord (= 5.2.0)
+      activestorage (= 5.2.0)
+      activesupport (= 5.2.0)
+      bundler (>= 1.3.0)
+      railties (= 5.2.0)
+      sprockets-rails (>= 2.0.0)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.0.4)
+      loofah (~> 2.2, >= 2.2.2)
+    railties (5.2.0)
+      actionpack (= 5.2.0)
+      activesupport (= 5.2.0)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.5.0)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.8)
+    rspec-expectations (2.14.5)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.6)
+    sprockets (3.7.2)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.5)
+      thread_safe (~> 0.1)
+    websocket-driver (0.7.0)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.3)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  appraisal
+  asset_symlink!
+  bundler (~> 1.5)
+  rails (~> 5.2.0)
+  rake (< 11.0)
+  rspec (~> 2.14.0)
+
+BUNDLED WITH
+   1.17.1

data/lib/asset_symlink.rb

@@ -11,7 +11,7 @@ module AssetSymlink
           Sprockets::Railtie.build_manifest(Rails.application)
         else
           Rails.application.assets_manifest
-        end 
+        end
         manifest.assets[private_name]
       end
       digested_location = Rails.root.join('public','assets', asset)
@@ -27,11 +27,20 @@ module AssetSymlink
 
   def self.normalize_configuration config
     case config
-    when Hash 
+    when :all
+      result = {}
+      manifest_file = Rails.application.config.assets.manifest
+      if manifest_file.nil?
+        raise ArgumentError, "please set config.assets.manifest = 'path/to/your/manifest.json'"
+      end
+      JSON.parse(File.read(manifest_file))["files"].map do |digested_name, value|
+        [value['logical_path'], value['logical_path']]
+      end.to_h
+    when Hash
       config
     when String
       {config => config}
-    when Array 
+    when Array
       config.inject({}) do |result, element|
         result.merge(normalize_configuration(element))
       end

data/lib/asset_symlink/version.rb

@@ -1,3 +1,3 @@
 module AssetSymlink
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/asset_symlink_spec.rb

@@ -4,20 +4,27 @@ describe AssetSymlink do
 
   describe 'execute' do
     let(:sandbox) {File.join(File.dirname(__FILE__),'..','tmp')}
+    let(:manifest) {File.join(sandbox, 'manifest.json')}
     let(:assets) {Pathname.new(sandbox).join('public', 'assets')}
 
     before(:each) do
       FileUtils.rm_rf assets, :secure => true
       FileUtils.mkdir_p(assets)
       @assets_stub = double()
+      Rails.stub_chain(:application,:config,:assets,:manifest => manifest)
       Rails.stub_chain(:application,:assets => @assets_stub)
       Rails.stub(:root).and_return(Pathname.new(sandbox))
+      File.open(manifest, 'w'){ |f| f.write({"files" => {}}.to_json) }
     end
 
     def add_fake_asset(name, location)
       @assets_stub.stub(:find_asset).with(name).and_return(double(:digest_path => location))
       FileUtils.mkdir_p(assets.join(location).dirname)
       File.open(assets.join(location), 'w'){}
+      manifest_hash = JSON.parse(File.read(manifest))
+      manifest_hash["files"][location] = {}
+      manifest_hash["files"][location]["logical_path"] = name
+      File.open(manifest, 'w'){ |f| f.write(manifest_hash.to_json) }
     end
 
     it 'should symlink items at the top level of the assets folder' do
@@ -46,6 +53,14 @@ describe AssetSymlink do
       AssetSymlink.execute('widget.js')
       expect(assets.join('widget.js')).to be_a_symlink_to('widget-abc123.js')
     end
+
+    it 'should create all asset symlinks by manifest.json' do
+      add_fake_asset('external/widget.js', 'external/widget-abc123.js')
+      add_fake_asset('external/widget1.js', 'external/widget-abc1234.js')
+      AssetSymlink.execute(:all)
+      expect(assets.join('external/widget.js')).to be_a_symlink_to('widget-abc123.js')
+      expect(assets.join('external/widget1.js')).to be_a_symlink_to('widget-abc1234.js')
+    end
   end
 
   describe 'normalize_configuration' do
@@ -66,7 +81,7 @@ describe AssetSymlink do
     end
 
     it 'should convert an array of hashes by merging them' do
-      AssetSymlink.normalize_configuration([{'foo.js' => 'v1/foo.js'}, 
+      AssetSymlink.normalize_configuration([{'foo.js' => 'v1/foo.js'},
                                             {'bar.js' => 'v1/bar.js'}]).should == {'foo.js' => 'v1/foo.js',
                                                                                   'bar.js' => 'v1/bar.js'}
     end
@@ -80,4 +95,4 @@ describe AssetSymlink do
       expect {AssetSymlink.normalize_configuration([1])}.to raise_error(ArgumentError)
     end
   end
-end
+end

data/spec/integration_spec.rb

@@ -5,12 +5,12 @@ describe 'Integration specs' do
   end
   let(:assets) {test_app_location.join('public', 'assets')}
   def run_in_test_app(command)
-    Dir.chdir(test_app_location) do      
+    Dir.chdir(test_app_location) do
       output = Kernel.send :`,command
       raise output unless $? == 0
     end
   end
-  
+
   before :all do
     FileUtils.rm_rf(test_app_location.join('public', 'assets'))
     run_in_test_app('rake assets:precompile 2>&1')
@@ -29,4 +29,4 @@ describe 'Integration specs' do
   def find_asset_name(path)
     File.basename(Dir.chdir(assets) { Dir.glob(path).first })
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_symlink
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Frederick Cheung
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-10 00:00:00.000000000 Z
+date: 2019-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -33,7 +33,7 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -107,6 +107,8 @@ files:
 - gemfiles/5.0.gemfile.lock
 - gemfiles/5.1.gemfile
 - gemfiles/5.1.gemfile.lock
+- gemfiles/5.2.gemfile
+- gemfiles/5.2.gemfile.lock
 - lib/asset_symlink.rb
 - lib/asset_symlink/railtie.rb
 - lib/asset_symlink/tasks/symlink.rake
@@ -165,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: easily make assets available under a consistent public name