asset_cloud 2.3.0 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9915f9ae949c5a943ba524a2816df249c3e6ab3cc295786fc0cbbad6dd1690c4
-  data.tar.gz: e0b47f11c95a23903c702ed9f1c8b41fdb4115a459ae83937448902efb22ff56
+  metadata.gz: f22a2b32e4f1e13f4743603220642baf85b8d1b3ddb30191c5851e84a0e12239
+  data.tar.gz: 3e5aece0ed39d47752f86be2f5da8a78a388db4b5f686df6eb100059f2435d6e
 SHA512:
-  metadata.gz: dd7caa8ab93936dfa3dc2a8823eaa3d8e6de5fc53a1c81928946595dbac5a67e67f2d925385494e30dcbfca18a16b3de805d2e6aab0ae32effa1b8abe063efdf
-  data.tar.gz: 59a74007e74f62b823d902414f6275ad26974f55fa0fb75f15a5bdef09ec104dee5ad2a673d5c8a6cb73fe94527ffce07783cd0ce3598721b66a0d8086672d9f
+  metadata.gz: 2f2d1ccf6ad860ab28e84aa67046bf45b0b8bd9e5a47b4c1973e8bbb23c8b686d040a85420d260e47aaa68ee22d0ced688c52383f0f02e46e97edaf3d773a3f5
+  data.tar.gz: 0e53e2aab25cc6dbeb0b7de72d94f5a8f3c671850451948577f9f6d876229fdd0cefc3bbace06561145dde8b838f7fc8688aa484e2fdd8c89a6b19403a8fc610

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.3.0"
+  s.version = "2.3.1"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}

data/lib/asset_cloud/asset.rb

@@ -34,13 +34,7 @@ module AssetCloud
     end
 
     def <=>(other)
-      return 1 unless other.is_a?(Asset)
-      compare_cloud = cloud.object_id <=> other.cloud.object_id
-      if compare_cloud == 0
-        key <=> other.key
-      else
-        compare_cloud
-      end
+      key <=> other.try(:key)
     end
 
     def new_asset?

data/spec/asset_spec.rb

@@ -186,13 +186,6 @@ describe "Asset" do
         expect(@asset == other_asset).to eq(true)
       end
 
-      it "is not equal if cloud of both assets are not equal" do
-        other_cloud = double('Cloud2', :asset_extension_classes_for_bucket => [], :object_id => 999)
-        other_asset = AssetCloud::Asset.new(other_cloud, @key)
-
-        expect(@asset == other_asset).to eq(false)
-      end
-
       it "is not equal if key of both assets are not equal" do
         other_key = "products/other_key.txt"
         other_asset = AssetCloud::Asset.new(@cloud, other_key)
@@ -209,6 +202,11 @@ describe "Asset" do
         expect(@asset == :some_symbol).to eq(false)
         expect(@asset == []).to eq(false)
         expect(@asset == nil).to eq(false)
+
+        expect(@asset <=> "some_string").to eq(nil)
+        expect(@asset <=> :some_symbol).to eq(nil)
+        expect(@asset <=> []).to eq(nil)
+        expect(@asset <=> nil).to eq(nil)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-14 00:00:00.000000000 Z
+date: 2020-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport