asset_cloud 2.2.7 → 2.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d356abcae5568be4981cdcbb779ba94471a67f942f048ee96119e9b9260cf366
-  data.tar.gz: 3923b527fe0e5c7e670641f53c6397723465a02877431b50e8e7da20bc67ee74
+  metadata.gz: f1331f148d5e428464e3d7f539963c1c2651f528656a3c8ef0266d6aa299379c
+  data.tar.gz: 7f62fa26ae75e6e630aee982c08067cfbf38e1e6e3e49cd9afc99a33505825c3
 SHA512:
-  metadata.gz: e8f3a5c2252c2cd574fc55e4feb4aa205a3340e8a43cb945414740be9f6313d422ecc241a8cb8279e48f7b32b6695817576f95779107dd072543c0024d69b33f
-  data.tar.gz: 480ada19cbcddae3f9acc2fc46d1022d82b3ba7582534b91aa9f0fe6dc0bbae9efa70f09f5fafd64b95be3e39601ec2b88d2d3bb34b10fe0fe8b7c540f5d0603
+  metadata.gz: 03aca7a78234bbb51998cad8a0740e7f7ae2d0a14a2b3dc32ed9317bea003cf1e684845c56ae1554e90e2cf7d4f6ba64dbabdf63b1b90f2e85f7a8186b27c7d1
+  data.tar.gz: 7284d30086ea786bdc0b1a18fe6a8a27ea829bedacded167244d21a7334926aa8d444202ad594c98f0c8ed2cb7c998b7c9725fcf4ab4519008970865146908e0

data/asset_cloud.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "2.2.7"
+  s.version = "2.2.8"
 
   s.authors = %w(Shopify)
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}

data/lib/asset_cloud/buckets/gcs_bucket.rb

@@ -13,8 +13,12 @@ module AssetCloud
       downloaded.read
     end
 
-    def write(key, data)
-      bucket.create_file(data, absolute_key(key))
+    def write(key, data, options = {})
+      bucket.create_file(
+        data,
+        absolute_key(key),
+        options
+      )
     end
 
     def delete(key)

data/spec/gcs_bucket_remote_spec.rb

@@ -54,6 +54,35 @@ describe AssetCloud::GCSBucket, if: ENV['GCS_PROJECT_ID'] && ENV['GCS_KEY_FILEPA
     @bucket.write(key, local_path)
   end
 
+  it "#write writes a file into the bucket with metadata" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    metadata = {
+      "X-Robots-Tag" => "none"
+    }
+
+    file = @bucket.write(key, local_path, metadata: metadata)
+    expect(file.metadata).to eq(metadata)
+  end
+
+  it "#write writes a file into the bucket with acl" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    acl = 'public'
+
+    file = @bucket.write(key, local_path, acl: acl)
+    expect(file.acl).to be_truthy
+  end
+
+  it "#write writes a file into the bucket with content_disposition" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    content_disposition = 'attachment'
+
+    file = @bucket.write(key, local_path, content_disposition: content_disposition)
+    expect(file.content_disposition).to eq(content_disposition)
+  end
+
   it "#delete removes the file from the bucket" do
     key = 'test/key.txt'
 

data/spec/gcs_bucket_spec.rb

@@ -11,7 +11,7 @@ class MockGCSBucket < AssetCloud::GCSBucket
   def file(key)
   end
 
-  def create_file(data, key)
+  def create_file(data, key, options = {})
   end
 end
 
@@ -40,11 +40,56 @@ describe AssetCloud::GCSBucket do
   it "#write writes a file into the bucket" do
     local_path = "#{directory}/products/key.txt"
     key = 'test/key.txt'
-    expect_any_instance_of(MockGCSBucket).to receive(:create_file).with(local_path, "s#{@cloud.url}/#{key}")
+    expect_any_instance_of(MockGCSBucket).to receive(:create_file).with(
+      local_path,
+      "s#{@cloud.url}/#{key}",
+      {}
+    )
 
     @bucket.write(key, local_path)
   end
 
+  it "#write writes a file into the bucket with metadata" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    metadata = {
+      "X-Robots-Tag" => "none"
+    }
+    expect_any_instance_of(MockGCSBucket).to receive(:create_file).with(
+      local_path,
+      "s#{@cloud.url}/#{key}",
+      metadata: metadata
+    )
+
+    @bucket.write(key, local_path, metadata: metadata)
+  end
+
+  it "#write writes a file into the bucket with acl" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    acl = 'public'
+    expect_any_instance_of(MockGCSBucket).to receive(:create_file).with(
+      local_path,
+      "s#{@cloud.url}/#{key}",
+      acl: acl
+    )
+
+    @bucket.write(key, local_path, acl: acl)
+  end
+
+  it "#write writes a file into the bucket with content_disposition" do
+    local_path = "#{directory}/products/key.txt"
+    key = 'test/key.txt'
+    content_disposition = 'attachment'
+    expect_any_instance_of(MockGCSBucket).to receive(:create_file).with(
+      local_path,
+      "s#{@cloud.url}/#{key}",
+      content_disposition: content_disposition
+    )
+
+    @bucket.write(key, local_path, content_disposition: content_disposition)
+  end
+
   it "#delete removes the file from the bucket" do
     key = 'test/key.txt'
     expect_any_instance_of(MockGCSBucket).to receive(:file).with("s#{@cloud.url}/#{key}").and_return(Google::Cloud::Storage::File.new)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 2.2.7
+  version: 2.2.8
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-01 00:00:00.000000000 Z
+date: 2019-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport