asset_cloud 1.1.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b1e23c78331e494fb7424655a26eb74993ddfc5
-  data.tar.gz: 38a165425c92cc6ae19d9ee0784ceb55546705b1
+  metadata.gz: fa28322db86635a35c0824e9629d1d65b1cb7e56
+  data.tar.gz: 5d493e09e7037f6bbc830c8f2cc7730c6ea05213
 SHA512:
-  metadata.gz: ebf40d57f22ddbb3816224d1722cc724c2ab54d13ea8ec945eb00c963abe9970a26e268f8e423f4697ae761654d1fe2695a162f203c72c67ba1df7032d5051f2
-  data.tar.gz: 24cce0199528c46eee2fbd100f1319b4ce1b459b97ffdbf87669e66b637ce58b3ed7d1ed3bc9915039ab20d1e3016b77059660c8aa2b6752b3964364254a08cd
+  metadata.gz: 0423e9ef826f7e230aec6ada6ddf050460ffbb0bf2027feeaabbcdd645897274aa890478ad0d522910fbd704531d98f2f54352114f2f17b21dd05df7c44bd41b
+  data.tar.gz: fe6bc175f198b741011d0ab6d6280813e611f8e19da376ed0e6245116a80acb324049954882f6a0fb16631a528be011621714fe072b1575423c15a95a0b6c753

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
 rvm:
-  - 1.9.3
-  - 2.0.0
-
+  - '1.9'
+  - '2.0'
+  - '2.1'

data/History.md

@@ -0,0 +1,5 @@
+# Asset Cloud Version History
+
+## Version 2.0.0, 2014-09-26
+
+* Change the way methods on asset extensions are invoke so it won't silently swallow exceptions [#3](https://github.com/Shopify/asset_cloud/pull/3).

data/asset_cloud.gemspec

@@ -2,10 +2,9 @@
 
 Gem::Specification.new do |s|
   s.name = %q{asset_cloud}
-  s.version = "1.1.1"
+  s.version = "2.0.0"
 
   s.authors = %w(Shopify)
-  s.date = %q{2009-08-04}
   s.summary = %q{An abstraction layer around arbitrary and diverse asset stores.}
   s.description = %q{An abstraction layer around arbitrary and diverse asset stores.}
 

data/lib/asset_cloud/asset.rb

@@ -165,14 +165,15 @@ module AssetCloud
     end
 
     def method_missing(method, *args)
-      @extensions.each do |ext|
-        begin
-          return ext.send(method, *args)
-        rescue NoMethodError, NotImplementedError => e
-          nil
-        end
+      if extension = @extensions.find { |e| e.respond_to?(method) }
+        extension.public_send(method, *args)
+      else
+        super
       end
-      super
+    end
+
+    def respond_to_missing?(method, include_all)
+      @extensions.any? { |extension| extension.respond_to?(method, include_all) } || super
     end
 
     private

data/spec/asset_extension_spec.rb

@@ -98,6 +98,17 @@ describe "AssetExtension" do
       asset.turn_into_xml
       asset.value.should == '<xml>dogs</xml>'
     end
+
+    it "does not swallow NotImplementedError" do
+      XmlAssetExtension.send(:define_method, :my_unimplemented_extension) do
+        raise NotImplementedError
+      end
+
+      asset = @cloud['dog_pound/dogs.xml']
+
+      expect(asset).to respond_to(:my_unimplemented_extension)
+      expect { asset.my_unimplemented_extension }.to raise_error(NotImplementedError)
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: asset_cloud
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Shopify
@@ -30,7 +30,7 @@ cert_chain:
   fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
   TConQSX2BnZdhIEYW+cKzEC/bLc=
   -----END CERTIFICATE-----
-date: 2009-08-04 00:00:00.000000000 Z
+date: 2014-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -97,6 +97,7 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
+- History.md
 - LICENSE
 - README.rdoc
 - Rakefile
@@ -152,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: An abstraction layer around arbitrary and diverse asset stores.