assembly-objectfile 1.5.3 → 1.5.4

data/README.rdoc

@@ -58,6 +58,7 @@ content type specific operations (such as jp2 generation).
 - 1.5.1 Pin mini_exiftool to 1.x and Nokogiri to 1.5.x branch for Ruby 1.8.7, added image/png and application/zip
 - 1.5.2 Fix for Rails 4 and support for 'rake console'
 - 1.5.3 More gemfile updates
+- 1.5.4 jp2able? method now returns true even if profile description is missing; add new method which does a check for existing color profile in an image
 
 ==Usage
 

data/lib/assembly-objectfile/object_fileable.rb

@@ -194,7 +194,7 @@ module Assembly
       object_type == :image 
     end
 
-    # Examines the input image for validity.  Used to determine if image is a valid and useful image.  If image is not a jp2, also checks for a valid profile.
+    # Examines the input image for validity.  Used to determine if image is a valid and useful image.  If image is not a jp2, also checks if it is jp2able?
     #
     # @return [boolean] true if image is valid, false if not.
     #
@@ -210,6 +210,17 @@ module Assembly
       
     end
 
+    # Examines the input image for a color profile.
+    #
+    # @return [boolean] true if image has a color profile, false if not.
+    #
+    # Example:
+    #   source_img=Assembly::ObjectFile.new('/input/path_to_file.tif')
+    #   puts source_img.has_color_profile? # gives true
+    def has_color_profile?
+      exif.nil? ? false : !exif['profiledescription'].nil? # check for existence of profile description  
+    end
+
     # Examines the input image for validity to create a jp2.  Same as valid_image? but also confirms the existence of a profile description and further restricts mimetypes.
     # It is used by the assembly robots to decide if a jp2 will be created and is also called before you create a jp2 using assembly-image.
     # @return [boolean] true if image should have a jp2 created, false if not.
@@ -222,7 +233,6 @@ module Assembly
       result=false
       unless exif.nil?
         result=(Assembly::VALID_IMAGE_MIMETYPES.include?(mimetype)) # check for allowed image mimetypes that can be converted to jp2
-        result=(exif['profiledescription'] != nil) # check for existence of profile description
       end
       return result
 

data/lib/assembly-objectfile/version.rb

@@ -3,7 +3,7 @@ module Assembly
   
   class ObjectFile
     # Project version number    
-    VERSION = "1.5.3"
+    VERSION = "1.5.4"
   end
 
 end

data/spec/object_file_spec.rb

@@ -53,13 +53,34 @@ describe Assembly::ObjectFile do
     @ai.dpg_folder.should == "05"
   end
   
-  it "should tell us that a jp2 file not jp2able and is not valid since it has no profile" do
+  it "should tell us that a jp2 file is jp2able but has no color profile" do
     File.exists?(TEST_JP2_INPUT_FILE).should be true
     @ai = Assembly::ObjectFile.new(TEST_JP2_INPUT_FILE)
     @ai.image?.should == true
     @ai.object_type.should == :image
     @ai.valid_image?.should == true
-    @ai.jp2able?.should == false
+    @ai.jp2able?.should == true
+    @ai.has_color_profile?.should == false
+  end
+
+  it "should tell us that a tiff file is jp2able and has a color profile" do
+    File.exists?(TEST_RES1_TIF1).should be true
+    @ai = Assembly::ObjectFile.new(TEST_RES1_TIF1)
+    @ai.image?.should == true
+    @ai.object_type.should == :image
+    @ai.valid_image?.should == true
+    @ai.jp2able?.should == true
+    @ai.has_color_profile?.should == true
+  end
+  
+  it "should tell us that a tiff file is not jp2able and is not valid since it has no profile" do
+    File.exists?(TEST_TIFF_NO_COLOR_FILE).should be true
+    @ai = Assembly::ObjectFile.new(TEST_TIFF_NO_COLOR_FILE)
+    @ai.image?.should == true
+    @ai.object_type.should == :image
+    @ai.valid_image?.should == true
+    @ai.jp2able?.should == true
+    @ai.has_color_profile?.should == false
   end
     
   it "should compute checksums for an image file" do

data/spec/spec_helper.rb

@@ -22,6 +22,8 @@ TEST_DPG_SPECIAL_PDF1=File.join(TEST_INPUT_DIR,'oo000oo0001','oo000oo0001_book.p
 TEST_DPG_SPECIAL_PDF2=File.join(TEST_INPUT_DIR,'oo000oo0001','31','oo000oo0001_31_001.pdf')
 TEST_DPG_SPECIAL_TIF=File.join(TEST_INPUT_DIR,'oo000oo0001','50','oo000oo0001_50_001.tif')
 
+TEST_TIFF_NO_COLOR_FILE=File.join(TEST_INPUT_DIR,'test_no_color_profile.tif')
+
 TEST_RES1_TIF1=File.join(TEST_INPUT_DIR,'res1_image1.tif')
 TEST_RES1_JP1=File.join(TEST_INPUT_DIR,'res1_image1.jp2')
 TEST_RES1_TIF2=File.join(TEST_INPUT_DIR,'res1_image2.tif')

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: assembly-objectfile
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 11
   prerelease: 
   segments: 
   - 1
   - 5
-  - 3
-  version: 1.5.3
+  - 4
+  version: 1.5.4
 platform: ruby
 authors: 
 - Peter Mangiafico
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-08-23 00:00:00 Z
+date: 2013-08-29 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   version_requirements: &id001 !ruby/object:Gem::Requirement 
@@ -219,6 +219,7 @@ files:
 - spec/test_data/input/test.tif
 - spec/test_data/input/test2.jp2
 - spec/test_data/input/test2.tif
+- spec/test_data/input/test_no_color_profile.tif
 homepage: ""
 licenses: []
 
@@ -290,4 +291,5 @@ test_files:
 - spec/test_data/input/test.tif
 - spec/test_data/input/test2.jp2
 - spec/test_data/input/test2.tif
+- spec/test_data/input/test_no_color_profile.tif
 has_rdoc: