ask-mcp 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae155e99332cb2a3fcec6b65c6d0ac20aa9b2b81b27f1e3aa3c667dc0c7a42fb
-  data.tar.gz: af84c5f5aae82c640e2c12316cde40444fe7733d6ad5aaddd6780242b98e1a1c
+  metadata.gz: 909c171336e0497c2377c2f4106e1ec0314adbbbf15791819caf6be0c9d04035
+  data.tar.gz: 5a5e95508499f38e310cce0052fcd4c9dfd2c95f8a4e965621c37d35c392293d
 SHA512:
-  metadata.gz: 62f473ff0fdc35b25adcdadf3aeb2a65c330767f7b73cc85bed204a32bff7fcc28f0348c2ee3f8e8ae1e3d7eaf3977714af67d67038c1be990d9feca2199d81f
-  data.tar.gz: e511364526282fcb429740dbd65bbce3e51d0bde06a06cb672e33a0c30b1b09e1971c663145f1b272d7e01015060349447bb7d53081b8dd9813dea02f19591e9
+  metadata.gz: 52526b46e9574fb4289ddde3b7ff340945eead680763ad7ece3903a8bea89a5a535cb3b9951b0236f6749808b22254c9f4b691133eff56e24a7438eb68ae8743
+  data.tar.gz: be8c62053892b8aa52e5216fcb58c7857ecfdff12b025173d9cd1be1a384cced8dd41ef4f9e17ca531fe6d869743dbc63caad275fbccb82014ddd4d94d49c3a2

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [0.4.1] - 2026-07-31
+
+### Changed
+
+- **`ToolServer` result wrapping** — plain `String` results are always treated
+  as success; result-like objects (`Ask::Result`, OpenStruct, etc.) use
+  `ok?`/`ok` and `output`/`error_message`; any other value is treated as
+  success with `to_s` used for the response.
+
+### Fixed
+
+- **Stdio server protocol version** — pins `PROTOCOL_VERSION` to
+  `2025-06-18` and echoes it back in the `initialize` response.
+
 ## [0.4.0] - 2026-06-26
 
 ### Added

data/lib/ask/mcp/adapters/tool_server.rb

@@ -8,28 +8,18 @@ module Ask
       # respond to +name+, +description+, +params_schema+, and +call(args)+ and
       # exposes them over MCP.
       #
-      # Usage:
-      #   class MyTool
-      #     def name; "hello" end
-      #     def description; "Says hello" end
-      #     def params_schema; nil end
-      #     def call(args = {}); OpenStruct.new(ok?: true, output: "Hello!") end
-      #   end
-      #
-      #   adapter = ToolServer.new([MyTool.new])
-      #   adapter.definitions  # => [{ name: "hello", ... }]
-      #   adapter.call("hello", {})  # => { content: [...], isError: false }
+      # Tools can return:
+      #   - An object responding to #ok?/#ok and #output/#error_message (Ask::Result style)
+      #   - A plain String (treated as success)
+      #   - Any other value (treated as success, .to_s is used for the response)
       class ToolServer
         attr_reader :tools
 
-        # @param tools [Array<#call, #name, #description, #params_schema>] tool instances to expose
         def initialize(tools = [])
           @tools = tools
           @tool_map = tools.each_with_object({}) { |t, h| h[t.name] = t }
         end
 
-        # MCP tool definitions for tools/list
-        # @return [Array<Hash>]
         def definitions
           @tools.map do |tool|
             schema = tool.params_schema || { type: "object", properties: {}, required: [] }
@@ -41,10 +31,6 @@ module Ask
           end
         end
 
-        # Call a tool and wrap the result in MCP format
-        # @param name [String] tool name
-        # @param arguments [Hash] arguments (may have symbol or string keys)
-        # @return [Hash] { content: [...], isError: true/false }
         def call(name, arguments = {})
           tool = @tool_map[name]
           unless tool
@@ -64,18 +50,31 @@ module Ask
         private
 
         def wrap_result(result)
-          if result.respond_to?(:ok?) ? result.ok? : result.ok
-            output = result.respond_to?(:output) ? result.output : result.to_s
-            text = output.is_a?(Hash) ? (output[:summary] || output.to_s) : output.to_s
-            { content: [{ type: "text", text: text }], isError: false }
-          else
-            msg = result.respond_to?(:error_message) ? result.error_message : result.to_s
-            { content: [{ type: "text", text: "Error: #{msg}" }], isError: true }
+          # Plain strings are always a success
+          if result.is_a?(String)
+            return { content: [{ type: "text", text: result }], isError: false }
+          end
+
+          # Result-like objects (Ask::Result, OpenStruct, etc.)
+          if result.respond_to?(:ok?) || result.respond_to?(:ok)
+            ok = result.respond_to?(:ok?) ? result.ok? : result.ok
+            return success_result(result, ok) if ok
+            return error_result(result.respond_to?(:error_message) ? result.error_message : result.to_s)
           end
+
+          # Everything else — treat as success
+          text = result.is_a?(Hash) ? (result[:summary] || result.to_s) : result.to_s
+          { content: [{ type: "text", text: text }], isError: false }
+        end
+
+        def success_result(result, _ok)
+          output = result.respond_to?(:output) ? result.output : result.to_s
+          text = output.is_a?(Hash) ? (output[:summary] || output.to_s) : output.to_s
+          { content: [{ type: "text", text: text }], isError: false }
         end
 
         def error_result(message)
-          { content: [{ type: "text", text: message }], isError: true }
+          { content: [{ type: "text", text: "Error: #{message}" }], isError: true }
         end
 
         def deep_stringify_keys(obj)

data/lib/ask/mcp/server/stdio.rb

@@ -9,6 +9,7 @@ module Ask
       # MCP server over stdio transport.
       class Stdio
         MAX_RESULT_CACHE = 100
+        PROTOCOL_VERSION = "2025-06-18"
 
         attr_reader :name, :tools, :capabilities, :resources, :prompts
 

data/lib/ask/mcp/version.rb

@@ -1,5 +1,5 @@
 module Ask
   module MCP
-    VERSION = "0.4.0"
+    VERSION = "0.4.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-mcp
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Kaka Ruto