ask-coding-providers 0.3.5 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d085b1481b659a565ab9842b4d01f3b40d137bc42c4c2ff48b7f8c6365f3804e
-  data.tar.gz: 133c09956ea2c6bdf6ff1fa122cbf227b1eebb95c0837b30bc7f38d5007db570
+  metadata.gz: 9a9bceeaeb150f93011b4ae4579f38785da28c602aad7b0e7481d28ae6f4e524
+  data.tar.gz: 3d9a6028ccbee66c43f133fe054f54202616930e4f213f651a194a01bf8606f2
 SHA512:
-  metadata.gz: e8f0448c7baa7b1e777431ccc3fa734f1503015b770bf0f9685f34a8d8b911cc704d1412a412e8e7019edd60f2764fef1c16f2e5a12d82648b768e8e246a3cef
-  data.tar.gz: 7ce2091d32619c309e231145d2d9f30deceb568d223545b15899471711bd8f2034518b8090bb2ec3b771c7c0d96e3f91f2b9a71e62909cf42356c5be2dc6cbfc
+  metadata.gz: 55fea7d85deb5021ff668f1381c3372ce55fcce605a867b26cc206b62d7e87e2896381a0d2448b8149c415c31c8ccd458040d6e8d16004922533bf4b3f888047
+  data.tar.gz: 3edc8ade5699fa8f1d18f73491f57d2dd7f15b925c254d62097cd5c73bfa7c8b2b660f3cbe7c029c7300a74bfd92c34231657e1a506e1dbb67040f23d6b6e652

data/CHANGELOG.md

@@ -2,6 +2,21 @@
 
 ## [Unreleased]
 
+## [0.4.0] - 2026-09-23
+
+### Added
+
+- **Approval scopes on the AskAgent adapter.** `approve_action` and
+  `approve_all` accept `scope: :once | :session` (default `:once`) and
+  pass it through to `Ask::Permissions::ApprovalQueue#approve` /
+  `#approve_all`. `:session` records a session grant — applied by
+  `Ask::Agent::Session` before the approved action runs — so matching
+  actions later in the session are auto-approved; `:once` stays
+  one-shot. `:project` raises `ArgumentError` in this adapter: project
+  grants are never injected here, so accepting it would be a silent
+  no-op.
+## [0.3.5] - 2026-09-23
+
 ### Changed
 
 - **Approval queue extracted to `ask-permissions`.** The AskAgent adapter's

data/README.md

@@ -39,6 +39,13 @@ adapter = Ask::CodingProviders.build_adapter("ask_agent", model: "deepseek-v4-fl
 - Adapter interface (`Ask::CodingProviders::Adapter`): `create_session`,
   `resume_session`, `list_sessions`, `subscribe`, `send_message`,
   `send_and_stream`, `get_events`, `respond`, `get_workspace_state`.
+- AskAgent approval scopes: `approve_action(session_id, action_id, scope:
+  :once | :session)` and `approve_all(session_id, scope: ...)` pass the
+  scope through to `Ask::Permissions::ApprovalQueue#approve` /
+  `#approve_all`. `:once` (default) approves only the named action;
+  `:session` records a session grant (applied by `Ask::Agent::Session`)
+  so matching actions later in the session are auto-approved. `:project`
+  raises `ArgumentError` — this adapter never injects project grants.
 - `Ask::CodingProviders::ZCode::ZCodeDB` - read-only helper for querying
   ZCode's SQLite session store at `~/.zcode/cli/db/db.sqlite`. Methods
   (`list_projects`, `find_sessions`, `session_history`, `recent_sessions`,

data/lib/ask/coding_providers/ask_agent/adapter.rb

@@ -46,13 +46,15 @@ module Ask
 
         private
 
-        def apply(action)
+        # The base queue passes an extra argument (approval scope) to these
+        # hooks; forward everything to super and only observe the result.
+        def apply(action, ...)
           result = super
           @on_status&.call(action.with(status: :approved))
           result
         end
 
-        def reject_action(action)
+        def reject_action(action, ...)
           result = super
           @on_status&.call(action.with(status: :rejected))
           result
@@ -88,6 +90,14 @@ module Ask
         APPROVAL_AUTO = :auto
         APPROVAL_MODES = [APPROVAL_OFF, APPROVAL_REQUIRE, APPROVAL_AUTO].freeze
 
+        # Approval scopes this adapter accepts. :once approves only the
+        # named action; :session records a session grant (applied by
+        # Ask::Agent::Session before the approved action runs) so matching
+        # actions later in the session are auto-approved. :project is
+        # deliberately excluded: this adapter never injects project grants
+        # into the queue, so accepting it would be a silent no-op.
+        APPROVAL_SCOPES = %i[once session].freeze
+
         # How long a turn stays settled before it is considered complete
         # (protects against follow-up turns starting right after the queue
         # drains).
@@ -270,10 +280,15 @@ module Ask
         # Approve one queued tool action. Continues the turn (follow-up
         # turns run in this thread and stream to active subscribers).
         #
+        # @param scope [Symbol] :once (default) approves only this action;
+        #   :session records a session grant for matching later actions.
+        #   :project raises ArgumentError (no project grants injected).
+        # @raise [ArgumentError] for :project or unknown scopes
         # @return [Array<Ask::Permissions::Action>]
-        def approve_action(session_id, action_id)
+        def approve_action(session_id, action_id, scope: :once)
+          validate_approval_scope!(scope)
           queue = approval_queue(session_id)
-          queue ? queue.approve(action_id) : []
+          queue ? queue.approve(action_id, scope: scope) : []
         end
 
         def reject_action(session_id, action_id)
@@ -282,9 +297,13 @@ module Ask
         end
 
         # Approve all pending tool actions.
-        def approve_all(session_id)
+        #
+        # @param scope [Symbol] see {#approve_action}
+        # @raise [ArgumentError] for :project or unknown scopes
+        def approve_all(session_id, scope: :once)
+          validate_approval_scope!(scope)
           queue = approval_queue(session_id)
-          queue ? queue.approve_all : []
+          queue ? queue.approve_all(scope: scope) : []
         end
 
         def reject_all(session_id)
@@ -379,6 +398,21 @@ module Ask
           session_entry(session_id)[:session]&.approval_queue
         end
 
+        # Scope validation runs before the session/queue lookup so :project
+        # (and unknown scopes) raise even when no queue exists — never a
+        # silent no-op.
+        def validate_approval_scope!(scope)
+          return scope if APPROVAL_SCOPES.include?(scope)
+          if scope == :project
+            raise ArgumentError,
+                  "approval scope :project is not supported by the AskAgent adapter " \
+                  "(project grants are not injected here; use :once or :session)"
+          end
+          raise ArgumentError,
+                "approval scope must be one of #{APPROVAL_SCOPES.inspect} " \
+                "(this adapter does not support :project), got #{scope.inspect}"
+        end
+
         # ── Session construction ──
 
         def build_session(entry)

data/lib/ask/coding_providers/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module CodingProviders
-    VERSION = "0.3.5"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-coding-providers
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.4.0
 platform: ruby
 authors:
 - Kaka Ruto
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement