ask-coding-providers 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1e380717ee69fa2d0da0df5a2c706e2b6e8ef3509ea6f6baad0c96d170d62f3
-  data.tar.gz: 21d327fadd79f5fbbdce88c71e1009b2f45b03431bd7cf29e258f4bcb07b3b05
+  metadata.gz: 5af7db1f38c3b4d11a223269116e1b7c83da716a6e5c4ef0120f321a9f566241
+  data.tar.gz: af4be91462e45a4b5fc07119976d098b439daae44714cdcfe302902bd4db5f64
 SHA512:
-  metadata.gz: 975feb731eb168bd1a291c395e6421fd882ca9b0a23766602dde39352a187cb79c354df70d531e4516eb6050854e2086bbe3c629185e7751ea6d54c6554eca3a
-  data.tar.gz: 23cf6fe197707a8a0d456fbc8299f004cbb87134b17393a634305d227d1ada59b1bf476458ad482cc734317be8b87ae0972e240f6bc87a5d2a08ee1576707c57
+  metadata.gz: 06be52e4d472be0c6456842884cb3ccdeb07da10322683de138de6a638cb14e8ba198c5649f57eca1e17e142e752382234bdba8e971cacf664c96f49e821d3fb
+  data.tar.gz: 81beeba55e7d5b6cdd197d615f0f3926bf44ee36a87a781aba9197fe301e22ac7e7e72520fa6635f239fe266a9b13cdedc33450653ff47b8a1d3afcaa6d89215

data/lib/ask/coding_providers/acp/adapter.rb

@@ -64,7 +64,7 @@ module Ask
           @client&.running? || false
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_running
           params = { cwd: workspace_path || @cwd }
           session = @client.session_new(**params)

data/lib/ask/coding_providers/adapter.rb

@@ -14,7 +14,7 @@ module Ask
       # @param workspace_path [String] the working directory
       # @param mode [String, nil] permission mode
       # @return [String] the session ID
-      def create_session(workspace_path, mode: nil)
+      def create_session(workspace_path, mode: nil, system_prompt: nil, **)
         raise NotImplementedError, "#{self.class} must implement #create_session"
       end
 

data/lib/ask/coding_providers/ask_agent/adapter.rb

@@ -149,7 +149,13 @@ module Ask
         # @param model [String, nil] model override for this session
         # @param system_prompt [String, nil] system prompt override for this
         #   session (takes precedence over any system_prompt in session_opts)
-        def create_session(workspace_path, mode: nil, model: nil, system_prompt: nil)
+        # @param agent [String, nil] declarative agent name (ask-agent
+        #   convention: agents/<name>/agent.rb + instructions.md, discovered
+        #   from the workspace's working directory). When given, the session
+        #   is built via Ask::Agent.new so the definition's tools, skills,
+        #   and instructions apply; the harness-level options (model,
+        #   system_prompt, approval, plan mode, todos) still win.
+        def create_session(workspace_path, mode: nil, model: nil, system_prompt: nil, agent: nil)
           ensure_started
           sid = "sess_#{SecureRandom.uuid}"
           @mutex.synchronize do
@@ -158,6 +164,7 @@ module Ask
               mode: mode,
               model: model || @model_id,
               system_prompt: system_prompt,
+              agent: agent,
               created_at: Time.now,
               session: nil,
               subscribers: [],
@@ -367,36 +374,71 @@ module Ask
         # ── Session construction ──
 
         def build_session(entry)
-          prompt = entry[:system_prompt] || @session_opts[:system_prompt]
-          chat = build_chat(entry[:model], prompt)
+          session = entry[:agent] ? build_agent_session(entry) : build_plain_session(entry)
+          session.on_event { |event| translate_event(entry, session, event) }
+          session
+        end
 
-          queue = EmittingApprovalQueue.new(
-            on_submit: ->(a) { emit_approval(entry, a, :pending) },
-            on_status: ->(a) { emit_approval(entry, a, a.status) }
-          )
+        # Build a session from a declarative agent definition (ask-agent
+        # convention). The definition's tools, skills (agent_dir), and
+        # instructions apply; harness-level options win where set. Agents
+        # are discovered from the working directory (the harness runs the
+        # session inside its workspace).
+        #
+        # The emitting approval queue is passed through Ask::Agent.new's
+        # opts, so Session#build_approval wires it with the session's
+        # apply/reject/register callbacks — approval events stream exactly
+        # like the plain path.
+        def build_agent_session(entry)
+          queue = emitting_queue(entry)
+          opts = {
+            approval: approval_config(queue),
+            plan_mode: @plan_mode,
+            todos: @todos,
+            max_turns: @max_turns,
+            # Caller options win over the definition; a nil model lets the
+            # definition's own model apply.
+            model: (entry[:model] unless entry[:model] == @model_id)
+          }.compact
+          opts[:system_prompt] = entry[:system_prompt] if entry[:system_prompt]
+          Ask::Agent.new(entry[:agent], **opts)
+        end
 
-          approval_cfg =
-            case @approval
-            when APPROVAL_REQUIRE then { queue: queue, require_approval: @approval_required }
-            when APPROVAL_AUTO then { queue: queue }
-            when APPROVAL_OFF then nil
-            else
-              raise ArgumentError, "approval must be one of #{APPROVAL_MODES.inspect}, got #{@approval.inspect}"
-            end
+        # Build the default session (no declarative agent).
+        def build_plain_session(entry)
+          prompt = entry[:system_prompt] || @session_opts[:system_prompt]
+          chat = build_chat(entry[:model], prompt)
 
           Ask::Agent::Session.new(
             model: chat,
             tools: @tools,
             max_turns: @max_turns,
-            approval: approval_cfg,
+            approval: approval_config(emitting_queue(entry)),
             plan_mode: @plan_mode,
             todos: @todos,
             **@session_opts
-          ).tap do |session|
-            session.on_event { |event| translate_event(entry, session, event) }
+          )
+        end
+
+        def emitting_queue(entry)
+          EmittingApprovalQueue.new(
+            on_submit: ->(a) { emit_approval(entry, a, :pending) },
+            on_status: ->(a) { emit_approval(entry, a, a.status) }
+          )
+        end
+
+        def approval_config(queue)
+          case @approval
+          when APPROVAL_REQUIRE then { queue: queue, require_approval: @approval_required }
+          when APPROVAL_AUTO then { queue: queue }
+          when APPROVAL_OFF then nil
+          else
+            raise ArgumentError, "approval must be one of #{APPROVAL_MODES.inspect}, got #{@approval.inspect}"
           end
         end
 
+
+
         def build_chat(model_id, system_prompt = nil)
           chat = Ask::Agent::Chat.new(
             model: model_id,

data/lib/ask/coding_providers/claude/adapter.rb

@@ -38,7 +38,7 @@ module Ask
           @started
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_started
           sid = "sess_#{SecureRandom.uuid}"
           @sessions[sid] = { workspace: workspace_path, mode: mode, created_at: Time.now }

data/lib/ask/coding_providers/codex/adapter.rb

@@ -42,7 +42,7 @@ module Ask
           @client&.running? || false
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_running
           thread = @client.thread_start(cwd: workspace_path)
           tid = thread["id"] || thread[:id]

data/lib/ask/coding_providers/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module CodingProviders
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-coding-providers
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Kaka Ruto