asin 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d24c856333d2ff7d131765947bd4d4abe8f1451
-  data.tar.gz: 2aa29f96ed6ec63316f37bfc8af91b4da330a498
+  metadata.gz: 2bce335cc98a4e105831d955ac58ef571fa1f787
+  data.tar.gz: 6edddcd8a872b3cd0e808ad7d77ce5a36f3a400b
 SHA512:
-  metadata.gz: b0ba427f9ae87eecbba63fc1ce18c783e246b0796fb2b4e73e1d173636c059f5ce569f82b7635937d24f867ce2cf9fdb25a3e8007aec6f43f694ee1fd7f7aa9b
-  data.tar.gz: 2df98bbd2428438fdd2c5179bd700de5aff4d98d7e3a15ab8746db2b7e0266d3e8142fb0ba493890a74ab6703c4387c4139c133b4aec4c0ec56757eb720c823a
+  metadata.gz: 40923d103c60cd2ebe4349784c8a470513fc31eb3bc302891cdff7fe8fa67b36aaf57803ffc93523ef08e3e6e13934ed98dad2596c57afbefaa6e565f562e597
+  data.tar.gz: d248e664238f55980980222a03612a78c4cb3f44658a19f880213d4e2890a75208d0ff741045a90b6d8a76c8a7454d2d88ac42a3ed3287db5e501f7408d14fac

data/.travis.yml

@@ -1,7 +1,3 @@
 sudo: false
-script: "CODECLIMATE_REPO_TOKEN=eb04e2a7fa1767ae9055bcb6d74aee731b3ada7eff6dad170cedadca3d649fb7 bundle exec rake"
 rvm:
-  - 2.0.0
-  - 2.1.0
-  - 2.2.0
-  - 2.3.0
+  - 2.5.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.1.0
+
+* use the http.rb gem instead of HTTPI adapter
+
 ## 2.0.2
 
 * changes from Hashie::Rash to Hashie::SCHash, because Hashie added its own Rash class that conflicted with the Rash gem.

data/Gemfile.lock

@@ -1,56 +1,71 @@
 PATH
   remote: .
   specs:
-    asin (2.0.2)
+    asin (2.1.0)
       confiture (>= 0.1)
       crack (>= 0.3)
       hashie (>= 1.1)
-      httpi (>= 0.9)
+      http (>= 3.0)
       snake_case_hash (>= 1.0.2)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    addressable (2.3.2)
-    byebug (3.5.1)
-      columnize (~> 0.8)
-      debugger-linecache (~> 1.2)
-      slop (~> 3.6)
-    codeclimate-test-reporter (0.3.0)
-      simplecov (>= 0.7.1, < 1.0.0)
-    columnize (0.8.9)
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
+    byebug (10.0.2)
+    codeclimate-test-reporter (1.0.8)
+      simplecov (<= 0.13)
     confiture (0.1.4)
-    crack (0.3.1)
-    debugger-linecache (1.2.0)
-    diff-lcs (1.2.5)
-    docile (1.1.3)
-    hashie (3.4.3)
-    httpclient (2.3.0.1)
-    httpi (2.4.1)
-      rack
-    multi_json (1.10.0)
-    rack (1.6.4)
-    rake (0.9.2.2)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.8)
-    rspec-expectations (2.14.5)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
+    diff-lcs (1.3)
+    docile (1.1.5)
+    domain_name (0.5.20180417)
+      unf (>= 0.0.5, < 1.0.0)
+    hashdiff (0.3.7)
+    hashie (3.5.7)
+    http (3.3.0)
+      addressable (~> 2.3)
+      http-cookie (~> 1.0)
+      http-form_data (~> 2.0)
+      http_parser.rb (~> 0.6.0)
+    http-cookie (1.0.3)
+      domain_name (~> 0.5)
+    http-form_data (2.1.1)
+    http_parser.rb (0.6.0)
+    http_parser.rb (0.6.0-java)
+    json (2.1.0)
+    json (2.1.0-java)
+    public_suffix (3.0.2)
+    rake (0.9.6)
+    rspec (2.99.0)
+      rspec-core (~> 2.99.0)
+      rspec-expectations (~> 2.99.0)
+      rspec-mocks (~> 2.99.0)
+    rspec-collection_matchers (1.1.3)
+      rspec-expectations (>= 2.99.0.beta1)
+    rspec-core (2.99.2)
+    rspec-expectations (2.99.2)
       diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.6)
-    simplecov (0.8.2)
+    rspec-mocks (2.99.4)
+    safe_yaml (1.0.4)
+    simplecov (0.13.0)
       docile (~> 1.1.0)
-      multi_json
-      simplecov-html (~> 0.8.0)
-    simplecov-html (0.8.0)
-    slop (3.6.0)
-    snake_case_hash (1.0.2)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.2)
+    snake_case_hash (1.0.4)
       hashie (~> 3.0)
-    vcr (2.2.5)
-    webmock (1.8.11)
-      addressable (>= 2.2.7)
-      crack (>= 0.1.7)
+    unf (0.1.4)
+      unf_ext
+    unf (0.1.4-java)
+    unf_ext (0.0.7.5)
+    vcr (4.0.0)
+    webmock (3.4.2)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
 
 PLATFORMS
   java
@@ -60,11 +75,11 @@ DEPENDENCIES
   asin!
   byebug
   codeclimate-test-reporter
-  httpclient (>= 2.2.3)
-  rake (~> 0.9.2)
+  rake (~> 0.9)
   rspec (~> 2.11)
-  vcr (~> 2.2)
-  webmock (~> 1.8)
+  rspec-collection_matchers (~> 1.1)
+  vcr (~> 4.0)
+  webmock (~> 3.4)
 
 BUNDLED WITH
-   1.11.2
+   1.16.1

data/README.md

@@ -1,8 +1,6 @@
 ## Infos
 
 [![Build Status](https://img.shields.io/travis/phoet/asin/master.svg)](https://travis-ci.org/phoet/asin)
-[![Code Climate](https://img.shields.io/codeclimate/github/phoet/asin.svg)](https://codeclimate.com/github/phoet/asin)
-[![Coverage Status](http://img.shields.io/codeclimate/coverage/github/phoet/asin.svg)](https://codeclimate.com/github/phoet/asin)
 
 
 ASIN is a simple, extensible wrapper for parts of the REST-API of Amazon Product Advertising API (aka Associates Web Service aka Amazon E-Commerce Service).
@@ -32,14 +30,12 @@ It's also a good starting point for looking into writing your own asin-adapter.
 
 ```bash
 gem install asin
-gem install curb # optional, see HTTPI
 ```
 
 or in your Gemfile:
 
 ```ruby
 gem 'asin'
-gem 'curb' # optional, see HTTPI
 ```
 
 ## Configuration
@@ -86,20 +82,22 @@ items = client.lookup '1430218150'
 
 # have a look at the title of the item
 items.first.item_attributes.title
-=> Learn Objective-C on the Mac (Learn Series)
+# => Learn Objective-C on the Mac (Learn Series)
 
 # search for any kind of stuff on amazon with keywords
-items = search_keywords 'Learn', 'Objective-C'
+items = client.search_keywords 'Learn', 'Objective-C'
 items.first.item_attributes.title
-=> "Learn Objective-C on the Mac (Learn Series)"
+# => "Learn Objective-C on the Mac (Learn Series)"
 
 # search for any kind of stuff on amazon with custom parameters
-search :Keywords => 'Learn Objective-C', :SearchIndex => :Books
+items = client.search :Keywords => 'Learn Objective-C', :SearchIndex => :Books
 items.first.item_attributes.title
-=> "Learn Objective-C on the Mac (Learn Series)"
+# => "Learn Objective-C on the Mac (Learn Series)"
 
 # search for similar items like the one you already have
 items = client.similar '1430218150'
+items.first.item_attributes.title
+# => "Beginning iOS 7 Development: Exploring the iOS SDK"
 ```
 
 There is an additional set of methods to support AWS cart operations:
@@ -110,17 +108,17 @@ client = ASIN::Client.instance
 # create a cart with an item
 cart = client.create_cart({:asin => '1430218150', :quantity => 1})
 cart.cart_items.cart_item
-=> [<#Hashie::Rash ASIN="1430218150" CartItemId="U3G241HVLLB8N6" ... >]
+# => [<#Hashie::Rash ASIN="1430218150" CartItemId="U3G241HVLLB8N6" ... >]
 
 # clear everything from the cart
 cart = client.clear_cart(cart)
 cart.cart_items.cart_item
-=> []
+# => []
 
 # update items in the cart
-cart = client.update_items(cart, {:cart_item_id => cart.items.first.CartItemId, :action => :SaveForLater}, {:cart_item_id => cart.items.first.CartItemId, :quantity => 7})
+cart = client.update_items(cart, {:cart_item_id => cart.items.first.CartItemId, :action => :SaveForLater}, {:cart_item_id # => cart.items.first.CartItemId, :quantity => 7})
 cart.saved_for_later_items.saved_for_later_item
-=> [<#Hashie::Rash ASIN="1430218150" CartItemId="U3G241HVLLB8N6" ... >]
+# => [<#Hashie::Rash ASIN="1430218150" CartItemId="U3G241HVLLB8N6" ... >]
 ```
 
 It's also possible to access browse nodes:
@@ -131,19 +129,9 @@ client = ASIN::Client.instance
 # create a cart with an item
 node = client.browse_node('17', :ResponseGroup => :TopSellers)
 node.first.browse_node_id
-=> '163357'
+# => '163357'
 node.first.name
-=> 'Literature & Fiction'
-```
-
-## HTTPI
-
-ASIN uses [HTTPI](https://github.com/rubiii/httpi) as a HTTP-Client adapter.
-See the HTTPI documentation for how to configure different clients or the logger.
-As a default HTTPI uses _httpclient_ so you should add that dependency to your project:
-
-```ruby
-gem 'httpclient'
+# => 'Literature & Fiction'
 ```
 
 ## Confiture

data/asin.gemspec

@@ -17,18 +17,15 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency('crack',     '>= 0.3')
-  s.add_dependency('hashie',    '>= 1.1')
-  s.add_dependency('snake_case_hash',      '>= 1.0.2')
-  s.add_dependency('httpi',     '>= 0.9')
-  s.add_dependency('confiture', '>= 0.1')
+  s.add_dependency('crack',           '>= 0.3')
+  s.add_dependency('hashie',          '>= 1.1')
+  s.add_dependency('snake_case_hash', '>= 1.0.2')
+  s.add_dependency('http',            '>= 3.0')
+  s.add_dependency('confiture',       '>= 0.1')
 
-  s.add_runtime_dependency('jruby-openssl') if RUBY_PLATFORM == 'java'
-
-  s.add_development_dependency('httpclient', '>= 2.2.3')
-
-  s.add_development_dependency('rake',       '~> 0.9.2')
-  s.add_development_dependency('vcr',        '~> 2.2')
-  s.add_development_dependency('webmock',    '~> 1.8')
-  s.add_development_dependency('rspec',      '~> 2.11')
+  s.add_development_dependency('rake',                      '~> 0.9')
+  s.add_development_dependency('vcr',                       '~> 4.0')
+  s.add_development_dependency('webmock',                   '~> 3.4')
+  s.add_development_dependency('rspec',                     '~> 2.11')
+  s.add_development_dependency('rspec-collection_matchers', '~> 1.1')
 end

data/lib/asin/adapter.rb

@@ -138,7 +138,7 @@ module ASIN
             end
 
             def language
-              item_attributes!.languages.language.first.name
+              item_attributes!.languages.language.first['Name']
             end
 
             def formatted_price

data/lib/asin/client.rb

@@ -1,4 +1,4 @@
-require 'httpi'
+require 'http'
 require 'rexml/document' # https://github.com/phoet/asin/pull/23
 require 'crack/xml'
 require 'cgi'
@@ -252,7 +252,7 @@ module ASIN
       url = "http://#{Configuration.host}#{PATH}?#{signed}"
       log(:info, "performing rest call to url='#{url}'")
 
-      response = HTTPI.get(url)
+      response = HTTP.get(url)
       if response.code == 200
         # force utf-8 chars, works only on 1.9 string
         resp = response.body

data/lib/asin/version.rb

@@ -1,3 +1,3 @@
 module ASIN
-  VERSION = "2.0.2"
+  VERSION = "2.1.0"
 end

data/spec/lib/cart_spec.rb

@@ -11,8 +11,8 @@ module ASIN
 
       it "should create a cart", :vcr do
         cart = @helper.create_cart({:asin => ANY_ASIN, :quantity => 1}, {:asin => ANY_OTHER_ASIN, :quantity => 2})
-        expect(cart.valid?).to be_true
-        expect(cart.empty?).to be_false
+        expect(cart.valid?).to be_truthy
+        expect(cart.empty?).to be_falsey
       end
 
       it "should handle item paramters" do
@@ -25,22 +25,22 @@ module ASIN
         it "should clear a cart", :vcr do
           @cart = @helper.create_cart({:asin => ANY_ASIN, :quantity => 1})
           cart = @helper.clear_cart(@cart)
-          expect(cart.valid?).to be_true
-          expect(cart.empty?).to be_true
+          expect(cart.valid?).to be_truthy
+          expect(cart.empty?).to be_truthy
         end
 
         it "should get a cart", :vcr do
           @cart = @helper.create_cart({:asin => ANY_ASIN, :quantity => 1})
           cart = @helper.get_cart(@cart.cart_id, @cart.hmac)
-          expect(cart.valid?).to be_true
-          expect(cart.empty?).to be_false
+          expect(cart.valid?).to be_truthy
+          expect(cart.empty?).to be_falsey
         end
 
         it "should add items to a cart", :vcr do
           @cart = @helper.create_cart({:asin => ANY_ASIN, :quantity => 1})
           cart = @helper.add_items(@cart, {:asin => ANY_OTHER_ASIN, :quantity => 2})
-          expect(cart.valid?).to be_true
-          expect(cart.empty?).to be_false
+          expect(cart.valid?).to be_truthy
+          expect(cart.empty?).to be_falsey
           expect(cart).to have(2).items
         end
 
@@ -49,7 +49,7 @@ module ASIN
           item_id = @cart.items.first.cart_item_id
           cart = @helper.update_items(@cart, {:cart_item_id => item_id, :action => 'SaveForLater'}, {:cart_item_id => item_id, :quantity => 7})
           expect(cart).to have(1).saved_items
-          expect(cart.valid?).to be_true
+          expect(cart.valid?).to be_truthy
         end
 
       end

data/spec/spec_helper.rb

@@ -12,13 +12,11 @@ unless Net.const_defined? :HTTPSession
 end
 
 require 'rspec'
+require 'rspec/collection_matchers'
 require 'asin'
-require 'asin/client' # is somehow needed for jruby
 require 'asin/adapter'
-require 'httpclient'
 require 'vcr'
-require 'httpi'
-
+require 'byebug'
 
 VCR.configure do |config|
   config.cassette_library_dir = 'spec/cassettes'
@@ -43,8 +41,6 @@ RSpec.configure do |config|
   end
 
   config.before :each do
-    HTTPI.log = false
-
     ASIN::Configuration.reset!
     @helper = ASIN::Client.instance
     @helper.configure :logger => nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asin
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Peter Schröder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-25 00:00:00.000000000 Z
+date: 2018-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack
@@ -53,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.0.2
 - !ruby/object:Gem::Dependency
-  name: httpi
+  name: http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: confiture
   requirement: !ruby/object:Gem::Requirement
@@ -81,75 +81,75 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: httpclient
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '3.4'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '2.11'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rspec-collection_matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '1.1'
 description: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search,
   BrowseNode and Cart Operations.
 email:
@@ -220,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: asin
-rubygems_version: 2.5.1
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search,