as_csv 1.0.0 → 1.0.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    as_csv (0.0.1.pre)
+    as_csv (1.0.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,9 +1,15 @@
 # AsCSV
 
+[![Build Status](https://travis-ci.org/danielfone/as_csv.png)](https://travis-ci.org/danielfone/as_csv)
+[![Dependency Status](https://gemnasium.com/danielfone/as_csv.png)](https://gemnasium.com/danielfone/as_csv)
+[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/danielfone/as_csv)
+
 This gem allows you to expose CSV in your apps as you'd expose JSON or XML.
 
 Rails is not strictly required, but currently the magic only works with rails 3.x.
 
+Ruby 1.8 will work, but by default the order of the columns will not be guaranteed.
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -161,6 +167,3 @@ bar2,bar2-description,,xyz98765
 6. Commit your changes (`git commit -am 'Add some feature'`)
 7. Push to the branch (`git push origin my-new-feature`)
 8. Create new Pull Request
-
-[![Build Status](https://travis-ci.org/danielfone/as_csv.png)](https://travis-ci.org/danielfone/as_csv)
-[![Dependency Status](https://gemnasium.com/danielfone/as_csv.png)](https://gemnasium.com/danielfone/as_csv)

data/as_csv.gemspec

@@ -20,4 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rails", "~> 3.2"
   gem.add_development_dependency "rspec-rails", "~> 2.12"
   gem.add_development_dependency "sqlite3"
+  gem.add_development_dependency "fastercsv" if RUBY_VERSION < '1.9'
 end

data/lib/as_csv/csv_builder.rb

@@ -8,7 +8,7 @@ module AsCSV
     end
 
     def to_csv
-      rows.collect { |row| CSV.generate_line row }.join if valid?
+      rows.collect { |row| CSVProxy.generate_line row }.join if valid?
     end
 
     def rows

data/lib/as_csv/csv_proxy.rb

@@ -0,0 +1,13 @@
+if RUBY_VERSION >= '1.9'
+  require 'csv'
+  AsCSV::CSVProxy = CSV
+else
+  begin
+    gem 'fastercsv'
+    require 'fastercsv'
+
+    AsCSV::CSVProxy = FasterCSV
+  rescue LoadError => e
+    raise "Error : FasterCSV not installed, please `gem install fastercsv` for faster processing on Ruby 1.8"
+  end
+end

data/lib/as_csv/version.rb

@@ -1,3 +1,3 @@
 module AsCSV
-  VERSION = "1.0.0"
+  VERSION = "1.0.2"
 end

data/lib/as_csv.rb

@@ -1,6 +1,9 @@
-require "csv"
 require "as_csv/version"
+require "as_csv/csv_proxy"
 require "as_csv/csv_builder"
 require "as_csv/core_ext/array"
 require "as_csv/active_model"
 require "as_csv/action_renderer"
+
+module AsCSV
+end

data/spec/core_ext/array_spec.rb

@@ -6,7 +6,7 @@ describe Array do
   it { should respond_to(:to_csv_without_builder) }
 
   context 'with objects responding to `as_csv`' do
-    before { subject << stub(:foo, as_csv: {header: 'value'})}
+    before { subject << stub(:foo, :as_csv => {:header => 'value'})}
 
     specify do
       AsCSV::CSVBuilder.any_instance.should_receive(:to_csv).and_call_original

data/spec/dummy/app/controllers/render_widgets_controller.rb

@@ -2,13 +2,13 @@ class RenderWidgetsController < ApplicationController
 
   def index
     respond_to do |format|
-      format.csv { render csv: WidgetWithOptions.scoped, style: :full }
+      format.csv { render :csv => WidgetWithOptions.scoped, :style => :full }
     end
   end
 
   def show
     respond_to do |format|
-      format.csv { render csv: Widget.find(params[:id]) }
+      format.csv { render :csv => Widget.find(params[:id]) }
     end
   end
 

data/spec/dummy/app/controllers/respond_with_widgets_controller.rb

@@ -2,7 +2,7 @@ class RespondWithWidgetsController < ApplicationController
   respond_to :csv
 
   def index
-    respond_with WidgetWithOptions.scoped, style: :full
+    respond_with WidgetWithOptions.scoped, :style => :full
   end
 
   def show

data/spec/dummy/app/models/widget_with_options.rb

@@ -3,7 +3,7 @@ class WidgetWithOptions < Widget
   def as_csv(options={})
     style = options[:style] || raise("options[:style] not set")
     case style
-    when :full then attributes.slice('name', 'code').merge({full: true})
+    when :full then attributes.slice('name', 'code').merge({:full => true})
     when :short then attributes.slice('name', 'code')
     else raise "options[:style] must be :full or :short"
     end

data/spec/dummy/config/initializers/session_store.rb

@@ -1,6 +1,6 @@
 # Be sure to restart your server when you modify this file.
 
-Dummy::Application.config.session_store :cookie_store, key: '_dummy_session'
+Dummy::Application.config.session_store :cookie_store, :key => '_dummy_session'
 
 # Use the database for sessions instead of the cookie-based default,
 # which shouldn't be used to store highly confidential information

data/spec/dummy/config/initializers/wrap_parameters.rb

@@ -5,7 +5,7 @@
 
 # Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
 ActiveSupport.on_load(:action_controller) do
-  wrap_parameters format: [:json]
+  wrap_parameters :format => [:json]
 end
 
 # Disable root element in JSON by default.

data/spec/dummy/db/seeds.rb

@@ -3,5 +3,5 @@
 #
 # Examples:
 #
-#   cities = City.create([{ name: 'Chicago' }, { name: 'Copenhagen' }])
-#   Mayor.create(name: 'Emanuel', city: cities.first)
+#   cities = City.create([{ :name => 'Chicago' }, { :name => 'Copenhagen' }])
+#   Mayor.create(:name => 'Emanuel', :city => cities.first)

data/spec/lib/csv_builder_spec.rb

@@ -9,7 +9,7 @@ describe AsCSV::CSVBuilder do
 
   describe '#rows' do
     subject(:rows) { csv_builder.rows }
-    before { csv_builder.stub headers: headers, data_rows: data_rows, "valid?" => true }
+    before { csv_builder.stub :headers => headers, :data_rows => data_rows, "valid?" => true }
     let(:headers)   { %w(h1 h2) }
     let(:data_rows) { [%w(v11 v12), %w(v21 v22)] }
 
@@ -19,10 +19,10 @@ describe AsCSV::CSVBuilder do
   
   context 'with single record' do
     let(:records) do
-      stub(:foo, as_csv: {
-        first:  '1',
-        second: '2',
-        third:  '3'
+      stub(:foo, :as_csv => {
+        :first  => '1',
+        :second => '2',
+        :third  => '3'
       })
     end
 
@@ -40,10 +40,10 @@ first,second,third
     let(:records) { [record1, record2] }
     2.times do |i|
       let("record#{i+1}") do
-        stub(:foo, as_csv: {
-          first:  "1#{i}",
-          second: "2#{i}",
-          third:  "3#{i}"
+        stub(:foo, :as_csv => {
+          :first  => "1#{i}",
+          :second => "2#{i}",
+          :third  => "3#{i}"
         })
       end
     end
@@ -63,7 +63,7 @@ first,second,third
     let(:records) { [record1, record2] }
     2.times do |i|
       let("record#{i+1}") do
-        stub(:foo, as_csv: {
+        stub(:foo, :as_csv => {
           "first#{i}"  => "1#{i}",
           "second#{i}" => "2#{i}",
           "third#{i}"  => "3#{i}"
@@ -101,7 +101,7 @@ first0,second0,third0,first1,second1,third1
   end
 
   context 'with record `as_csv` != Hash' do
-    let(:records) { stub(:foo, as_csv: 'test') }
+    let(:records) { stub(:foo, :as_csv => 'test') }
 
     message = "expected as_csv to return Hash"
     ([:valid?] + EXPOSED_METHODS).each do |method|

data/spec/models/widget_spec.rb

@@ -5,7 +5,7 @@ describe Widget do
   it { should respond_to :as_csv }
 
   describe 'dummy' do
-    subject(:dummy_widget) { Widget.create! name: "widget-name", description: 'widget-description', code: 1234 }
+    subject(:dummy_widget) { Widget.create! :name => "widget-name", :description => 'widget-description', :code => 1234 }
 
     describe :to_csv do
       subject { dummy_widget.to_csv }
@@ -21,10 +21,10 @@ describe Widget do
   describe 'collection' do
     before do
       Widget.create! [
-        { name: "widget-1", description: 'widget-description-1', code: 1001 },
-        { name: "widget-2", description: 'widget-description-2', code: 1002 },
-        { name: "widget-3", description: 'widget-description-3', code: 1003 },
-        { name: "widget-4", description: 'widget-description-4', code: 1004 },
+        { :name => "widget-1", :description => 'widget-description-1', :code => 1001 },
+        { :name => "widget-2", :description => 'widget-description-2', :code => 1002 },
+        { :name => "widget-3", :description => 'widget-description-3', :code => 1003 },
+        { :name => "widget-4", :description => 'widget-description-4', :code => 1004 },
       ]
     end
 

data/spec/models/widget_with_options_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
 describe WidgetWithOptions do
-  subject(:widget) { described_class.new name: 'widget-name', code: 1234 }
+  subject(:widget) { described_class.new :name => 'widget-name', :code => 1234 }
 
   describe :to_csv do
     subject { widget.to_csv(options) }
 
     context 'with style = :full' do
-      let(:options) { {style: :full} }
+      let(:options) { {:style => :full} }
       it do
         should == <<-CSV.strip_heredoc
           name,code,full
@@ -17,7 +17,7 @@ describe WidgetWithOptions do
     end
 
     context 'with style = :short' do
-      let(:options) { {style: :short} }
+      let(:options) { {:style => :short} }
       it do
         should == <<-CSV.strip_heredoc
           name,code

data/spec/spec_helper.rb

@@ -23,5 +23,7 @@ RSpec.configure do |config|
 
   config.treat_symbols_as_metadata_keys_with_true_values = true
 
+  config.order = "random"
+
   config.extend WidgetsControllerMixin, :widgets_controllers
 end

data/spec/support/widgets_controller_mixin.rb

@@ -2,15 +2,15 @@ module WidgetsControllerMixin
   def exercise_controller
     before do
       Widget.create! [
-        { name: "widget-1", description: 'widget-description-1', code: 1001 },
-        { name: "widget-2", description: 'widget-description-2', code: 1002 },
-        { name: "widget-3", description: 'widget-description-3', code: 1003 },
-        { name: "widget-4", description: 'widget-description-4', code: 1004 },
+        { :name => "widget-1", :description => 'widget-description-1', :code => 1001 },
+        { :name => "widget-2", :description => 'widget-description-2', :code => 1002 },
+        { :name => "widget-3", :description => 'widget-description-3', :code => 1003 },
+        { :name => "widget-4", :description => 'widget-description-4', :code => 1004 },
       ]
     end
 
     context 'GET show/1.csv' do
-      before { get :show, id: 1, format: :csv }
+      before { get :show, :id => 1, :format => :csv }
       describe 'response' do
         subject { response }
         its(:code) { should == "200" }
@@ -25,7 +25,7 @@ module WidgetsControllerMixin
     end
 
     context 'GET index.csv' do
-      before { get :index, format: :csv }
+      before { get :index, :format => :csv }
       describe 'response' do
         subject { response }
         its(:code) { should == "200" }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: as_csv
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -79,6 +79,7 @@ files:
 - lib/as_csv/active_model.rb
 - lib/as_csv/core_ext/array.rb
 - lib/as_csv/csv_builder.rb
+- lib/as_csv/csv_proxy.rb
 - lib/as_csv/version.rb
 - spec/controllers/render_widgets_controller_spec.rb
 - spec/controllers/respond_with_widgets_controller_spec.rb