aruba 0.14.7 → 0.14.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dba945a4e37f106b69d2ced3247e109f6e92999514eb3da5717a8ef2f6010a18
-  data.tar.gz: ab054313ce5795a0ef82e4e06c9454f1f29964f1f541ffca91180daefe1f58a7
+  metadata.gz: 7e721e1228e9ab5f000571f0acf6c25a98e90d449d18e48240f1194963fb7314
+  data.tar.gz: 84ded1fc93c5c0b2c208f15703fbc76084fca287868eb91d06a473fc964b35d3
 SHA512:
-  metadata.gz: 5dce373736b4192591e676fe9a922f414dc28f3d29fada4279d77c07fbc02353ff37ecd5319dd382eb592420cf8f373c058f1bb303356c499c6b6d255863ef04
-  data.tar.gz: b6f3e91ecda08d84ceef455687c644897fbb954f1dfc6385cb49e47dea66ed823d1c2a2c41744307333b73c370a84944d5f5ef77f3b2e4429983e6d2893798d1
+  metadata.gz: 0da00e29ba8466a005392a5621f122225f3cc43539276b96de1cda4c7b414c73375f27473b415862de22fd12b13b49573f4c6e73c3d15be924867175717b5854
+  data.tar.gz: d611e3e1d0594b0bc982ccbbc09c7685112197fb28324002114b2ffd0b24d636b47c2b91e0d5999dd60d41256e447c982db4b6e53ebc47adf58edfe64e87c1dc

data/.rubocop.yml

@@ -77,6 +77,9 @@ Style/CollectionMethods:
 Style/Documentation:
   Enabled: false
 
+Style/DotPosition:
+  EnforcedStyle: trailing
+
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false

data/Gemfile

@@ -58,6 +58,14 @@ group :development, :test do
 
     # Reporting
     gem 'bcat', '~> 0.6.2'
+  end
+
+  # YARD documentation
+  if RUBY_VERSION >= '2.3.0'
+    gem 'yard', '~> 0.9.11'
+    gem 'kramdown', '~> 2.1'
+  elsif RUBY_VERSION >= '2.0.0'
+    gem 'yard', '~> 0.9.11'
     gem 'kramdown', '~> 1.7.0'
   end
 

data/History.md

@@ -2,6 +2,15 @@
 
 # RELEASED
 
+## [v0.14.8](https://github.com/cucumber/aruba/compare/v0.14.7...v0.14.8)
+
+* Deprecate `#run` and `#run_simple` in favor of `#run_command` and
+  `#run_command_and_stop` (#585)
+* Update dependencies, most notably loosening the dependency on `childprocess`
+  (#591)
+* Properly warn about deprecated use of the run methods with one positional
+  option (#588)
+
 ## [v0.14.7](https://github.com/cucumber/aruba/compare/v0.14.6...v0.14.7)
 
 * Fix Cucumber steps to use `have_same_file_content_as` matcher (#572)

data/README.md

@@ -1,5 +1,4 @@
 [![Gem Version](https://badge.fury.io/rb/aruba.svg)](http://badge.fury.io/rb/aruba)
-[![Dependency Status](https://gemnasium.com/cucumber/aruba.svg)](https://gemnasium.com/cucumber/aruba)
 [![Code Climate](https://codeclimate.com/github/cucumber/aruba.svg)](https://codeclimate.com/github/cucumber/aruba)
 [![Join the chat at https://gitter.im/cucumber/aruba](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/cucumber/aruba?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 

data/Rakefile

@@ -36,9 +36,10 @@ namespace :travis do
 end
 
 task :rubocop do
-  begin
-    sh 'rubocop --fail-level E'
-  rescue
+  if RUBY_VERSION >= '2'
+    sh 'bundle exec rubocop --fail-level E'
+  else
+    warn 'Your ruby version is not supported for code linting'
   end
 end
 

data/aruba.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.homepage    = 'http://github.com/cucumber/aruba'
 
   s.add_runtime_dependency 'cucumber', '>= 1.3.19'
-  s.add_runtime_dependency 'childprocess', ['>= 0.6.3', '< 0.10.0']
+  s.add_runtime_dependency 'childprocess', ['>= 0.6.3', '< 1.1.0']
   s.add_runtime_dependency 'ffi', '~> 1.9'
   s.add_runtime_dependency 'rspec-expectations', '>= 2.99'
   s.add_runtime_dependency 'contracts', '~> 0.9'

data/features/api/command/find_command.feature

@@ -11,7 +11,7 @@ Feature: Find a started command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
+      before(:each) { run_command('echo hello') }
       let(:command) { find_command('echo hello') }
 
       before(:each) { stop_all_commands }
@@ -44,8 +44,8 @@ Feature: Find a started command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello1') }
-      before(:each) { run('echo hello2') }
+      before(:each) { run_command('echo hello1') }
+      before(:each) { run_command('echo hello2') }
       let(:command) { find_command('echo hello1') }
 
       before(:each) { stop_all_commands }
@@ -67,9 +67,9 @@ Feature: Find a started command
 
     RSpec.describe 'Run command', :type => :aruba do
       before(:each) { set_environment_variable 'ENV_VAR', '1' }
-      before(:each) { run('bash -c "echo -n $ENV_VAR"') }
+      before(:each) { run_command('bash -c "echo -n $ENV_VAR"') }
       before(:each) { set_environment_variable 'ENV_VAR', '2' }
-      before(:each) { run('bash -c "echo -n $ENV_VAR"') }
+      before(:each) { run_command('bash -c "echo -n $ENV_VAR"') }
 
       let(:command) { find_command('bash -c "echo -n $ENV_VAR"') }
 

data/features/api/command/last_command_started.feature

@@ -9,7 +9,7 @@ Feature: Return last command started
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
+      before(:each) { run_command('echo hello') }
       before(:each) { stop_all_commands }
 
       it { expect(last_command_started).to be_successfully_executed }
@@ -25,8 +25,8 @@ Feature: Return last command started
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
-      before(:each) { run('echo world') }
+      before(:each) { run_command('echo hello') }
+      before(:each) { run_command('echo world') }
 
       before(:each) { stop_all_commands }
 

data/features/api/command/last_command_stopped.feature

@@ -9,7 +9,7 @@ Feature: Return last command stopped
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
+      before(:each) { run_command('echo hello') }
       before(:each) { stop_all_commands }
 
       it { expect(last_command_stopped).to be_successfully_executed }
@@ -25,8 +25,8 @@ Feature: Return last command stopped
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
-      before(:each) { run('echo world') }
+      before(:each) { run_command('echo hello') }
+      before(:each) { run_command('echo world') }
 
       before(:each) { stop_all_commands }
 
@@ -43,9 +43,9 @@ Feature: Return last command stopped
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('echo hello') }
+      before(:each) { run_command('echo hello') }
       before(:each) { find_command('echo hello').stop }
-      before(:each) { run('echo world') }
+      before(:each) { run_command('echo world') }
 
       it { expect(last_command_stopped).to be_successfully_executed }
       it { expect(last_command_stopped.commandline).to eq 'echo hello' }
@@ -80,7 +80,7 @@ Feature: Return last command stopped
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
 
       it { expect{ last_command_stopped.commandline }.to raise_error Aruba::NoCommandHasBeenStoppedError }
     end

data/features/api/command/run.feature

@@ -1,15 +1,15 @@
 Feature: Run command
 
-  To run a command use the `#run`-method. There are some configuration options
+  To run a command use the `#run_command`-method. There are some configuration options
   which are relevant here:
 
   - `startup_wait_time`:
 
     Given this option `aruba` waits n seconds after it started the command.
-    This is most useful when using `#run()` and not really makes sense for
-    `#run_simple()`.
+    This is most useful when using `#run_command()` and not really makes sense for
+    `#run_command_and_stop()`.
 
-    You can use `#run()` + `startup_wait_time` to start background jobs.
+    You can use `#run_command()` + `startup_wait_time` to start background jobs.
 
   - `exit_timeout`:
 
@@ -34,7 +34,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       it { expect(last_command_started).to be_successfully_executed }
     end
     """
@@ -52,7 +52,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('bin/cli') }
+      before(:each) { run_command('bin/cli') }
       it { expect(last_command_started).to be_successfully_executed }
     end
     """
@@ -66,7 +66,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Find path for command', :type => :aruba do
-      it { expect { run('cli') }.to raise_error Aruba::LaunchError, /Command "cli" not found in PATH-variable/ }
+      it { expect { run_command('cli') }.to raise_error Aruba::LaunchError, /Command "cli" not found in PATH-variable/ }
     end
     """
     When I run `rspec`
@@ -112,7 +112,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 2 do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       before(:each) { last_command_started.send_signal 'HUP' }
 
       it { expect(last_command_started).to be_successfully_executed }
@@ -145,7 +145,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 3 do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
 
       it { expect(last_command_started).to be_successfully_executed }
       it { expect(last_command_started).to have_output /Hello, Aruba here/ }
@@ -157,7 +157,7 @@ Feature: Run command
   Scenario: Mixing commands with long and short startup phase (deprecated)
 
     If you commands with a long and short startup phases, you should consider
-    using the `startup_wait_time`-option local to the `#run`-call.
+    using the `startup_wait_time`-option local to the `#run_command`-call.
 
     Given an executable named "bin/cli1" with:
     """bash
@@ -220,8 +220,8 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1 do
-      before(:each) { run('cli1', 3, 0.1, 'TERM', 2) }
-      before(:each) { run('cli2', 3, 0.1, 'TERM', 1) }
+      before(:each) { run_command('cli1', 3, 0.1, 'TERM', 2) }
+      before(:each) { run_command('cli2', 3, 0.1, 'TERM', 1) }
       before(:each) { last_command_started.send_signal 'HUP' }
 
       it { expect(last_command_started).to be_successfully_executed }
@@ -236,7 +236,7 @@ Feature: Run command
   Scenario: Mixing commands with long and short startup phase
 
     If you commands with a long and short startup phases, you should consider
-    using the `startup_wait_time`-option local to the `#run`-call.
+    using the `startup_wait_time`-option local to the `#run_command`-call.
 
     Given an executable named "bin/cli1" with:
     """bash
@@ -299,8 +299,8 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1 do
-      before(:each) { run('cli1', :startup_wait_time => 2) }
-      before(:each) { run('cli2', :startup_wait_time => 1) }
+      before(:each) { run_command('cli1', :startup_wait_time => 2) }
+      before(:each) { run_command('cli2', :startup_wait_time => 1) }
       before(:each) { last_command_started.send_signal 'HUP' }
 
       it { expect(last_command_started).to be_successfully_executed }
@@ -315,7 +315,7 @@ Feature: Run command
   Scenario: Mixing long and short running commands (deprecated)
 
     If need to mix "long running" and "short running" commands, you should consider using the
-    `exit_timeout`-option local to the `#run`-method.
+    `exit_timeout`-option local to the `#run_command`-method.
 
     Given an executable named "bin/cli1" with:
     """bash
@@ -343,8 +343,8 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli1', 3) }
-      before(:each) { run('cli2', 1) }
+      before(:each) { run_command('cli1', 3) }
+      before(:each) { run_command('cli2', 1) }
 
       it { expect(last_command_started).to be_successfully_executed }
       it { expect(last_command_started).to have_output /Hello, Aruba here/ }
@@ -356,7 +356,7 @@ Feature: Run command
   Scenario: Mixing long and short running commands
 
     If need to mix "long running" and "short running" commands, you should consider using the
-    `exit_timeout`-option local to the `#run`-method.
+    `exit_timeout`-option local to the `#run_command`-method.
 
     Given an executable named "bin/cli1" with:
     """bash
@@ -384,8 +384,8 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli1', :exit_timeout => 3) }
-      before(:each) { run('cli2', :exit_timeout => 1) }
+      before(:each) { run_command('cli1', :exit_timeout => 3) }
+      before(:each) { run_command('cli2', :exit_timeout => 1) }
 
       it { expect(last_command_started).to be_successfully_executed }
       it { expect(last_command_started).to have_output /Hello, Aruba here/ }
@@ -405,7 +405,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       let!(:found_command) { find_command('cli') }
       it { expect { found_command.start }.to raise_error Aruba::CommandAlreadyStartedError }
     end

data/features/api/command/run_simple.feature

@@ -1,6 +1,6 @@
 Feature: Run command
 
-  To run a command use the `#run`-method. There are some configuration options
+  To run a command use the `#run_command_and_stop`-method. There are some configuration options
   which are relevant here:
 
   - `fail_on_error`:
@@ -23,7 +23,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli') }.to raise_error RSpec::Expectations::ExpectationNotMetError }
+      it { expect { run_command_and_stop('cli') }.to raise_error RSpec::Expectations::ExpectationNotMetError }
     end
     """
     When I run `rspec`
@@ -40,7 +40,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli', :fail_on_error => true) }.to raise_error }
+      it { expect { run_command_and_stop('cli', :fail_on_error => true) }.to raise_error }
     end
     """
     When I run `rspec`
@@ -57,7 +57,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli', true) }.to raise_error }
+      it { expect { run_command_and_stop('cli', true) }.to raise_error }
     end
     """
     When I run `rspec`
@@ -74,7 +74,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli', :fail_on_error => false) }.not_to raise_error }
+      it { expect { run_command_and_stop('cli', :fail_on_error => false) }.not_to raise_error }
     end
     """
     When I run `rspec`
@@ -91,7 +91,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli', false) }.not_to raise_error }
+      it { expect { run_command_and_stop('cli', false) }.not_to raise_error }
     end
     """
     When I run `rspec`
@@ -126,7 +126,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 2 do
-      before(:each) { run_simple('cli') }
+      before(:each) { run_command_and_stop('cli') }
 
       it { expect(last_command_started).to be_successfully_executed }
       it { expect(last_command_started).to have_output /Hello, Aruba is working/ }
@@ -156,7 +156,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 3 do
-      before(:each) { run_simple('cli') }
+      before(:each) { run_command_and_stop('cli') }
 
       it { expect(last_command_started).to be_successfully_executed }
       it { expect(last_command_started).to have_output /Hello, Aruba here/ }
@@ -165,10 +165,10 @@ Feature: Run command
     When I run `rspec`
     Then the specs should all pass
 
-  Scenario: Sending signals to commands started with `#run_simple()`
+  Scenario: Sending signals to commands started with `#run_command_and_stop()`
 
     Sending signals to a command which is started by
-    `#run_simple()` does not make sense. The command is stopped internally when
+    `#run_command_and_stop()` does not make sense. The command is stopped internally when
     its exit status is checked.
 
     Given an executable named "bin/cli" with:
@@ -199,7 +199,7 @@ Feature: Run command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 2, :startup_wait_time => 1 do
-      before(:each) { run_simple('cli') }
+      before(:each) { run_command_and_stop('cli') }
       it { expect { last_command_started.send_signal 'HUP' }.to raise_error Aruba::CommandAlreadyStoppedError }
     end
     """
@@ -224,7 +224,7 @@ Feature: Run command
     end
 
     RSpec.describe 'Run command', :type => :aruba do
-      it { expect { run_simple('cli', :fail_on_error => true) }.to_not raise_error }
+      it { expect { run_command_and_stop('cli', :fail_on_error => true) }.to_not raise_error }
     end
     """
     When I run `rspec`

data/features/api/command/send_signal.feature

@@ -26,7 +26,7 @@ Feature: Send running command a signal
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 5 do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       before(:each) { last_command_started.send_signal 'HUP' }
       it { expect(last_command_started).to have_output /Exit/ }
     end
@@ -45,7 +45,7 @@ Feature: Send running command a signal
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :exit_timeout => 1, :startup_wait_time => 5 do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       it { expect { last_command_started.send_signal 'HUP' }.to raise_error Aruba::CommandAlreadyStoppedError, /Command "cli" with PID/ }
     end
     """

data/features/api/command/stderr.feature

@@ -18,7 +18,7 @@ Feature: Access STDERR of command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       before(:each) { stop_all_commands }
       it { expect(last_command_started.stderr).to start_with  'Hello' }
     end
@@ -38,7 +38,7 @@ Feature: Access STDERR of command
     require 'spec_helper'
 
     RSpec.describe 'Run command', :type => :aruba, :io_wait_timeout => 2 do
-      before(:each) { run('cli') }
+      before(:each) { run_command('cli') }
       it { expect(last_command_started.stderr).to start_with 'Hello' }
     end
     """