aruba-jbb 0.2.6.5 → 0.2.6.7

data/History.txt

@@ -1,3 +1,11 @@
+== 0.2.6.7 msassak
+
+=== Bug fixes
+* Outputting large amounts of data causes BackgroundProcess#exitstatus to hang (#18 Mike Sassak)
+
+== 0.2.6.6 jbb
+* reverted run api method to old implementation and removed background_process
+
 == 0.2.6.5 jbb
 * removed lib/aruba-jbb.rb file
 

data/README.rdoc

@@ -66,8 +66,8 @@ This will cause Aruba to create soft links called <tt>./tmp/aruba/bin</tt>,
 <tt>./tmp/aruba/config</tt> and <tt>./tmp/aruba/lib</tt> each pointing
 to the corresponding directory in the user's cwd.
 
-Upstream addressed the more limtied problem of locating <code>./bin</code> 
-by adding <code>@bin</code> tag which appends <code>./bin</code> to Cucumber's
+Upstream addressed the more limited problem of locating <code>./bin</code> 
+by adding a <code>@bin</code> tag which appends <code>./bin</code> to Cucumber's
 LOADPATH. This technique is supported by Aruba-jbb as well.
 
 
@@ -82,7 +82,11 @@ The last version of this fork having them was 0.2.6.
 To test against specific versions of Ruby using RVM you are advised to use
 following idiom (note the comma between Ruby version numbers):
 
-<code>$ rvm 1.9.2,1.8.7 exec cucumber [flags] [arguments] </code>
+<code>$ rvm 1.9.2,1.8.7 exec rake cucumber:wip </code>
+
+or
+
+<code>$ rvm 1.9.2,1.8.7 exec cucumber </code>
 
 
 == Getting more output with tags.

data/aruba-jbb.gemspec

@@ -2,10 +2,10 @@
 
 Gem::Specification.new do |s|
   s.name = %q{aruba-jbb}
-  s.version = "0.2.6.5"
+  s.version = "0.2.6.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Aslak Hellesøy", "David Chelimsky", "James B. Byrne"]
+  s.authors = ["Aslak Hellesøy", "David Chelimsky", "James B. Byrne", "Mike Sassak"]
   s.date = %q{2010-09-29}
   s.description = %q{Fork of Aruba, Cucumber steps for testing CLI applications.}
   s.email = %q{cukes@googlegroups.com}

data/features/flushing.feature

@@ -0,0 +1,25 @@
+Feature: Flushing output
+
+  In order to test processes that output a lot of data
+  As a developer using Aruba
+  I want to make sure that large amounts of output aren't buffered  
+
+
+  Scenario: Handle a large STDOUT data stream
+    #When I run "ruby -e \" 500.times.each { |i| puts %Q(rword #{i+1} ) * 6 }\""
+    When I run "ruby -e \" 1500.times { puts %Q(rword ) * 12 }\""
+    Then the stdout should contain "rword"
+
+
+  Scenario: Tons of output
+    When I run "ruby -e 'puts :a.to_s * 65536'"
+    Then the output should contain "a"
+    And the output should be 65537 bytes long
+
+
+  Scenario: Tons of interactive output
+    When I run "ruby -e 'len = gets.chomp; puts :a.to_s * len.to_i'" interactively
+    And I type "65536"
+    Then the output should contain "a"
+    And the output should be 65537 bytes long
+

data/features/output.feature

@@ -5,7 +5,8 @@ Feature: Output
   I want to use the "the output should contain" step
 
   Scenario: Run unknown command
-    When I run "neverever gonna work"
+    When I run "neverever gonna work"   
+    #""" sh: neverever: command not found """ for shell run implementation
     Then the output should contain:
     """
     No such file or directory - neverever gonna work

data/features/step_definitions/aruba_dev_steps.rb

@@ -77,3 +77,7 @@ end
 When /^the following step should fail with Spec::Expectations::ExpectationNotMetError:$/ do |multiline_step|
   proc {steps multiline_step}.should raise_error(RSpec::Expectations::ExpectationNotMetError)
 end
+
+Then /^the output should be (\d+) bytes long$/ do |length|
+  combined_output.length.should == length.to_i 
+end

data/lib/aruba/api.rb

@@ -149,8 +149,6 @@ module Aruba
 
 
     def combined_output
-      @last_stdout ||= ""
-      @last_stderr ||= ""
       if @interactive
         interactive_output
       else
@@ -254,7 +252,7 @@ module Aruba
 
 
     def interactive_output
-      if @interactive
+      @_interactive ||= if @interactive
         @interactive.wait(1) || @interactive.kill('TERM')
         @interactive.stdout.read
       else
@@ -324,22 +322,43 @@ module Aruba
         ENV[key] = value
       end
     end
-
-
+    
     def run(cmd, fail_on_error=true)
       cmd = detect_ruby(cmd)
 
+
       in_current_dir do
         announce_or_puts("$ cd #{Dir.pwd}") if @announce_dir
         announce_or_puts("$ #{cmd}") if @announce_cmd
         ps = BackgroundProcess.run(cmd)
-        @last_exit_status = ps.exitstatus # waits for the process to finish
-        @last_stdout = ps.stdout.read
+        @last_stdout = ps.stdout.read 
         announce_or_puts(@last_stdout) if @announce_stdout
         @last_stderr = ps.stderr.read
         announce_or_puts(@last_stderr) if @announce_stderr
+        @last_exit_status = ps.exitstatus # Waits for process to finish
+      end
+
+=begin
+      stderr_file = Tempfile.new('cucumber')
+      stderr_file.close
+      in_current_dir do
+        announce_or_puts("$ cd #{Dir.pwd}") if @announce_dir
+        announce_or_puts("$ #{cmd}") if @announce_cmd
+
+        mode = RUBY_VERSION =~ /^1\.9/ ? {:external_encoding=>"UTF-8"} : 'r'
+        
+        IO.popen("unset BUNDLE_PATH && unset BUNDLE_BIN_PATH && unset BUNDLE_GEMFILE && #{cmd} 2> #{stderr_file.path}", mode) do |io|
+          @last_stdout = io.read
+          announce_or_puts(@last_stdout) if @announce_stdout
+        end
+
+        @last_exit_status = $?.exitstatus
       end
 
+      @last_stderr = IO.read(stderr_file.path)
+      announce_or_puts(@last_stderr) if @announce_stderr
+=end
+
       if(@last_exit_status != 0 && fail_on_error)
         fail("Exit status was #{@last_exit_status}. Output:\n#{combined_output}")
       end

metadata

@@ -1,19 +1,20 @@
 --- !ruby/object:Gem::Specification 
 name: aruba-jbb
 version: !ruby/object:Gem::Version 
-  hash: 77
+  hash: 73
   prerelease: false
   segments: 
   - 0
   - 2
   - 6
-  - 5
-  version: 0.2.6.5
+  - 7
+  version: 0.2.6.7
 platform: ruby
 authors: 
 - "Aslak Helles\xC3\xB8y"
 - David Chelimsky
 - James B. Byrne
+- Mike Sassak
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -93,6 +94,7 @@ files:
 - config/.gitignore
 - features/exit_statuses.feature
 - features/file_system_commands.feature
+- features/flushing.feature
 - features/interactive.feature
 - features/output.feature
 - features/step_definitions/aruba_dev_steps.rb
@@ -140,6 +142,7 @@ summary: Cucumber steps for testing external processes from the CLI
 test_files: 
 - features/exit_statuses.feature
 - features/file_system_commands.feature
+- features/flushing.feature
 - features/interactive.feature
 - features/output.feature
 - features/step_definitions/aruba_dev_steps.rb