artwork 0.3.1 → 0.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 3e51d5060c17f4737eda437c0f9ce39f16d0ae83
+  data.tar.gz: da1b48d509a9ddc8809f8a1f750fbf25d9f9c388
+SHA512:
+  metadata.gz: 4db0e6456851055b2c9e952ffe8d57c368978425bc4d5e909436f6e6f59055c5fb28414f0ede41835883f0867ccfcbf30125d603e15097e99ebe287575a7c9a1
+  data.tar.gz: 7e1b104e52d173e01e9c1abe5deba6b574f7a22779070fd8918260513f27bbcec87714d457970648f4799283544023244da91336868496c21a04a04c44cc65d1

data/lib/artwork/configuration.rb

@@ -1,18 +1,22 @@
 module Artwork
   module Configuration
     def supported_resolutions_list
-      get_required :supported_resolutions_list
+      get(:supported_resolutions_list) or @@supported_resolutions_list or raise "Please set #{__method__}"
     end
 
     def supported_resolutions_list=(resolutions)
-      set :supported_resolutions_list, resolutions.map(&:to_i).sort
+      list = resolutions.map(&:to_i).sort
+
+      @@supported_resolutions_list ||= list
+      set :supported_resolutions_list, list
     end
 
     def default_resolution
-      get_required :default_resolution
+      get(:default_resolution) or @@default_resolution or raise "Please set #{__method__}"
     end
 
     def default_resolution=(resolution)
+      @@default_resolution ||= resolution
       set :default_resolution, resolution
     end
 
@@ -52,10 +56,6 @@ module Artwork
       Thread.current[setting]
     end
 
-    def get_required(setting)
-      get(setting) or raise "Please set #{name}.#{setting}"
-    end
-
     def fetch_2x_images_flag_from(request)
       request.cookies['_retina'].to_i > 0
     end

data/lib/artwork/version.rb

@@ -1,3 +1,3 @@
 module Artwork
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

data/spec/artwork/configuration_spec.rb

@@ -5,19 +5,59 @@ module Artwork
     let(:config) { Class.new { extend Configuration } }
 
     before :each do
-      thread_variables = {}
-      allow(Thread).to receive(:current) { thread_variables }
+      [
+        :default_resolution, :supported_resolutions_list,
+        :current_resolution, :load_2x_images
+      ].each do |key|
+
+        Thread.current[key] = nil
+
+      end
     end
 
     [:default_resolution, :supported_resolutions_list].each do |option_name|
       describe "##{option_name}" do
+        let(:default_value) { option_name == :supported_resolutions_list ? [1440] : 1440 }
+        let(:custom_value) { option_name == :supported_resolutions_list ? [1024] : 1024 }
+
         it 'raises an error if not set' do
           expect { config.send(option_name) }.to raise_error
         end
 
-        it 'uses Thread.current to store values' do
-          expect(Thread).to receive(:current).and_return(option_name => 'value')
-          expect(config.send(option_name)).to eq 'value'
+        it 'can be initialized with default value' do
+          setter = ->(value) { config.send("#{option_name}=", value) }
+          getter = -> { config.send(option_name) }
+
+          Thread.new { setter.call(default_value) }.join
+
+          expect(getter.call).to eq default_value
+
+          Thread.new do
+            expect(getter.call).to eq default_value
+
+            setter.call(custom_value)
+
+            expect(getter.call).to eq custom_value
+          end.join
+
+          expect(getter.call).to eq default_value
+        end
+
+        it 'does not allow editing of the default value' do
+          setter = ->(value) { config.send("#{option_name}=", value) }
+          getter = -> { config.send(option_name) }
+
+          setter.call default_value
+
+          expect(getter.call).to eq default_value
+
+          setter.call custom_value
+
+          expect(getter.call).to eq custom_value
+
+          Thread.new do
+            expect(getter.call).to eq default_value
+          end.join
         end
       end
     end

metadata

@@ -1,122 +1,109 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: artwork
-version: !ruby/object:Gem::Version 
-  hash: 17
-  prerelease: 
-  segments: 
-  - 0
-  - 3
-  - 1
-  version: 0.3.1
+version: !ruby/object:Gem::Version
+  version: 0.3.2
 platform: ruby
-authors: 
+authors:
 - Dimitar Dimitrov
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2014-06-27 00:00:00 +03:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 1
-        - 6
-        version: "1.6"
-  type: :development
-  version_requirements: *id001
-  prerelease: false
+date: 2014-07-15 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: bundler
-- !ruby/object:Gem::Dependency 
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
   type: :development
-  version_requirements: *id002
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
   name: rake
-- !ruby/object:Gem::Dependency 
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 3
-        version: "3"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
   prerelease: false
-  name: rspec
-- !ruby/object:Gem::Dependency 
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 2
-        - 3
-        version: "2.3"
-  type: :runtime
-  version_requirements: *id004
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
   name: rails
-- !ruby/object:Gem::Dependency 
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 5
-        segments: 
-        - 2
-        - 3
-        version: "2.3"
+      - !ruby/object:Gem::Version
+        version: '2.3'
   type: :runtime
-  version_requirements: *id005
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.3'
+- !ruby/object:Gem::Dependency
   name: paperclip
-- !ruby/object:Gem::Dependency 
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '2.3'
   type: :runtime
-  version_requirements: *id006
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.3'
+- !ruby/object:Gem::Dependency
   name: uglifier
-description: Automated user resolution based image size choosing for your Rails views, but done at the backend.
-email: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Automated user resolution based image size choosing for your Rails views,
+  but done at the backend.
+email:
 - dimitar@live.bg
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- .gitignore
-- .rspec
+files:
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -138,41 +125,31 @@ files:
 - spec/artwork/view_spec.rb
 - spec/artwork_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: https://github.com/mitio/artwork
-licenses: 
+licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Automated user resolution based image size choosing for Rails.
-test_files: 
+test_files:
 - spec/artwork/configuration_spec.rb
 - spec/artwork/controller_spec.rb
 - spec/artwork/model_spec.rb