arturo 1.1.1 → 1.1.2

data/README.md

@@ -74,19 +74,11 @@ feature and deploy it to all users.
 
     $ gem install arturo --version="~> 1.0"
 
-**Note**: the following two sections describe the **intended** use of
-Arturo with Rails 2. Arturo does not yet have Rails 2 support.
+### In Rails 2.3
 
-### In Rails 2, with Bundler
-
-    gem 'arturo', :git => 'git://github.com/jamesarosen/arturo.git',
-                  :tag => 'rails_2_3'
-
-### In Rails 2, without Bundler
-
-Put the `rails_2_3` branch of `git://github.com/jamesarosen/arturo.git` into
-your `vendor/plugins/` directory. You can use Git submodules or a simple
-checkout.
+For Rails 2.3 support, see the
+[`rails_2_3` branch](http://github.com/jamesarosen/arturo/tree/rails_2_3)
+of Arturo.
 
 ## Configuration
 
@@ -103,6 +95,8 @@ checkout.
 
     $ rake db:migrate
 
+#### Edit the generated migration as necessary
+
 #### Edit the configuration
 
 ##### Initializer

data/app/controllers/arturo/features_controller.rb

@@ -5,18 +5,10 @@ require 'action_controller'
 #       to clean it up a bit?
 module Arturo
 
-  begin
-    require 'application_controller'
-  rescue LoadError
-    # do nothing
-  end
-
-  base = Object.const_defined?(:ApplicationController) ? ApplicationController : ActionController::Base
-
   # Handles all Feature actions. Clients of the Arturo engine
   # should redefine Arturo::FeaturesController#permitted? to
   # return true only for users who are permitted to manage features.
-  class FeaturesController < base
+  class FeaturesController < ApplicationController
     include Arturo::FeatureManagement
 
     unloadable

data/app/models/arturo/feature.rb

@@ -8,7 +8,7 @@ module Arturo
     include Arturo::SpecialHandling
 
     Arturo::Feature::SYMBOL_REGEX = /^[a-zA-z][a-zA-Z0-9_]*$/
-    DEFAULT_ATTRIBUTES = { :deployment_percentage => 0 }
+    DEFAULT_ATTRIBUTES = { :deployment_percentage => 0 }.with_indifferent_access
 
     attr_readonly :symbol
 
@@ -69,8 +69,7 @@ module Arturo
       threshold = self.deployment_percentage || 0
       return false if threshold == 0
       return true if threshold == 100
-      (((feature_recipient.id + 17) * 13) % 100) < threshold
-      
+      (((feature_recipient.id + (self.id || 1) + 17) * 13) % 100) < threshold
     end
   end
 end

data/lib/arturo/test_support.rb

@@ -0,0 +1,30 @@
+Arturo.class_eval do
+
+  # Enable a feature; create it if necessary.
+  # For use in testing. Not auto-required on load. To load,
+  #
+  #   require 'arturo/test_support'
+  #
+  # @param [Symbol, String] name the feature name
+  def enable_feature!(name)
+    feature = Arturo::Feature.find_by_symbol(name)
+    if feature
+      feature.update_attributes(:deployment_percentage => 100)
+    else
+      Arturo::Feature.create(:symbol => name, :deployment_percentage => 100)
+    end
+  end
+
+  # Disable a feature if it exists.
+  # For use in testing. Not auto-required on load. To load,
+  #
+  #   require 'arturo/test_support'
+  #
+  # @param [Symbol, String] name the feature name
+  def disable_feature!(name)
+    if (feature = Arturo::Feature.find_by_symbol(name))
+      feature.update_attributes(:deployment_percentage => 0)
+    end
+  end
+
+end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 1
-  - 1
-  version: 1.1.1
+  - 2
+  version: 1.1.2
 platform: ruby
 authors: 
 - James A. Rosen
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-25 00:00:00 -07:00
+date: 2010-11-04 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -114,6 +114,7 @@ files:
 - lib/arturo/feature_factories.rb
 - lib/arturo/feature_management.rb
 - lib/arturo/special_handling.rb
+- lib/arturo/test_support.rb
 - lib/arturo.rb
 - lib/generators/arturo/assets_generator.rb
 - lib/generators/arturo/initializer_generator.rb