artifactory 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 10265df7277800763574fae7df4d0c6ff325c890
-  data.tar.gz: 5184c53709a8a1f37de75bd4a50d0521d823fe02
+  metadata.gz: debdaf9656756bf1f7068230636025e40b3a0aec
+  data.tar.gz: b6a4d23d52134bae4a126386b4afa2abe7159df8
 SHA512:
-  metadata.gz: 54ee97b220dab7402ab9d355ee9913e773a2b5af56f0ec9595a4ee7fdbc974e13bedacb24a836883e36db0e9f3ebda0b831c58ed17c3125c65ea602a9127f157
-  data.tar.gz: 06266bca20064100915396a12811a04c3f0d85f20d3d8b56f57f5545e6c379fad69a65b98ebf6243834a19aa4745b0ba39471174d99c6d7a56dce18f9e265d1c
+  metadata.gz: 677aa4dc20927179229f4fa6733a74565a928aedbb3d6300f698f485ee769848b618e0de60080595c52f93ba1a359df3e49ec18abe590a4fedef65afa6e830ca
+  data.tar.gz: f2e1802388c8c0ae0cc8561ba453f56dd84c6a6bdf8f109812dbb73f87d8faedffe45f48f708f40fe5484558af6df59bd0110b74ba5250787b5d3b57ca975559

data/CHANGELOG.md

@@ -3,6 +3,9 @@ Artifactory Client CHANGELOG
 This file is used to document the changes between releases of the Artifactory
 Ruby client.
 
+v2.5.1 (11-10-2016)
+-------------------
+
 v2.5.0 (09-15-2016)
 -------------------
 - Add support for extended YUM repo attributes

data/Gemfile

@@ -5,6 +5,14 @@ group :test do
   gem 'sinatra', '~> 1.4'
   gem 'rspec',   '~> 3.0'
   gem 'webmock', '~> 1.17'
+  if RUBY_VERSION =~ /^1\.9\.3.*/
+    # gaurd that webmock only brings in addressable with 1.9.3 support.
+    gem 'addressable', '<= 2.4.0'
+    # guard simplecov import of json gem
+    gem 'json', '<= 1.8.3'
+  end
   # rspec-mocks 3.4.1 breaks tests with 'System level too deep' errors.
   gem 'rspec-mocks', '3.4.0'
+  gem 'simplecov'
+  gem 'simplecov-console'
 end

data/Rakefile

@@ -12,3 +12,8 @@ namespace :travis do
   desc 'Run tests on Travis'
   task :ci => [:unit,:integration]
 end
+
+desc 'Generate coverage report'
+RSpec::Core::RakeTask.new(:coverage) do |t|
+  ENV['COVERAGE'] = 'true'
+end

data/lib/artifactory/resources/artifact.rb

@@ -540,6 +540,7 @@ module Artifactory
 
       response = client.put(endpoint, file, headers)
 
+      return unless response.is_a?(Hash)
       self.class.from_hash(response)
     end
 

data/lib/artifactory/version.rb

@@ -15,5 +15,5 @@
 #
 
 module Artifactory
-  VERSION = '2.5.0'
+  VERSION = '2.5.1'
 end

data/spec/spec_helper.rb

@@ -2,6 +2,18 @@ require 'bundler/setup'
 require 'rspec'
 require 'webmock/rspec'
 
+if ENV['COVERAGE']
+  require 'simplecov'
+  require 'simplecov-console'
+  SimpleCov.start do
+    add_filter 'spec/'
+    formatter SimpleCov::Formatter::MultiFormatter.new [
+      SimpleCov::Formatter::HTMLFormatter,
+      SimpleCov::Formatter::Console,
+    ]
+  end
+end
+
 # Require our main library
 require 'artifactory'
 

data/spec/unit/resources/artifact_spec.rb

@@ -109,6 +109,21 @@ module Artifactory
       end
     end
 
+    describe '#upload_checksum' do
+      it 'uploads checksum.sha1' do
+        value = 'ABCD1234'
+
+        tempfile = double('Tempfile').as_null_object
+        expect(Tempfile).to receive(:new).with('checksum.sha1') { tempfile }
+        expect(tempfile).to receive(:write).with(value).once
+        expect(client).to receive(:put).with(
+            "libs-release-local/remote/path.sha1",
+            tempfile
+        )
+        subject.upload_checksum('libs-release-local', '/remote/path', 'sha1', value)
+      end
+    end
+
     describe '#upload_with_checksum' do
       it 'delegates to #upload' do
         expect(subject).to receive(:upload).with(
@@ -136,6 +151,19 @@ module Artifactory
         )
         subject.upload_from_archive('libs-release-local', '/remote/path')
       end
+
+      it 'receives empty response' do
+        file = double(File)
+        allow(File).to receive(:new).and_return( file )
+        expect(client).to receive(:put).with(
+            "libs-release-local/remote/path",
+            file,
+            { 'X-Explode-Archive' => true },
+        )
+        subject.local_path = '/local/path'
+        subject.upload_from_archive('libs-release-local', '/remote/path')
+      end
+
     end
 
     describe '.gavc_search' do
@@ -498,7 +526,25 @@ module Artifactory
     end
 
     describe '#download' do
-      it
+      it 'download content to directory' do
+        Dir.mktmpdir('artifact_download') do |tmpdir|
+          subject.download_uri = '/artifact.deb'
+
+          expect(client).to receive(:get) { 'some content' }
+          subject.download(tmpdir)
+          expect(Dir.entries(tmpdir)).to include('artifact.deb')
+        end
+      end
+
+      it 'download content to directory with filename' do
+        Dir.mktmpdir('artifact_download') do |tmpdir|
+          subject.download_uri = '/artifact.deb'
+
+          expect(client).to receive(:get) { 'some content' }
+          subject.download(tmpdir, {filename: 'foobar.deb'})
+          expect(Dir.entries(tmpdir)).to include('foobar.deb')
+        end
+      end
     end
 
     describe '#relative_path' do

data/spec/unit/resources/repository_spec.rb

@@ -193,5 +193,25 @@ module Artifactory
         expect(subject.artifacts).to be_a(Collection::Artifact)
       end
     end
+
+    describe '#upload_with_checksum' do
+      it 'delecates to artifact' do
+        artifact = double('Artifact')
+        allow(Resource::Artifact).to receive(:new) { artifact }
+        subject.key = 'libs-release-local'
+        expect(artifact).to receive(:upload_with_checksum).once
+        subject.upload_with_checksum('/local/path', '/remote/path', 'checksum', {properties: :foobar})
+      end
+    end
+
+    describe '#upload_from_archive' do
+      it 'delecates to artifact' do
+        artifact = double('Artifact')
+        allow(Resource::Artifact).to receive(:new) { artifact }
+        subject.key = 'libs-release-local'
+        expect(artifact).to receive(:upload_from_archive).once
+        subject.upload_from_archive('/local/path', '/remote/path', {properties: :foobar})
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: artifactory
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Seth Vargo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-15 00:00:00.000000000 Z
+date: 2016-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler