arstotzka 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dab766f1bb96f47815fccca69b12bfa5240538d03b9e1fe6f059529f01f4bac8
-  data.tar.gz: 9ff7799976593647f92d0eb1e1422a6ddc3b5538cf1694e7bdcf16b7d016c3c2
+  metadata.gz: 9a4b941b1b173ae1f57c979ab7b58771a675dc297184cecb936c4e3e5854de5c
+  data.tar.gz: 4dcc0ad6c185c423aa7cb9376ebc47f392a9fb7eccb5753f0448817a1337dc10
 SHA512:
-  metadata.gz: c8da448735a633c9958a0c7f604a3008e5157088424b900ac0d880a7151bb6f9df534a70da5b9a33df2f46a5aab49f743535dc1116342b3faf80f07dde12c148
-  data.tar.gz: 305d9d2b4d048549f31cd4a23c182ad19976b4b47ada251ccd57d3a26e7820e640986f6e495a919590cb0c46bf1897ddbc3b70fa6ccc8c68c901d7a55931f487
+  metadata.gz: 55402898468c8a5f593abfba401cf36a76e08771b4b98c6d1240af8224f54d141e13f6c19033befee4a9244289bee3b2aebf0f682a874090162c7fb529aaf63b
+  data.tar.gz: 064e5a70a830ea70ff8d1dc544f36f81ebd88c8ce4df77efad625a1e4d9d67d8b5245b5dc8f851c9fc7ccd8dff5ef7eb9a83ad702556a494ed7084fdae08515f

data/.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2
 jobs:
   build:
     docker:
-      - image: darthjee/circleci_ruby_gems:0.0.1
+      - image: darthjee/circleci_ruby_gems:0.0.2
     steps:
       - checkout
       - run:
@@ -26,3 +26,6 @@ jobs:
       - run:
           name: Check version documentation
           command: scripts/check_readme.sh
+      - run:
+          name: Rubycritcs check
+          command: scripts/rubycritic.sh

data/.gitignore

@@ -5,3 +5,4 @@ doc
 pkg
 measurement
 **/*.swp
+rubycritic/

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM darthjee/ruby_gems:0.0.1
+FROM darthjee/ruby_gems:0.0.2
 
 USER app
 COPY --chown=app ./ /home/app/app/

data/README.md

@@ -19,7 +19,7 @@ JSON keys)
 
 Yard Documentation
 -------------------
-https://www.rubydoc.info/gems/arstotzka/1.3.0
+https://www.rubydoc.info/gems/arstotzka/1.3.1
 
 Instalation
 ---------------

data/Rakefile

@@ -4,6 +4,7 @@ require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'yardstick/rake/measurement'
 require './config/yardstick'
+require './config/rubycritc'
 
 RSpec::Core::RakeTask.new
 

data/arstotzka.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec',         '>= 3.8'
   gem.add_development_dependency 'rubocop',       '0.58.1'
   gem.add_development_dependency 'rubocop-rspec', '1.30.0'
+  gem.add_development_dependency 'rubycritic',    '>= 4.0.2'
   gem.add_development_dependency 'simplecov',     '~> 0.16.x'
   gem.add_development_dependency 'yard',          '>= 0.9.18'
   gem.add_development_dependency 'yardstick',     '>= 0.9.9'

data/config/rubycritc.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+require 'rubycritic/rake_task'
+
+RubyCritic::RakeTask.new do |task|
+  options = %w[
+    --path rubycritic/
+    --no-browser
+  ]
+  task.options = options.join(' ')
+  task.paths   = %w[lib]
+end

data/config/yardstick.yml

@@ -19,28 +19,30 @@ rules:
   ReturnTag:
     enabled: true
     exclude:
-      - Arstotzka::Crawler#post_process
+      - Arstotzka::Crawler#block
       - Arstotzka::Crawler#options
-      - Arstotzka::Fetcher#instance
+      - Arstotzka::Exception::FetcherBuilderNotFound#attribute
+      - Arstotzka::Exception::FetcherBuilderNotFound#klass
       - Arstotzka::Fetcher#options
       - Arstotzka::FetcherBuilder#options
+      - Arstotzka::HashReader#options
       - Arstotzka::MethodBuilder#attr_names
       - Arstotzka::MethodBuilder#options
-      - Arstotzka::Options#keys
       - Arstotzka::Reader#keys
       - Arstotzka::Reader#options
       - Arstotzka::Wrapper#options
   Summary::Presence:
     enabled: true
     exclude:
-      - Arstotzka::Crawler#post_process
+      - Arstotzka::Crawler#block
       - Arstotzka::Crawler#options
-      - Arstotzka::Fetcher#instance
+      - Arstotzka::Exception::FetcherBuilderNotFound#attribute
+      - Arstotzka::Exception::FetcherBuilderNotFound#klass
       - Arstotzka::Fetcher#options
       - Arstotzka::FetcherBuilder#options
+      - Arstotzka::HashReader#options
       - Arstotzka::MethodBuilder#attr_names
       - Arstotzka::MethodBuilder#options
-      - Arstotzka::Options#keys
       - Arstotzka::Reader#keys
       - Arstotzka::Reader#options
       - Arstotzka::Wrapper#options

data/lib/arstotzka.rb

@@ -172,6 +172,7 @@ module Arstotzka
   autoload :Exception,      'arstotzka/exception'
   autoload :Fetcher,        'arstotzka/fetcher'
   autoload :FetcherBuilder, 'arstotzka/fetcher_builder'
+  autoload :HashReader,     'arstotzka/hash_reader'
   autoload :MethodBuilder,  'arstotzka/method_builder'
   autoload :Options,        'arstotzka/options'
   autoload :Reader,         'arstotzka/reader'

data/lib/arstotzka/class_methods.rb

@@ -12,8 +12,8 @@ module Arstotzka
     # @param options [Arstotzka::Options] fetcher options
     #
     # @return [Artotzka::FetcherBuilder]
-    def add_fetcher(attribute, options)
-      fetcher_builders[attribute.to_sym] = FetcherBuilder.new(options.merge(key: attribute))
+    def add_fetcher(attribute, options = {})
+      fetcher_builders[attribute] = FetcherBuilder.new(options.merge(key: attribute))
     end
 
     # @api private
@@ -27,7 +27,39 @@ module Arstotzka
     #
     # @return [Arstotzka::Fetcher]
     def fetcher_for(attribute, instance)
-      fetcher_builders[attribute.to_sym].build(instance)
+      return builder_for(attribute).build(instance) if fetcher_for?(attribute)
+
+      raise Exception::FetcherBuilderNotFound.new(attribute, self)
+    end
+
+    protected
+
+    # @api private
+    #
+    # Checks if class can build a fetcher for attribute
+    #
+    # @param attribute [::Symbol]
+    #
+    # @return [TrueClass,FalseClass]
+    def fetcher_for?(attribute)
+      return true if fetcher_builders.key?(attribute)
+      return unless superclass.include?(Arstotzka)
+
+      superclass.fetcher_for?(attribute)
+    end
+
+    # @api private
+    #
+    # Returns fetcher builder for an attribute
+    #
+    # @param attribute [::Symbol]
+    #
+    # @return [Arstotzka::FetcherBuilder]
+    def builder_for(attribute)
+      builder = fetcher_builders[attribute]
+      return superclass.builder_for(attribute) unless builder
+
+      builder
     end
 
     private
@@ -69,7 +101,7 @@ module Arstotzka
     #   ActiveSupport::Concern
     def expose(*attr_names, **options_hash)
       options = Options.new(options_hash.symbolize_keys)
-      MethodBuilder.new(attr_names, self, options).build
+      MethodBuilder.new(attr_names.map(&:to_sym), self, options).build
     end
 
     # @private

data/lib/arstotzka/crawler.rb

@@ -36,8 +36,7 @@ module Arstotzka
     #   @param options [Arstotzka::Options] options of initialization object
     def initialize(options = {}, &block)
       self.options = options
-
-      @post_process = block || proc { |value| value }
+      @block = block
     end
 
     # Crawls into the hash looking for all keys in the given keys
@@ -94,7 +93,7 @@ module Arstotzka
     private
 
     # @private
-    attr_reader :post_process, :options
+    attr_reader :block, :options
     delegate :compact, :default, to: :options
 
     # Fetch the value from hash by crawling the keys
@@ -150,6 +149,15 @@ module Arstotzka
       post_process.call(value)
     end
 
+    # @private
+    #
+    # Return post processor responsible for processing final result
+    #
+    # @return [Proc]
+    def post_process
+      @post_process ||= block || proc { |value| value }
+    end
+
     # @private
     #
     # Iterate over array applying #crawl over each element
@@ -160,8 +168,8 @@ module Arstotzka
     # @return [Array] the new array with the individual values returned
     # @see #crawl
     def crawl_array(array, index)
-      array.map { |j| value(j, index) }.tap do |a|
-        a.compact! if compact
+      array.map { |element| value(element, index) }.tap do |new_array|
+        new_array.compact! if compact
       end
     end
   end

data/lib/arstotzka/exception.rb

@@ -1,8 +1,36 @@
 # frozen_string_literal: true
 
 module Arstotzka
+  # @api private
+  #
+  # Arstotzka exceptions
   module Exception
     # Exception raised when a key in the hash is not found
     class KeyNotFound < StandardError; end
+
+    # Exception raised when configuration for FetcherBuilder is not found
+    class FetcherBuilderNotFound < StandardError
+      # Returns a new instance of FetcherBuilderNotFound
+      #
+      # @param attribute [Symbol] attribute's name
+      # @param klass [Class] Class where the fetcher was being accessed
+      #
+      # @return [FetcherBuilderNotFound]
+      def initialize(attribute, klass)
+        @attribute = attribute
+        @klass = klass
+      end
+
+      # Returns message specifying which attemp created the failure
+      #
+      # @return [String]
+      def message
+        "FetcherBuild not found for #{attribute} on #{klass}"
+      end
+
+      private
+
+      attr_reader :attribute, :klass
+    end
   end
 end

data/lib/arstotzka/fetcher.rb

@@ -11,10 +11,12 @@ module Arstotzka
     # Creates an instance of Artotzka::Fetcher
     #
     # @overload iniitalize(options_hash = {})
-    #   @param options_hash [Hash] options for {Crawler}, {Wrapper} and {Reader}
+    #   @param options_hash [Hash] options for {Crawler}, {Wrapper},
+    #   {Reader} and {HashReader}
     #
     # @overload iniitalize(options)
-    #   @param options [Arstotzka::Options] options for {Crawler}, {Wrapper} and {Reader}
+    #   @param options [Arstotzka::Options] options for {Crawler}, {Wrapper},
+    #   {Reader} and {HashReader}
     def initialize(options_hash = {})
       self.options = options_hash
     end
@@ -81,35 +83,32 @@ module Arstotzka
     #                 # ]
     def fetch
       value = crawler.value(hash)
-      value.flatten! if flatten && value.respond_to?(:flatten!)
+      value.flatten! if flatten && value.is_a?(Array)
       value = instance.send(after, value) if after
       value
     end
 
+    # Checks if other equals self
+    #
+    # @param other [Object]
+    #
+    # @return [TrueClass,FalseClass]
+    def ==(other)
+      return false unless other.class == self.class
+      options == other.options &&
+        instance == other.instance
+    end
+
+    protected
+
+    attr_reader :options
+
     private
 
     # @private
-    attr_reader :instance, :options
     delegate :instance, :after, :flatten, to: :options
     delegate :wrap, to: :wrapper
-
-    # @private
-    #
-    # Retrieves the hash to be crawled from the instance
-    #
-    # @return [Hash]
-    # rubocop:disable Metrics/AbcSize
-    def hash
-      @hash ||= case options.json.to_s
-                when /^@@.*/
-                  instance.class.class_variable_get(options.json)
-                when /^@.*/
-                  then instance.instance_variable_get(options.json)
-                else
-                  instance.send(options.json.to_s)
-                end
-    end
-    # rubocop:enable Metrics/AbcSize
+    delegate :hash, to: :hash_reader
 
     # @private
     #
@@ -134,5 +133,14 @@ module Arstotzka
     def wrapper
       @wrapper ||= Wrapper.new(options.merge(instance: instance))
     end
+
+    # @api private
+    #
+    # Reader responsible for fetching hash from instance
+    #
+    # @return [Arstotzka::HashReader]
+    def hash_reader
+      @hash_reader ||= HashReader.new(options)
+    end
   end
 end

data/lib/arstotzka/hash_reader.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+module Arstotzka
+  # @api private
+  #
+  # Class responsible for reading json / hash from instance
+  class HashReader
+    include Base
+
+    # Returns a new instance of HashReader
+    #
+    # @overload iniitalize(options_hash = {})
+    #   @param options_hash [Hash]
+    #
+    # @overload iniitalize(options)
+    #   @param options [Arstotzka::Options]
+    def initialize(options_hash = {})
+      self.options = options_hash
+    end
+
+    # Retrieves the hash to be crawled from the instance
+    #
+    # @return [Hash]
+    #
+    # @example Simple Usage
+    #   class Dummy
+    #     def initialize(json = {})
+    #       @json = json
+    #     end
+    #
+    #     private
+    #
+    #     attr_reader :json
+    #   end
+    #
+    #   hash = { key: 'value' }
+    #   instance = Dummy.new(hash)
+    #
+    #   reader = Arstotzka::HashReader.new(
+    #     instance: instance
+    #   )
+    #
+    #   reader.hash # returns { key: 'value' }
+    #
+    # @example When fetching from class variable
+    #   class ClassVariable
+    #     def self.json=(json)
+    #       @@json = json
+    #     end
+    #   end
+    #
+    #   hash = { key: 'value' }
+    #   ClassVariable.json = hash
+    #
+    #   instance = ClassVariable.new
+    #
+    #   reader = Arstotzka::HashReader.new(
+    #     instance: instance, json: :@@json
+    #   )
+    #
+    #   reader.hash # returns { key: 'value' }
+    def hash
+      @hash ||= case json.to_s
+                when /^@@.*/
+                  instance.class.class_variable_get(json)
+                when /^@.*/
+                  then instance.instance_variable_get(json)
+                else
+                  instance.send(json)
+                end
+    end
+
+    private
+
+    attr_reader :options
+
+    delegate :instance, to: :options
+    delegate :json, to: :options
+  end
+end

data/lib/arstotzka/method_builder.rb

@@ -41,7 +41,7 @@ module Arstotzka
     include Base
     # Returns new instance of Arstotzka::MethodBuilder
     #
-    # @param attr_names [Array] list of attributes to be fetched from the hash/json
+    # @param attr_names [Array<Symbol>] list of attributes to be fetched from the hash/json
     # @param klass [Class] class to receive the methods
     #   (using {https://www.rubydoc.info/gems/sinclair Sinclair})
     #

data/lib/arstotzka/options.rb

@@ -316,11 +316,24 @@ module Arstotzka
       self.class.new(to_h.merge(options))
     end
 
+    # Retuns all keys used when fetching
+    #
+    # @return [Array<String>]
     def keys
       return full_path.split('.') if full_path
       return [key.to_s] unless path&.present?
 
       [path, key].compact.join('.').split('.')
     end
+
+    # Checks if another instance equals self
+    #
+    # @param other [Object]
+    #
+    # @return [TrueClass,FalseClass]
+    def ==(other)
+      return false unless other.class == self.class
+      to_h == other.to_h
+    end
   end
 end

data/lib/arstotzka/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Arstotzka
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end

data/lib/arstotzka/wrapper.rb

@@ -66,7 +66,7 @@ module Arstotzka
 
     # @private
     attr_reader :options
-    delegate :klass, :type, to: :options
+    delegate :klass, :type, :after_each, to: :options
 
     # @private
     #
@@ -90,7 +90,7 @@ module Arstotzka
     #
     # @return [Arra]
     def wrap_array(array)
-      array.map { |v| wrap v }
+      array.map { |element| wrap element }
     end
 
     # @private
@@ -132,9 +132,9 @@ module Arstotzka
     #
     # @return [Object] result of method call
     def after(value)
-      return value unless options.after_each
+      return value unless after_each
 
-      options.instance.send(options.after_each, value)
+      options.instance.send(after_each, value)
     end
   end
 end

data/scripts/rubycritic.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+DIFF_LIST=$(git diff --name-only $CIRCLE_SHA1 $(git merge-base $CIRCLE_SHA1 origin/master) | grep "^lib/")
+
+if [ ! -z "$DIFF_LIST" ]; then
+  mkdir -p tmp/rubycritic/compare
+  bundle exec rubycritic --format console --branch origin/master -t 0 $DIFF_LIST
+else
+  echo "No changes detected. Skipping rubycritic..."
+fi

data/spec/integration/yard/arstotzka/hash_reader_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Arstotzka::HashReader do
+  subject(:reader) { described_class.new(options) }
+
+  describe '#hash' do
+    let(:klass)    { Arstotzka::Fetcher::Dummy }
+    let(:json)     { { key: 'value' } }
+    let(:instance) { klass.new(json) }
+    let(:options)  { { instance: instance } }
+
+    context 'when no extra options are given' do
+      it 'reads hash from instance json method' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+
+    context 'when fetching from instance variable' do
+      let(:klass)   { Arstotzka::Fetcher::NoAccessor }
+      let(:options) { { instance: instance, json: :@hash } }
+
+      it 'reads hash from instance variable' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+
+    context 'when fetching from class variable' do
+      let(:klass) { Arstotzka::Fetcher::ClassVariable }
+      let(:options)  { { instance: instance, json: :@@json } }
+      let(:instance) { klass.new }
+
+      before { klass.json = json }
+
+      it 'reads hash from class variable' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+  end
+end

data/spec/integration/yard/arstotzka/method_builder_spec.rb

@@ -31,8 +31,8 @@ describe Arstotzka::MethodBuilder do
     end
 
     describe '#age' do
-      let(:klass) { Class.new(MyModel) }
-      let(:attributes)   { [:age, 'cars'] }
+      let(:klass)        { Class.new(MyModel) }
+      let(:attributes)   { %i[age cars] }
       let(:options_hash) { { type: :integer } }
 
       before do
@@ -49,8 +49,8 @@ describe Arstotzka::MethodBuilder do
     end
 
     describe '#cars' do
-      let(:klass) { Class.new(MyModel) }
-      let(:attributes)   { [:age, 'cars'] }
+      let(:klass)        { Class.new(MyModel) }
+      let(:attributes)   { %i[age cars] }
       let(:options_hash) { { type: :integer } }
 
       before do

data/spec/lib/arstotzka/hash_reader_spec.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Arstotzka::HashReader do
+  subject(:reader) { described_class.new(options) }
+
+  describe '#hash' do
+    let(:klass)    { Arstotzka::Fetcher::Dummy }
+    let(:json)     { { key: SecureRandom.hex } }
+    let(:instance) { klass.new(json) }
+    let(:options)  { { instance: instance } }
+
+    context 'when no extra options are given' do
+      it 'reads hash from instance json method' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+
+    context 'when fetching from instance variable' do
+      let(:klass)   { Arstotzka::Fetcher::NoAccessor }
+      let(:options) { { instance: instance, json: :@hash } }
+
+      it 'reads hash from instance variable' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+
+    context 'when fetching from class variable' do
+      let(:klass)    { Arstotzka::Fetcher::ClassVariable }
+      let(:options)  { { instance: instance, json: :@@json } }
+      let(:instance) { klass.new }
+
+      before do
+        klass.json = json
+      end
+
+      it 'reads hash from class variable' do
+        expect(reader.hash).to eq(json)
+      end
+    end
+  end
+end

data/spec/lib/arstotzka_spec.rb

@@ -8,6 +8,67 @@ describe Arstotzka do
   let(:json)        { load_json_fixture_file('arstotzka.json') }
   let(:value)       { dummy.public_send(attribute) }
 
+  describe '.add_fether' do
+    let(:klass) { Class.new(Arstotzka::Dummy) }
+
+    it do
+      expect { klass.add_fetcher(:new_attribute) }
+        .to change { klass.send(:fetcher_builders).keys }
+        .to([:new_attribute])
+    end
+  end
+
+  describe '.fetcher_for' do
+    let(:klass)    { Arstotzka::Dummy }
+    let(:instance) { klass.new({}) }
+    let(:expected) do
+      Arstotzka::Fetcher.new(
+        key: :name,
+        path: 'user',
+        instance: instance
+      )
+    end
+
+    it do
+      expect(klass.fetcher_for(:name, instance))
+        .to be_a(Arstotzka::Fetcher)
+    end
+
+    it 'returns correct fetcher' do
+      expect(klass.fetcher_for(:name, instance))
+        .to eq(expected)
+    end
+
+    context 'when fetcher was never added' do
+      it do
+        expect { klass.fetcher_for(:new_attribute, instance) }
+          .to raise_error(
+            Arstotzka::Exception::FetcherBuilderNotFound,
+            "FetcherBuild not found for new_attribute on #{klass}"
+          )
+      end
+    end
+
+    context 'when dealing with subclass' do
+      let(:klass) { Class.new(Arstotzka::Dummy) }
+
+      it do
+        expect { klass.fetcher_for(:name, instance) }
+          .not_to raise_error
+      end
+
+      context 'when fetcher was never added' do
+        it do
+          expect { klass.fetcher_for(:new_attribute, instance) }
+            .to raise_error(
+              Arstotzka::Exception::FetcherBuilderNotFound,
+              "FetcherBuild not found for new_attribute on #{klass}"
+            )
+        end
+      end
+    end
+  end
+
   context 'when parser is configured with no options' do
     let(:attribute) { :id }
 
@@ -130,4 +191,13 @@ describe Arstotzka do
       expect(value).to be_a(Float)
     end
   end
+
+  context 'when class is a child' do
+    let(:klass)     { Class.new(Arstotzka::Dummy) }
+    let(:attribute) { :name }
+
+    it 'retrieves attribute from base json' do
+      expect(value).to eq(json['user']['name'])
+    end
+  end
 end

data/spec/support/models/arstotzka/dummy.rb

@@ -5,7 +5,7 @@ module Arstotzka
     include Arstotzka
     attr_reader :json
 
-    expose :id
+    expose 'id'
     expose :name, path: 'user'
     expose :father_name, full_path: 'father.name'
     expose :age, cached: true
@@ -23,5 +23,10 @@ module Arstotzka
         g.publisher == 'sega'
       end
     end
+
+    def ==(other)
+      return false unless other.class == self.class
+      json == other.json
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arstotzka
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Darthjee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-30 00:00:00.000000000 Z
+date: 2019-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -122,6 +122,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.30.0
+- !ruby/object:Gem::Dependency
+  name: rubycritic
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.0.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -199,6 +213,7 @@ files:
 - Rakefile
 - arstotzka.gemspec
 - arstotzka.jpg
+- config/rubycritc.rb
 - config/yardstick.rb
 - config/yardstick.yml
 - docker-compose.yml
@@ -209,6 +224,7 @@ files:
 - lib/arstotzka/exception.rb
 - lib/arstotzka/fetcher.rb
 - lib/arstotzka/fetcher_builder.rb
+- lib/arstotzka/hash_reader.rb
 - lib/arstotzka/method_builder.rb
 - lib/arstotzka/options.rb
 - lib/arstotzka/reader.rb
@@ -216,6 +232,7 @@ files:
 - lib/arstotzka/version.rb
 - lib/arstotzka/wrapper.rb
 - scripts/check_readme.sh
+- scripts/rubycritic.sh
 - spec/fixtures/accounts.json
 - spec/fixtures/accounts_missing.json
 - spec/fixtures/arstotzka.json
@@ -227,6 +244,7 @@ files:
 - spec/integration/yard/arstotzka/crawler_spec.rb
 - spec/integration/yard/arstotzka/fetcher_builder_spec.rb
 - spec/integration/yard/arstotzka/fetcher_spec.rb
+- spec/integration/yard/arstotzka/hash_reader_spec.rb
 - spec/integration/yard/arstotzka/method_builder_spec.rb
 - spec/integration/yard/arstotzka/options_spec.rb
 - spec/integration/yard/arstotzka/reader_spec.rb
@@ -236,6 +254,7 @@ files:
 - spec/lib/arstotzka/crawler_spec.rb
 - spec/lib/arstotzka/fetcher_builder_spec.rb
 - spec/lib/arstotzka/fetcher_spec.rb
+- spec/lib/arstotzka/hash_reader_spec.rb
 - spec/lib/arstotzka/method_builder_spec.rb
 - spec/lib/arstotzka/options_spec.rb
 - spec/lib/arstotzka/reader_spec.rb
@@ -310,6 +329,7 @@ test_files:
 - spec/integration/yard/arstotzka/crawler_spec.rb
 - spec/integration/yard/arstotzka/fetcher_builder_spec.rb
 - spec/integration/yard/arstotzka/fetcher_spec.rb
+- spec/integration/yard/arstotzka/hash_reader_spec.rb
 - spec/integration/yard/arstotzka/method_builder_spec.rb
 - spec/integration/yard/arstotzka/options_spec.rb
 - spec/integration/yard/arstotzka/reader_spec.rb
@@ -319,6 +339,7 @@ test_files:
 - spec/lib/arstotzka/crawler_spec.rb
 - spec/lib/arstotzka/fetcher_builder_spec.rb
 - spec/lib/arstotzka/fetcher_spec.rb
+- spec/lib/arstotzka/hash_reader_spec.rb
 - spec/lib/arstotzka/method_builder_spec.rb
 - spec/lib/arstotzka/options_spec.rb
 - spec/lib/arstotzka/reader_spec.rb