array_transform 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bca98ed72596ed8c419fbeddb3a8a2519cd9254a
-  data.tar.gz: fd9186d92671ca0af507d226f21c8e37c928da64
+  metadata.gz: c57bfcf0be433080cc910278e3bda5a38781dcc8
+  data.tar.gz: abbb2dc11abff401b46ea8335a4157fa84fe4503
 SHA512:
-  metadata.gz: 5e288388692d65fb498b70e6aee8eb1963394b80d108bd0df7df827778314b045663f7ebd58323f64e63298b6970f33132bae28881ff161c54af8bedd8b20146
-  data.tar.gz: 5fe282f824b6b4cee0ba1158ce3e33c25a23d315b82d852a6094754aa6aab2af27e72bbd1cd7b91525f343943b3a74dd5e38fa9d4642b2cfe3943097f9dde677
+  metadata.gz: fd0df6edbdc025db7c16cb51e75410828319eb466d5ac55039bf36f195c5d335de29838d507e3a31bf6271e816cc3cef16e5021894e909ce843ad0032fe6b761
+  data.tar.gz: a618260d70b43048033b684739eb92950cbae0512aecd83803426ef46c0f56e05f3599f9f9e771e221b38b4f3ffc1348a52e8df068444b1432fc45a093afa228

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+### 0.1.1 / 2018-11-14
+
+* Bug fixes
+  * Fixed bug where join with lookup operation used wrong data structure for lookup of join column index.
+  * Fixed join with lookup operation to work with join on a lookup column in any position (not just the first position).
+
+
+### 0.1.0 / 2018-11-14
+
+Initial Release.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    array_transform (0.1.0)
+    array_transform (0.1.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,20 +1,3 @@
-# TODO before commit
-
-* update assertions to match error messages
-* change copy column to leverage add column (?)
-* Error handling strategy
-
-# TODO
-
-* Add Code Climate badge
-* Add CI badge
-* Add DSL
-* Update readme
-* Add merge columns operation
-* Add split column operation
-* Add copy rows operation
-* Add append rows operation
-
 # ArrayTransform
 
 [![Build Status](https://travis-ci.com/Scrimmage/array_transform.svg?token=4X3FUNyi2mcNDmPpLxLJ&branch=master)](https://travis-ci.com/Scrimmage/array_transform)

data/lib/array_transform.rb

@@ -10,6 +10,4 @@ require "array_transform/operations/remove_rows"
 require "array_transform/operations/update_row"
 
 module ArrayTransform
-  # class Error < StandardError; end
-  # Your code goes here...
 end

data/lib/array_transform/concerns/callable.rb

@@ -10,12 +10,6 @@ module ArrayTransform::Callable
   module Callable
     def call
       super
-  #     catch :halt do
-  #      super
-  #       super.tap do
-  #         success unless result_specified?
-  #       end
-  #     end
     end
   end
 
@@ -27,106 +21,4 @@ module ArrayTransform::Callable
     end
   end
 
-  # # Indicates whether the call failed
-  # def failed?
-  #   !success?
-  # end
-
-  # # Indicates whether the call called success or failure
-  # def result_specified?
-  #   defined?(@success)
-  # end
-
-  # # Mark the call as successful.
-  # def success
-  #   @success = true
-  # end
-
-  # # Indicates if the call was successful
-  # def success?
-  #   !!@success
-  # end
-
 end
-
-
-
-
-# module UseCase
-
-#   def self.included(base)
-#     base.class_eval do
-#       prepend Perform
-#       extend ClassMethods
-#       include Virtus.model(strict: true, required: false)
-#       include ActiveModel::Validations
-#     end
-#   end
-
-#   module Perform
-#     # Executes use case logic
-#     #
-#     # Use cases must implement this method. Assumes success if failure is not called.
-#     def perform
-#       catch :halt do
-#         super.tap do
-#           success unless result_specified?
-#         end
-#       end
-#     end
-#   end
-
-#   module ClassMethods
-#     # Executes and returns the use case
-#     #
-#     # A use case object is instantiated with the supplied
-#     # arguments, perform is called and the object is returned.
-#     def perform(*args, &block)
-#       new(*args, &block).tap do |use_case|
-#         use_case.perform
-#       end
-#     end
-#   end
-
-#   attr_accessor :error_category, :error_key, :upstream_use_case
-
-#   # Mark the use case as failed.
-#   def failure
-#     @success = false
-#   end
-
-#   # Mark the use case as failed and exits the use case.
-#   def failure!(message = nil)
-#     failure
-#     throw :halt
-#   end
-
-#   # Block invoked only if use case failed.
-#   def on_failure(&block)
-#     yield(self) if failed?
-#     self
-#   end
-
-#   # Block invoked only if use case succeeded.
-#   def on_success(&block)
-#     yield(self) if success?
-#     self
-#   end
-
-#   # Add errors to the provided use case and mark it as failed.
-#   def propagate_failure!(use_case)
-#     if failed?
-#       use_case.upstream_use_case = self
-#       use_case.errors.add(:base, "UseCase #{self.class.name} failed: #{system_error_messages_string}")
-#       use_case.error_key = error_key
-#       use_case.failure!
-#     end
-#     self
-#   end
-
-#   # Halts execution of the use case if validation fails.
-#   def validate!
-#     failure! unless valid?
-#   end
-
-# end

data/lib/array_transform/operations/add_index_column.rb

@@ -3,11 +3,6 @@ module ArrayTransform::Operations
   class AddIndexColumn
     include ArrayTransform::Callable
 
-    # TODO: take a custom number generator?
-    # TODO: support before/after (before_column_header, after_column_header)
-    # [1, 2, 3].insert(1, 4)
-    #  => [1, 4, 2, 3]
-
     def initialize(
       new_column_header: nil,
       data:,

data/lib/array_transform/operations/copy_column.rb

@@ -35,14 +35,6 @@ module ArrayTransform::Operations
     end
 
     def copy_column
-      # compare with performance of:
-      #
-      # column_index && AddColumn.call(
-      #   cell_operation: -> (row_index) { data[row_index][column_index] },
-      #   data: data,
-      #   new_column_header: new_column_header
-      # )
-
       column_index && data.each do |row|
         row << row[column_index]
       end

data/lib/array_transform/operations/join_with_lookup.rb

@@ -9,7 +9,7 @@ module ArrayTransform::Operations
       data:,
       lookup_data:,
       lookup_column_header: nil,
-      lookup_column_index: nil, # default to 0? smart join on first column match?
+      lookup_column_index: nil,
       lookup_default: nil
     )
       @column_header = column_header
@@ -42,10 +42,10 @@ module ArrayTransform::Operations
     end
 
     def index_lookup_data
-      # TODO: check for dup keys
       @lookup_by_key = lookup_data.inject({}) { |map, row|
-        map[row[lookup_column_index]] = row[1..-1]
-        map
+        map.tap {
+          map[row[lookup_column_index]] = row.dup.tap { |row_copy| row_copy.delete_at(lookup_column_index) }
+        }
       }
     end
 
@@ -61,7 +61,7 @@ module ArrayTransform::Operations
     end
 
     def lookup_column_header_index
-      data[0] && data[0].index(lookup_column_header)
+      lookup_data[0] && lookup_data[0].index(lookup_column_header)
     end
 
     def lookup_default
@@ -77,8 +77,6 @@ module ArrayTransform::Operations
         raise(ArgumentError, "can only specify one of :lookup_column_index or :lookup_column_header")
       end
 
-      # TODO: lookup data must have at least two columns?
-
       if @lookup_default && lookup_data[0] && @lookup_default.count != lookup_data[0].count - 1
         raise(ArgumentError, "lookup_default must have exactly #{lookup_data[0].count - 1} columns")
       end

data/lib/array_transform/version.rb

@@ -1,3 +1,3 @@
 module ArrayTransform
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: array_transform
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Matthew Chadwick
@@ -78,6 +78,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock