array_logic 0.2.3 → 0.2.4

data/README.rdoc

@@ -39,25 +39,6 @@ and *blockers*:
 
 See test/array_logic/rule_test for more examples
 
-== Combinations that match
-
-Two methods allow you to determine sample combinations that match the current
-rule.  
-
-    rule = ArrayLogic::Rule.new 'a1 and a2'
-
-    rule.matching_combinations   -->  [[1,2]]
-    rule.blocking_combinations   -->  [[1],[2]]
-
-To limit the number of samples presented, both only use ids used within
-the rule. For the example above, an array that includes [1,2] would match, 
-and so would [1,2,3]. However, arrays that only contain 1 or 2 would not match 
-(for example [1,3])
-
-Run example.rb to see some more examples
-
-    ruby /lib/example.rb
-
 == Functions
 
 Version 0.2 introduces the concept of functions to ArrayLogic. The function
@@ -123,3 +104,35 @@ functions can be combined with other rules:
 
     rule = ArrayLogic::Rule.new '(sum(:id) == 12) and not a6'
     rule.match(answers)   --> false
+
+== Combinations that match
+
+Two methods allow you to determine sample combinations that match the current
+rule.  
+
+    rule = ArrayLogic::Rule.new 'a1 and a2'
+
+    rule.matching_combinations   -->  [[1,2]]
+    rule.blocking_combinations   -->  [[1],[2]]
+
+To limit the number of samples presented, both only use ids used within
+the rule. For the example above, an array that includes [1,2] would match, 
+and so would [1,2,3]. However, arrays that only contain 1 or 2 would not match 
+(for example [1,3])
+
+=== Combinations and functions
+
+Combinations are determined by analysing arrays of integers matching the ids
+found in the rule. This works for most rules but not those that contain functions.
+
+Therefore, when either matching_combinations, or blocking_combinations are called
+on a rule that contains a function, an exception is raised.
+
+    rule = ArrayLogic::Rule.new 'sum(:id) > 5'
+    rule.matching_combinations   -->  raises ArrayLogic::UnableToDetermineCombinationsError
+
+Thereby handling this issue is passed back to the host application
+
+Run example.rb to see some more examples
+
+    ruby /lib/example.rb

data/lib/array_logic.rb

@@ -1,4 +1,5 @@
 require_relative('array_logic/rule')
+require_relative('array_logic/exceptions')
 module ArrayLogic
     
 end

data/lib/array_logic/exceptions.rb

@@ -0,0 +1,6 @@
+
+module ArrayLogic
+  class UnableToDetermineCombinationsError < StandardError
+
+  end
+end

data/lib/array_logic/rule.rb

@@ -65,6 +65,9 @@ module ArrayLogic
     end
     
     def combinations_of_identifiers_in_rule_that_pass(&test)
+      if function_pattern =~ rule
+        raise UnableToDetermineCombinationsError, "Unable to determine combinations for rules that include functions"
+      end
       if rule_valid?
         combinations = Array.new
         (1..id_count).each{|n| object_ids_used.combination(n).each{|c| combinations << c if test.call(c)}}

data/lib/array_logic/version.rb

@@ -1,10 +1,16 @@
 module ArrayLogic
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end
 
 # History
 # =======
 # 
+# Version 0.2.4
+# -------------
+# Adds mechanism for handling issue of being unable to determine combinations
+# for rules with functions, without increasing complexity of combinations methods.
+# Choice of how to handle the issue can be made in the host app.
+# 
 # Version 0.2.3
 # -------------
 # Bug fix: Identification of ids in rule would see a number preceded by a number 

data/test/array_logic/rule_test.rb

@@ -448,6 +448,13 @@ module ArrayLogic
       assert_equal(1, @rule.matching_combinations.length, "should not identify combinations for both occurancies of each id")
     end
     
+    def test_matching_combinations_with_function
+      @rule.rule = 'sum(:id) == 1'
+      assert_raise UnableToDetermineCombinationsError do
+        @rule.matching_combinations
+      end
+    end
+    
     def test_blocking_combinations
       @rule.rule = 't1 or t2'
       assert_equal([], @rule.blocking_combinations)
@@ -467,6 +474,13 @@ module ArrayLogic
       assert_equal([], @rule.blocking_combinations)
     end
     
+    def test_blocking_combinations_with_function
+      @rule.rule = 'sum(:id) == 1 and t1'
+      assert_raise UnableToDetermineCombinationsError do
+        @rule.blocking_combinations
+      end
+    end
+    
     def test_assigning_rule_on_creation
       text = 'a1 and a2'
       rule = Rule.new(text)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: array_logic
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
   prerelease: 
 platform: ruby
 authors:
@@ -20,6 +20,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/array_logic/version.rb
+- lib/array_logic/exceptions.rb
 - lib/array_logic/rule.rb
 - lib/array_logic.rb
 - lib/example.rb