array_logic 0.2.2 → 0.2.3

data/lib/array_logic/rule.rb

@@ -113,7 +113,7 @@ module ArrayLogic
 
     # examples: a1, a2, a33, t1
     def thing_id_pattern
-      /\w\d+/
+      /[a-zA-Z]\d+/
     end
 
     def ids_include_this_id

data/lib/array_logic/version.rb

@@ -1,10 +1,16 @@
 module ArrayLogic
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end
 
 # History
 # =======
 # 
+# Version 0.2.3
+# -------------
+# Bug fix: Identification of ids in rule would see a number preceded by a number 
+# as a valid id. So 51 would be seen as 1, and 34 as 4. Updated id pattern to 
+# only return numbers that are preceded by a letter.
+# 
 # Version 0.2.2
 # -------------
 # Refactor to allow functions to be more flexible. That's is, to handle unexpected

data/test/array_logic/rule_test.rb

@@ -414,11 +414,21 @@ module ArrayLogic
       assert_equal([1, 2, 3, 4], @rule.object_ids_used)
     end
     
-    def test_object_ids_user_does_not_return_duplicates
+    def test_object_ids_used_does_not_return_duplicates
       @rule.rule = 't1 and t2 and (2 in t1 t2)'
       assert_equal([1, 2], @rule.object_ids_used)
     end
     
+    def test_object_ids_used_with_function
+      @rule.rule = 'sum(:cope_index) > 10'
+      assert_equal([], @rule.object_ids_used)
+    end
+    
+    def test_object_ids_used_with_function_and_valid_ids
+      @rule.rule = 't1 and t2 and (sum(:cope_index) > 10)'
+      assert_equal([1, 2], @rule.object_ids_used)
+    end
+    
     def test_matching_combinations
       @rule.rule = 't1 or t2'
       assert_equal([[1], [2], [1,2]], @rule.matching_combinations)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: array_logic
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
   prerelease: 
 platform: ruby
 authors: