aroundhome_cops 4.2.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad7cf8c4f2e3bc38092798cb7b402c496e97b17860ee3b54a93c7772b31064c2
-  data.tar.gz: dfe328629f993ec3a742e71e93a6b9c633f7c115766c59b0dfa5b4c8774afc6d
+  metadata.gz: 7b3ed872a0065df50104dab56c15c0ec6112345943e4a87ccea027a956893aad
+  data.tar.gz: 6fb3f2a8f00d60815922347aec18555e06b5155af2610237f2d9223d72279c65
 SHA512:
-  metadata.gz: 30f56dec47ec145cfd8456d663cff8fba04950510d526bd8d0f04b15e3943ddc89b15bd88215e17033349de4c55223e6fb31b6a48b8e41326d2a9c0e62432b81
-  data.tar.gz: c2f76650583c22985cb277d35204f08ff32a89c54fdfa670c10b16bb72f8e47c5a85710891428948f51fa318bd18b544569cc3028e1420cd17f1851edc451bb8
+  metadata.gz: f33fcac4d0b2f1e2c2d2ddf599a0564e8e8e6a2a8c48ff2c63f46434380924ded040d93c279028d67eb9f9d490702cce0d4aef5006e0b7c71d1cf10fee5f6d2c
+  data.tar.gz: 25e603de2b851c365356fdaa260a165f3b455212952e48e2510b31bc3e976b9dc884cb90f03b4e1d23190d83bb1e4cdbbc0279360f38694301c4295be5507358

data/.ruby-version

@@ -1 +1 @@
-2.5.8
+2.6.9

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+## Version 5.0.0
+* Opt into all Rubocop offenses up until 1.35 & rspec 2.12
+* Update minimum rubocop to 1.35
+  * Dropped support for ruby < 2.6
+
+## Version 4.3.1
+* Disable updating to rubocop 1.31 as it will break our config.
+
+## Version 4.3.0
+* Disable `RSpec/PredicateMatcher` due to false positives
+
 ## Version 4.2.0
 * Add rubocop-rake as a dependency, to enforce better specs
 

data/aroundhome_cops.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
                                         .reject { |f| f.match(%r{^spec/}) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.5.0'
+  spec.required_ruby_version = '>= 2.6.0'
 
-  spec.add_dependency 'rubocop', '~> 1.22'
+  spec.add_dependency 'rubocop', '~> 1.35'
   spec.add_dependency 'rubocop-rake', '~> 0.6'
   spec.add_dependency 'rubocop-rspec', '~> 2.5'
 end

data/default.yml

@@ -53,7 +53,7 @@ Layout/LineLength:
 # long, since they are less comparable to methods and more comparable to
 # modules/classes.
 Metrics/BlockLength:
-  IgnoredMethods:
+  AllowedMethods:
     - context
     - describe
     - namespace
@@ -160,6 +160,24 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Max: 7
 
+# While well intentioned at teaching about the existence of be_something matchers
+# in RSpec, this one produces false positives on methods such as
+#
+#     expect(hash.key?('foo')).to be_truthy
+#
+# Where it suggests to change towards:
+#
+#     expect(hash).to be_key('foo')
+#
+# While this works, it is less readable. The hash IS NOT the key, but it HAS the key.
+# Similar mistakes happen for other methods (e.g. File.exist?).
+RSpec/PredicateMatcher:
+  Enabled: false
+
+# While in general 2FA is a good idea, adding 2FA to CI/CD is a difficulty.
+Gemspec/RequireMFA: # new in 1.23
+  Enabled: false
+
 # ----------------- Rubocop-forced enablements --------------
 
 # Since version 0.80 rubocop wants to cause fewer breaking changes by new cops.
@@ -168,8 +186,6 @@ RSpec/NestedGroups:
 # them below.
 # Disabled cops will appear above with a comment explaining disablement.
 
-Gemspec/DateAssignment: # (new in 1.10)
-  Enabled: true
 Layout/SpaceBeforeBrackets: # (new in 1.7)
   Enabled: true
 Lint/AmbiguousAssignment: # (new in 1.7)
@@ -258,6 +274,50 @@ Style/MultilineInPatternThen: # (new in 1.16)
   Enabled: true
 Style/QuotedSymbols: # (new in 1.16)
   Enabled: true
+Gemspec/DeprecatedAttributeAssignment: # new in 1.30
+  Enabled: true
+Layout/LineContinuationLeadingSpace: # new in 1.31
+  Enabled: true
+Layout/LineContinuationSpacing: # new in 1.31
+  Enabled: true
+Lint/ConstantOverwrittenInRescue: # new in 1.31
+  Enabled: true
+Lint/NonAtomicFileOperation: # new in 1.31
+  Enabled: true
+Lint/RefinementImportMethods: # new in 1.27
+  Enabled: true
+Lint/RequireRangeParentheses: # new in 1.32
+  Enabled: true
+Lint/UselessRuby2Keywords: # new in 1.23
+  Enabled: true
+Naming/BlockForwarding: # new in 1.24
+  Enabled: true
+Security/CompoundHash: # new in 1.28
+  Enabled: true
+Style/EmptyHeredoc: # new in 1.32
+  Enabled: true
+Style/EnvHome: # new in 1.29
+  Enabled: true
+Style/FetchEnvVar: # new in 1.28
+  Enabled: true
+Style/FileRead: # new in 1.24
+  Enabled: true
+Style/FileWrite: # new in 1.24
+  Enabled: true
+Style/MagicCommentFormat: # new in 1.35
+  Enabled: true
+Style/MapCompactWithConditionalBlock: # new in 1.30
+  Enabled: true
+Style/MapToHash: # new in 1.24
+  Enabled: true
+Style/NestedFileDirname: # new in 1.26
+  Enabled: true
+Style/ObjectThen: # new in 1.28
+  Enabled: true
+Style/OpenStructUse: # new in 1.23
+  Enabled: true
+Style/RedundantInitialize: # new in 1.27
+  Enabled: true
 
 # ----------------- Rubocop-Rspec forced enablements --------------
 RSpec/ExcessiveDocstringSpacing: # (new in 2.5)
@@ -268,3 +328,17 @@ RSpec/Rails/AvoidSetupHook: # (new in 2.4)
   Enabled: true
 RSpec/SubjectDeclaration: # (new in 2.5)
   Enabled: true
+RSpec/BeEq: # new in 2.9.0
+  Enabled: true
+RSpec/BeNil: # new in 2.9.0
+  Enabled: true
+RSpec/ChangeByZero: # new in 2.11.0
+  Enabled: true
+RSpec/VerifiedDoubleReference: # new in 2.10.0
+  Enabled: true
+RSpec/Capybara/SpecificMatcher: # new in 2.12
+  Enabled: true
+RSpec/FactoryBot/SyntaxMethods: # new in 2.7
+  Enabled: true
+RSpec/Rails/HaveHttpStatus: # new in 2.12
+  Enabled: true

data/lib/aroundhome_cops.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AroundhomeCops
-  VERSION = '4.2.0'
+  VERSION = '5.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aroundhome_cops
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Jan Sandbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-14 00:00:00.000000000 Z
+date: 2022-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '1.35'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: '1.35'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,14 +80,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Dependency and configuration for rubocop.