armitage-rubocop 1.51.0.6 → 1.58.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e77bde1b3e1b6502f2d828d6242ccc04889fe06d3e439de13eb5221156e29ce9
-  data.tar.gz: 35738f2d152e290eb5923eba76dc234d983bbddfe8463ef95eee3ad4e7daddf5
+  metadata.gz: 105b624f044e9ba370284612b43ce8546af596774d1687ad495222d94d8eacad
+  data.tar.gz: b35ae9d048b6a7addbe52f7d151b17718e9033b1551c37447c720bd413acf2c8
 SHA512:
-  metadata.gz: f723d8a08c3f1797cf9c2980d5cf6f2d0b45f9493abb66f1437ea906689ab928be85e2e705513cc66f66569ff55a9a43e187d11c518c74ae34c52ae8eb0cdb9c
-  data.tar.gz: bfa22cf84ed9580e58203c325b74d74463560ec55a716073514e0f007579f3ee8ad42a711c976a7f1cb1120396806cb2fefde5d28c689b9387b337b4ac4d4b3f
+  metadata.gz: 6ab2cd78ed64bd24dc50769bb9a46e32a08e6739e37dae478c2b41fea35616ff36fee4740c4bb114d8a6545c5b49c272b8e1120d0f7558b08dfa30fd760445ab
+  data.tar.gz: 936bdccec3600342a9216b270db644b804ad0c6eccf7e25329224df45918ef3fea7d8e4afe0a32055eee8cf65b2aa0687760bbdeec42042ea49ed55a438477f1

data/Gemfile.lock

@@ -1,84 +1,102 @@
 PATH
   remote: .
   specs:
-    armitage-rubocop (1.51.0.6)
-      rubocop (= 1.51.0)
-      rubocop-capybara (= 2.18.0)
-      rubocop-factory_bot (= 2.23.1)
-      rubocop-performance (= 1.18.0)
-      rubocop-rails (= 2.19.1)
+    armitage-rubocop (1.58.0)
+      rubocop (= 1.58.0)
+      rubocop-capybara (= 2.19.0)
+      rubocop-factory_bot (= 2.24.0)
+      rubocop-performance (= 1.19.1)
+      rubocop-rails (= 2.22.2)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.22.0)
+      rubocop-rspec (= 2.25.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.5)
+    activesupport (7.1.2)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
     ast (2.4.2)
+    base64 (0.2.0)
+    bigdecimal (3.1.4)
     coderay (1.1.3)
     concurrent-ruby (1.2.2)
-    i18n (1.13.0)
+    connection_pool (2.4.1)
+    drb (2.2.0)
+      ruby2_keywords
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    minitest (5.18.0)
+    minitest (5.20.0)
+    mutex_m (0.2.0)
     parallel (1.23.0)
-    parser (3.2.2.1)
+    parser (3.2.2.4)
       ast (~> 2.4.1)
+      racc
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (3.0.7)
+    racc (1.7.3)
+    rack (3.0.8)
     rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.8.0)
-    rexml (3.2.5)
-    rubocop (1.51.0)
+    rake (13.1.0)
+    regexp_parser (2.8.3)
+    rexml (3.2.6)
+    rubocop (1.58.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
+    rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.19.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
+    rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
-    rubocop-performance (1.18.0)
+    rubocop-performance (1.19.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.19.1)
+    rubocop-rails (2.22.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.22.0)
-      rubocop (~> 1.33)
+    rubocop-rspec (2.25.0)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
   arm64-darwin-22
+  arm64-darwin-23
 
 DEPENDENCIES
   armitage-rubocop!
   bundler (~> 2.3)
   pry (~> 0.14)
-  rake (~> 13.0)
+  rake (~> 13.1)
 
 BUNDLED WITH
    2.4.12

data/Rakefile

@@ -71,7 +71,7 @@ namespace :armitage_rubocop do
 
       # NOTE: try to load without Psych exceptions
       invalid_yamls = yamls.each_with_object([]) do |file_name, invalid_files|
-        YAML.safe_load(File.read(file_name)) rescue (invalid_files << "- \e[33m#{file_name}\e[0m")
+        YAML.safe_load_file(file_name) rescue (invalid_files << "- \e[33m#{file_name}\e[0m")
       end
 
       if invalid_yamls.empty?

data/armitage-rubocop.gemspec

@@ -6,11 +6,11 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 3.1'
 
-  spec.version     = '1.51.0.6'
+  spec.version     = '1.58.0'
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
   spec.authors     = ['Rustam Ibragimov']
-  spec.email       = ['iamdaiver@icloud.com']
+  spec.email       = ['iamdaiver@gmail.com']
   spec.homepage    = 'https://github.com/0exp/armitage'
 
   spec.summary     = 'A set of rubocop settings'
@@ -23,15 +23,15 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 1.51.0'
-  spec.add_dependency 'rubocop-performance', '= 1.18.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.19.1'
-  spec.add_dependency 'rubocop-rspec',       '= 2.22.0'
+  spec.add_dependency 'rubocop',             '= 1.58.0'
+  spec.add_dependency 'rubocop-performance', '= 1.19.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.22.2'
+  spec.add_dependency 'rubocop-rspec',       '= 2.25.0'
   spec.add_dependency 'rubocop-rake',        '= 0.6.0'
-  spec.add_dependency 'rubocop-capybara',    '= 2.18.0'
-  spec.add_dependency 'rubocop-factory_bot', '= 2.23.1'
+  spec.add_dependency 'rubocop-capybara',    '= 2.19.0'
+  spec.add_dependency 'rubocop-factory_bot', '= 2.24.0'
 
   spec.add_development_dependency 'bundler', '~> 2.3'
-  spec.add_development_dependency 'rake',    '~> 13.0'
+  spec.add_development_dependency 'rake',    '~> 13.1'
   spec.add_development_dependency 'pry',     '~> 0.14'
 end

data/lib/common/bundler.yml

@@ -1,3 +1,6 @@
+Bundler/DuplicatedGroup:
+  Enabled: true
+
 Bundler/GemComment:
   Enabled: false
 

data/lib/common/lint.yml

@@ -203,6 +203,9 @@ Lint/InterpolationCheck:
 Lint/LambdaWithoutLiteralBlock:
   Enabled: true
 
+Lint/LiteralAssignmentInCondition:
+  Enabled: true
+
 Lint/LiteralAsCondition:
   Enabled: true
 
@@ -219,6 +222,9 @@ Lint/Loop:
 Lint/MissingCopEnableDirective:
   Enabled: true
 
+Lint/MixedCaseRange:
+  Enabled: true
+
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
   # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
@@ -290,6 +296,9 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true
 
+Lint/RedundantRegexpQuantifiers:
+  Enabled: true
+
 Lint/RedundantDirGlobSort:
   Enabled: true
 

data/lib/common/performance.yml

@@ -76,6 +76,9 @@ Performance/InefficientHashSearch:
 Performance/IoReadlines:
   Enabled: true
 
+Performance/MapMethodChain:
+  Enabled: true
+
 Performance/MapCompact:
   Enabled: true
 

data/lib/common/rails.yml

@@ -4,10 +4,6 @@ Rails/AddColumnIndex:
 Rails/ActionControllerTestCase:
   Enabled: true
 
-Rails/ActionFilter:
-  Enabled: true
-  EnforcedStyle: action
-
 Rails/ActionOrder:
   Enabled: false
 
@@ -93,6 +89,9 @@ Rails/CompactBlank:
 Rails/ContentTag:
   Enabled: true
 
+Rails/DangerousColumnNames:
+  Enabled: true
+
 Rails/DotSeparatedKeys:
   Enabled: true
 
@@ -113,6 +112,7 @@ Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
   AllowToTime: true
+  AutoCorrect: true
 
 Rails/DefaultScope:
   Enabled: false
@@ -137,6 +137,9 @@ Rails/EnumHash:
   Include:
     - app/models/**/*.rb
 
+Rails/EnvLocal:
+  Enabled: true
+
 Rails/EnvironmentVariableAccess:
   Enabled: false # TODO: think about it later
   AllowReads: true
@@ -154,6 +157,7 @@ Rails/Exit:
 Rails/FilePath:
   Enabled: true
   EnforcedStyle: arguments
+  AutoCorrect: true
 
 Rails/FindBy:
   Enabled: true
@@ -194,6 +198,7 @@ Rails/IgnoredColumnsAssignment:
 
 Rails/IgnoredSkipActionFilterOption:
   Enabled: true
+  AutoCorrect: true
 
 Rails/IndexBy:
   Enabled: true
@@ -271,6 +276,10 @@ Rails/RedundantAllowNil:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantActiveRecordAllMethod:
+  Enabled: true
+  AutoCorrect: false
+
 Rails/RedundantPresenceValidationOnBelongsTo:
   Enabled: true
 
@@ -308,6 +317,9 @@ Rails/RequestReferer:
 Rails/ReversibleMigration:
   Enabled: true
 
+Rails/SelectMap:
+  Enabled: true
+
 Rails/SafeNavigation:
   Enabled: true
 
@@ -358,6 +370,10 @@ Rails/ToFormattedS:
 
 Rails/TransactionExitStatement:
   Enabled: true
+  TransactionMethods: []
+
+Rails/UnusedRenderContent:
+  Enabled: true
 
 Rails/UniqBeforePluck:
   Enabled: true
@@ -375,6 +391,7 @@ Rails/UnknownEnv:
     - test
     - staging
     - production
+    - local
 
 Rails/Validation:
   Enabled: true

data/lib/common/style.yml

@@ -15,6 +15,9 @@ Style/AndOr:
   Enabled: false
   EnforcedStyle: always
 
+Style/ArrayFirstLast:
+  Enabled: false
+
 Style/ArrayIntersect:
   Enabled: true
 
@@ -23,7 +26,6 @@ Style/ArrayCoercion:
 
 Style/ArgumentsForwarding:
   Enabled: false
-  AllowOnlyRestArgument: true
 
 Style/ArrayJoin:
   Enabled: true
@@ -579,6 +581,24 @@ Style/RaiseArgs:
 Style/RandomWithOffset:
   Enabled: true
 
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: true
+
+Style/RedundantRegexpArgument:
+  Enabled: true
+
+Style/RedundantCurrentDirectoryInPath:
+  Enabled: true
+
+Style/RedundantArrayConstructor:
+  Enabled: true
+
+Style/RedundantRegexpConstructor:
+  Enabled: true
+
+Style/RedundantFilterChain:
+  Enabled: true
+
 Style/RedundantLineContinuation:
   Enabled: true
 
@@ -663,6 +683,9 @@ Style/ReturnNil:
 Style/RedundantSelfAssignmentBranch:
   Enabled: false # NOTE: can decrease the code readability
 
+Style/SuperWithArgsParentheses:
+  Enabled: true
+
 Style/SafeNavigation:
   Enabled: true
   ConvertCodeThatCanStartToReturnNil: false
@@ -688,6 +711,9 @@ Style/SignalException:
   Enabled: true
   EnforcedStyle: only_raise
 
+Style/SingleLineDoEndBlock:
+  Enabled: true
+
 Style/SingleArgumentDig:
   Enabled: true
 
@@ -859,6 +885,9 @@ Style/WordArray:
   EnforcedStyle: percent
   MinSize: 2
 
+Style/YAMLFileRead:
+  Enabled: true
+
 Style/YodaCondition:
   Enabled: false
   EnforcedStyle: forbid_for_all_comparison_operators

data/lib/rspec/capybara.yml

@@ -1,9 +1,20 @@
 Capybara/CurrentPathExpectation:
   Enabled: true
 
+Capybara/ClickLinkOrButtonStyle:
+  Enabled: true
+
 RSpec/Capybara/FeatureMethods:
   Enabled: false
 
+Capybara/RSpec/PredicateMatcher:
+  Enabled: true
+  Strict: true
+  EnforcedStyle: inflected
+
+Capybara/RSpec/HaveSelector:
+  Enabled: false
+
 Capybara/VisibilityMatcher:
   Enabled: true
 

data/lib/rspec/factory_bot.yml

@@ -29,3 +29,6 @@ FactoryBot/RedundantFactoryOption:
 
 FactoryBot/AssociationStyle:
   Enabled: false
+
+FactoryBot/IdSequence:
+  Enabled: true

data/lib/rspec/rails.yml

@@ -15,3 +15,6 @@ RSpec/Rails/MinitestAssertions:
 
 RSpec/Rails/TravelAround:
   Enabled: false
+
+RSpec/Rails/NegationBeValid:
+  Enabled: false

data/lib/rspec/rspec.yml

@@ -63,6 +63,9 @@ RSpec/Dialect:
   Enabled: true
   PreferredMethods: {}
 
+RSpec/Eq:
+  Enabled: true
+
 RSpec/EmptyExampleGroup:
   Enabled: true
   AutoCorrect: true
@@ -118,6 +121,12 @@ RSpec/ExpectOutput:
 RSpec/FilePath:
   Enabled: false
 
+RSpec/SpecFilePathSuffix:
+  Enabled: false
+
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
 RSpec/Focus:
   Enabled: true
   AutoCorrect: true
@@ -174,6 +183,12 @@ RSpec/LetSetup:
 RSpec/MatchArray:
   Enabled: false
 
+RSpec/MetadataStyle:
+  Enabled: false
+
+RSpec/EmptyMetadata:
+  Enabled: false
+
 RSpec/MessageChain:
   Enabled: false
 
@@ -229,6 +244,9 @@ RSpec/PredicateMatcher:
     - have_http_status
     - have_been_made
 
+RSpec/ReceiveMessages:
+  Enabled: true
+
 RSpec/RedundantAround:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.51.0.6
+  version: 1.58.0
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-28 00:00:00.000000000 Z
+date: 2023-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.51.0
+        version: 1.58.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.51.0
+        version: 1.58.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 1.19.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 1.19.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.19.1
+        version: 2.22.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.19.1
+        version: 2.22.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 2.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.22.0
+        version: 2.25.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,28 +86,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.18.0
+        version: 2.19.0
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.24.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -153,7 +153,7 @@ dependencies:
 description: 'A set of rubocop settings used in my own projects.Support for: vanilla
   ruby, rspec, rails.'
 email:
-- iamdaiver@icloud.com
+- iamdaiver@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -208,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.13
+rubygems_version: 3.4.21
 signing_key:
 specification_version: 4
 summary: A set of rubocop settings