armitage-rubocop 1.10.0 → 1.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8afbab1ecfa368603af11b10060d60e87d42477cd64b8e9401fdd6e440c23cbf
-  data.tar.gz: 55bc896c32fd888d69abf34d32fe9d257ddd61dbcb6a6de830c285d1c60acb71
+  metadata.gz: 55bed071bbf70dccdff35074b5a97ab60a3cf71d639def4d9db4f8c13130f508
+  data.tar.gz: 6ca102e44ec17a96852e1ec8d65a325d9f5a502c0b0c1239706e246e17f4f5fa
 SHA512:
-  metadata.gz: 1c9abb332a11f23d27dc575295938f87b79c0d8830bd437376b36056942a76a4b68a794d017b8a0bd262a16877d95a788255ce2e4e7436591a7b469ed07dffc9
-  data.tar.gz: 632d104cf20aea5ea7e9c68a651506f1d013c4be36356086c6e3570e5fd1953b369df38f329cd4212e727ffe27204dff8a4ebe6784de03e2a99b287583c4a1e7
+  metadata.gz: 7bb7405b53235b06fedc9685094b9468b45eb7d2b7d9b08e42ca81e7f846e5fd349ee6e648189abdb4a35df08b8accfff1d8b6253efe09b51518d68d382adda8
+  data.tar.gz: 7a00d9eb867fa8cb747997d38c547bed288a694735cc34d7779af1476c13baf992856d41cb98b8a809608a1bf866e1abaa9c40d040bf6734b3b0f4f3eb56ed50

data/.rubocop.yml

@@ -4,4 +4,4 @@ inherit_from:
 
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.7.2
+  TargetRubyVersion: 3.1

data/Gemfile.lock

@@ -1,17 +1,17 @@
 PATH
   remote: .
   specs:
-    armitage-rubocop (1.8.1)
-      rubocop (= 1.10.0)
-      rubocop-performance (= 1.9.2)
-      rubocop-rails (= 2.9.1)
-      rubocop-rake (= 0.5.1)
-      rubocop-rspec (= 2.2.0)
+    armitage-rubocop (1.23.0)
+      rubocop (= 1.23.0)
+      rubocop-performance (= 1.12.0)
+      rubocop-rails (= 2.12.4)
+      rubocop-rake (= 0.6.0)
+      rubocop-rspec (= 2.6.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.3)
+    activesupport (6.1.4.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -19,54 +19,52 @@ GEM
       zeitwerk (~> 2.3)
     ast (2.4.2)
     coderay (1.1.3)
-    concurrent-ruby (1.1.8)
-    i18n (1.8.9)
+    concurrent-ruby (1.1.9)
+    i18n (1.8.11)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
     minitest (5.14.4)
-    parallel (1.20.1)
-    parser (3.0.0.0)
+    parallel (1.21.0)
+    parser (3.0.3.1)
       ast (~> 2.4.1)
-    pry (0.14.0)
+    pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rack (2.2.3)
     rainbow (3.0.0)
-    rake (13.0.3)
+    rake (13.0.6)
     regexp_parser (2.1.1)
-    rexml (3.2.4)
-    rubocop (1.10.0)
+    rexml (3.2.5)
+    rubocop (1.23.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    rubocop-performance (1.9.2)
-      rubocop (>= 0.90.0, < 2.0)
+    rubocop-ast (1.13.0)
+      parser (>= 3.0.1.1)
+    rubocop-performance (1.12.0)
+      rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.9.1)
+    rubocop-rails (2.12.4)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.90.0, < 2.0)
-    rubocop-rake (0.5.1)
-      rubocop
-    rubocop-rspec (2.2.0)
+      rubocop (>= 1.7.0, < 2.0)
+    rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.6.0)
+      rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.0.0)
-    zeitwerk (2.4.2)
+    unicode-display_width (2.1.0)
+    zeitwerk (2.5.1)
 
 PLATFORMS
-  ruby
-  x86_64-darwin-20
+  x86_64-darwin-21
 
 DEPENDENCIES
   armitage-rubocop!
@@ -75,4 +73,4 @@ DEPENDENCIES
   rake (~> 13.0)
 
 BUNDLED WITH
-   2.2.3
+   2.2.31

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '1.10.0'
+  spec.version     = '1.23.0'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,11 +22,11 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 1.10.0'
-  spec.add_dependency 'rubocop-performance', '= 1.9.2'
-  spec.add_dependency 'rubocop-rails',       '= 2.9.1'
-  spec.add_dependency 'rubocop-rspec',       '= 2.2.0'
-  spec.add_dependency 'rubocop-rake',        '= 0.5.1'
+  spec.add_dependency 'rubocop',             '= 1.23.0'
+  spec.add_dependency 'rubocop-performance', '= 1.12.0'
+  spec.add_dependency 'rubocop-rails',       '= 2.12.4'
+  spec.add_dependency 'rubocop-rspec',       '= 2.6.0'
+  spec.add_dependency 'rubocop-rake',        '= 0.6.0'
 
   spec.add_development_dependency 'bundler', '~> 2.2'
   spec.add_development_dependency 'rake',    '~> 13.0'

data/lib/common/bundler.yml

@@ -1,11 +1,18 @@
 Bundler/GemComment:
   Enabled: false
 
+Bundler/GemVersion:
+  Enabled: false
+
+Bundler/GemFilename:
+  Enabled: false
+
 Bundler/DuplicatedGem:
   Enabled: true
 
 Bundler/InsecureProtocolSource:
   Enabled: true
+  AllowHttpProtocol: false
 
 Bundler/OrderedGems:
   Enabled: false

data/lib/common/gemspec.yml

@@ -15,3 +15,6 @@ Gemspec/RequiredRubyVersion:
 
 Gemspec/RubyVersionGlobalsUsage:
   Enabled: true
+
+Gemspec/RequireMFA:
+  Enabled: false # NOTE: it is strongly relates to the chosen business practics

data/lib/common/layout.yml

@@ -6,6 +6,7 @@ Layout/AccessModifierIndentation:
 Layout/ArgumentAlignment:
   Enabled: true
   IndentationWidth: ~
+  EnforcedStyle: with_first_argument
 
 Layout/ArrayAlignment:
   Enabled: true
@@ -29,6 +30,13 @@ Layout/BeginEndAlignment:
   EnforcedStyleAlignWith: start_of_line
   Severity: warning
 
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+
+Layout/RedundantLineBreak:
+  InspectBlocks: false
+  Enabled: true
+
 Layout/BlockAlignment:
   Enabled: true
   EnforcedStyleAlignWith: either
@@ -110,7 +118,7 @@ Layout/EmptyLinesAroundAttributeAccessor:
 Layout/EmptyLineBetweenDefs:
   Enabled: true
   NumberOfEmptyLines: 1
-  AllowAdjacentOneLineDefs: false
+  AllowAdjacentOneLineDefs: true
   EmptyLineBetweenMethodDefs: true
   EmptyLineBetweenClassDefs: true
   EmptyLineBetweenModuleDefs: true

data/lib/common/lint.yml

@@ -2,6 +2,7 @@ Lint/AmbiguousAssignment:
   Enabled: false
 
 Lint/AmbiguousBlockAssociation:
+  IgnoredMethods: []
   Enabled: true
 
 Lint/AmbiguousOperator:
@@ -10,6 +11,13 @@ Lint/AmbiguousOperator:
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
+Lint/AmbiguousRange:
+  Enabled: true
+  RequireParenthesesForMethodChains: false
+
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: false
+
 Lint/AssignmentInCondition:
   Enabled: false
   AllowSafeAssignment: true
@@ -88,11 +96,16 @@ Lint/ElseLayout:
 Lint/EmptyBlock:
   Enabled: true
   AllowComments: true
+  AllowEmptyLambdas: true
 
 Lint/EmptyClass:
   Enabled: false
   AllowComments: true
 
+Lint/EmptyInPattern:
+  Enabled: false
+  AllowComments: true
+
 Lint/EmptyConditionalBody:
   Enabled: true
   AllowComments: true
@@ -137,11 +150,16 @@ Lint/FormatParameterMismatch:
 Lint/SelfAssignment:
   Enabled: true
 
+Layout/SingleLineBlockChain:
+  Enabled: false
+
 Lint/StructNewOverride:
   Enabled: true
 
 Lint/SuppressedException:
-  Enabled: false
+  AllowComments: true
+  AllowNil: true
+  Enabled: true # NOTE: experimental!
 
 Lint/HashCompareByIdentity:
   Enabled: false
@@ -155,6 +173,9 @@ Lint/IdentityComparison:
 Lint/ImplicitStringConcatenation:
   Enabled: true
 
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: true
+
 Lint/IneffectiveAccessModifier:
   Enabled: true
 
@@ -194,7 +215,6 @@ Lint/MissingSuper:
 
 Lint/MultipleComparison:
   Enabled: true
-  AllowMethodComparison: true
 
 Lint/NestedMethodDefinition:
   Enabled: true
@@ -236,6 +256,9 @@ Lint/PercentStringArray:
 Lint/PercentSymbolArray:
   Enabled: true
 
+Lint/UselessRuby2Keywords:
+  Enabled: true
+
 Lint/RaiseException:
   Enabled: true
   AutoCorrect: false

data/lib/common/naming.yml

@@ -30,6 +30,9 @@ Naming/HeredocDelimiterCase:
 Naming/HeredocDelimiterNaming:
   Enabled: false
 
+Naming/InclusiveLanguage:
+  Enabled: false
+
 Naming/MemoizedInstanceVariableName:
   Enabled: false
 

data/lib/common/performance.yml

@@ -28,6 +28,9 @@ Performance/Casecmp:
 Performance/ChainArrayAllocation:
   Enabled: false
 
+Performance/ConcurrentMonotonicTime:
+  Enabled: true
+
 Performance/CompareWithBlock:
   Enabled: true
 
@@ -73,6 +76,9 @@ Performance/InefficientHashSearch:
 Performance/IoReadlines:
   Enabled: true
 
+Performance/MapCompact:
+  Enabled: true
+
 Performance/MethodObjectAsBlock:
   Enabled: true
 
@@ -98,6 +104,12 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 1
 
+Performance/RedundantSplitRegexpArgument:
+  Enabled: true
+
+Performance/RedundantEqualityComparisonBlock:
+  Enabled: false
+
 Performance/RegexpMatch:
   Enabled: true
 
@@ -107,6 +119,9 @@ Performance/ReverseEach:
 Performance/ReverseFirst:
   Enabled: true
 
+Performance/SelectMap:
+  Enabled: true
+
 Performance/Size:
   Enabled: true
 

data/lib/common/rails.yml

@@ -1,3 +1,6 @@
+Rails/AddColumnIndex:
+  Enabled: false # NOTE: cop works incorrectly with `Sequel` (sequel supports :index in add_column)
+
 Rails/ActionFilter:
   Enabled: true
   EnforcedStyle: action
@@ -15,6 +18,15 @@ Rails/ActiveRecordOverride:
   Include:
     - app/models/**/*.rb
 
+Rails/EagerEvaluationLogMessage:
+  Enabled: true
+
+Rails/ExpandedDateRange:
+  Enabled: true
+
+Rails/UnusedIgnoredColumns:
+  Enabled: false
+
 Rails/ActiveSupportAliases:
   Enabled: true
 
@@ -39,6 +51,13 @@ Rails/AttributeDefaultBlockValue:
 Rails/ArelStar:
   Enabled: true
 
+Rails/RequireDependency:
+  Enabled: true
+  # NOTE: `require_dependency` is obsolete when you use `Zeitwerk`
+
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: true
+
 Rails/RakeEnvironment:
   Enabled: true
   AutoCorrect: true
@@ -65,6 +84,7 @@ Rails/ContentTag:
 Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
+  AllowToTime: true
 
 Rails/DefaultScope:
   Enabled: false
@@ -89,6 +109,11 @@ Rails/EnumHash:
   Include:
     - app/models/**/*.rb
 
+Rails/EnvironmentVariableAccess:
+  Enabled: false # TODO: think about it later
+  AllowReads: true
+  AllowWrites: false
+
 Rails/EnumUniqueness:
   Enabled: true
 
@@ -104,6 +129,7 @@ Rails/FilePath:
 
 Rails/FindBy:
   Enabled: true
+  IgnoreWhereFirst: true
 
 Rails/FindById:
   Enabled: true
@@ -123,6 +149,9 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: false
 
+Rails/I18nLocaleAssignment:
+  Enabled: false
+
 Rails/IgnoredSkipActionFilterOption:
   Enabled: true
 
@@ -253,10 +282,16 @@ Rails/SkipsModelValidations:
 Rails/SquishedSQLHeredocs:
   Enabled: true
 
+Rails/RedundantTravelBack:
+  Enabled: false # NOTE: can affect the readability
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
 
+Rails/TimeZoneAssignment:
+  Enabled: false
+
 Rails/UniqBeforePluck:
   Enabled: true
   EnforcedStyle: conservative

data/lib/common/security.yml

@@ -13,3 +13,6 @@ Security/Open:
 
 Security/YAMLLoad:
   Enabled: false
+
+Security/IoMethods:
+  Enabled: false

data/lib/common/style.yml

@@ -245,6 +245,7 @@ Style/HashAsLastArrayItem:
   AutoCorrect: true
 
 Style/HashConversion:
+  AllowSplatArgument: true
   Enabled: false
 
 Style/HashExcept:
@@ -320,8 +321,13 @@ Style/LineEndConcatenation:
   Enabled: true
 
 Style/MethodCallWithArgsParentheses:
-  Enabled: false
-  IgnoredMethods: []
+  Enabled: false # NOTE: experimental!
+  EnforcedStyle: require_parentheses
+  IgnoreMacros: true
+  AllowParenthesesInMultilineCall: true
+  AllowParenthesesInChaining: true
+  AllowParenthesesInCamelCaseMethod: true
+  AllowParenthesesInStringInterpolation: true
 
 Style/MethodCallWithoutArgsParentheses:
   Enabled: true
@@ -361,6 +367,9 @@ Style/MultilineIfModifier:
 Style/MultilineIfThen:
   Enabled: true
 
+Style/MultilineInPatternThen:
+  Enabled: true
+
 Style/MultilineMemoization:
   Enabled: true
   EnforcedStyle: keyword
@@ -425,6 +434,13 @@ Style/NonNilCheck:
 Style/Not:
   Enabled: true
 
+Style/NumberedParameters:
+  Enabled: false
+
+Style/NumberedParametersLimit:
+  Max: 1_000_000
+  Enabled: true
+
 Style/NumericLiteralPrefix:
   Enabled: true
   EnforcedOctalStyle: zero_with_o
@@ -441,6 +457,9 @@ Style/NumericPredicate:
 Style/OneLineConditional:
   Enabled: true
 
+Style/OpenStructUse:
+  Enabled: true
+
 Style/OptionHash:
   Enabled: false
 
@@ -542,6 +561,9 @@ Style/RescueStandardError:
 Style/ReturnNil:
   Enabled: false
 
+Style/RedundantSelfAssignmentBranch:
+  Enabled: false # NOTE: can decrease the code readability
+
 Style/SafeNavigation:
   Enabled: true
   ConvertCodeThatCanStartToReturnNil: false
@@ -549,6 +571,9 @@ Style/SafeNavigation:
 Style/Sample:
   Enabled: true
 
+Style/SelectByRegexp:
+  Enabled: false
+
 Style/SelfAssignment:
   Enabled: true
 
@@ -593,6 +618,10 @@ Style/StderrPuts:
 
 Style/StringConcatenation:
   Enabled: true
+  Mode: aggressive
+
+Style/StringChars:
+  Enabled: true
 
 Style/StringHashKeys:
   Enabled: false
@@ -624,6 +653,10 @@ Style/SymbolLiteral:
   Enabled: true
 
 Style/SymbolProc:
+  AllowMethodsWithArguments: true
+  IgnoredMethods:
+    - respond_to
+    - define_method
   Enabled: true
 
 Style/SwapValues:
@@ -634,6 +667,9 @@ Style/TernaryParentheses:
   EnforcedStyle: require_parentheses_when_complex
   AllowSafeAssignment: true
 
+Style/TopLevelMethodDefinition:
+  Enabled: true
+
 Style/TrailingBodyOnClass:
   Enabled: true
 
@@ -672,6 +708,10 @@ Style/TrivialAccessors:
 Style/UnlessElse:
   Enabled: false
 
+Style/UnlessLogicalOperators:
+  EnforcedStyle: forbid_mixed_logical_operators
+  Enabled: false
+
 Style/RedundantCapitalW:
   Enabled: true
 
@@ -718,3 +758,7 @@ Style/YodaCondition:
 
 Style/ZeroLengthPredicate:
   Enabled: true
+
+Style/QuotedSymbols:
+  Enabled: true
+  EnforcedStyle: same_as_string_literals

data/lib/rspec/rails.yml

@@ -1,2 +1,5 @@
 RSpec/Rails/HttpStatus:
   Enabled: false
+
+RSpec/Rails/AvoidSetupHook:
+  Enabled: true

data/lib/rspec/rspec.yml

@@ -80,6 +80,9 @@ RSpec/ExampleWording:
 RSpec/ExpectActual:
   Enabled: true
 
+RSpec/ExcessiveDocstringSpacing:
+  Enabled: true
+
 RSpec/ExpectChange:
   Enabled: true
   EnforcedStyle: block
@@ -103,6 +106,9 @@ RSpec/HookArgument:
 RSpec/HooksBeforeExamples:
   Enabled: true
 
+RSpec/IdenticalEqualityAssertion:
+  Enabled: true
+
 RSpec/ImplicitBlockExpectation:
   Enabled: false
 
@@ -234,6 +240,9 @@ RSpec/SingleArgumentMessageChain:
 RSpec/SubjectStub:
   Enabled: true
 
+RSpec/SubjectDeclaration:
+  Enabled: true
+
 RSpec/StubbedMock:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.23.0
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-27 00:00:00.000000000 Z
+date: 2021-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,70 +16,70 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: 1.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: 1.23.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.9.2
+        version: 1.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.9.2
+        version: 1.12.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.12.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.1
+        version: 2.12.4
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.2.0
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.5.1
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -180,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: A set of rubocop settings