arma_fixer 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a09ab5b4665de2f3e31bb39cc5767ded2c79ce76
-  data.tar.gz: 1926b5464ae286f739ac5f6d9920e5ffb74f9661
+  metadata.gz: 1e2bdf6561c52f18e15c6b76151cf34cefaecb85
+  data.tar.gz: 0dcb794c30751289f6734a39c40366788b875b4b
 SHA512:
-  metadata.gz: 40afc47969507acef1ef8a5444f8d2408cd11584501981ba9f7b286d8b17e666466e1042f86317ede86a377576154c8bd1691252a8c8337670b9fb61a0fd84a4
-  data.tar.gz: 9df60ad0aba67b5d7cb24fb2b7c52384f677ee9da12d4d146b2e60594bf54cc2a12dacdb882cff78190ec82d1edc691dbf14653e27427e5b645d3b5dc7f69035
+  metadata.gz: 05d6173c50949a96c3ef0fab29e098b729658670c761176aaea4600ad7a821b1f9440cb0d0b0c8e063dff408875976f7d4eec44e8218b92109d4cb77159875f2
+  data.tar.gz: 716861dbe6324fe61377eee929af7f89378d433c86ef6800b64bca3f98e875bf0b71a0466c25b27aab4e8132b9d794d60e7893cf3b435dc71d089f866493cb7f

data/lib/arma_fixer.rb

@@ -4,18 +4,18 @@ require_relative './arma_fixer/execute'
 require_relative './arma_fixer/railtie' if defined?(Rails)
 
 module ArmaFixer
-  mattr_accessor :root_path
+  self.class.delegate :show, to: Execute
 
   module_function
 
   def run!
     start_time = Time.now
-    puts 'Started ArmaFixer task...'
+    show 'Started ArmaFixer task...'
 
     ArmaFixer::Validation.run!
     ArmaFixer::Execute.run!
 
     time_taken = (Time.now - start_time).round(2)
-    puts "Completed ArmaFixer task in #{time_taken} seconds."
+    show "Completed ArmaFixer task in #{time_taken} seconds."
   end
 end

data/lib/arma_fixer/execute.rb

@@ -4,45 +4,83 @@ module ArmaFixer
 
     def run!
       ArmaFixer::MODELS_HASH.each do |model_name, columns|
-        model = ArmaFixer::APP.const_get(model_name)
+        records = ArmaFixer::APP.const_get(model_name).where('')
+        count = records.count
+        if proceed?(model_name, count)
+          show "Processing #{count} #{model_name} records. Please wait..."
+          saved_record_ids = []
+          process_records(records, columns, saved_record_ids)
+          show "Saved #{model_name} IDs: #{saved_record_ids.sort!}"
+          close_files
+        else
+          show "Skipped processing #{model_name} records."
+          next
+        end
+      end
+    end
+
+    def show(*args)
+      puts(*args)
+    end
 
-        model.where('').each do |record|
-          save_record = false
-          columns.each do |attr, image_path|
-            value = record.public_send(attr)
-            next if checker.call(value)
+    private
 
-            save_record = true
-            method = "#{attr}="
-            image = image_path ? File.open(image_path) : default_image
+    module_function
 
-            value = record.public_send(method, image)
-          end
+    def process_records(records, columns, saved_record_ids)
+      records.find_each do |record|
+        save_record = false
 
-          if save_record
-            record.save
-            puts "Saved #{model_name} ID #{record.id}"
-          end
+        columns.each do |attr, path|
+          next if valid_value?(record, attr)
+          file = fetch_file(path)
+          record.public_send("#{attr}=", file)
+          save_record = true
         end
+
+        save_id(record, saved_record_ids) if save_record
       end
     end
 
-    private
-
-    module_function
+    def proceed?(model_name, count)
+      if ENV['ARMAF_CONFIRMATION'] == 'true'
+        show "#{model_name} has #{count} records. Do you want to continue? (yes(y) / anything-else)"
+        input = STDIN.gets.chomp
+        %w(y yes).include?(input)
+      else
+        true
+      end
+    end
 
-    def default_image
-      @default_image ||= File.open(ArmaFixer::DEFAULT_IMAGE_PATH) if defined?(ArmaFixer::DEFAULT_IMAGE_PATH)
+    def valid_value?(record, attr)
+      value = record.public_send(attr)
+      checker.call(value)
     end
 
     def checker
-      @checker ||= begin
-        if defined?(ArmaFixer::ATTR_CHECKER)
-          ArmaFixer::ATTR_CHECKER
-        else
-          -> (v) { !v.nil? }
-        end
+      if defined?(ArmaFixer::ATTR_CHECKER)
+        ArmaFixer::ATTR_CHECKER
+      else
+        -> (v) { !v.nil? }
       end
     end
+
+    def fetch_file(path)
+      file_path = path || ArmaFixer::DEFAULT_IMAGE_PATH
+      files_hash[path] ||= File.open(file_path)
+    end
+
+    def files_hash
+      @files_hash ||= {}
+    end
+
+    def close_files
+      files_hash.each_value.reject(&:autoclose?).each(&:close)
+    end
+
+    def save_id(record, ids)
+      record.save(validate: false)
+      ids << record.id
+    end
   end
 end

data/lib/arma_fixer/version.rb

@@ -1,3 +1,3 @@
 module ArmaFixer
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/lib/tasks/rake_spec.rb

@@ -16,8 +16,9 @@ describe Rake do
   end
 
   let(:user_model) do
-    klass = Class.new
-    klass.class_eval do
+    next app::User if defined?(app::User)
+
+    app.const_set(:User, Class.new do
       attr_accessor :code_file, :id
       def save
         true
@@ -26,22 +27,15 @@ describe Rake do
       def self.ancestors
         [ActiveRecord::Base, *super]
       end
-    end
-
-    app.const_set(:User, klass) unless defined?(app::User)
-    app::User
+    end)
   end
 
   let(:user_one) { user_model.new }
-  let(:user_two) do
-    user_model.new.tap do |user|
-      user.code_file = 123
-    end
-  end
+  let(:user_two) { user_model.new.tap { |u| u.code_file = 123 } }
   let(:users_list) { [user_one, user_two] }
 
   before do
-    allow(ArmaFixer).to receive(:puts).with(any_args) # suppressing output
+    allow(ArmaFixer::Execute).to receive(:show).with(any_args).and_return(nil)
 
     expect(user_one).to receive(:save)
     expect(user_two).to_not receive(:save)
@@ -50,6 +44,10 @@ describe Rake do
     dc_task.define_task(:environment)
     allow(user_model).to receive(:where).with('').and_return(users_list)
 
+    users_list.class_eval do
+      alias_method :find_each, :each
+    end
+
     stub_const('ArmaFixer::APP', app)
     stub_const('ArmaFixer::MODELS_HASH', models_hash)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arma_fixer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Syed Humza Shah
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-12-02 00:00:00.000000000 Z
+date: 2015-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.10.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement