ariejan-warcraft_armory 1.0.0 → 1.0.1

data/Changelog

@@ -1,2 +1,6 @@
+2009-02-03
+ * [1.0.1] ariejan - Bumped to 1.0.1
+ * ariejan - Separated Armory and Character into a module named Warcraft.
+ * ariejan - Updated README to reflect the correct naming of the gem.
 2008-08-14
  * [1.0.0] ariejan - Initial release

data/README.textile

@@ -22,11 +22,14 @@ h2. Download and installation
 
 Simply install the RubyGem and require it in your project. If you're on rails, require it in your config/environment.rb.
 
-<pre>gem install ariejan-warcraft-armory --source http://gems.github.com</pre>
+<pre>gem install ariejan-warcraft_armory --source http://gems.github.com</pre>
 
 And require it when you need it:
 
-<pre><code>require 'warcraft-armory'</code></pre>
+<pre><code>
+require 'rubygems'
+require 'warcraft_armory'
+</code></pre>
 
 Add the following to your environment.rb if you want to use Rails 2.1's dependency manager (which is highly recommended):
 
@@ -36,9 +39,9 @@ Add the following to your environment.rb if you want to use Rails 2.1's dependen
 
 h2. Usage
 
-<pre><code>character = WarcraftAmory.find(:eu, 'Aszune', 'Nosius')</code></pre>
+<pre><code>character = Warcraft::Amory.find(:eu, 'Aszune', 'Adries')</code></pre>
 
-This will either return a WarcraftCharacter object or nil when not character information was found. 
+This will either return a Warcraft::Character object or nil when not character information was found. 
 
 h2. More Information
 

data/lib/warcraft_armory.rb

@@ -1,34 +1,43 @@
 require 'hpricot'
 require 'open-uri'
 
-class WarcraftCharacter
-  attr_accessor :name, :level, :guild, :race, :class_name
-end
-
-class WarcraftArmory  
-  # Find a WoW character
-  #
-  # +location+ defines the server location, valid (tested) options are :eu or :us
-  # +realm+ the realm where your character is. E.g. "Aszune"
-  # +character_name+ the name of your character. E.g. "Adries"
-  def self.find(location, realm, character_name)
-    self.parse_html(Hpricot(open("http://#{location.to_s}.wowarmory.com/character-sheet.xml?r=#{realm}&n=#{character_name}")))
+module Warcraft
+  class Character
+    attr_accessor :name, :level, :guild, :race, :class_name, :armory_url
   end
+
+  class Armory  
+    # Find a WoW character
+    #
+    # +location+ defines the server location, valid (tested) options are :eu or :us
+    # +realm+ the realm where your character is. E.g. "Aszune"
+    # +character_name+ the name of your character. E.g. "Adries"
+    def self.find(location, realm, character_name)
+      self.parse_html("http://#{location.to_s}.wowarmory.com/character-sheet.xml?r=#{realm}&n=#{character_name}")
+    end
   
-  protected
+    protected
   
-  def self.parse_html(html)
-    char = WarcraftCharacter.new
+    def self.process(url)
+      html = Hpricot(open(url))
+      parse_html(html, url)
+    end
+  
+    def self.parse_html(html, url)
+      char = Warcraft::Character.new
    
-    details = (html/"div.character-outer").inner_text.strip.split("\n")
-    small_details = details[4].split('?')
-    
-    char.name       = details[0]
-    char.guild      = details[2]
-    char.level      = small_details[1]
-    char.race       = small_details[2]
-    char.class_name = small_details[3]
+      details = (html/"div.character-outer").inner_text.strip.split("\n")
+      small_details = details[4].split('?')
+
+      char.armory_url = url
+      char.name       = details[0]
+      char.guild      = details[2]
+      char.level      = small_details[1]
+      char.race       = small_details[2]
+      char.class_name = small_details[3]
     
-    char
-  end
-end
+      char
+    end
+  end # class Armory
+
+end # module Warcraft

data/test/warcraft_armory_test.rb

@@ -24,8 +24,9 @@ class WarcraftArmoryTest < Test::Unit::TestCase
   end
   
   def test_character_loading
-    character = WarcraftArmory.parse_html(@html)
+    character = Warcraft::Armory.parse_html(@html, "http://armory_url")
     
+    assert_equal 'http://armory_url', character.armory_url
     assert_equal 'Adries', character.name
     assert_equal '13', character.level
     assert_equal 'Human', character.race    
@@ -33,6 +34,6 @@ class WarcraftArmoryTest < Test::Unit::TestCase
     
     assert_equal 'The Justice League', character.guild
     
-    assert_equal WarcraftCharacter, character.class
+    assert_equal Warcraft::Character, character.class
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ariejan-warcraft_armory
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors: 
 - Ariejan de Vroom