ares.rb 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 86fcb669db898aaa5c0b99ca572e0400c1eaf3d1
-  data.tar.gz: e7f779fba64ca7912a1802899108615e7ce01b73
+SHA256:
+  metadata.gz: f91b5af9bca65eb5d80708b5abf1900fd66565e6132f1936e8a51c348c04d84e
+  data.tar.gz: fd81071e422c3ba4aa53325879774cf4bb36c0fa9a02399f1e1e6d1540f23cee
 SHA512:
-  metadata.gz: 16c156fb20b4fbee8d5f4228a6428262e57fb76c92899ea1cf1df05738d9a422254f52ff248862699159d29bcd18394873366d9607716c58df5fd6d9b248b208
-  data.tar.gz: 17230015bc4b2fb5b7f56b4e4e1aa47b9d39ee787838ad3dc5272322b343f1799fd4a62d74d3b233df730e7c5f93ccc45e6062b6ecfecb2b22f776a5c25e74fe
+  metadata.gz: e066a7e10bba0b844427f77ffc15f1bd20600fced8419971e413b5b95fa2ca5da13f4e3a3edcb63b4bd2e37cc92ad7df26c3f3eef1256594bc22e9980fcbf1be
+  data.tar.gz: a5a8e93814b4384c91c8aaba681db4e9ca24a8613ee39d7ebc59d180949aac589480aebbfe04d2ba241c1933f1ecf3ec9af8e6730b4e753e432439c5d291454e

data/.rubocop.yml

@@ -0,0 +1,23 @@
+AllCops:
+  Exclude:
+    - 'ares.gemspec'
+    - 'spec/**/*'
+  TargetRubyVersion: 2.3
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 89
+
+Documentation:
+  Enabled: false
+
+Naming/VariableName:
+  Enabled: false
+
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+Style/MultilineIfModifier:
+  Enabled: false

data/.travis.yml

@@ -1,7 +1,38 @@
 language: ruby
 rvm:
   - 2.3.1
-script: bundle exec rspec
-addons:
-  code_climate:
-    repo_token: 6a9c9df74fe9e772f1d98e955eaacd1804985c563ede95f401962917112884bf
+  - 2.4.5
+  - 2.5.3
+  - 2.6.0
+
+stages:
+  - code-quality
+  - test
+
+jobs:
+  include:
+    - rvm: 2.3.1
+      stage: code-quality
+      script: bundle exec rubocop
+    - rvm: 2.3.1
+      stage: test
+      script: bundle exec rspec
+    - rvm: 2.4.5
+      stage: code-quality
+      script: bundle exec rubocop
+    - rvm: 2.4.5
+      stage: test
+      script: bundle exec rspec
+    - rvm: 2.5.3
+      stage: code-quality
+      script: bundle exec rubocop
+    - rvm: 2.5.3
+      stage: test
+      script: bundle exec rspec
+    - rvm: 2.6.0
+      stage: code-quality
+      script: bundle exec rubocop
+    - rvm: 2.6.0
+      stage: test
+      script: bundle exec rspec
+

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in ares.gemspec

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/ares.gemspec

@@ -1,30 +1,33 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ares/version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'ares.rb'
   spec.version       = Ares::VERSION
-  spec.authors       = ['Ondřej Svoboda','Bohuslav Blin']
+  spec.authors       = ['Ondřej Svoboda', 'Bohuslav Blin']
   spec.email         = ['blin@uol.cz']
 
   spec.summary       = 'ARES library'
   spec.description   = 'Gem for accesing business information from ARES database.'
-  spec.homepage      = "http://www.uol.cz"
+  spec.homepage      = 'http://www.uol.cz'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
   spec.add_dependency 'ico-validator', '~> 0.4'
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'rails'
   spec.add_development_dependency 'rake', '~> 11.0'
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'webmock'
+  spec.add_development_dependency 'rubocop'
   spec.add_development_dependency 'vcr'
-  spec.add_development_dependency 'rails'
+  spec.add_development_dependency 'webmock'
 
   spec.add_runtime_dependency 'httparty'
   spec.add_runtime_dependency 'nokogiri'
+  spec.add_runtime_dependency 'activesupport'
 end

data/bin/console

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'ares'
+require 'pry'
+Pry.start

data/lib/ares.rb

@@ -1,9 +1,23 @@
+# frozen_string_literal: true
+
 require 'httparty'
 require 'nokogiri'
+require 'active_support/core_ext/hash'
+
 require 'ares/version'
 require 'ares/errors'
 require 'ares/logging'
-require 'ares/client'
+require 'ares/http'
+
+require 'ares/responses'
+require 'ares/responses/base'
+require 'ares/responses/standard'
+require 'ares/responses/basic'
+
+require 'ares/client/base'
+require 'ares/client/standard'
+require 'ares/client/basic'
+
 require 'ico-validator'
 
 module Ares
@@ -20,27 +34,30 @@ module Ares
   class << self
     include Ares::Logging
 
-    # Returns standard client
-    # @returns [Client::Standard]
-    def client
-      @client ||= Client.standard
-    end
-
     # @see Client::Standard#call
     # @return [Responses::StandardResponse::Record]
     def standard(options)
       validate_ico_format(options[:ico])
-      response = client.call(options)
-      fail ArgumentError, "Arguments #{options} are invalid" if response.error?
+      response = Client::Standard.call(options)
+      raise ArgumentError, "Arguments #{options} are invalid" if response.error?
+
+      response.record
+    end
+
+    # @see Client::Basic#call
+    # @return [Responses::NoIdeaNow::Record]
+    def basic(options)
+      validate_ico_format(options[:ico])
+      response = Client::Basic.call(options)
+      raise ArgumentError, "Arguments #{options} are invalid" if response.error?
+
       response.record
     end
 
     private
 
     def validate_ico_format(ico)
-      unless IcoValidation.valid_ico?(ico)
-        fail ArgumentError, "ICO '#{ico}' is invalid"
-      end
+      raise ArgumentError, "ICO '#{ico}' is invalid" unless IcoValidation.valid_ico?(ico)
     end
   end
 end

data/lib/ares/client/base.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+# require 'ares/responses/standard_response'
+
+module Ares
+  module Client
+    class Base
+      include Ares::Http
+
+      def self.call(opts)
+        new.call(opts)
+      end
+
+      def call(opts)
+        xml = get(self.class::ENDPOINT, opts)
+        document = Nokogiri::XML(xml)
+        process_response(document)
+      end
+
+      protected
+
+      def process_response(_document)
+        raise NotImplementedError, "#{self.class} must implement process_response}"
+      end
+    end
+  end
+end

data/lib/ares/client/basic.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+##
+# From what I can quickly find I can only search by ICO
+# at least for the time being...
+#
+module Ares
+  module Client
+    class Basic < Base
+      ENDPOINT = 'https://wwwinfo.mfcr.cz/cgi-bin/ares/darv_bas.cgi'
+
+      def call(opts)
+        xml = get(self.class::ENDPOINT, opts.merge!(ver: '1.0.2'))
+        process_response(xml)
+      end
+
+      private
+
+      def process_response(document)
+        Ares::Responses::Basic.new(document)
+      end
+    end
+  end
+end

data/lib/ares/client/standard.rb

@@ -1,11 +1,11 @@
-require 'ares/responses/standard_response'
+# frozen_string_literal: true
 
 module Ares
   module Client
-    class Standard
+    class Standard < Base
       ENDPOINT = 'http://wwwinfo.mfcr.cz/cgi-bin/ares/darv_std.cgi'
 
-      include Ares::Http
+      private
 
       # Search for standard entity's identification data
       #
@@ -24,11 +24,9 @@ module Ares
       # @option opts [Integer] :diakritika (1) [0, 1]
       # @option opts [String] :czk (iso) Encoding [iso, utf]
       # @returns [Ares::Responses::StandardResponse]
-      def call(opts)
-        xml = get(ENDPOINT, opts)
-        document = Nokogiri::XML(xml)
-        Ares::Responses::StandardResponse.new(document)
+      def process_response(document)
+        Ares::Responses::Standard.new(document)
       end
     end
   end
-end
+end

data/lib/ares/errors.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module Ares
-  class AresError < RuntimeError;
+  class AresError < RuntimeError
   end
-  class RecordNotFound < AresError;
+  class RecordNotFound < AresError
   end
-end
+end

data/lib/ares/http.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ares
   module Http
     def get(url, params = {})

data/lib/ares/logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'logger'
 
 module Ares
@@ -6,4 +8,4 @@ module Ares
       @logger ||= Logger.new(STDOUT)
     end
   end
-end
+end

data/lib/ares/responses.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ares
   module Responses
     class TextCode
@@ -19,9 +21,9 @@ module Ares
     end
 
     class Error < TextCode
-      def error?; true end
+      def error?
+        true
+      end
     end
   end
 end
-
-require 'ares/responses/standard_response'

data/lib/ares/responses/base.rb

@@ -0,0 +1,64 @@
+module Ares
+  module Responses
+    class Base
+      include Enumerable
+
+      # @!attribute [r] xml_document
+      #   @return [String] XML Document returned by ares
+      # @!attribute [r] time
+      #   @return [String] Created at
+      # @!attribute [r] count
+      #   @return [String] Element count
+      # @!attribute [r] type
+      #   @return [String] 'Standard'
+      # @!attribute [r] output_format
+      #   @return [String] 'XML'
+      # @!attribute [r] xslt
+      #   @return [String] 'klient'
+      # @!attribute [r] validation_xslt
+      #   @return [String] Path to xsl document
+      # @!attribute [r] id
+      #   @return [String] ID
+      attr_reader :xml_document, :time, :count, :type,
+                  :output_format, :xslt, :validation_xslt, :id
+
+      # Returns response with found company
+      # or nil if not found.
+      #
+      # @returns [Response, NilClass] response
+      def response
+        @content.first
+      end
+
+      def record
+        response ? response.records.first : nil
+      end
+
+      def error?
+        any?(&:error?)
+      end
+
+      def each(&block)
+        @content.each(&block)
+      end
+
+      def to_xml
+        @xml_document.to_xml
+      end
+
+      protected
+
+      # rubocop:disable Metrics/AbcSize
+      def assign_base_attributes(attributes)
+        @time = attributes['odpoved_datum_cas'].to_s
+        @count = attributes['odpoved_pocet'].to_s
+        @type = attributes['odpoved_typ'].to_s # musi byt 'Standard'
+        @output_format = (attributes['vystup_format'] || 'XML').to_s
+        @xslt = (attributes['xslt'] || 'klient').to_s
+        @validation_xslt = attributes['validation_XSLT'].to_s
+        @id = attributes['Id'].to_s
+      end
+      # rubocop:enable Metrics/AbcSize
+    end
+  end
+end

data/lib/ares/responses/basic.rb

@@ -0,0 +1,137 @@
+module Ares
+  module Responses
+    class Basic < Base
+      def initialize(xml_document)
+        @response_hash = Hash.from_xml(xml_document)
+        @base_response = @response_hash.values.first
+
+        assign_base_attributes(@base_response)
+
+        @content = @base_response.map { |key, value| parse_elem(key, value) }.compact
+      end
+
+      def error?
+        @content.any? { |e| e.is_a? Ares::Responses::Error }
+      end
+
+      def record
+        response
+      end
+
+      def parse_elem(key, value)
+        case key
+        when 'Fault'
+          Ares::Responses::Error.new(
+            value,
+            value['faultcode'].to_s,
+            value['faultstring'].to_s
+          )
+        when 'Odpoved'
+          Response.new(value)
+        end
+      end
+
+      class Base
+        # rubocop:disable Metrics/MethodLength
+        # rubocop:disable Metrics/AbcSize
+        def initialize(value)
+          self.class.class_eval do
+            if const_defined?(:ATTRIBUTES)
+              attr_reader(*const_get(:ATTRIBUTES).map(&:parameterize))
+            end
+            if const_defined?(:COMPOSITE_ATTRIBUTES)
+              attr_reader(*const_get(:COMPOSITE_ATTRIBUTES)
+                .values.map(&:parameterize))
+            end
+          end
+
+          return unless value
+
+          if self.class.const_defined?(:ATTRIBUTES)
+            self.class::ATTRIBUTES.each do |attribute|
+              instance_variable_set("@#{attribute.parameterize}",
+                                    value[attribute].presence)
+            end
+          end
+          self.class::COMPOSITE_ATTRIBUTES.each do |class_name, key|
+            full_class = "Ares::Responses::Basic::#{class_name}".constantize
+            instance_variable_set("@#{key.parameterize}",
+                                  full_class.new(value[key].presence))
+          end if self.class.const_defined?(:COMPOSITE_ATTRIBUTES)
+        end
+        # rubocop:enable Metrics/AbcSize
+        # rubocop:enable Metrics/MethodLength
+      end
+
+      class Response < Base
+        ATTRIBUTES = %w[Pomocne_ID Vysledek_hledani Pocet_zaznamu].freeze
+
+        COMPOSITE_ATTRIBUTES = {
+          Introduction: 'Uvod',
+          Record: 'Vypis_basic'
+        }.freeze
+      end
+
+      class Record < Base
+        ATTRIBUTES = %w[ICO Obchodni_firma Datum_vzniku Adresa_ARES Priznaky_subjektu
+                        Kategorie_poctu_pracovniku].freeze
+
+        COMPOSITE_ATTRIBUTES = {
+          LegalForm: 'Pravni_forma',
+          SendingAddress: 'Adresa_dorucovaci',
+          Address: 'Adresa_ARES',
+          CzNace: 'Nace',
+          RegisteredInstitution: 'Registrace_RZP'
+        }.freeze
+      end
+
+      class RegisteredInstitution < Base
+        COMPOSITE_ATTRIBUTES = {
+          BusinessOffice: 'Zivnostensky_urad',
+          FinanceOffice: 'Financni_urad'
+        }.freeze
+      end
+
+      class BusinessOffice < Base
+        ATTRIBUTES = %w[Kod_ZU Nazev_ZU].freeze
+      end
+
+      class FinanceOffice < Base
+        ATTRIBUTES = %w[Kod_FU Nazev_FU].freeze
+      end
+
+      class CzNace < Base
+        ATTRIBUTES = %w[NACE].freeze
+      end
+
+      class SendingAddress < Base
+        ATTRIBUTES = %w[zdroj Ulice_cislo PSC_obec].freeze
+      end
+
+      class Address < Base
+        ATTRIBUTES = %w[zdroj ID_adresy Kod_statu Nazev_statu Nazev_okresu Nazev_obce
+                        Nazev_casti_obce Nazev_mestske_casti Nazev_ulice Cislo_domovni
+                        Typ_cislo_domovni Cislo_orientacni PSC].freeze
+
+        COMPOSITE_ATTRIBUTES = {
+          AddressUIR: 'Adresa_UIR'
+        }.freeze
+      end
+
+      class AddressUIR < Base
+        ATTRIBUTES = %w[Kod_oblasti Kod_kraje Kod_okresu Kod_obce Kod_pobvod Kod_sobvod
+                        Kod_casti_obce Kod_mestske_casti PSC Kod_ulice Cislo_domovni
+                        Typ_cislo_domovni Cislo_orientacni Kod_adresy Kod_objektu
+                        PCD].freeze
+      end
+
+      class LegalForm < Base
+        ATTRIBUTES = %w[zdroj Kod_PF Nazev_PF].freeze
+      end
+
+      class Introduction < Base
+        ATTRIBUTES = %w[Nadpis Aktualizace_DB Datum_vypisu Cas_vypisu Typ_odkazu].freeze
+      end
+    end
+  end
+end

data/lib/ares/responses/{standard_response.rb → standard.rb}

@@ -1,77 +1,32 @@
+##
+# rubocop:disable Metrics/PerceivedComplexity
+# rubocop:disable Metrics/CyclomaticComplexity
+# rubocop:disable Metrics/MethodLength
+# rubocop:disable Metrics/AbcSize
+#
 module Ares
   module Responses
     # Coresponds to <are:Ares_odpovedi> element.
-    class StandardResponse
-      include Enumerable
-
-      # @!attribute [r] xml_document
-      #   @return [String] XML Document returned by ares
-      # @!attribute [r] time
-      #   @return [String] Created at
-      # @!attribute [r] count
-      #   @return [String] Element count
-      # @!attribute [r] type
-      #   @return [String] 'Standard'
-      # @!attribute [r] output_format
-      #   @return [String] 'XML'
-      # @!attribute [r] xslt
-      #   @return [String] 'klient'
-      # @!attribute [r] validation_xslt
-      #   @return [String] Path to xsl document
-      # @!attribute [r] id
-      #   @return [String] ID
-      attr_reader :xml_document, :time, :count, :type,
-                  :output_format, :xslt, :validation_xslt, :id
-
+    class Standard < Base
       def initialize(xml_document)
         @xml_document = xml_document
 
-        attributes = xml_document.root.attributes
-        @time = attributes['odpoved_datum_cas'].to_s
-        @count = attributes['odpoved_pocet'].to_s
-        @type = attributes['odpoved_typ'].to_s # musí být 'Standard'
-        @output_format = (attributes['vystup_format'] || 'XML').to_s
-        @xslt = (attributes['xslt'] || 'klient').to_s
-        @validation_xslt = attributes['validation_XSLT'].to_s
-        @id = attributes['Id'].to_s
+        assign_base_attributes(xml_document.root.attributes)
 
         @content = xml_document.root.children.map { |elem| parse_elem elem }.compact
       end
 
-      # Returns response with found company
-      # or nil if not found.
-      #
-      # @returns [Response, NilClass] response
-      def response
-        @content.first
-      end
-
-      def record
-        response ? response.records.first : nil
-      end
-
-      def error?
-        any? { |c| c.error? }
-      end
-
-      def each(&block)
-        @content.each(&block)
-      end
-
-      def to_xml
-        @xml_document.to_xml
-      end
-
       private
 
       def parse_elem(elem)
-        if elem.name == 'Fault'
+        case elem.name
+        when 'Fault'
           Ares::Responses::Error.new(
-              elem,
-              elem.at_xpath('./faultcode/text()').to_s,
-              elem.at_xpath('./faultstring/text()').to_s
+            elem,
+            elem.at_xpath('./faultcode/text()').to_s,
+            elem.at_xpath('./faultstring/text()').to_s
           )
-        elsif elem.name == 'Odpoved'
+        when 'Odpoved'
           Response.new(elem)
         end
       end
@@ -86,7 +41,8 @@ module Ares
         #   @return [Integer] Responses count
         # @!attribute [r] search_type
         #   @return [String] type of search:
-        #     * FREE - searching by ico, if not found search by RC, if not found find by company's name
+        #     * FREE - searching by ico, if not found search
+        #              by RC, if not found find by company's name
         #     * ICO, RC, OF - search by type, if not found searching ends.
         #     Searching type is shown in (Kod_shody_*) element.
         #
@@ -112,34 +68,37 @@ module Ares
         private
 
         # @param child [Nokogiri::XML::Element] Child element
+        # rubocop:disable Lint/EmptyWhen
         def parse_elem(child)
           case child.name
-            when 'Pomocne_ID'
-              @id = child.value
-            when 'Pocet_zaznamu'
-              @count = child.content.to_i
-            when 'Typ_vyhledani'
-              @search_type = child.content
-            when 'Error'
-              @records << Ares::Responses::Error.new(
-                  child,
-                  child.at_xpath('./Error_kod/text()').to_s,
-                  child.at_xpath('./Error_text/text()').to_s
-              )
-            when 'Zaznam'
-              @records << Record.new(child)
-            when 'text'
-              # do nothing
-            else
-              Ares.logger.warn("#{self}: Unexpected record #{child.name} at #{child.path}")
+          when 'Pomocne_ID'
+            @id = child.value
+          when 'Pocet_zaznamu'
+            @count = child.content.to_i
+          when 'Typ_vyhledani'
+            @search_type = child.content
+          when 'Error'
+            @records << Ares::Responses::Error.new(
+              child,
+              child.at_xpath('./Error_kod/text()').to_s,
+              child.at_xpath('./Error_text/text()').to_s
+            )
+          when 'Zaznam'
+            @records << Record.new(child)
+          when 'text'
+          # do nothing
+          else
+            Ares.logger.warn("#{self}: Unexpected record #{child.name} at #{child.path}")
           end
         end
+        # rubocop:enable Lint/EmptyWhen
       end
 
       # <are:Zaznam> element
       class Record
         # @!attribute [r] match
-        #    @return [Responses::TextCode] <are:Shoda_ICO/RC/OF> Code of matching register ('ICO', 'RC', 'OF')
+        #    @return [Responses::TextCode] <are:Shoda_ICO/RC/OF>
+        #               Code of matching register ('ICO', 'RC', 'OF')
         # @!attribute [r] search_by
         #    @return [String] <are:Vyhledano_dle> Register where record was found
         # @!attribute [r] register_type
@@ -170,9 +129,10 @@ module Ares
         def initialize(elem)
           @match = get_match(elem)
           @search_by = elem.at_xpath('./are:Vyhledano_dle').content
-          @register_type = TextCode.new('RegisterType',
-                                        elem.at_xpath('./are:Typ_registru/dtt:Kod').content,
-                                        elem.at_xpath('./are:Typ_registru/dtt:Text').content)
+          @register_type = TextCode
+                           .new('RegisterType',
+                                elem.at_xpath('./are:Typ_registru/dtt:Kod').content,
+                                elem.at_xpath('./are:Typ_registru/dtt:Text').content)
           date = elem.at_xpath('./are:Datum_vzniku')
           @creation_date = date ? Time.parse(date.content) : nil
           date = elem.at_xpath('./are:Datum_zaniku')
@@ -196,6 +156,7 @@ module Ares
         # @returns [AresAddress, NilClass] Address
         def address
           return unless identification
+
           identification.address
         end
 
@@ -203,17 +164,17 @@ module Ares
 
         def get_match(elem)
           name = code = text = nil
-          if match = elem.at_xpath('./are:Shoda_ICO')
+          if (match = elem.at_xpath('./are:Shoda_ICO'))
             name = 'Match ICO'
             code = match.at_xpath('./dtt:Kod').content
             text = match.at_xpath('./dtt:Text')
             text = (text ? text.content : nil)
-          elsif match = elem.at_xpath('./are:Shoda_RC')
+          elsif (match = elem.at_xpath('./are:Shoda_RC'))
             name = 'Match RC'
             code = match.at_xpath('./dtt:Kod').content
             text = match.at_xpath('./dtt:Text')
             text = (text ? text.content : nil)
-          elsif match = elem.at_xpath('./are:Shoda_OF')
+          elsif (match = elem.at_xpath('./are:Shoda_OF'))
             name = 'Match OF'
             code = match.at_xpath('./dtt:Kod').content
             text = match.at_xpath('./dtt:Text')
@@ -228,13 +189,13 @@ module Ares
 
       # <Pravni_forma> element
       class LegalForm
-        # Typ ekonomického subjektu:
-        # F-fyzická osoba tuzemská,
-        # P-právnická osoba tuzemská,
-        # X-zahraniční právnická osoba,
-        # Z-zahraniční fyzická osoba,
-        # O-fyzická osoba s organizační složkou
-        # C-civilní osoba nepodnikající (v CEU)
+        # Typ ekonomickeho subjektu:
+        # F-fyzicka osoba tuzemska,
+        # P-pravnicka osoba tuzemska,
+        # X-zahranicni pravnicka osoba,
+        # Z-zahranicni fyzicka osoba,
+        # O-fyzicka osoba s organizacni slozkou
+        # C-civilni osoba nepodnikajici (v CEU)
         attr_reader :code, :name, :person, :text, :person_type
 
         def initialize(elem)
@@ -280,8 +241,8 @@ module Ares
 
       # <Osoba> element
       class Person
-        attr_reader :title_before, :name, :last_name, :title_after, :birthdate, :personal_id_number,
-                    :text, :address
+        attr_reader :title_before, :name, :last_name, :title_after,
+                    :birthdate, :personal_id_number, :text, :address
 
         def initialize(elem)
           @title_before = elem.at_xpath('./dtt:Titul_pred')
@@ -299,7 +260,7 @@ module Ares
       # Ares address definition
       # ares_datatypes_v_1.0.4.xsd:788
       class AresAddress
-        # Názvy:
+        # Nazvy:
         # uol ico: 27074358
         # en: http://wwwinfo.mfcr.cz/cgi-bin/ares/ares_sad.cgi?zdroj=0&adr=204437556&jazyk=en
         # cs: http://wwwinfo.mfcr.cz/cgi-bin/ares/ares_sad.cgi?zdroj=0&adr=204437556
@@ -334,11 +295,12 @@ module Ares
         #   @return [Integer] postcode (PSC)
         # @!attribute [r] foreign_postcode
         #   @return [Integer] Foreign postcode (Zahr_PSC)
-        attr_reader :id, :state_code, :state, :territory, :region, :district, :town, :residential_area,
-                    :town_district, :street, :building_number, :sequence_number, :land_registry_number,
+        attr_reader :id, :state_code, :state, :territory, :region, :district,
+                    :town, :residential_area, :town_district, :street,
+                    :building_number, :sequence_number, :land_registry_number,
                     :postcode, :foreign_postcode
 
-        # TODO: Dopřeložit
+        # TODO: localize
 
         # @!attribute [r] pobvod
         #   @return [Integer] (Nazev_pobvodu)
@@ -370,6 +332,8 @@ module Ares
 
         # TODO: localize
         # @param lang [String] ('cz') Language
+        #
+        # rubocop:disable Metrics/BlockNesting
         def to_s(lang = 'cz')
           s = ''
           if street
@@ -383,7 +347,7 @@ module Ares
             end
             s << ", #{postcode} #{town}"
             if residential_area
-              (town =~ /-/) ? s << ',' : s << '-' if town
+              s << (town =~ /-/ ? ',' : '-') if town
               s << residential_area
             end
           else
@@ -409,6 +373,7 @@ module Ares
           end
           s
         end
+        # rubocop:enable Metrics/BlockNesting
 
         private
 
@@ -439,4 +404,10 @@ module Ares
       end
     end
   end
-end
+end
+#
+# rubocop:enable Metrics/PerceivedComplexity
+# rubocop:enable Metrics/CyclomaticComplexity
+# rubocop:enable Metrics/MethodLength
+# rubocop:enable Metrics/AbcSize
+##

data/lib/ares/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ares
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ares.rb
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Ondřej Svoboda
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-03 00:00:00.000000000 Z
+date: 2019-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ico-validator
@@ -26,19 +26,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.4'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -68,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -96,7 +110,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,6 +151,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Gem for accesing business information from ARES database.
 email:
 - blin@uol.cz
@@ -147,6 +175,7 @@ files:
 - ".gitignore"
 - ".hound.yml"
 - ".rspec"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
@@ -156,14 +185,18 @@ files:
 - Rakefile
 - TODO.md
 - ares.gemspec
+- bin/console
 - lib/ares.rb
-- lib/ares/client.rb
+- lib/ares/client/base.rb
+- lib/ares/client/basic.rb
 - lib/ares/client/standard.rb
 - lib/ares/errors.rb
 - lib/ares/http.rb
 - lib/ares/logging.rb
 - lib/ares/responses.rb
-- lib/ares/responses/standard_response.rb
+- lib/ares/responses/base.rb
+- lib/ares/responses/basic.rb
+- lib/ares/responses/standard.rb
 - lib/ares/version.rb
 homepage: http://www.uol.cz
 licenses: []
@@ -184,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: ARES library

data/lib/ares/client.rb

@@ -1,14 +0,0 @@
-require 'ares/http'
-require 'ares/responses'
-
-module Ares
-  module Client
-    autoload :Standard, 'ares/client/standard'
-
-    class << self
-      def standard
-        Standard.new
-      end
-    end
-  end
-end