arel_extensions 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 632b32bb630753413ebde8d2ad0d9b567aab88697c64b5abbbf1f50e53789690
-  data.tar.gz: 7d8c0d52c2c07ff36362dbe00b68c1e3216b3924dbd98fea99e5b643953b217e
+  metadata.gz: a07429d6f459dff77dc3fa56aa258f1fee94ecb7401772ec3ceaea8dc0a8c4d7
+  data.tar.gz: d1600677cf0e63777bd8d8b656f4e17f0fa534e23579cfe3c18044e855a6115b
 SHA512:
-  metadata.gz: 54438691157a004658d1ce8f3e4c47e76bdaab4d0f569199f13add0bef389dd91c2cc99807625ef18b9e96cdf570069fa529d55720e9393e8ce3783470e24156
-  data.tar.gz: cfc50270090b43b343444dbecba639b32966b1a45fb5f475338b140e5641c14353007f01cb7228a1870445e808244fa441bdf4fcab7a31fdd2e6e8618bb901bf
+  metadata.gz: 752646ca62337cff68c38bcda876d5aa1f7cf6cb8f31906b6d6335237aa1a074daf4891b94b45486d758f1af035d87aac2449951aab683d35f84c123b10c39f8
+  data.tar.gz: d3002160ab13dc1ecbdac0d863a72847a4b3f151cfe12ada6d694b4fb02d70a7e16facbe455d474a5e2ce51ca5686c8abfee26962b91f04023e2fdeb335e22e0

data/README.md

@@ -152,7 +152,9 @@ t[:birthdate].format('%Y-%m-%d').to_sql
 ```
 
 Which formats the datetime without any time zone conversion.
-The second form is:
+The second form accepts 2 kinds of values:
+
+1. String:
 
 ```ruby
 t[:birthdate].format('%Y/%m/%d %H:%M:%S', 'posix/Pacific/Tahiti')
@@ -162,7 +164,18 @@ t[:birthdate].format('%Y/%m/%d %H:%M:%S', 'posix/Pacific/Tahiti')
 #                                                                            ^^^^^^^^^^^^^^^^^^^^ 🚨 Invalid timezone for SQL Server. Explanation below.
 ```
 
-This will convert the datetime field to the supplied time zone.
+which will convert the datetime field to the supplied time zone. This generally
+means that you're letting the RDBMS decide or infer what is the timezone of the
+column before conversion to the supplied timezone.
+
+1. Hash of the form `{ src_time_zone => dst_time_zone }`:
+
+```ruby
+t[:birthdate].format('%Y/%m/%d %H:%M:%S', { 'posix/Europe/Paris' => 'posix/Pacific/Tahiti' })
+```
+
+which will explicitly indicate the original timestamp that should be considered
+by the RDBMS.
 
 Warning:
 
@@ -176,6 +189,14 @@ Warning:
   - ☣️ Choosing abbreviate forms like `CET`, which stands for `Central European
     Time` will behave differently on `PostgreSQL` and `MySQL`. Don't assume
     uniform behavior, or even a _rational_ one.
+- ⚠️ Pay attention to the type of the `datetime` column you're working with. For
+  example, in Postgres, a `datetime` can be one of the following types:
+  1. `timestamp with time zone`
+  2. `timestamp without time zone`
+  In the first case, you don't need to supply a conversion hash because postgres
+  knows how to convert it to the desired time zone. However, if you do the same
+  for the second case, you might get surprises, especially if your Postgres
+  installation's default timezone is not `UTC`.
 - ⚠️ SQLite is not supported.
 - 🚨 Always test against your setup 🚨
 

data/lib/arel_extensions/nodes/format.rb

@@ -10,7 +10,7 @@ module ArelExtensions
       def initialize expr
         col = expr[0]
         @iso_format = convert_format(expr[1])
-        @time_zone  = Arel::Nodes.build_quoted(expr[2]) if expr[2]
+        @time_zone  = expr[2]
         @col_type = type_of_attribute(col)
         super [col, convert_to_string_node(@iso_format)]
       end

data/lib/arel_extensions/version.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = "1.3.1".freeze
+  VERSION = "1.3.2".freeze
 end

data/lib/arel_extensions/visitors/mssql.rb

@@ -276,9 +276,16 @@ module ArelExtensions
             collector << ' '
           end
           collector = visit o.left, collector
-          if o.time_zone
-            collector << ") AT TIME ZONE 'UTC' AT TIME ZONE "
-            collector = visit o.time_zone, collector
+          case o.time_zone
+          when Hash
+            src_tz, dst_tz = o.time_zone.first
+            collector << ') AT TIME ZONE '
+            collector = visit Arel::Nodes.build_quoted(src_tz), collector
+            collector << ' AT TIME ZONE '
+            collector = visit Arel::Nodes.build_quoted(dst_tz), collector
+          when String
+            collector << ') AT TIME ZONE '
+            collector = visit Arel::Nodes.build_quoted(o.time_zone), collector
           end
           collector << LOADED_VISITOR::COMMA
           collector << fmt.to_s
@@ -307,9 +314,16 @@ module ArelExtensions
                 collector << ' '
               end
               collector = visit o.left, collector
-              if o.time_zone
-                collector << ") AT TIME ZONE 'UTC' AT TIME ZONE "
-                collector = visit o.time_zone, collector
+              case o.time_zone
+              when Hash
+                src_tz, dst_tz = o.time_zone.first.first, o.time_zone.first.second
+                collector << ") AT TIME ZONE "
+                collector = visit Arel::Nodes.build_quoted(src_tz), collector
+                collector << " AT TIME ZONE "
+                collector = visit Arel::Nodes.build_quoted(dst_tz), collector
+              when String
+                collector << ") AT TIME ZONE "
+                collector = visit Arel::Nodes.build_quoted(o.time_zone), collector
               end
               collector << ')'
               collector << ')'                                  if !fmt

data/lib/arel_extensions/visitors/mysql.rb

@@ -211,9 +211,17 @@ module ArelExtensions
           collector << "DATE_FORMAT("
           collector << "CONVERT_TZ(" if o.time_zone
           collector = visit o.left, collector
-          if o.time_zone
+          case o.time_zone
+          when Hash
+            src_tz, dst_tz = o.time_zone.first
+            collector << COMMA
+            collector = visit Arel::Nodes.build_quoted(src_tz), collector
+            collector << COMMA
+            collector = visit Arel::Nodes.build_quoted(dst_tz), collector
+            collector << ')'
+          when String
             collector << COMMA << "'UTC'" << COMMA
-            collector = visit o.time_zone, collector
+            collector = visit Arel::Nodes.build_quoted(o.time_zone), collector
             collector << ')'
           end
           collector << COMMA

data/lib/arel_extensions/visitors/oracle.rb

@@ -449,9 +449,16 @@ module ArelExtensions
         collector << "TO_CHAR("
         collector << "CAST(" if o.time_zone
         collector = visit o.left, collector
-        if o.time_zone
-          collector << " as timestamp) at time zone "
-          collector = visit o.time_zone, collector
+        case o.time_zone
+        when Hash
+          src_tz, dst_tz = o.time_zone.first
+          collector << ' as timestamp) at time zone '
+          collector = visit Arel::Nodes.build_quoted(src_tz), collector
+          collecto < ' at time zone '
+          collector = visit Arel::Nodes.build_quoted(dst_tz), collector
+        when String
+          collector << ' as timestamp) at time zone '
+          collector = visit Arel::Nodes.build_quoted(o.time_zone), collector
         end
         collector << COMMA
         collector = visit Arel::Nodes.build_quoted(fmt), collector

data/lib/arel_extensions/visitors/postgresql.rb

@@ -175,10 +175,18 @@ module ArelExtensions
       def visit_ArelExtensions_Nodes_Format o, collector
         fmt = ArelExtensions::Visitors::strftime_to_format(o.iso_format, DATE_FORMAT_DIRECTIVES)
         collector << "TO_CHAR("
+        collector << '(' if o.time_zone
         collector = visit o.left, collector
-        if o.time_zone
-          collector << " AT TIME ZONE "
-          collector = visit o.time_zone, collector
+        case o.time_zone
+        when Hash
+          src_tz, dst_tz = o.time_zone.first
+          collector << ') AT TIME ZONE '
+          collector = visit Arel::Nodes.build_quoted(src_tz), collector
+          collector << ' AT TIME ZONE '
+          collector = visit Arel::Nodes.build_quoted(dst_tz), collector
+        when String
+          collector << ') AT TIME ZONE '
+          collector = visit Arel::Nodes.build_quoted(o.time_zone), collector
         end
         collector << COMMA
         collector = visit Arel::Nodes.build_quoted(fmt), collector

data/test/arelx_test_helper.rb

@@ -52,7 +52,6 @@ end
 load_lib(db_and_gem[ENV['DB']])
 
 require 'arel_extensions'
-Arel::Table.engine = FakeRecord::Base.new
 
 $arel_silence_type_casting_deprecation = true
 

data/test/with_ar/all_agnostic_test.rb

@@ -403,35 +403,39 @@ module ArelExtensions
                             'tahiti'    => 'Hawaiian Standard Time',
                             'paris'     => 'Central European Standard Time'
                            },
-          'mysql'       => {
+          'posix'       => {
                             'utc'       => 'UTC',
                             'sao_paulo' => 'America/Sao_Paulo',
                             'tahiti'    => 'Pacific/Tahiti',
                             'paris'     => 'Europe/Paris'
-                           },
-          'oracle'  => {
-                            'utc'       => 'UTC',
-                            'sao_paulo' => 'America/Sao_Paulo',
-                            'tahiti'    => 'Pacific/Tahiti',
-                            'paris'     => 'Europe/Paris'
-                            },
-          'postgresql'  => {
-                            'utc'       => 'UTC',
-                            'sao_paulo' => 'America/Sao Paulo (-03)',
-                            'tahiti'    => 'Pacific/Tahiti (-10)',
-                            'paris'     => 'Europe/Paris'
-                            },
+                           }
         }
 
-        tz = time_zones[ENV['DB']]
-        skip "Unsupported timezone conversion for DB=#{ENV['DB']}" if tz.nil?
+        skip "Unsupported timezone conversion for DB=#{ENV['DB']}" if !['mssql', 'mysql', 'oracle', 'postgresql'].include?(ENV['DB'])
+
+        tz = ENV['DB'] == 'mssql' ? time_zones['mssql'] : time_zones['posix']
+
         assert_equal '2014/03/03 12:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', tz['utc']))
-        assert_equal '2014/03/03 09:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', tz['sao_paulo']))
-        assert_equal '2014/03/03 02:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', tz['tahiti']))
+        assert_equal '2014/03/03 09:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['sao_paulo'] }))
+        assert_equal '2014/03/03 02:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['tahiti'] }))
+
+        # Skipping conversion from UTC to the desired timezones fails in SQL
+        # Server and Postgres. This is mainly due to the fact that timezone
+        # information is not preserved in the column itself.
+        #
+        # MySQL is happy to consider that times by default are in UTC.
+        assert_equal '2014/03/03 13:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['paris'] }))
+        refute_equal '2014/03/03 13:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S', tz['paris'])) if !['mysql'].include?(ENV['DB'])
 
         # Winter/Summer time
-        assert_equal '2022/02/01 11:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-02-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', tz['paris']))
-        assert_equal '2022/08/01 12:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-08-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', tz['paris']))
+        assert_equal '2014/08/03 14:42:00', t(@lucas, (@updated_at + 5.months).format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['paris'] }))
+        if ENV['DB'] == 'mssql'
+          assert_equal '2022/02/01 11:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-02-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['paris'] }))
+          assert_equal '2022/08/01 12:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-08-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', { tz['utc'] => tz['paris'] }))
+        else
+          assert_equal '2022/02/01 11:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-02-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', tz['paris']))
+          assert_equal '2022/08/01 12:42:00', t(@lucas, Arel::Nodes.build_quoted('2022-08-01 10:42:00').cast(:datetime).format('%Y/%m/%d %H:%M:%S', tz['paris']))
+        end
       end
 
       def test_coalesce

data/version_v1.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = "1.3.1".freeze
+  VERSION = "1.3.2".freeze
 end

data/version_v2.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = "2.1.1".freeze
+  VERSION = "2.1.2".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arel_extensions
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Yann Azoury
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-03 00:00:00.000000000 Z
+date: 2022-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arel